X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst.pm;h=537cae1bff92d8a73447444d5835e18729af0f8f;hp=a628d53cf8200577fd85bc0d9bae0cd6b031b77d;hb=e260802a2794d499f6faf2619dbbf943541829ab;hpb=05d79b223fd5c1594a492fc05faca548e66478d9 diff --git a/lib/Catalyst.pm b/lib/Catalyst.pm index a628d53..537cae1 100644 --- a/lib/Catalyst.pm +++ b/lib/Catalyst.pm @@ -1,7 +1,7 @@ package Catalyst; use Moose; -extends 'Catalyst::Component', 'Class::Accessor::Fast'; +extends 'Catalyst::Component'; use Moose::Util qw/find_meta/; use bytes; use Scope::Upper (); @@ -527,7 +527,7 @@ sub _comp_search_prefixes { if( @result ) { # Disgusting hack to work out correct method name my $warn_for = lc $prefixes[0]; - my $msg = "Used regexp fallback for \$c->{$warn_for}('${name}'), which found '" . + my $msg = "Used regexp fallback for \$c->${warn_for}('${name}'), which found '" . (join '", "', @result) . "'. Relying on regexp fallback behavior for " . "component resolution is unreliable and unsafe."; my $short = $result[0]; @@ -2398,14 +2398,19 @@ sub setup_log { $levels ||= ''; $levels =~ s/^\s+//; $levels =~ s/\s+$//; - my %levels = map { $_ => 1 } split /\s*,\s*/, $levels || ''; - + my %levels = map { $_ => 1 } split /\s*,\s*/, $levels; + + my $env_debug = Catalyst::Utils::env_value( $class, 'DEBUG' ); + if ( defined $env_debug ) { + $levels{debug} = 1 if $env_debug; # Ugly! + delete($levels{debug}) unless $env_debug; + } + unless ( $class->log ) { $class->log( Catalyst::Log->new(keys %levels) ); } - my $env_debug = Catalyst::Utils::env_value( $class, 'DEBUG' ); - if ( defined($env_debug) or $levels{debug} ) { + if ( $levels{debug} ) { Class::MOP::get_metaclass_by_name($class)->add_method('debug' => sub { 1 }); $class->log->debug('Debug messages enabled'); }