X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=d6a66e5fd075098c76e72d313cbb3a43ec210686;hp=318654aa5eb1908cfed77830b156dc8968be9e95;hb=cb1e348badf54b4ceacca793b0baa6312e2a7e5d;hpb=dae2b0faaf2982bde81606ea0392c13fd9309cb1 diff --git a/TODO b/TODO index 318654a..d6a66e5 100644 --- a/TODO +++ b/TODO @@ -1,69 +1,89 @@ -TBD pre 5.8000_04 dev release: +# Known Bugs: - - Go through everything which used to use CAF, and ensure that it now uses MX::E::CAF + tests, - extending t/caf_backcompat.t and replacing t/custom_request.t (t0m) + - Bug ->go or ->visit causes actions which have Args or CaptureArgs called + twice when called via ->go or ->visit. - - Simple test for NEXT compat in core (t0m). + Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master - - Looks like stash is not available during prepare_path when running under - Catalyst::Test.. Run MojoMojo's t/01app.t and it will explode with - "Can't use an undefined value as a HASH reference" - test case for core - + fix maybe (marcus) +# Compatibility warnings to add: ---- + - $self->config should warn as config should only ever be called as a + class method (TESTS). - - Make the skipped test at the bottom of t/aggregate/live_engine_request_uri.t - pass / not be skipped. (From what C::P::SmartURI used to do) +# Proposed functionality / feature additions: - This can be fixed by the following patch: +## Log setup needs to be less lame -Index: lib/Catalyst/Request.pm -=================================================================== ---- lib/Catalyst/Request.pm (revision 8709) -+++ lib/Catalyst/Request.pm (working copy) -@@ -96,7 +96,7 @@ - lazy => 1, - default => sub { - my $self = shift; -- return $self->path if $self->uri; -+ return $self->{path} if $self->{uri}; - }, - ); +So Catalyst::Plugin::Log::* can die +in a fire. Having $c->log_class would be a good start. kane volunteered +to do some of this. - But I'd like a 2nd opinion from someone who knows core better than me - about if that is the correct fix.. (t0m / Caelum) +Simple example: Catalyst::Plugin::Log::Colorful should just be a +subclass of Catalyst::Log, no ::Plugin:: needed. - - Common engine test failures, look into and get tests into core. +See also: Catalyst::Plugin::Log::Dispatch and +http://github.com/willert/catalyst-plugin-log4perl-simple/tree - - Catalyst-Plugin-Authorization-ACL, Can't locate object method "tree" via package "Catalyst::Dispatcher", fix the plugin as tree was never a public method. +## Capture arguments that the plack engine component was run with somewhere, + to more easily support custom args from scripts (e.g. Gitalist's + --git_dir) - - Catalyst-Model-Akismet, incorrectly inherits from Catalyst::Component::InstancePerContext, should compose as a role, fix the module. +## throw away the restarter and allow using the restarters Plack provides - - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol table as methods, tests + fix? +## remove per-request state from the engine instance - - Catalyst::Plugin::Cache::Curried - - Catalyst::Controller::WrapCGI - - Both import 'meta' into controller package - mst thinks this can be fixed?. - but @marcus> and the generated accessors even call $_[0]->meta, so I don't think we can remove it. - . Add a test for this in core. - . Fix core to use CMOP to look up metaclass, rather than ->meta method, and - namespace::clean the meta method out, fix generated accessors to do the same? +## be smarter about how we use PSGI - not every response needs to be delayed + and streaming - - MooseX::Emulate::Class::Accessor::Fast - - Tests for uses of C::A::F from Catalyst repos. - t0m - - New release once these are done. +# The horrible hack for plugin setup - replacing it: - - Update Test suite to not assume MyApp ISA Controller - - After that set up attr handlers that will output helpful error messages when you do it as well as how to fix it. (done already?) - - - Comments marked /Moose TODO/i in the code - - - Eliminate all instances of $instance->{$key} + * Have a look at the Devel::REPL BEFORE_PLUGIN stuff + I wonder if what we need is that combined with plugins-as-roles - - Catalyst-Log-Log4perl - deep recursion in the test suite, investigate + * Catalyst::Engine::HTTP::Prefork no longer works since it requires + Catalyst::Engine::CGI which no longer is in the cataplack distribution. + Investigation shows moving CE:CGI to CE:HTTP:Prefork allows tests to pass. - - Profiling vs 5.70 and optimisation as needed. +# PSGI - - http://lists.scsys.co.uk/pipermail/catalyst-dev/2008-November/001546.html - - patch to list, andyg to look at? +## To do at release time + - Release psgi branch of Catalyst-Devel + - Release new Task::Catalyst + - Release 5.9 branch of Catalyst-Manual + - Release Catalyst::Engine::HTTP::Prefork with deprecation notice + (and maybe compat?) + +## Blockers + + * Better docs for stopping using Engine::HTTP::Prefork and + starting using Starman, maybe? + + * I've noticed a small difference with Catalyst::Test. The latest stable + version include two headers, 'host' and 'https'. They are missing from + this version - Pedro Melo on list + ^^ Cannot replicate this? Mailed back to ask for tests.. + +# App / ctx split: + + NOTE - these are notes that t0m thought up after doing back compat for + catalyst_component_class, may be inaccurate, wrong or missing things + bug mst (at least) to correct before trying more than the first 2 + steps. Please knock yourself out on the first two however :) + + - Eliminate actions in MyApp from the main test suite + - Uncomment warning in C::C::register_action_methods, add tests it works + by mocking out the logging.. + - Remove MyApp @ISA controller (ask metaclass if it has attributes, and if + so you need back compat :/) + - Make Catalyst::Context, move the per request stuff in there, handles from + main app class to delegate + - Make an instance of the app class which is a global variable + - Make new instance of the context class, not the app class per-request + - Remove the components as class data, move to instance data on the app + class (you probably have to do this for _all_ the class data, good luck!) + - Make it possible for users to spin up different instances of the app class + (with different config etc each) + - Profit! (Things like changing the complete app config per vhost, i.e. + writing a config loader / app class role which dispatches per vhost to + differently configured apps is piss easy)