X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=999e23739f3b8a99803fd9ac84aa40fbacd5a4b9;hp=eb2bafbf1ccad1c339ff3bb823b1b357f5b47fbb;hb=11d52bbdb4fccbe1678d869494acb9d43ae83c99;hpb=aaee1a0a5c8f57a15bc1474b52add5729f65c66f diff --git a/TODO b/TODO index eb2bafb..999e237 100644 --- a/TODO +++ b/TODO @@ -1,46 +1,59 @@ -Known Bugs: +# Known Bugs: - - Bug ->go or ->visit causes actions which have Args or CaptureArgs caled + - Bug ->go or ->visit causes actions which have Args or CaptureArgs called twice when called via ->go or ->visit. Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master +# Compatibility warnings to add: - - Certain errors in your application to do with using other code which does - not exist can cause an 'Unknown error' issue. + - $self->config should warn as config should only ever be called as a + class method (TESTS). - Test app: http://github.com/bobtfish/catalyst-app-bug-unknown-error/tree/master - < rafl> 21:13:03 < vincent> hah, Class::MOP::Method::Generated->_eval_closure - < rafl> 21:13:40 < vincent> right, shove a local $@ in there - < rafl> i can do that and add tests in an hour or two +# Proposed functionality / feature additions: +## Log setup needs to be less lame - - -restarter.t will fail if you don't have ::StashChange installed, and - also quite often at other times. +So Catalyst::Plugin::Log::* can die +in a fire. Having $c->log_class would be a good start. kane volunteered +to do some of this. +Simple example: Catalyst::Plugin::Log::Colorful should just be a +subclass of Catalyst::Log, no ::Plugin:: needed. - - Catalyst::Test - bugs with Moosification (Khisanth/kane) +See also: Catalyst::Plugin::Log::Dispatch and +http://github.com/willert/catalyst-plugin-log4perl-simple/tree - - Attribute called 'actions' in controllers - needs to be renamed to _actions. +## throw away the restarter and allow using the restarters Plack provides - - before finalize causes you to miserably fail to call plugins finalize - method (dmaki) +## be smarter about how we use PSGI - not every response needs to be delayed + and streaming -Compatibility warnings to add: +# The horrible hack for plugin setup - replacing it: - - $self->config should warn as config should only ever be called as a - class method. + * Have a look at the Devel::REPL BEFORE_PLUGIN stuff + I wonder if what we need is that combined with plugins-as-roles -Proposed functionality / feature additions: - - - Log setup needs to be less lame, so Catalyst::Plugin::Log::* can die - in a fire. Having $c->log_class would be a good start. kane volunteered - to do some of this. - - Simple example: Catalyst::Plugin::Log::Colorful should just be a - subclass of Catalyst::Log, no ::Plugin:: needed. - - See also: Catalyst::Plugin::Log::Dispatch and - http://github.com/willert/catalyst-plugin-log4perl-simple/tree +# App / ctx split: + NOTE - these are notes that t0m thought up after doing back compat for + catalyst_component_class, may be inaccurate, wrong or missing things + bug mst (at least) to correct before trying more than the first 2 + steps. Please knock yourself out on the first two however :) + - Eliminate actions in MyApp from the main test suite + - Uncomment warning in C::C::register_action_methods, add tests it works + by mocking out the logging.. + - Remove MyApp @ISA controller (ask metaclass if it has attributes, and if + so you need back compat :/) + - Make Catalyst::Context, move the per request stuff in there, handles from + main app class to delegate + - Make an instance of the app class which is a global variable + - Make new instance of the context class, not the app class per-request + - Remove the components as class data, move to instance data on the app + class (you probably have to do this for _all_ the class data, good luck!) + - Make it possible for users to spin up different instances of the app class + (with different config etc each) + - Profit! (Things like changing the complete app config per vhost, i.e. + writing a config loader / app class role which dispatches per vhost to + differently configured apps is piss easy)