X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=8fd77ad926538e929fb74e5dd93af02753b764b7;hp=93f92c06f14dc56665ef879afece8bbe483e55b1;hb=62b6b631cf9141ffd9ae02e4b87c182b080b335a;hpb=cec7aff62facbd4519a306b57081a557477bee37

diff --git a/TODO b/TODO
index 93f92c0..8fd77ad 100644
--- a/TODO
+++ b/TODO
@@ -1,47 +1,56 @@
-  - Class::C3::Adopt::NEXT - some people are getting more than one warning
-    per package, make a test case for this (t0m)
+# Known Bugs:
 
-  - Catalyst::Plugin::Authentication fails tests. Believed to be as
-    Catalyst::Plugin::Authentication::Credential::Password has a
-    ->mk_accessors('_config'), which is also class data.
-    Make a test case for this (t0m)
+   - Bug ->go or ->visit causes actions which have Args or CaptureArgs called
+     twice when called via ->go or ->visit.
 
-  - Looks like stash is not available during prepare_path when running under
-    Catalyst::Test.. Run MojoMojo's t/01app.t and it will explode with
-    "Can't use an undefined value as a HASH reference" - test case for core
-    + fix maybe (marcus)
+     Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master
 
-  - Common engine test failures, look into and get tests into core.
+# Compatibility warnings to add:
 
-  - Catalyst-Plugin-Authorization-ACL, Can't locate object method "tree" via package "Catalyst::Dispatcher", fix the plugin as tree was never a public method.
+  - $self->config should warn as config should only ever be called as a
+    class method (TESTS).
 
-  - Catalyst-Model-Akismet, incorrectly inherits from Catalyst::Component::InstancePerContext, should compose as a role, fix the module.
+# Proposed functionality / feature additions:
 
-  - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol table as methods, tests + fix?
+## Log setup needs to be less lame
 
-  - Catalyst::Plugin::Cache::Curried
-  - Catalyst::Controller::WrapCGI
-    - Both import 'meta' into controller package - mst thinks this can be fixed?.
-      but @marcus> and the generated accessors even call $_[0]->meta, so I don't think we can remove it. 
-      . Add a test for this in core.
-      . Fix core to use CMOP to look up metaclass, rather than ->meta method, and
-        namespace::clean the meta method out, fix generated accessors to do the same?
+So Catalyst::Plugin::Log::* can die
+in a fire. Having $c->log_class would be a good start. kane volunteered
+to do some of this.
 
-  - MooseX::Emulate::Class::Accessor::Fast
-    - Tests for uses of C::A::F from Catalyst repos. - t0m
-    - New release once these are done.
+Simple example: Catalyst::Plugin::Log::Colorful should just be a
+subclass of Catalyst::Log, no ::Plugin:: needed.
 
-  - Update Test suite to not assume MyApp ISA Controller
-    - After that set up attr handlers that will output helpful error messages when you do it as well as how to fix it. (done already?)
-  
-  - Comments marked /Moose TODO/i in the code
-  
-  - Eliminate all instances of $instance->{$key}
+See also: Catalyst::Plugin::Log::Dispatch and
+http://github.com/willert/catalyst-plugin-log4perl-simple/tree
 
-  - Catalyst-Log-Log4perl - deep recursion in the test suite, investigate
+# REFACTORING
 
-  - Profiling vs 5.70 and optimisation as needed.
+##  The horrible hack for plugin setup - replacing it:
 
-  - http://lists.scsys.co.uk/pipermail/catalyst-dev/2008-November/001546.html
-    - patch to list, andyg to look at?
+ * Have a look at the Devel::REPL BEFORE_PLUGIN stuff
+   I wonder if what we need is that combined with plugins-as-roles
 
+## App / ctx split:
+
+  NOTE - these are notes that t0m thought up after doing back compat for
+         catalyst_component_class, may be inaccurate, wrong or missing things
+         bug mst (at least) to correct before trying more than the first 2
+         steps. Please knock yourself out on the first two however :)
+
+  - Eliminate actions in MyApp from the main test suite
+  - Uncomment warning in C::C::register_action_methods, add tests it works
+    by mocking out the logging..
+  - Remove MyApp @ISA controller (ask metaclass if it has attributes, and if
+                                  so you need back compat :/)
+  - Make Catalyst::Context, move the per request stuff in there, handles from
+    main app class to delegate
+  - Make an instance of the app class which is a global variable
+  - Make new instance of the context class, not the app class per-request
+  - Remove the components as class data, move to instance data on the app
+    class (you probably have to do this for _all_ the class data, good luck!)
+  - Make it possible for users to spin up different instances of the app class
+    (with different config etc each)
+  - Profit! (Things like changing the complete app config per vhost, i.e.
+    writing a config loader / app class role which dispatches per vhost to
+    differently configured apps is piss easy)