X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=8fd77ad926538e929fb74e5dd93af02753b764b7;hp=41ce344070eada7f3c85186e28c9134867fb0b56;hb=6e3f9d973268bf6e117dcb0a5d775de61e22c418;hpb=c41cfce33f5510dee4937dfaaff2fd331130a84b diff --git a/TODO b/TODO index 41ce344..8fd77ad 100644 --- a/TODO +++ b/TODO @@ -1,99 +1,56 @@ -Pending patches: - - meta test for MX::Emulate::CAF needed by Catalyst::Plugin::Cache::Curried - - - Class::Accessor::Chained::Fast test for MX::Emulate::CAF, to fix - HTML::Widget - - - Re-opening packages with MX::Emulate::CAF (for - Catalyst::Plugin::HashedCookies) - - - Double-applying mk_accessors breaks, t/double_apply.t for MX::Emulate::CAF - -Back-compat investigation / known issues: +# Known Bugs: - - Plugins with new methods. - - Moose 'not inlining new method' warnings need to be fixed. - - Warning in Moose could also be more helpful.. - - Why does the current test not fail / warn? - - Generally unhappy with the on_end_of_scope immutable approach, - try removing new method from plugins (and emitting warning). + - Bug ->go or ->visit causes actions which have Args or CaptureArgs called + twice when called via ->go or ->visit. - - Common engine test failures, look into and get tests into core. + Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master - - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol - table as methods, tests + fix, or explanation and documentation? - (rafl & phaylon) +# Compatibility warnings to add: - - Run another round of repository smokes against latest 5.80 trunk, manually - go through all the things which are broken (t0m). - - - Catalyst::Plugin::Authorization::ACL - - Catalyst::Plugin::Server - - Should hopefully be fixed now.. - - - Catalyst-Plugin-Cache dies due to mk_accessors('meta') - - - Catalyst-Action-REST appears to have real issues, investigate - - - Catalyst-Model-Search ditto - - - CatalystX-CRUD ditto - - - Catalyst-Engine-Apache - Deep recursion on subroutine - "Catalyst::Action::execute", investigate once all other tests pass - - - Catalyst-Plugin-Scheduler - - Catalyst-Engine-HTTPEngine - - Catalyst-View-HTML-Template - - Catalyst-View-XSLT - - Catalyst-Plugin-Setenv - - Catalyst-Plugin-RequireSSL - Bullshit 'cannot locate' errors - Bug in smoke test rig. + - $self->config should warn as config should only ever be called as a + class method (TESTS). - - Issues with TWMC not being loaded when it used to be in 5.70 - (Bill Moseley) +# Proposed functionality / feature additions: - - Fix memory leaks (I already tried Devel::Leak::Object, but no joy). +## Log setup needs to be less lame - - In 5.70, you can have a component which doesn't inherit from ::Component, - and has no new method, and it'll do the right thing for you. We just - ignore that, we should still support that, but warn for/deprecate it so - it can go for 5.9X... - This all obviously needs better tests :/ +So Catalyst::Plugin::Log::* can die +in a fire. Having $c->log_class would be a good start. kane volunteered +to do some of this. -Cleanups: +Simple example: Catalyst::Plugin::Log::Colorful should just be a +subclass of Catalyst::Log, no ::Plugin:: needed. - - Catalyst-Model-Akismet, incorrectly inherits from - Catalyst::Component::InstancePerContext, should compose as a role. - Fix the module. - - - Update Test suite to not assume MyApp ISA Controller - - After that set up attr handlers that will output helpful error messages - when you do it as well as how to fix it. (done already?) +See also: Catalyst::Plugin::Log::Dispatch and +http://github.com/willert/catalyst-plugin-log4perl-simple/tree - - Eliminate all instances of $instance->{$key}, I think the only thing - left is lib/Catalyst/Engine/HTTP.pm: $self->{inputbuf}, which I haven't - touched as it is used as an lvalue in a lot of places (t0m) +# REFACTORING - - Find whatever in the test suite craps a file called GLOB(0xfoo) onto my - disk and fix it. (Believed to be in the optional TEST_HTTP tests?) (t0m) +## The horrible hack for plugin setup - replacing it: -Documentation: + * Have a look at the Devel::REPL BEFORE_PLUGIN stuff + I wonder if what we need is that combined with plugins-as-roles - - extends in components must be inside a BEGIN block. +## App / ctx split: - - How to write Moosified Catalyst components. + NOTE - these are notes that t0m thought up after doing back compat for + catalyst_component_class, may be inaccurate, wrong or missing things + bug mst (at least) to correct before trying more than the first 2 + steps. Please knock yourself out on the first two however :) - - Manual / Tutorial updates - - - Fix the Roadmap to be less full of lies. - -Profiling: - - - vs 5.70 and optimisation as needed. - -Tests: - - - Moosified test application? - - - Test warning from back-compat methods in Catalyst::Dispatcher + - Eliminate actions in MyApp from the main test suite + - Uncomment warning in C::C::register_action_methods, add tests it works + by mocking out the logging.. + - Remove MyApp @ISA controller (ask metaclass if it has attributes, and if + so you need back compat :/) + - Make Catalyst::Context, move the per request stuff in there, handles from + main app class to delegate + - Make an instance of the app class which is a global variable + - Make new instance of the context class, not the app class per-request + - Remove the components as class data, move to instance data on the app + class (you probably have to do this for _all_ the class data, good luck!) + - Make it possible for users to spin up different instances of the app class + (with different config etc each) + - Profit! (Things like changing the complete app config per vhost, i.e. + writing a config loader / app class role which dispatches per vhost to + differently configured apps is piss easy)