X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=7d3486343290ad54d89c890a0ac50fa2f9662203;hp=318654aa5eb1908cfed77830b156dc8968be9e95;hb=79f5d5718d885ee1c3f288159a31562f9cf5b02f;hpb=dae2b0faaf2982bde81606ea0392c13fd9309cb1 diff --git a/TODO b/TODO index 318654a..7d34863 100644 --- a/TODO +++ b/TODO @@ -1,69 +1,36 @@ -TBD pre 5.8000_04 dev release: +Known Bugs: - - Go through everything which used to use CAF, and ensure that it now uses MX::E::CAF + tests, - extending t/caf_backcompat.t and replacing t/custom_request.t (t0m) + - Bug ->go or ->visit causes actions which have Args or CaptureArgs called + twice when called via ->go or ->visit. - - Simple test for NEXT compat in core (t0m). + Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master - - Looks like stash is not available during prepare_path when running under - Catalyst::Test.. Run MojoMojo's t/01app.t and it will explode with - "Can't use an undefined value as a HASH reference" - test case for core - + fix maybe (marcus) +Compatibility warnings to add: ---- + - $self->config should warn as config should only ever be called as a + class method. - - Make the skipped test at the bottom of t/aggregate/live_engine_request_uri.t - pass / not be skipped. (From what C::P::SmartURI used to do) +Proposed functionality / feature additions: - This can be fixed by the following patch: + - Log setup needs to be less lame, so Catalyst::Plugin::Log::* can die + in a fire. Having $c->log_class would be a good start. kane volunteered + to do some of this. -Index: lib/Catalyst/Request.pm -=================================================================== ---- lib/Catalyst/Request.pm (revision 8709) -+++ lib/Catalyst/Request.pm (working copy) -@@ -96,7 +96,7 @@ - lazy => 1, - default => sub { - my $self = shift; -- return $self->path if $self->uri; -+ return $self->{path} if $self->{uri}; - }, - ); + Simple example: Catalyst::Plugin::Log::Colorful should just be a + subclass of Catalyst::Log, no ::Plugin:: needed. - But I'd like a 2nd opinion from someone who knows core better than me - about if that is the correct fix.. (t0m / Caelum) + See also: Catalyst::Plugin::Log::Dispatch and + http://github.com/willert/catalyst-plugin-log4perl-simple/tree - - Common engine test failures, look into and get tests into core. +TODO for brach namespace_handling_refactor: - - Catalyst-Plugin-Authorization-ACL, Can't locate object method "tree" via package "Catalyst::Dispatcher", fix the plugin as tree was never a public method. +- refactor code in + * Catalyst::Dispatcher::get_containers # No Idea + * Catalyst::Dispatcher::dispatch_type # DONE - - Catalyst-Model-Akismet, incorrectly inherits from Catalyst::Component::InstancePerContext, should compose as a role, fix the module. - - - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol table as methods, tests + fix? - - - Catalyst::Plugin::Cache::Curried - - Catalyst::Controller::WrapCGI - - Both import 'meta' into controller package - mst thinks this can be fixed?. - but @marcus> and the generated accessors even call $_[0]->meta, so I don't think we can remove it. - . Add a test for this in core. - . Fix core to use CMOP to look up metaclass, rather than ->meta method, and - namespace::clean the meta method out, fix generated accessors to do the same? - - - MooseX::Emulate::Class::Accessor::Fast - - Tests for uses of C::A::F from Catalyst repos. - t0m - - New release once these are done. - - - Update Test suite to not assume MyApp ISA Controller - - After that set up attr handlers that will output helpful error messages when you do it as well as how to fix it. (done already?) - - - Comments marked /Moose TODO/i in the code - - - Eliminate all instances of $instance->{$key} - - - Catalyst-Log-Log4perl - deep recursion in the test suite, investigate - - - Profiling vs 5.70 and optimisation as needed. - - - http://lists.scsys.co.uk/pipermail/catalyst-dev/2008-November/001546.html - - patch to list, andyg to look at? + * Catalyst::Controller::_parse_ActionClass_attr # DONE + * Catalyst::Dispatcher::_load_dispatch_types # DONE + * Catalyst::setup_plugins # DONE + to use the same namespacing method +- Ok, so can you add tests for ->config(actions => { foo => { ActionClass => '+Bar' }});