X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=5e3c68e4339e3ae8d7fc76401f13e33250366d48;hp=94d2badb79c2f124e177d3e81edfd1976c090514;hb=gsoc_breadboard;hpb=b8c160a4a02cba800468b8bba63e244da662b694 diff --git a/TODO b/TODO index 94d2bad..5e3c68e 100644 --- a/TODO +++ b/TODO @@ -24,14 +24,8 @@ subclass of Catalyst::Log, no ::Plugin:: needed. See also: Catalyst::Plugin::Log::Dispatch and http://github.com/willert/catalyst-plugin-log4perl-simple/tree -## Capture arguments that the plack engine component was run with somewhere, - to more easily support custom args from scripts (e.g. Gitalist's - --git_dir) - ## throw away the restarter and allow using the restarters Plack provides -## remove per-request state from the engine instance - ## be smarter about how we use PSGI - not every response needs to be delayed and streaming @@ -40,23 +34,6 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree * Have a look at the Devel::REPL BEFORE_PLUGIN stuff I wonder if what we need is that combined with plugins-as-roles -# PSGI - -## To do at release time - - - Release psgi branch of Catalyst-Devel - - Release new Task::Catalyst - - Release 5.9 branch of Catalyst-Manual - - Release Catalyst::Engine::HTTP::Prefork with deprecation notice - + exit in Makefile.PL if Catalyst > 5.89 is installed. - -## Blockers - - * I've noticed a small difference with Catalyst::Test. The latest stable - version include two headers, 'host' and 'https'. They are missing from - this version - Pedro Melo on list - ^^ Cannot replicate this? Mailed back to ask for tests.. - # App / ctx split: NOTE - these are notes that t0m thought up after doing back compat for @@ -101,10 +78,8 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree - expand_component_module - - sugar is still not completely implemented - - Some back compat - - wrappers around setup_component, setup_components, locate_components in Catalyst.pm + - wrappers around setup_component, setup_components in Catalyst.pm - $instance->expand_modules - search_extra - Crazy tests for things such as: @@ -114,59 +89,89 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree ... } -##### Need planning, have questions: +##### Items for discussion and planning +# (in no particular order, just numbered to be more easily refered to) + + 1) per request life cycle - - per request life cycle + 2) sugar syntax - - sugar - we should discuss the syntax with rafl and edenc + 3) when / when not COMPONENT should be called - - when / when not COMPONENT should be called + 4) problems when get_all_components() is called when there is no 'context' yet - - locate_components service vs setup_components method - - can we be more lazy? - - should setup_components be a service that things like the ->component lookup - can depend on? + 5) Back compat problems: + - expand_component_module + - $instance->expand_modules + - search_extra + - what to do when a user overrides the locate_components method? - - There are a few more FIXMEs, idk if any relevant here + 6) locate_components service vs setup_components method + - can we be more lazy? + - should setup_components be a service that things like the ->component lookup + can depend on? -### Next steps - planned: + 7) $class->log->warn is being used to give warnings, but maybe there is a + better way to do it - - some imports need to get the importing package in Catalyst::IOC - - done - needs testing + 8) the ConstructorInjection depends on the application_name, which probably + makes app/ctx split harder. We need a way to get the application instance + passed properly. - - Back compat for Catalyst.pm moved methods (locate_components) - - done - needs testing + 9) there is a call in Catalyst::Controller to catalyst_component_name class + accessor (which doesn't exist anymore). - - Test custom container - - writing some tests which verify that the models you think should be - there are there, and that they received their dependencies as arguments - - i.e. Model::Bar should get params { foo => $model_foo } when being - constructed, etc - - Need to test that if you have a standard component Frotz - and a customized component Fnar, and Fnar depends on Frotz - - And yeah, some tests that the customised components actually work via - $c->model('Foo'), and that COMPONENT is called (or not called) - as appropiate and that ACCEPT_CONTEXT is called (or not) as appropriate + 10) make ACCEPT_CONTEXT and COMPONENT optional in Catalyst::IOC::BlockInjection and Catalyst::IOC::ConstructorInjection + - Create COMPONENTSingleton life cycle -### Next steps - less planned: + 11) we build the service too early, causing the COMPONENT method to be + called early, breaking components which build other components (e.g. + Model::DBIC::Schema). - - make ACCEPT_CONTEXT and COMPONENT optional in Catalyst::IOC::BlockInjection and Catalyst::IOC::ConstructorInjection - - Create COMPONENTSingleton life cycle + 12) root service has a very ambiguous name - maybe root_dir? - - Creating service()-like sugar for component + 13) should _get_component_type_name (in Catalyst::IOC::Container) exist? - - Test cases for extending the container in an application. - - Using the sugar added in the previous item - - Test when Model::Foo depends_on Model::Bar - - Test for component Foo => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on("config") } ) - - Fix ^^ so that you can get your component's namespaced config nicely. + 14) Test cases for extending the container in an application. + - Using the sugar added in the previous item + - Test when Model::Foo depends_on Model::Bar + - Test for component Foo => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on("config") } ) + - Fix ^^ so that you can get your component's namespaced config nicely. + + 15) Tests for using the container outside of Catalyst + - Custom container which adds some (very simple) services which are initialized from + the application config file (note plain services, not components) + - Depend on (and test) these inside Catalyst + - Test loading container outside Catalyst, and these services working + - Test Catalyst / MyApp is not loaded + + 16) _build_(request|response)_constructor_args need replicating in + this branch. + +### Next steps + + - Push the config built in the container back up onto the app + + - Find a better way to make path_to work. Current fix is in + Catalyst::IOC::Container, subs build_home_service, build_root_service. + + - Improve validation on the 'component' methods in Catalyst::IOC + (check the type of the component, etc) + + - Thigs to test: + - Imports getting the importing package in Catalyst::IOC + - Back compat for Catalyst.pm moved methods (locate_components) + - Custom container + - writing some tests which verify that the models you think should be + there are there, and that they received their dependencies as arguments + - i.e. Model::Bar should get params { foo => $model_foo } when being + constructed, etc + - Need to test that if you have a standard component Frotz + and a customized component Fnar, and Fnar depends on Frotz + - And yeah, some tests that the customised components actually work via + $c->model('Foo'), and that COMPONENT is called (or not called) + as appropiate and that ACCEPT_CONTEXT is called (or not) as appropriate - - Tests for using the container outside of Catalyst - - Custom container which adds some (very simple) services which are initialized from - the application config file (note plain services, not components) - - Depend on (and test) these inside Catalyst - - Test loading container outside Catalyst, and these services working - - Test Catalyst / MyApp is not loaded #### Extending my app, notes @@ -177,7 +182,7 @@ and what needs to be done to fix it! package MyApp::Container; use Catalyst::IOC; - + container $self, as { container model => as { component Foo => (); # As per default! @@ -185,11 +190,11 @@ use Catalyst::IOC; component Baz => ( lifecycle => 'InstancePerContext ); component Quux => ( lifecycle => 'Singleton' ); # ACCEPT_CONTEXT not called # Catalyst::Model::Adaptor example - conponent Fnar => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on('config')} ); + component Fnar => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on('config')} ); # ^^ FIXME - gets whole config, not Model::Foo # There should be a 'nice' way to get the 'standard' config - }; - # Note - implementation of BB may need to be changed to support making sure existing + }; + # Note - implementation of BB may need to be changed to support making sure existing # services actually get overridden. not sure how the default container behaves when doing that # above code would build the constructor injection as it currently does, # defaulting to the class name in the right namespace as declared by the surrounding container