X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=2dd12f7840c0634778d5a503b6477fbe0c33f2d7;hp=7b76bf9a22a520e02f11017bd254db24dcfca2c0;hb=d2598ac82e8508f4d6da90ec60a1ed60840c2016;hpb=9de04be2409ca5e726e2300090359ed3e066f4e4 diff --git a/TODO b/TODO index 7b76bf9..2dd12f7 100644 --- a/TODO +++ b/TODO @@ -1,77 +1,63 @@ -Pending patches: - - meta test for MX::Emulate::CAF needed by Catalyst::Plugin::Cache::Curried - http://code2.0beta.co.uk/moose/svnweb/index.cgi/moose/revision?rev=7036 - (groditi) +# Known Bugs: - - batman's chained patch / issue? + - Bug ->go or ->visit causes actions which have Args or CaptureArgs called + twice when called via ->go or ->visit. - - Adopt::NEXT - - New warning message + updated docs with how it works (t0m/rafl) + Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master -Known issues: + - Bricas' Exception blog post - - Fix t/caf_backcompat_plugin_accessor_override.t - complex case - to do with class data / instance data.. Maybe need better tests? + http://bricas.vox.com/library/post/catalyst-exceptionclass.html -Cleanups: + Broken by recent exception refactoring - - Fix 'as soon as Class::MOP 0.67 + 1 is released - Class::MOP::load_class($class) can be used instead' in Catalyst::Utils - (t0m) - - - Provide an env var in Adopt::NEXT to just turn the warnings off globally? +# Compatibility warnings to add: - - Catalyst-Plugin-Authorization-ACL, Can't locate object method "tree" - via package "Catalyst::Dispatcher", fix the plugin as tree was never - a public method. + - $self->config should warn as config should only ever be called as a + class method. - - Catalyst-Model-Akismet, incorrectly inherits from - Catalyst::Component::InstancePerContext, should compose as a role. - Fix the module. - - - Update Test suite to not assume MyApp ISA Controller - - After that set up attr handlers that will output helpful error messages - when you do it as well as how to fix it. (done already?) +# Proposed functionality / feature additions: - - Comments marked /Moose TODO/i in Catalyst::Request re {_body} (t0m) +## Log setup needs to be less lame - - Eliminate all instances of $instance->{$key}, I think the only thing - left is lib/Catalyst/Engine/HTTP.pm: $self->{inputbuf}, which I haven't - touched as it is used as an lvalue in a lot of places (t0m) +So Catalyst::Plugin::Log::* can die +in a fire. Having $c->log_class would be a good start. kane volunteered +to do some of this. - - Find whatever in the test suite craps a file called GLOB(0xfoo) onto my - disk and fix it. (Believed to be in the optional tests?) (t0m) +Simple example: Catalyst::Plugin::Log::Colorful should just be a +subclass of Catalyst::Log, no ::Plugin:: needed. -Documentation: +See also: Catalyst::Plugin::Log::Dispatch and +http://github.com/willert/catalyst-plugin-log4perl-simple/tree - - extends in components must be inside a BEGIN block. +# REFACTORING - - How to write Moosified Catalyst components. +## The horrible hack for plugin setup - replacing it: - - Manual / Tutorial updates + * Have a look at the Devel::REPL BEFORE_PLUGIN stuff + I wonder if what we need is that combined with plugins-as-roles - - Fix the Roadmap to be less full of lies. +## App / ctx split: -Profiling: + NOTE - these are notes that t0m thought up after doing back compat for + _component_class, may be inaccurate, wrong or missing things + bug mst (at least) to correct before trying more than the first 2 + steps. Please knock yourself out on the first two however :) - - vs 5.70 and optimisation as needed. + - Eliminate actions in MyApp from the main test suite + - Uncomment warning in C::C::register_action_methods, add tests it works + by mocking out the logging.. + - Remove MyApp @ISA controller (ask metaclass if it has attributes, and if + so you need back compat :/) + - Make Catalyst::Context, move the per request stuff in there, handles from + main app class to delegate + - Make an instance of the app class which is a global variable + - Make new instance of the context class, not the app class per-request + - Remove the components as class data, move to instance data on the app + class (you probably have to do this for _all_ the class data, good luck!) + - Make it possible for users to spin up different instances of the app class + (with different config etc each) + - Profit! (Things like changing the complete app config per vhost, i.e. + writing a config loader / app class role which dispatches per vhost to + differently configured apps is piss easy) -Back-compat investigation: - - - Common engine test failures, look into and get tests into core. - - - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol - table as methods, tests + fix, or explanation and documentation? - (rafl & phaylon) - - - Run another round of repository smokes against latest 5.80 trunk, manually - go through all the things which are broken (t0m). - - - Issues with TWMC not being loaded when it used to be in 5.70 - (Bill Moseley) - - - Fix memory leaks (I already tried Devel::Leak::Object, but no joy). - -Tests: - - - Moosified test application?