X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=2dd12f7840c0634778d5a503b6477fbe0c33f2d7;hp=69fdf4d9f3945f2fdf931058af8c25e063efb7d8;hb=48d435ba6a0925260fd58c8c18ff425e99708eae;hpb=6a8f85af6d0032d3f6aecc0ce9420ceb523910b2 diff --git a/TODO b/TODO index 69fdf4d..2dd12f7 100644 --- a/TODO +++ b/TODO @@ -1,52 +1,63 @@ -Known Bugs: +# Known Bugs: - - Bug ->go or ->visit causes actions which have Args or CaptureArgs caled + - Bug ->go or ->visit causes actions which have Args or CaptureArgs called twice when called via ->go or ->visit. Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master + - Bricas' Exception blog post - - Certain errors in your application to do with using other code which does - not exist can cause an 'Unknown error' issue. + http://bricas.vox.com/library/post/catalyst-exceptionclass.html - This is now fixed, by moving back to B::Hooks::EndOfScope, but this (used - to) cause issues with the following modules: + Broken by recent exception refactoring - - Catalyst-Plugin-Session-State-Cookie - - Catalyst-Plugin-Session-Store-FastMmap - - Catalyst-Plugin-Session-PerUser - - Catalyst-Plugin-Session-Store-File - - Catalyst-Authentication-Credential-HTTP - - Catalyst-Plugin-SmartURI +# Compatibility warnings to add: - according to comments in r8991. Retest these before shipping anything.. + - $self->config should warn as config should only ever be called as a + class method. - - -restarter.t will fail if you don't have ::StashChange installed, and - also quite often at other times. +# Proposed functionality / feature additions: +## Log setup needs to be less lame - - Catalyst::Test - bugs with Moosification (Khisanth/kane) +So Catalyst::Plugin::Log::* can die +in a fire. Having $c->log_class would be a good start. kane volunteered +to do some of this. - - Attribute called 'actions' in controllers - needs to be renamed to _actions. +Simple example: Catalyst::Plugin::Log::Colorful should just be a +subclass of Catalyst::Log, no ::Plugin:: needed. - - before finalize causes you to miserably fail to call plugins finalize - method (dmaki) +See also: Catalyst::Plugin::Log::Dispatch and +http://github.com/willert/catalyst-plugin-log4perl-simple/tree -Compatibility warnings to add: +# REFACTORING - - $self->config should warn as config should only ever be called as a - class method. +## The horrible hack for plugin setup - replacing it: -Proposed functionality / feature additions: + * Have a look at the Devel::REPL BEFORE_PLUGIN stuff + I wonder if what we need is that combined with plugins-as-roles - - Log setup needs to be less lame, so Catalyst::Plugin::Log::* can die - in a fire. Having $c->log_class would be a good start. kane volunteered - to do some of this. +## App / ctx split: - Simple example: Catalyst::Plugin::Log::Colorful should just be a - subclass of Catalyst::Log, no ::Plugin:: needed. - - See also: Catalyst::Plugin::Log::Dispatch and - http://github.com/willert/catalyst-plugin-log4perl-simple/tree + NOTE - these are notes that t0m thought up after doing back compat for + _component_class, may be inaccurate, wrong or missing things + bug mst (at least) to correct before trying more than the first 2 + steps. Please knock yourself out on the first two however :) + - Eliminate actions in MyApp from the main test suite + - Uncomment warning in C::C::register_action_methods, add tests it works + by mocking out the logging.. + - Remove MyApp @ISA controller (ask metaclass if it has attributes, and if + so you need back compat :/) + - Make Catalyst::Context, move the per request stuff in there, handles from + main app class to delegate + - Make an instance of the app class which is a global variable + - Make new instance of the context class, not the app class per-request + - Remove the components as class data, move to instance data on the app + class (you probably have to do this for _all_ the class data, good luck!) + - Make it possible for users to spin up different instances of the app class + (with different config etc each) + - Profit! (Things like changing the complete app config per vhost, i.e. + writing a config loader / app class role which dispatches per vhost to + differently configured apps is piss easy)