X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=2dd12f7840c0634778d5a503b6477fbe0c33f2d7;hp=47a80139adfa0a57e19094ae3a3e5e82ac6ca20a;hb=d2598ac82e8508f4d6da90ec60a1ed60840c2016;hpb=74c89dead3cfd8e95cbe853adbc6fe9eed539f4e diff --git a/TODO b/TODO index 47a8013..2dd12f7 100644 --- a/TODO +++ b/TODO @@ -1,33 +1,63 @@ - - Fix t/caf_backcompat_plugin_accessor_override.t - - - Looks like stash is not available during prepare_path when running under - Catalyst::Test.. Run MojoMojo's t/01app.t and it will explode with - "Can't use an undefined value as a HASH reference" - test case for core - + fix maybe (marcus) +# Known Bugs: - - Common engine test failures, look into and get tests into core. + - Bug ->go or ->visit causes actions which have Args or CaptureArgs called + twice when called via ->go or ->visit. - - Catalyst-Plugin-Authorization-ACL, Can't locate object method "tree" via package "Catalyst::Dispatcher", fix the plugin as tree was never a public method. + Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master - - Catalyst-Model-Akismet, incorrectly inherits from Catalyst::Component::InstancePerContext, should compose as a role, fix the module. + - Bricas' Exception blog post - - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol table as methods, tests + fix? + http://bricas.vox.com/library/post/catalyst-exceptionclass.html - - MooseX::Emulate::Class::Accessor::Fast - - Tests for uses of C::A::F from Catalyst repos. - t0m - - New release once these are done. + Broken by recent exception refactoring - - Update Test suite to not assume MyApp ISA Controller - - After that set up attr handlers that will output helpful error messages when you do it as well as how to fix it. (done already?) - - - Comments marked /Moose TODO/i in the code - - - Eliminate all instances of $instance->{$key} +# Compatibility warnings to add: - - Catalyst-Log-Log4perl - deep recursion in the test suite, investigate + - $self->config should warn as config should only ever be called as a + class method. - - Profiling vs 5.70 and optimisation as needed. +# Proposed functionality / feature additions: - - http://lists.scsys.co.uk/pipermail/catalyst-dev/2008-November/001546.html - - patch to list, andyg to look at? +## Log setup needs to be less lame + +So Catalyst::Plugin::Log::* can die +in a fire. Having $c->log_class would be a good start. kane volunteered +to do some of this. + +Simple example: Catalyst::Plugin::Log::Colorful should just be a +subclass of Catalyst::Log, no ::Plugin:: needed. + +See also: Catalyst::Plugin::Log::Dispatch and +http://github.com/willert/catalyst-plugin-log4perl-simple/tree + +# REFACTORING + +## The horrible hack for plugin setup - replacing it: + + * Have a look at the Devel::REPL BEFORE_PLUGIN stuff + I wonder if what we need is that combined with plugins-as-roles + +## App / ctx split: + + NOTE - these are notes that t0m thought up after doing back compat for + _component_class, may be inaccurate, wrong or missing things + bug mst (at least) to correct before trying more than the first 2 + steps. Please knock yourself out on the first two however :) + + - Eliminate actions in MyApp from the main test suite + - Uncomment warning in C::C::register_action_methods, add tests it works + by mocking out the logging.. + - Remove MyApp @ISA controller (ask metaclass if it has attributes, and if + so you need back compat :/) + - Make Catalyst::Context, move the per request stuff in there, handles from + main app class to delegate + - Make an instance of the app class which is a global variable + - Make new instance of the context class, not the app class per-request + - Remove the components as class data, move to instance data on the app + class (you probably have to do this for _all_ the class data, good luck!) + - Make it possible for users to spin up different instances of the app class + (with different config etc each) + - Profit! (Things like changing the complete app config per vhost, i.e. + writing a config loader / app class role which dispatches per vhost to + differently configured apps is piss easy)