X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=2683e0ce0310aed19e58646edb62c3d036e7468c;hp=e53739b39127f76dcf604625d1265ab0b3ec8cd2;hb=6f009cc62849c974d53b1094284bb1089082be07;hpb=72697c1dd132db9c4df3ec69e770cb3592f44382 diff --git a/TODO b/TODO index e53739b..2683e0c 100644 --- a/TODO +++ b/TODO @@ -24,59 +24,40 @@ subclass of Catalyst::Log, no ::Plugin:: needed. See also: Catalyst::Plugin::Log::Dispatch and http://github.com/willert/catalyst-plugin-log4perl-simple/tree -# REFACTORING +## Capture arguments that the plack engine component was run with somewhere, + to more easily support custom args from scripts (e.g. Gitalist's + --git_dir) -## PSGI +## throw away the restarter and allow using the restarters Plack provides -### To do at release time +## remove per-request state from the engine instance - - Release psgi branch of Catalyst-Devel - - Release new Task::Catalyst - - Release 5.9 branch of Catalyst-Manual - -### Blockers +## be smarter about how we use PSGI - not every response needs to be delayed + and streaming - * Test::WWW::Mechanize::Catalyst new release +# The horrible hack for plugin setup - replacing it: - * Test everything in the %conflicts list + * Have a look at the Devel::REPL BEFORE_PLUGIN stuff + I wonder if what we need is that combined with plugins-as-roles - * Test tutorial apps +# PSGI - * Test nginx middleware to determine if it is needed with: +## To do at release time - root app - with use_request_uri_for_path - root app - without use_request_uri_for_path - non-root app - with use_request_uri_for_path - non-root app - without use_request_uri_for_path + - Release psgi branch of Catalyst-Devel + - Release new Task::Catalyst + - Release 5.9 branch of Catalyst-Manual + - Release Catalyst::Engine::HTTP::Prefork with deprecation notice + + exit in Makefile.PL if Catalyst > 5.89 is installed. - If it isn't needed, remove. If it is needed, split it out into it's own - file and document why it's needed. +## Blockers * I've noticed a small difference with Catalyst::Test. The latest stable version include two headers, 'host' and 'https'. They are missing from this version - Pedro Melo on list ^^ Cannot replicate this? Mailed back to ask for tests.. -### Nice to have - - * Test/WWW/Mechanize/Catalyst.pm stable throws a deprecation alert when - using Catalyst::Test changes introduced by Cataplack. Suggested fix is - in the repo: http://dev.catalystframework.org/svnweb/Catalyst/revision?rev=14059 - - * Capture arguments that the plack engine component was run with somewhere, - to more easily support custom args from scripts (e.g. Gitalist's - --git_dir) - * throw away the restarter and allow using the restarters Plack provides - * remove per-request state from the engine instance - * be smarter about how we use PSGI - not every response needs to be delayed - and streaming - -## The horrible hack for plugin setup - replacing it: - - * Have a look at the Devel::REPL BEFORE_PLUGIN stuff - I wonder if what we need is that combined with plugins-as-roles - -## App / ctx split: +# App / ctx split: NOTE - these are notes that t0m thought up after doing back compat for catalyst_component_class, may be inaccurate, wrong or missing things @@ -99,3 +80,118 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree - Profit! (Things like changing the complete app config per vhost, i.e. writing a config loader / app class role which dispatches per vhost to differently configured apps is piss easy) + +## GSOC + +### Final steps for GSOC + +##### Things that work: + + - the default container loads all components, calls ACCEPT_CONTEXT() when appropriate, and COMPONENT() when appropriate, behaving like current Catalyst does + + - its possible to create a custom container, and override the components you want. Lifecycle, class, dependencies, all overridable. + + - config files are loaded without Catalyst::Plugin::ConfigLoader + + - per request life cycle somewhat works + + - external modules are loaded just using a custom container, much like Catalyst::Model::Adaptor + +##### Things that don't work: + + - expand_component_module + + - sugar is still not completely implemented + + - Some back compat + - wrappers around setup_component, setup_components, locate_components in Catalyst.pm + - $instance->expand_modules + - search_extra + - Crazy tests for things such as: + sub COMPONENT { + ... + *${appclass}::Model::TopLevel::GENERATED::ACCEPT_CONTEXT = sub { ... }; + ... + } + +##### Need planning, have questions: + + - per request life cycle + + - sugar - we should discuss the syntax with rafl and edenc + + - when / when not COMPONENT should be called + + - locate_components service vs setup_components method + - can we be more lazy? + - should setup_components be a service that things like the ->component lookup + can depend on? + + - There are a few more FIXMEs, idk if any relevant here + +### Next steps - planned: + + - some imports need to get the importing package in Catalyst::IOC + - done - needs testing + + - Back compat for Catalyst.pm moved methods (locate_components) + - done - needs testing + + - Test custom container + - writing some tests which verify that the models you think should be + there are there, and that they received their dependencies as arguments + - i.e. Model::Bar should get params { foo => $model_foo } when being + constructed, etc + - Need to test that if you have a standard component Frotz + and a customized component Fnar, and Fnar depends on Frotz + - And yeah, some tests that the customised components actually work via + $c->model('Foo'), and that COMPONENT is called (or not called) + as appropiate and that ACCEPT_CONTEXT is called (or not) as appropriate + +### Next steps - less planned: + + - make ACCEPT_CONTEXT and COMPONENT optional in Catalyst::IOC::BlockInjection and Catalyst::IOC::ConstructorInjection + - Create COMPONENTSingleton life cycle + + - Test cases for extending the container in an application. + - Using the sugar added in the previous item + - Test when Model::Foo depends_on Model::Bar + - Test for component Foo => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on("config") } ) + - Fix ^^ so that you can get your component's namespaced config nicely. + + - Tests for using the container outside of Catalyst + - Custom container which adds some (very simple) services which are initialized from + the application config file (note plain services, not components) + - Depend on (and test) these inside Catalyst + - Test loading container outside Catalyst, and these services working + - Test Catalyst / MyApp is not loaded + +#### Extending my app, notes + +Basically try to implement something like this (starting out without the sugar!), and see how it breaks +and what needs to be done to fix it! + +##### Eventual syntax + +package MyApp::Container; +use Catalyst::IOC; + + container $self, as { + container model => as { + component Foo => (); # As per default! + component Bar => (dependencies => ['/model/Foo']); # Magic! + component Baz => ( lifecycle => 'InstancePerContext ); + component Quux => ( lifecycle => 'Singleton' ); # ACCEPT_CONTEXT not called + # Catalyst::Model::Adaptor example + conponent Fnar => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on('config')} ); + # ^^ FIXME - gets whole config, not Model::Foo + # There should be a 'nice' way to get the 'standard' config + }; + # Note - implementation of BB may need to be changed to support making sure existing + # services actually get overridden. not sure how the default container behaves when doing that + # above code would build the constructor injection as it currently does, + # defaulting to the class name in the right namespace as declared by the surrounding container + # as well as adding using the catalyst-specific service class + }; + +1;