X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=TODO;h=141b67b4628d1b676f7c4364b9da5e37c6d209db;hp=d101589c0c54d3a1d50f6f81d317f0b7db8fd48b;hb=139b894c380e870c0b25ea20749cc6f689d93fa0;hpb=6cb9e3832b3faf55e2990e9bff51c709a8cfc4fb diff --git a/TODO b/TODO index d101589..141b67b 100644 --- a/TODO +++ b/TODO @@ -1,45 +1,49 @@ -TBD pre 5.8000_04 dev release: - - - Simple test for NEXT compat in core (t0m). - - - Looks like stash is not available during prepare_path when running under - Catalyst::Test.. Run MojoMojo's t/01app.t and it will explode with - "Can't use an undefined value as a HASH reference" - test case for core - + fix maybe (marcus) - ---- - - - Common engine test failures, look into and get tests into core. - - - Catalyst-Plugin-Authorization-ACL, Can't locate object method "tree" via package "Catalyst::Dispatcher", fix the plugin as tree was never a public method. - - - Catalyst-Model-Akismet, incorrectly inherits from Catalyst::Component::InstancePerContext, should compose as a role, fix the module. - - - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol table as methods, tests + fix? - - - Catalyst::Plugin::Cache::Curried - - Catalyst::Controller::WrapCGI - - Both import 'meta' into controller package - mst thinks this can be fixed?. - but @marcus> and the generated accessors even call $_[0]->meta, so I don't think we can remove it. - . Add a test for this in core. - . Fix core to use CMOP to look up metaclass, rather than ->meta method, and - namespace::clean the meta method out, fix generated accessors to do the same? - - - MooseX::Emulate::Class::Accessor::Fast - - Tests for uses of C::A::F from Catalyst repos. - t0m - - New release once these are done. - - - Update Test suite to not assume MyApp ISA Controller - - After that set up attr handlers that will output helpful error messages when you do it as well as how to fix it. (done already?) - - - Comments marked /Moose TODO/i in the code - - - Eliminate all instances of $instance->{$key} - - - Catalyst-Log-Log4perl - deep recursion in the test suite, investigate - - - Profiling vs 5.70 and optimisation as needed. - - - http://lists.scsys.co.uk/pipermail/catalyst-dev/2008-November/001546.html - - patch to list, andyg to look at? - +Known Bugs: + + - Bug ->go or ->visit causes actions which have Args or CaptureArgs called + twice when called via ->go or ->visit. + + Test app: http://github.com/bobtfish/catalyst-app-bug-go_chain/tree/master + +Compatibility warnings to add: + + - $self->config should warn as config should only ever be called as a + class method. + +Proposed functionality / feature additions: + + - Log setup needs to be less lame, so Catalyst::Plugin::Log::* can die + in a fire. Having $c->log_class would be a good start. kane volunteered + to do some of this. + + Simple example: Catalyst::Plugin::Log::Colorful should just be a + subclass of Catalyst::Log, no ::Plugin:: needed. + + See also: Catalyst::Plugin::Log::Dispatch and + http://github.com/willert/catalyst-plugin-log4perl-simple/tree + + Fixes to component interfaces to deal with anon classes: + +22:16 <@mst> t0m: explain what breaks +22:16 <@mst> I'm not 100% sure we have the same problem in mind +22:17 <@t0m> well, various shit in Catalyst utils to resolve app from MyApp::Controller::Foo breaks +22:17 <@mst> Caelum: http://scsys.co.uk:8001/31240 +22:17 <@mst> t0m: the trick would be to not need to do that +22:17 <@mst> t0m: $self->_application should be fine +22:18 <@t0m> $action->class can't be fed back into $c->component() +22:18 <@t0m> which breaks ::REST +22:18 <@mst> right +22:18 <@mst> we need to +22:19 <@mst> (a) add an ->_component_name or similar method to controllers +22:19 <@mst> (b) pass action objects either that or the controller +22:20 <@t0m> do you have a controller calling $action->dispatch? Course you must, the action lives in a controller.. +22:21 <@mst> and that doesn't matter anyway +22:21 <@mst> dispatch has $c +22:21 <@mst> it needs to do +22:21 <@mst> $c->component($self->_component_name) +22:21 <@mst> and that _component_name needs to come from the controller at register_actions time +22:22 <@t0m> confound: Oi, please to be releasing my Action::REST fixes, I'm about to do more.. +22:22 <@t0m> mst: right, gotcha +22:22 <@mst> note that needs to happen in core +22:22 <@mst> then actions can use that instead of $self->class +22:22 <@mst> and shit will work