some todos

[catagits/Catalyst-Runtime.git] / lib / Catalyst / IOC / Container.pm

diff --git a/lib/Catalyst/IOC/Container.pm b/lib/Catalyst/IOC/Container.pm
index 0832f63..b89fd96 100644 (file)
--- a/lib/Catalyst/IOC/Container.pm
+++ b/lib/Catalyst/IOC/Container.pm
@@ -681,6 +681,8 @@ sub _find_component_regexp {
 # user overrides the container (which is what we want), the sub-container they
 # will use is precisely $type, not 'component'. So for now, I'm returning both
 # services, to decide later what to do.
+# TODO
+# add pod, remove code repetition
 sub get_all_component_services {
     my $self = shift;
 
@@ -711,6 +713,8 @@ sub get_all_component_services {
     return lock_hash %components;
 }
 
+# TODO
+# add pod, remove code repetition
 sub get_all_singleton_lifecycle_components {
     my $self = shift;
 
@@ -739,16 +743,12 @@ sub get_all_singleton_lifecycle_components {
     return lock_hash %components;
 }
 
+# TODO
+# remove code repetition
 sub get_all_components {
     my ($self, $class) = @_;
     my %components;
 
-    # FIXME - if we're getting from these containers, we need to either:
-    #   - pass 'ctx' and 'accept_context_args' OR
-    #   - make these params optional
-    # big problem when setting up the dispatcher - this method is called
-    # as $container->get_all_components('MyApp'). What to do with Request
-    # life cycles?
     foreach my $type (qw/model view controller /) {
         my $container = $self->get_sub_container($type);