include test for failure mode

[catagits/Catalyst-Runtime.git] / lib / Catalyst / Component.pm

diff --git a/lib/Catalyst/Component.pm b/lib/Catalyst/Component.pm
index 2950f44..80fc838 100644 (file)
--- a/lib/Catalyst/Component.pm
+++ b/lib/Catalyst/Component.pm
@@ -2,8 +2,9 @@ package Catalyst::Component;
 
 use Moose;
 use Class::MOP;
-use MooseX::Adopt::Class::Accessor::Fast;
+use Class::MOP::Object;
 use Catalyst::Utils;
+use Class::C3::Adopt::NEXT;
 use MRO::Compat;
 use mro 'c3';
 
@@ -55,18 +56,18 @@ component loader with config() support and a process() method placeholder.
 =cut
 
 __PACKAGE__->mk_classdata('_plugins');
+__PACKAGE__->mk_classdata('_config');
 
-around new => sub {
-    my ( $orig, $self) = @_;
-
+sub BUILDARGS {
+    my ($self) = @_;
+    
     # Temporary fix, some components does not pass context to constructor
     my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {};
 
     my $args =  $self->merge_config_hashes( $self->config, $arguments );
-    $self->$orig( $args );
-};
-
-no Moose;
+    
+    return $args;
+}
 
 sub COMPONENT {
     my ( $self, $c ) = @_;
@@ -76,46 +77,35 @@ sub COMPONENT {
     if( my $next = $self->next::can ){
       my $class = blessed $self || $self;
       my ($next_package) = Class::MOP::get_code_info($next);
-      warn "There is a COMPONENT method resolving after Catalyst::Component in ${next_package}. This behavior is deprecated and will stop working in future releases.";
-      return $next->($self, $arguments);
+      warn "There is a COMPONENT method resolving after Catalyst::Component in ${next_package}.\n";
+      warn "This behavior can no longer be supported, and so your application is probably broken.\n";
+      warn "Your linearised isa hierarchy is: " . join(', ', mro::get_linear_isa($class)) . "\n";
+      warn "Please see perldoc Catalyst::Upgrading for more information about this issue.\n";
     }
     return $self->new($c, $arguments);
 }
 
 sub config {
-  my $self = shift;
-  my $class = blessed $self || $self;
-
-  my $config;
-  my $meta = $class->meta;
-  if( $meta->has_package_symbol('$config') ){
-      $config = ${ $meta->get_package_symbol('$config') };
-  } else {
-    foreach my $super ( $meta->linearized_isa ) {
-      my $super_meta = Moose::Meta::Class->initialize($super);
-      if( $super_meta->has_package_symbol('$config') ){
-        $config = ${ $super_meta->get_package_symbol('$config') };
-        unless( @_ ){ #don't copy and write it twice
-          $config = $class->merge_config_hashes( $config, {} );
-          $meta->add_package_symbol('$config', \ $config);
+    my $self = shift;
+    my $config = $self->_config || {};
+    if (@_) {
+        my $newconfig = { %{@_ > 1 ? {@_} : $_[0]} };
+        $self->_config(
+            $self->merge_config_hashes( $config, $newconfig )
+        );
+    } else {
+        # this is a bit of a kludge, required to make
+        # __PACKAGE__->config->{foo} = 'bar';
+        # work in a subclass.
+        my $class = blessed($self) || $self;
+        my $meta = Class::MOP::get_metaclass_by_name($class);
+        unless ($meta->has_package_symbol('$_config')) {
+
+            $config = $self->merge_config_hashes( $config, {} );
+            $self->_config( $config );
         }
-        last;
-      }
     }
-  }
-
-  unless( defined $config ){
-    $config = {};
-    $meta->add_package_symbol('$config', \ $config) unless @_;
-  }
-
-  if (@_) {
-    my $from_args = { %{@_ > 1 ? {@_} : $_[0]} };
-    my $new_config = $class->merge_config_hashes( $config, $from_args);
-    $meta->add_package_symbol('$config', \ $new_config);
-  }
-
-  return $config;
+    return $config;
 }
 
 sub merge_config_hashes {
@@ -130,6 +120,7 @@ sub process {
           . " did not override Catalyst::Component::process" );
 }
 
+no Moose;
 
 __PACKAGE__->meta->make_immutable;
 1;
@@ -179,7 +170,7 @@ Alias for the method in L<Catalyst::Utils>.
 
 =head2 ACCEPT_CONTEXT($c, @args)
 
-Catalyst components are normally initalized during server startup, either
+Catalyst components are normally initialized during server startup, either
 as a Class or a Instance. However, some components require information about
 the current request. To do so, they can implement an ACCEPT_CONTEXT method.
 
@@ -193,11 +184,9 @@ calling code in the application rather than the component itself.
 
 L<Catalyst>, L<Catalyst::Model>, L<Catalyst::View>, L<Catalyst::Controller>.
 
-=head1 AUTHOR
+=head1 AUTHORS
 
-Sebastian Riedel, C<sri@cpan.org>
-Marcus Ramberg, C<mramberg@cpan.org>
-Matt S Trout, C<mst@shadowcatsystems.co.uk>
+Catalyst Contributors, see Catalyst.pm
 
 =head1 COPYRIGHT