In Catalyst::Test, don't mangle headers of non-HTML responses. RT#79043

[catagits/Catalyst-Runtime.git] / lib / Catalyst / Base.pm

diff --git a/lib/Catalyst/Base.pm b/lib/Catalyst/Base.pm
index b1f105b..1dca5c9 100644 (file)
--- a/lib/Catalyst/Base.pm
+++ b/lib/Catalyst/Base.pm
@@ -1,173 +1,41 @@
 package Catalyst::Base;
+use Moose;
+BEGIN { extends 'Catalyst::Controller' }
 
-use strict;
-use base qw/Catalyst::Component Catalyst::AttrContainer Class::Accessor::Fast/;
-
-use Catalyst::Exception;
-use Catalyst::Utils;
-use Class::Inspector;
-use NEXT;
-
-__PACKAGE__->mk_classdata($_) for qw/_dispatch_steps _action_class/;
-
-__PACKAGE__->_dispatch_steps( [qw/_BEGIN _AUTO _ACTION/] );
-__PACKAGE__->_action_class('Catalyst::Action');
-
-sub _DISPATCH : Private {
-    my ( $self, $c ) = @_;
-
-    foreach my $disp ( @{ $self->_dispatch_steps } ) {
-        last unless $c->forward($disp);
-    }
-
-    $c->forward('_END');
-}
-
-sub _BEGIN : Private {
-    my ( $self, $c ) = @_;
-    my $begin = ( $c->get_actions( 'begin', $c->namespace ) )[-1];
-    return 1 unless $begin;
-    $begin->execute($c);
-    return !@{ $c->error };
-}
-
-sub _AUTO : Private {
-    my ( $self, $c ) = @_;
-    my @auto = $c->get_actions( 'auto', $c->namespace );
-    foreach my $auto (@auto) {
-        $auto->execute($c);
-        return 0 unless $c->state;
-    }
-    return 1;
-}
-
-sub _ACTION : Private {
-    my ( $self, $c ) = @_;
-    if (   ref $c->action
-        && $c->action->isa('Catalyst::Action')
-        && $c->req->action )
-    {
-        $c->action->execute($c);
-    }
-    return !@{ $c->error };
-}
-
-sub _END : Private {
-    my ( $self, $c ) = @_;
-    my $end = ( $c->get_actions( 'end', $c->namespace ) )[-1];
-    return 1 unless $end;
-    $end->execute($c);
-    return !@{ $c->error };
-}
+after 'BUILD' => sub {
+    my $self = shift;
+    warn(ref($self) . " is using the deprecated Catalyst::Base, update your application as this will be removed in the next major release");
+};
 
-=head1 NAME
-
-Catalyst::Base - Catalyst Base Class
-
-=head1 SYNOPSIS
-
-See L<Catalyst>
-
-=head1 DESCRIPTION
-
-Catalyst Base Class
+no Moose;
 
-=head1 METHODS
+1;
 
-=head2 $self->action_namespace($c)
+__END__
 
-=cut
+=head1 NAME
 
-sub action_namespace {
-    my ( $self, $c ) = @_;
-    return Catalyst::Utils::class2prefix( ref $self,
-        $c->config->{case_sensitive} )
-      || '';
-}
+Catalyst::Base - Deprecated base class
 
-=head2 $self->register_actions($c)
+=head1 DESCRIPTION
 
-=cut
+This used to be the base class for Catalyst Controllers. It
+remains here for compatibility reasons, but its use is highly deprecated.
 
-sub register_actions {
-    my ( $self, $c ) = @_;
-    my $class = ref $self || $self;
-    my $namespace = $self->action_namespace($c);
-    my %methods;
-    $methods{ $self->can($_) } = $_
-      for @{ Class::Inspector->methods($class) || [] };
-
-    # Advanced inheritance support for plugins and the like
-    my @action_cache;
-    {
-        no strict 'refs';
-        for my $isa ( @{"$class\::ISA"}, $class ) {
-            push @action_cache, @{ $isa->_action_cache }
-              if $isa->can('_action_cache');
-        }
-    }
-
-    foreach my $cache (@action_cache) {
-        my $code   = $cache->[0];
-        my $method = $methods{$code};
-        next unless $method;
-        my $attrs = $self->_parse_attrs( @{ $cache->[1] } );
-        if ( $attrs->{Private} && ( keys %$attrs > 1 ) ) {
-            $c->log->debug( 'Bad action definition "'
-                  . join( ' ', @{ $cache->[1] } )
-                  . qq/" for "$class->$method"/ )
-              if $c->debug;
-            next;
-        }
-        my $reverse = $namespace ? "$namespace/$method" : $method;
-        my $action = $self->_action_class->new(
-            {
-                name       => $method,
-                code       => $code,
-                reverse    => $reverse,
-                namespace  => $namespace,
-                class      => $class,
-                attributes => $attrs,
-            }
-        );
-        $c->dispatcher->register( $c, $action );
-    }
-}
-
-sub _parse_attrs {
-    my ( $self, @attrs ) = @_;
-    my %attributes;
-    foreach my $attr (@attrs) {
-
-        # Parse out :Foo(bar) into Foo => bar etc (and arrayify)
-
-        if ( my ( $key, $value ) = ( $attr =~ /^(.*?)(?:\(\s*(.+?)\s*\))?$/ ) )
-        {
-
-            if ( defined $value ) {
-                ( $value =~ s/^'(.*)'$/$1/ ) || ( $value =~ s/^"(.*)"/$1/ );
-            }
-            push( @{ $attributes{$key} }, $value );
-        }
-    }
-    return \%attributes;
-}
+If your application produces a warning, then please update your application to
+inherit from L<Catalyst::Controller> instead.
 
 =head1 SEE ALSO
 
 L<Catalyst>, L<Catalyst::Controller>.
 
-=head1 AUTHOR
+=head1 AUTHORS
 
-Sebastian Riedel, C<sri@cpan.org>
-Marcus Ramberg, C<mramberg@cpan.org>
-Matt S Trout, C<mst@shadowcatsystems.co.uk>
+Catalyst Contributors, see Catalyst.pm
 
 =head1 COPYRIGHT
 
-This program is free software, you can redistribute it and/or modify it under
+This library is free software. You can redistribute it and/or modify it under
 the same terms as Perl itself.
 
 =cut
-
-1;