Think more about this

[catagits/Catalyst-Runtime.git] / TODO

diff --git a/TODO b/TODO
index 4937c44..6c74e14 100644 (file)
--- a/TODO
+++ b/TODO
@@ -148,28 +148,33 @@ after BUILD => sub {
   - +    $class->container->get_sub_container('model')->make_single_default;
     +    $class->container->get_sub_container('view')->make_single_default;
 
+    locate_components service vs setup_components method
+      - can we be more lazy?
+      - should setup_components be a service that things like the ->component lookup
+        can depend on?
+      
     get_components_names_types
 
-    locate_components
-
     +# FIXME - t0m, how do you feel about this name?
     +# also, do you think I should draw it here, or just return the data structure?
     +sub get_components_names_types {
 
-    +    MyApp->config->{ 'Plugin::ConfigLoader' }->{ substitutions } = {
-
-    +# FIXME - just till I understand how it's supposed to be done
-    +# Made this so that COMPONENT is executed once,
-    +# and ACCEPT_CONTEXT every call.
-    +has instance => (
-    +    is => 'rw',
-
-    # This is ok??
-    +my $applevel_config = TestAppContainer->container->resolve(service => 'config')->{applevel_config};
-    +__PACKAGE__->config(applevel_config => 'foo');
-
+    +Same as L<build_model_subcontainer>, but for controllers. The difference is
+    +that there is no ACCEPT_CONTEXT for controllers.
+    ^^ This is wrong!!
+    
+    -    my $accept_context_args = $self->param('accept_context_args');
+    +    my $accept_context_args = $params{accept_context_args};
+    ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the 
+       accept_context args, no?
+       Without this change, the user could make a custom service which mangled the param, and use 
+       Catalyst/IOC/Service/WithAcceptContext.pm, with this change, that module will always see the
+       un-mangled version?? However, without this change, shit doesn't work...
 
     accept_context_args - where does this come from?
+    
+    +    $purity = $purity // 1;
+    ^^ perl 5.10 only
 
 ### Known issues
 
@@ -178,3 +183,4 @@ after BUILD => sub {
 
     - expand_component_module
 
+    - People wrapping locate_components in Catalyst.pm