Think more about this

[catagits/Catalyst-Runtime.git] / TODO

diff --git a/TODO b/TODO
index 38b2d1d..6c74e14 100644 (file)
--- a/TODO
+++ b/TODO
@@ -148,10 +148,13 @@ after BUILD => sub {
   - +    $class->container->get_sub_container('model')->make_single_default;
     +    $class->container->get_sub_container('view')->make_single_default;
 
+    locate_components service vs setup_components method
+      - can we be more lazy?
+      - should setup_components be a service that things like the ->component lookup
+        can depend on?
+      
     get_components_names_types
 
-    locate_components
-
     +# FIXME - t0m, how do you feel about this name?
     +# also, do you think I should draw it here, or just return the data structure?
     +sub get_components_names_types {
@@ -162,10 +165,11 @@ after BUILD => sub {
     
     -    my $accept_context_args = $self->param('accept_context_args');
     +    my $accept_context_args = $params{accept_context_args};
-    ^^ This is wrong! The service should be allowed to mangle the accept_context args, no?
+    ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the 
+       accept_context args, no?
        Without this change, the user could make a custom service which mangled the param, and use 
        Catalyst/IOC/Service/WithAcceptContext.pm, with this change, that module will always see the
-       un-mangled version??
+       un-mangled version?? However, without this change, shit doesn't work...
 
     accept_context_args - where does this come from?
     
@@ -179,3 +183,4 @@ after BUILD => sub {
 
     - expand_component_module
 
+    - People wrapping locate_components in Catalyst.pm