putting back accidentally removed lines

[catagits/Catalyst-Runtime.git] / TODO

diff --git a/TODO b/TODO
index 409d8b2..2c419a7 100644 (file)
--- a/TODO
+++ b/TODO
@@ -57,30 +57,90 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree
 
 ## GSOC
 
-### Next large steps:
+### Next steps - less planned:
 
-  - Moving setup_components etc into the container
-
-    - This is so that you can just load the container and get models etc from it,
-      without loading Catalyst.
-
-  - Finished documentation for ::IOC parts.
+  - Creating service()-like sugar for component
 
   - Test cases for extending the container in an application.
-
-  - Allowing people to change component lifecycles
-
-    - This is done by being able to use an alternate Service class..
-
-      I.E. We currently force everything to do Catalyst/IOC/Service/WithAcceptContext.pm, but
-      things without an ACCEPT_CONTEXT could just not bother, and it would be nice to have
-      one that cached the object in request scope (i.e. Catalyst::Component::InstancePerContext)
-      etc.
-
-      However we need to work out an interface for people to setup / configure this.
-
-### To polish off
-
-  - Document current methods
-  - +    $class->container->get_sub_container('model')->make_single_default;
-+    $class->container->get_sub_container('view')->make_single_default;
+    - Using the sugar added in the previous item
+    - Test when Model::Foo depends_on Model::Bar
+
+  - Tests for using the container outside of Catalyst
+    - Custom container which adds some (very simple) services which are initialized from
+      the application config file (note plain services, not components)
+    - Depend on (and test) these inside Catalyst
+    - Test loading container outside Catalyst, and these services working
+    - Test Catalyst / MyApp is not loaded
+
+#### Extending my app, notes
+
+Basically try to implement something like this (starting out without the sugar!), and see how it breaks
+and what needs to be done to fix it!
+
+##### Eventual syntax
+
+package MyApp::Container;
+use Catalyst::IOC;
+    
+    container $self, as { 
+            container model => as {
+                component Foo => (); # As per default!
+                component Bar => (dependencies => ['/model/Foo']); # Magic!
+                component Baz => ( lifecycle => 'InstancePerContext );
+                component Quux => ( lifecycle => 'Singleton' ); # ACCEPT_CONTEXT not called
+            };                    
+            # Note - implementation of BB may need to be changed to support making sure existing 
+            # services actually get overridden. not sure how the default container behaves when doing that
+            # above code would build the constructor injection as it currently does,
+            # defaulting to the class name in the right namespace as declared by the surrounding container
+            # as well as adding using the catalyst-specific service class
+    };
+
+1;
+
+##### To start with
+
+package MyApp::Container;
+use Moose;
+
+extends 'Catalyst::Container;
+
+after BUILD => sub {
+    my $self = shift;
+    my $model_container = $self->get_sub_container('model');
+    my $service = Catalyst::IOC::ConstructorInjection->new(
+        name      => 'Baz',
+        class     => 'MyApp::Model::Baz',
+        dependencies => [
+            depends_on( '/application_name' ),
+            depends_on( '/config' ),
+            depends_on( '/model/Foo' ),
+        ],
+        lifecycle => 'InstancePerContext',
+    );
+    $model_container->add_service( 'Foo', $service );
+};
+
+### To polish off / t0m review
+
+    locate_components service vs setup_components method
+      - can we be more lazy?
+      - should setup_components be a service that things like the ->component lookup
+        can depend on?
+
+    -    my $accept_context_args = $self->param('accept_context_args');
+    +    my $accept_context_args = $params{accept_context_args};
+    ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the 
+       accept_context args, no?
+       Without this change, the user could make a custom service which mangled the param, and use 
+       Catalyst/IOC/Service/WithAcceptContext.pm, with this change, that module will always see the
+       un-mangled version?? However, without this change, shit doesn't work...
+
+### Known issues
+
+    - Broken $instance->expand_modules() in setup_components and figure
+      out later how to bring it back
+
+    - expand_component_module
+
+    - People wrapping locate_components in Catalyst.pm