putting back accidentally removed lines

[catagits/Catalyst-Runtime.git] / TODO

diff --git a/TODO b/TODO
index 23cdab7..2c419a7 100644 (file)
--- a/TODO
+++ b/TODO
@@ -57,34 +57,6 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree
 
 ## GSOC
 
-### Next large steps, planned:
-
-For all components that have been discovered, in whatever way, we create a service:
- - that's a catalyst component service
- - which is basically just a constructor injection
- - except the constructor name is COMPONENT
- - and we're "implicitly" passing along some constructor args
- - Lifecycle => Singleton
-
- - Fix B::B so that Service::WithParametrs' parameters attribute has a builder
- - Fix ConstructorInjection so that default parameters are supplied (for accept_context_args)
- - Fix ConstructorInjection's 'suffix' - should be called 'config_key' or something, and
-   should be an attribute on the service (as it never changes), rather than a parameter
-   to the service 
-
- - We make a 'components' sub container in the main container.
-   - This gets the ConstructorInjection COMPONENT services, as model_Foo.
-   - Lifecycle of these services is Singleton
-   - This simplifies the code for MyApp->components, as it need only list one sub-container
-
- - We create a second service (depending on the first one) for ACCEPT_CONTEXT
-   - This has a custom service which calls ACCEPT_CONTEXT when the instance is fetched
-   - Not Singleton lifecycle
- 
-   Note - ACCEPT_CONTEXT can be called on app values - if you have a Model::Foo, with an ACCEPT_CONTEXT
-   and you call MyApp->model('Foo') then ACCEPT_CONTEXT gets invoked with a $c of 'MyApp' (this is not\
-   the normal case, but we need to preserve for compat)
-
 ### Next steps - less planned:
 
   - Creating service()-like sugar for component
@@ -93,6 +65,12 @@ For all components that have been discovered, in whatever way, we create a servi
     - Using the sugar added in the previous item
     - Test when Model::Foo depends_on Model::Bar
 
+  - Tests for using the container outside of Catalyst
+    - Custom container which adds some (very simple) services which are initialized from
+      the application config file (note plain services, not components)
+    - Depend on (and test) these inside Catalyst
+    - Test loading container outside Catalyst, and these services working
+    - Test Catalyst / MyApp is not loaded
 
 #### Extending my app, notes
 
@@ -145,47 +123,18 @@ after BUILD => sub {
 
 ### To polish off / t0m review
 
-  - +    $class->container->get_sub_container('model')->make_single_default;
-    +    $class->container->get_sub_container('view')->make_single_default;
-
-    +sub controller { shift->_lookup_mvc('controller', @_) }
-
-    get_components_names_types
-
-    locate_components
-
-    +# FIXME - t0m, how do you feel about this name?
-    +# also, do you think I should draw it here, or just return the data structure?
-    +sub get_components_names_types {
-
-    +    MyApp->config->{ 'Plugin::ConfigLoader' }->{ substitutions } = {
+    locate_components service vs setup_components method
+      - can we be more lazy?
+      - should setup_components be a service that things like the ->component lookup
+        can depend on?
 
-    +# FIXME - just till I understand how it's supposed to be done
-    +# Made this so that COMPONENT is executed once,
-    +# and ACCEPT_CONTEXT every call.
-    +has instance => (
-    +    is => 'rw',
-
-    # This is ok??
-    +my $applevel_config = TestAppContainer->container->resolve(service => 'config')->{applevel_config};
-    +__PACKAGE__->config(applevel_config => 'foo');
-
-
-    +Same as L<build_model_subcontainer>, but for controllers. The difference is
-    +that there is no ACCEPT_CONTEXT for controllers.
-    ^^ This is wrong!!
-    
     -    my $accept_context_args = $self->param('accept_context_args');
     +    my $accept_context_args = $params{accept_context_args};
-    ^^ This is wrong! The service should be allowed to mangle the accept_context args, no?
+    ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the 
+       accept_context args, no?
        Without this change, the user could make a custom service which mangled the param, and use 
        Catalyst/IOC/Service/WithAcceptContext.pm, with this change, that module will always see the
-       un-mangled version??
-
-    accept_context_args - where does this come from?
-    
-    +    $purity = $purity // 1;
-    ^^ perl 5.10 only
+       un-mangled version?? However, without this change, shit doesn't work...
 
 ### Known issues
 
@@ -194,3 +143,4 @@ after BUILD => sub {
 
     - expand_component_module
 
+    - People wrapping locate_components in Catalyst.pm