See also: Catalyst::Plugin::Log::Dispatch and
http://github.com/willert/catalyst-plugin-log4perl-simple/tree
-# REFACTORING
+## Capture arguments that the plack engine component was run with somewhere,
+ to more easily support custom args from scripts (e.g. Gitalist's
+ --git_dir)
-## The horrible hack for plugin setup - replacing it:
+## throw away the restarter and allow using the restarters Plack provides
+
+## remove per-request state from the engine instance
+
+## be smarter about how we use PSGI - not every response needs to be delayed
+ and streaming
+
+# The horrible hack for plugin setup - replacing it:
* Have a look at the Devel::REPL BEFORE_PLUGIN stuff
I wonder if what we need is that combined with plugins-as-roles
-## App / ctx split:
+# PSGI
+
+## To do at release time
+
+ - Release psgi branch of Catalyst-Devel
+ - Release new Task::Catalyst
+ - Release 5.9 branch of Catalyst-Manual
+ - Release Catalyst::Engine::HTTP::Prefork with deprecation notice
+ + exit in Makefile.PL if Catalyst > 5.89 is installed.
+
+## Blockers
+
+ * I've noticed a small difference with Catalyst::Test. The latest stable
+ version include two headers, 'host' and 'https'. They are missing from
+ this version - Pedro Melo on list
+ ^^ Cannot replicate this? Mailed back to ask for tests..
+
+# App / ctx split:
NOTE - these are notes that t0m thought up after doing back compat for
catalyst_component_class, may be inaccurate, wrong or missing things
## GSOC
+### Final steps for GSOC
+
+##### Things that work:
+
+ - the default container loads all components, calls ACCEPT_CONTEXT() when appropriate, and COMPONENT() when appropriate, behaving like current Catalyst does
+
+ - its possible to create a custom container, and override the components you want. Lifecycle, class, dependencies, all overridable.
+
+ - config files are loaded without Catalyst::Plugin::ConfigLoader
+
+ - per request life cycle somewhat works
+
+ - external modules are loaded just using a custom container, much like Catalyst::Model::Adaptor
+
+##### Things that don't work:
+
+ - expand_component_module
+
+ - sugar is still not completely implemented
+
+ - Some back compat
+ - wrappers around setup_component, setup_components, locate_components in Catalyst.pm
+ - $instance->expand_modules
+ - search_extra
+ - Crazy tests for things such as:
+ sub COMPONENT {
+ ...
+ *${appclass}::Model::TopLevel::GENERATED::ACCEPT_CONTEXT = sub { ... };
+ ...
+ }
+
+##### Need planning, have questions:
+
+ - per request life cycle
+
+ - sugar - we should discuss the syntax with rafl and edenc
+
+ - when / when not COMPONENT should be called
+
+ - locate_components service vs setup_components method
+ - can we be more lazy?
+ - should setup_components be a service that things like the ->component lookup
+ can depend on?
+
+ - There are a few more FIXMEs, idk if any relevant here
+
### Next steps - planned:
+ - some imports need to get the importing package in Catalyst::IOC
+ - done - needs testing
+
+ - Back compat for Catalyst.pm moved methods (locate_components)
+ - done - needs testing
+
- Test custom container
- writing some tests which verify that the models you think should be
there are there, and that they received their dependencies as arguments
$c->model('Foo'), and that COMPONENT is called (or not called)
as appropiate and that ACCEPT_CONTEXT is called (or not) as appropriate
- - Kill flush_request_services
- - we're already passing $ctx in when we locate services so the ::Request
- lifecycle can just stash the object in, or retrieve the object from the
- stash
- (actually, we're not passing $ctx when we locate services. Problem!)
-
### Next steps - less planned:
- - Creating service()-like sugar for component
+ - make ACCEPT_CONTEXT and COMPONENT optional in Catalyst::IOC::BlockInjection and Catalyst::IOC::ConstructorInjection
+ - Create COMPONENTSingleton life cycle
- Test cases for extending the container in an application.
- Using the sugar added in the previous item
};
1;
-
-##### To start with
-
-package MyApp::Container;
-use Moose;
-
-extends 'Catalyst::Container;
-
-after BUILD => sub {
- my $self = shift;
- my $model_container = $self->get_sub_container('model');
- my $service = Catalyst::IOC::ConstructorInjection->new(
- name => 'Baz',
- class => 'MyApp::Model::Baz',
- dependencies => [
- depends_on( '/application_name' ),
- depends_on( '/config' ),
- depends_on( '/model/Foo' ),
- ],
- lifecycle => 'InstancePerContext',
- );
- $model_container->add_service( 'Foo', $service );
-};
-
-### To polish off / t0m review
-
- locate_components service vs setup_components method
- - can we be more lazy?
- - should setup_components be a service that things like the ->component lookup
- can depend on?
-
- - my $accept_context_args = $self->param('accept_context_args');
- + my $accept_context_args = $params{accept_context_args};
- ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the
- accept_context args, no?
- Without this change, the user could make a custom service which mangled the param, and use
- Catalyst/IOC/Service/WithAcceptContext.pm, with this change, that module will always see the
- un-mangled version?? However, without this change, shit doesn't work...
-
-### Known issues
-
- - Broken $instance->expand_modules() in setup_components and figure
- out later how to bring it back
-
- - expand_component_module
-
- - People wrapping locate_components in Catalyst.pm
projects / catagits/Catalyst-Runtime.git / blobdiff