From: Tomas Doran Date: Sun, 3 Jan 2010 14:41:22 +0000 (+0000) Subject: Don't override setup, rather hook setup_finalize otherwise as a role we won't play... X-Git-Tag: v0.27~2 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Plugin-Static-Simple.git;a=commitdiff_plain;h=aa5935f174f36400df9ec6a656abbd7f4fdfa844 Don't override setup, rather hook setup_finalize otherwise as a role we won't play nicely with other plugins --- diff --git a/Makefile.PL b/Makefile.PL index d5fe674..2966418 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,4 +1,6 @@ -use inc::Module::Install 0.87; +use strict; +use warnings; +use inc::Module::Install 0.91; name 'Catalyst-Plugin-Static-Simple'; all_from 'lib/Catalyst/Plugin/Static/Simple.pm'; @@ -6,7 +8,8 @@ all_from 'lib/Catalyst/Plugin/Static/Simple.pm'; requires 'Catalyst::Runtime' => '5.80008'; requires 'MIME::Types' => '1.25'; requires 'Test::More'; -requires 'MRO::Compat'; +requires 'Moose'; +requires 'namespace::autoclean'; if( can_use 'Catalyst::Plugin::SubRequest' ) { unless( can_use 'Catalyst::Plugin::SubRequest' => '0.08' ) { diff --git a/lib/Catalyst/Plugin/Static/Simple.pm b/lib/Catalyst/Plugin/Static/Simple.pm index 2cfe241..4f1a1c9 100644 --- a/lib/Catalyst/Plugin/Static/Simple.pm +++ b/lib/Catalyst/Plugin/Static/Simple.pm @@ -5,7 +5,7 @@ use File::stat; use File::Spec (); use IO::File (); use MIME::Types (); -use MRO::Compat; +use namespace::autoclean; our $VERSION = '0.26'; @@ -84,11 +84,9 @@ before finalize => sub { } }; -sub setup { +before setup_finalize => sub { my $c = shift; - $c->maybe::next::method(@_); - my $config = $c->config->{static} ||= {}; $config->{dirs} ||= []; @@ -106,7 +104,7 @@ sub setup { # preload the type index hash so it's not built on the first request $config->{mime_types_obj}->create_type_index; -} +}; # Search through all included directories for the static file # Based on Template Toolkit INCLUDE_PATH code @@ -296,7 +294,7 @@ C<404> error if your applicaton can not process the request: # handled by static::simple, not dispatched to your application /images/exists.png - + # static::simple will not find the file and let your application # handle the request. You are responsible for generating a file # or returning a 404 error