From: Tomas Doran <bobtfish@bobtfish.net>
Date: Tue, 23 Jun 2009 08:16:31 +0000 (+0000)
Subject: Checking in changes prior to tagging of version 0.24.  Changelog diff is:
X-Git-Tag: v0.24^0
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Plugin-Session.git;a=commitdiff_plain;h=f8f81744361da95c2b7f8a35c4e5aec63622e677

Checking in changes prior to tagging of version 0.24.  Changelog diff is:

Index: Changes
===================================================================
--- Changes	(revision 10553)
+++ Changes	(working copy)
@@ -1,5 +1,11 @@
Revision history for Perl extension Catalyst::Plugin::Session

+0.24 2009-06-23
+        - Be more paranoid about getting values of $c->req to avoid issues
+          with old Test::WWW::Mechanize::Catalyst.
+        - Check we have a modern version of TWMC before doing the tests which
+          need it.
+
0.23 2009-06-16
- Add the verify_user_agent config parameter (kmx)
- Add a test case to prove that logging in with a session cookie still
---

diff --git a/Changes b/Changes
index 323e4cb..b4627ce 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,11 @@
 Revision history for Perl extension Catalyst::Plugin::Session
 
+0.24 2009-06-23
+        - Be more paranoid about getting values of $c->req to avoid issues
+          with old Test::WWW::Mechanize::Catalyst.
+        - Check we have a modern version of TWMC before doing the tests which
+          need it.
+
 0.23 2009-06-16
         - Add the verify_user_agent config parameter (kmx)
         - Add a test case to prove that logging in with a session cookie still 
diff --git a/lib/Catalyst/Plugin/Session.pm b/lib/Catalyst/Plugin/Session.pm
index 7290266..8e3a2da 100644
--- a/lib/Catalyst/Plugin/Session.pm
+++ b/lib/Catalyst/Plugin/Session.pm
@@ -13,7 +13,7 @@ use Carp;
 
 use namespace::clean -except => 'meta';
 
-our $VERSION = '0.23';
+our $VERSION = '0.24';
 
 my @session_data_accessors; # used in delete_session
 
@@ -463,12 +463,12 @@ sub initialize_session_data {
 
             (
                 $c->config->{session}{verify_address}
-                ? ( __address => $c->request->address )
+                ? ( __address => $c->request->address||'' )
                 : ()
             ),
             (
                 $c->config->{session}{verify_user_agent}
-                ? ( __user_agent => $c->request->user_agent )
+                ? ( __user_agent => $c->request->user_agent||'' )
                 : ()
             ),
         }
diff --git a/t/05_semi_persistent_flash.t b/t/05_semi_persistent_flash.t
index d9d685a..249be7f 100644
--- a/t/05_semi_persistent_flash.t
+++ b/t/05_semi_persistent_flash.t
@@ -8,9 +8,12 @@ BEGIN {
         or plan skip_all =>
             "Catalyst::Plugin::Session::State::Cookie version 0.03 or higher is required for this test";
 
-    eval { require Test::WWW::Mechanize::Catalyst }
-      or plan skip_all =>
-      'Test::WWW::Mechanize::Catalyst is required for this test';
+    eval {
+        require Test::WWW::Mechanize::Catalyst;
+        Test::WWW::Mechanize::Catalyst->VERSION(0.51);
+    }
+    or plan skip_all =>
+        'Test::WWW::Mechanize::Catalyst >= 0.51 is required for this test';
 
     plan tests => '10';
 
diff --git a/t/live_app.t b/t/live_app.t
index ae2f791..f2b1bd1 100644
--- a/t/live_app.t
+++ b/t/live_app.t
@@ -10,9 +10,12 @@ BEGIN {
       or plan skip_all =>
       "Catalyst::Plugin::Session::State::Cookie 0.03 or higher is required for this test";
 
-    eval { require Test::WWW::Mechanize::Catalyst }
-      or plan skip_all =>
-      "Test::WWW::Mechanize::Catalyst is required for this test";
+    eval {
+        require Test::WWW::Mechanize::Catalyst;
+        Test::WWW::Mechanize::Catalyst->VERSION(0.51);
+    }
+    or plan skip_all =>
+        'Test::WWW::Mechanize::Catalyst >= 0.51 is required for this test';
 
     plan tests => 36;
 }
diff --git a/t/live_session_fixation.t b/t/live_session_fixation.t
index 88c9c93..37c4abc 100644
--- a/t/live_session_fixation.t
+++ b/t/live_session_fixation.t
@@ -10,9 +10,12 @@ BEGIN {
       or plan skip_all =>
       "Catalyst::Plugin::Session::State::Cookie 0.03 or higher is required for this test";
 
-    eval { require Test::WWW::Mechanize::Catalyst }
-      or plan skip_all =>
-      "Test::WWW::Mechanize::Catalyst is required for this test";
+    eval {
+        require Test::WWW::Mechanize::Catalyst;
+        Test::WWW::Mechanize::Catalyst->VERSION(0.51);
+    }
+    or plan skip_all =>
+        'Test::WWW::Mechanize::Catalyst >= 0.51 is required for this test';
 
     plan tests => 2;
 }
diff --git a/t/live_verify_user_agent.t b/t/live_verify_user_agent.t
index 04b1fa5..310d51b 100644
--- a/t/live_verify_user_agent.t
+++ b/t/live_verify_user_agent.t
@@ -10,9 +10,12 @@ BEGIN {
       or plan skip_all =>
       "Catalyst::Plugin::Session::State::Cookie 0.03 or higher is required for this test";
 
-    eval { require Test::WWW::Mechanize::Catalyst }
-      or plan skip_all =>
-      "Test::WWW::Mechanize::Catalyst is required for this test";
+    eval {
+        require Test::WWW::Mechanize::Catalyst;
+        Test::WWW::Mechanize::Catalyst->VERSION(0.51);
+    }
+    or plan skip_all =>
+        'Test::WWW::Mechanize::Catalyst >= 0.51 is required for this test';
 
     plan tests => 12;
 }