From: Brian Cassidy Date: Fri, 14 Sep 2007 14:12:15 +0000 (+0000) Subject: require specific ver of Test::WWW::Mechanize::Catalyst for t/live_app. remove some... X-Git-Tag: v0.08~5 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Plugin-Session-State-Cookie.git;a=commitdiff_plain;h=c4a96adb1d059b734eec945989d48ee54fb0676e require specific ver of Test::WWW::Mechanize::Catalyst for t/live_app. remove some warnings --- diff --git a/Changes b/Changes index ed72a68..1b04264 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,7 @@ Revision history for Perl extension Catalyst::Plugin::Session::State::Cookie 0.08 2007-08-09 9:46PM (+0500) - Fix live test with Mech version 0.37+ + - Switch to Module::Install 0.07 2007-04-04 23:10:00 - Fix the bug that caused sessions to expire immediately when another diff --git a/Makefile.PL b/Makefile.PL index fa84163..447f824 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,4 +1,4 @@ -use inc::Module::Install; +use inc::Module::Install 0.67; name 'Catalyst-Plugin-Session-State-Cookie'; all_from 'lib/Catalyst/Plugin/Session/State/Cookie.pm'; diff --git a/t/live_app.t b/t/live_app.t index 3c814fb..9ef202e 100644 --- a/t/live_app.t +++ b/t/live_app.t @@ -10,6 +10,7 @@ BEGIN { plan skip_all => "This test requires Test::WWW::Mechanize::Catalyst in order to run" if $@; + plan skip_all => 'Test::WWW::Mechanize::Catalyst >= 0.40 required' if $Test::WWW::Mechanize::Catalyst::VERSION < 0.40; plan 'no_plan'; } @@ -53,7 +54,7 @@ $m->get_ok( "http://localhost/stream", "get page" ); $m->content_contains( "hit number 1", "session data created" ); my $expired; -$m->cookie_jar->scan( sub { $expired = $_[8]; warn join":",@_; } ); +$m->cookie_jar->scan( sub { $expired = $_[8]; } ); $m->get_ok( "http://localhost/page", "get page" ); $m->content_contains( "hit number 2", "session data restored" ); @@ -67,7 +68,7 @@ $m->get_ok( "http://localhost/page", "get stream" ); $m->content_contains( "hit number 4", "session data restored" ); my $updated_expired; -$m->cookie_jar->scan( sub { $updated_expired = $_[8]; warn join":",@_; } ); +$m->cookie_jar->scan( sub { $updated_expired = $_[8]; } ); cmp_ok( $expired, "<", $updated_expired, "cookie expiration was extended" );