X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Plugin-Session-State-Cookie.git;a=blobdiff_plain;f=lib%2FCatalyst%2FPlugin%2FSession%2FState%2FCookie.pm;h=aa0e61a76df2bf69184b5343192580908c011112;hp=2ad97b76c5ee89bf8e6a71950ea343be60a07bdf;hb=519fe077777d954a0d2d8885f594fc5b04b4ff0f;hpb=2bde9162132ed51c98e86106f3b9be65459c12a3 diff --git a/lib/Catalyst/Plugin/Session/State/Cookie.pm b/lib/Catalyst/Plugin/Session/State/Cookie.pm index 2ad97b7..aa0e61a 100644 --- a/lib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/lib/Catalyst/Plugin/Session/State/Cookie.pm @@ -7,7 +7,7 @@ use warnings; use NEXT; use Catalyst::Utils (); -our $VERSION = "0.02"; +our $VERSION = "0.06"; sub setup_session { my $c = shift; @@ -18,14 +18,14 @@ sub setup_session { ||= Catalyst::Utils::appprefix($c) . '_session'; } -sub finalize_cookies { - my $c = shift; +sub extend_session_id { + my ( $c, $sid, $expires ) = @_; if ( my $cookie = $c->get_session_cookie ) { - $c->update_session_cookie( $c->make_session_cookie( $cookie->value ) ); + $c->update_session_cookie( $c->make_session_cookie( $sid ) ); } - $c->NEXT::finalize_cookies( @_ ); + $c->NEXT::extend_session_id( $sid, $expires ); } sub set_session_id { @@ -33,13 +33,26 @@ sub set_session_id { $c->update_session_cookie( $c->make_session_cookie( $sid ) ); - return $c->NEXT::set_session_id(@_); + return $c->NEXT::set_session_id($sid); } sub update_session_cookie { my ( $c, $updated ) = @_; - my $cookie_name = $c->config->{session}{cookie_name}; - $c->response->cookies->{$cookie_name} = $updated; + + unless ( $c->cookie_is_rejecting( $updated ) ) { + my $cookie_name = $c->config->{session}{cookie_name}; + $c->response->cookies->{$cookie_name} = $updated; + } +} + +sub cookie_is_rejecting { + my ( $c, $cookie ) = @_; + + if ( $cookie->{path} ) { + return 1 if index '/'.$c->request->path, $cookie->{path}; + } + + return 0; } sub make_session_cookie { @@ -48,8 +61,9 @@ sub make_session_cookie { my $cfg = $c->config->{session}; my $cookie = { value => $sid, - %attrs, ( $cfg->{cookie_domain} ? ( domain => $cfg->{cookie_domain} ) : () ), + ( $cfg->{cookie_path} ? ( path => $cfg->{cookie_path} ) : () ), + %attrs, }; unless ( exists $cookie->{expires} ) { @@ -107,9 +121,11 @@ sub get_session_id { } sub delete_session_id { - my $c = shift; - $c->NEXT::delete_session_id(); - delete $c->response->cookies->{ $c->config->{session}{cookie_name} }; + my ( $c, $sid ) = @_; + + $c->update_session_cookie( $c->make_session_cookie( $sid, expires => 0 ) ); + + $c->NEXT::delete_session_id($sid); } __PACKAGE__ @@ -188,6 +204,10 @@ user's browser is shut down. If this attribute set true, the cookie will only be sent via HTTPS. +=item cookie_path + +The path of the request url where cookie should be baked. + =back =head1 CAVEATS