X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Plugin-Session-State-Cookie.git;a=blobdiff_plain;f=lib%2FCatalyst%2FPlugin%2FSession%2FState%2FCookie.pm;h=865fb48e0e10a956e399682c982c3654b2b4e4be;hp=7fbde70b66c4309deec3f35f7b5bfea1458dae82;hb=ea139a65b7a69a7e3059f2440b5ea62a9ef15c13;hpb=3e8b97ed68abf4af61db73b5cb02e27a902642fb diff --git a/lib/Catalyst/Plugin/Session/State/Cookie.pm b/lib/Catalyst/Plugin/Session/State/Cookie.pm index 7fbde70..865fb48 100644 --- a/lib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/lib/Catalyst/Plugin/Session/State/Cookie.pm @@ -1,5 +1,5 @@ package Catalyst::Plugin::Session::State::Cookie; -use base qw/Catalyst::Plugin::Session::State/; +use base qw/Catalyst::Plugin::Session::State Class::Accessor::Fast/; use strict; use warnings; @@ -7,7 +7,9 @@ use warnings; use NEXT; use Catalyst::Utils (); -our $VERSION = "0.04"; +our $VERSION = "0.07"; + +BEGIN { __PACKAGE__->mk_accessors(qw/_deleted_session_id/) } sub setup_session { my $c = shift; @@ -25,7 +27,7 @@ sub extend_session_id { $c->update_session_cookie( $c->make_session_cookie( $sid ) ); } - $c->NEXT::extend_session_id( @_ ); + $c->NEXT::extend_session_id( $sid, $expires ); } sub set_session_id { @@ -33,13 +35,26 @@ sub set_session_id { $c->update_session_cookie( $c->make_session_cookie( $sid ) ); - return $c->NEXT::set_session_id(@_); + return $c->NEXT::set_session_id($sid); } sub update_session_cookie { my ( $c, $updated ) = @_; - my $cookie_name = $c->config->{session}{cookie_name}; - $c->response->cookies->{$cookie_name} = $updated; + + unless ( $c->cookie_is_rejecting( $updated ) ) { + my $cookie_name = $c->config->{session}{cookie_name}; + $c->response->cookies->{$cookie_name} = $updated; + } +} + +sub cookie_is_rejecting { + my ( $c, $cookie ) = @_; + + if ( $cookie->{path} ) { + return 1 if index '/'.$c->request->path, $cookie->{path}; + } + + return 0; } sub make_session_cookie { @@ -49,6 +64,7 @@ sub make_session_cookie { my $cookie = { value => $sid, ( $cfg->{cookie_domain} ? ( domain => $cfg->{cookie_domain} ) : () ), + ( $cfg->{cookie_path} ? ( path => $cfg->{cookie_path} ) : () ), %attrs, }; @@ -97,7 +113,7 @@ sub get_session_cookie { sub get_session_id { my $c = shift; - if ( my $cookie = $c->get_session_cookie ) { + if ( !$c->_deleted_session_id and my $cookie = $c->get_session_cookie ) { my $sid = $cookie->value; $c->log->debug(qq/Found sessionid "$sid" in cookie/) if $c->debug; return $sid if $sid; @@ -108,6 +124,8 @@ sub get_session_id { sub delete_session_id { my ( $c, $sid ) = @_; + + $c->_deleted_session_id(1); # to prevent get_session_id from returning it $c->update_session_cookie( $c->make_session_cookie( $sid, expires => 0 ) ); @@ -190,6 +208,10 @@ user's browser is shut down. If this attribute set true, the cookie will only be sent via HTTPS. +=item cookie_path + +The path of the request url where cookie should be baked. + =back =head1 CAVEATS