X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Plugin-Session-State-Cookie.git;a=blobdiff_plain;f=lib%2FCatalyst%2FPlugin%2FSession%2FState%2FCookie.pm;h=669013bf578c5c6715d479a78a1f6054de18e3f9;hp=a87ccc892602cd8c20989e48036f5b39c564620c;hb=e84f7667e30aa794967cc599f285c3f4e64ca603;hpb=8bdcbb468aedff34275a7fb30b18ea8be066255b diff --git a/lib/Catalyst/Plugin/Session/State/Cookie.pm b/lib/Catalyst/Plugin/Session/State/Cookie.pm index a87ccc8..669013b 100644 --- a/lib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/lib/Catalyst/Plugin/Session/State/Cookie.pm @@ -1,5 +1,5 @@ package Catalyst::Plugin::Session::State::Cookie; -use base qw/Catalyst::Plugin::Session::State/; +use base qw/Catalyst::Plugin::Session::State Class::Accessor::Fast/; use strict; use warnings; @@ -7,7 +7,9 @@ use warnings; use NEXT; use Catalyst::Utils (); -our $VERSION = "0.05"; +our $VERSION = "0.08"; + +BEGIN { __PACKAGE__->mk_accessors(qw/_deleted_session_id/) } sub setup_session { my $c = shift; @@ -25,7 +27,7 @@ sub extend_session_id { $c->update_session_cookie( $c->make_session_cookie( $sid ) ); } - $c->NEXT::extend_session_id( @_ ); + $c->NEXT::extend_session_id( $sid, $expires ); } sub set_session_id { @@ -33,7 +35,7 @@ sub set_session_id { $c->update_session_cookie( $c->make_session_cookie( $sid ) ); - return $c->NEXT::set_session_id(@_); + return $c->NEXT::set_session_id($sid); } sub update_session_cookie { @@ -49,7 +51,7 @@ sub cookie_is_rejecting { my ( $c, $cookie ) = @_; if ( $cookie->{path} ) { - return 1 if index $c->request->path, $cookie->{path}; + return 1 if index '/'.$c->request->path, $cookie->{path}; } return 0; @@ -111,7 +113,7 @@ sub get_session_cookie { sub get_session_id { my $c = shift; - if ( my $cookie = $c->get_session_cookie ) { + if ( !$c->_deleted_session_id and my $cookie = $c->get_session_cookie ) { my $sid = $cookie->value; $c->log->debug(qq/Found sessionid "$sid" in cookie/) if $c->debug; return $sid if $sid; @@ -122,6 +124,8 @@ sub get_session_id { sub delete_session_id { my ( $c, $sid ) = @_; + + $c->_deleted_session_id(1); # to prevent get_session_id from returning it $c->update_session_cookie( $c->make_session_cookie( $sid, expires => 0 ) ); @@ -238,6 +242,7 @@ Andy Grundman Christian Hansen Yuval Kogman, C Marcus Ramberg +Jonathan Rockway, C Sebastian Riedel =head1 COPYRIGHT