X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Plugin-Session-State-Cookie.git;a=blobdiff_plain;f=lib%2FCatalyst%2FPlugin%2FSession%2FState%2FCookie.pm;h=648516f7db03fc0971cf2ca99e87c8be01cd6103;hp=8d32081e6de65e71774852d26f848db42ab27ee9;hb=ef0cdc56b1d1caebc3b106934963c10203eb64d9;hpb=bab1512d7270f7f38f63a54ebe0677f27e9172b5 diff --git a/lib/Catalyst/Plugin/Session/State/Cookie.pm b/lib/Catalyst/Plugin/Session/State/Cookie.pm index 8d32081..648516f 100644 --- a/lib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/lib/Catalyst/Plugin/Session/State/Cookie.pm @@ -7,7 +7,7 @@ extends 'Catalyst::Plugin::Session::State'; use MRO::Compat; use Catalyst::Utils (); -our $VERSION = "0.14"; +our $VERSION = "0.17"; has _deleted_session_id => ( is => 'rw' ); @@ -16,7 +16,7 @@ sub setup_session { $c->maybe::next::method(@_); - $c->config->{session}{cookie_name} + $c->_session_plugin_config->{cookie_name} ||= Catalyst::Utils::appprefix($c) . '_session'; } @@ -42,7 +42,7 @@ sub update_session_cookie { my ( $c, $updated ) = @_; unless ( $c->cookie_is_rejecting( $updated ) ) { - my $cookie_name = $c->config->{session}{cookie_name}; + my $cookie_name = $c->_session_plugin_config->{cookie_name}; $c->response->cookies->{$cookie_name} = $updated; } } @@ -60,7 +60,7 @@ sub cookie_is_rejecting { sub make_session_cookie { my ( $c, $sid, %attrs ) = @_; - my $cfg = $c->config->{session}; + my $cfg = $c->_session_plugin_config; my $cookie = { value => $sid, ( $cfg->{cookie_domain} ? ( domain => $cfg->{cookie_domain} ) : () ), @@ -77,8 +77,9 @@ sub make_session_cookie { $cookie->{secure} = 1 unless ( ($sec==0) || ($sec==2) ); $cookie->{secure} = 1 if ( ($sec==2) && $c->req->secure ); + $cookie->{httponly} = $cfg->{cookie_httponly}; $cookie->{httponly} = 1 - unless exists $cookie->{httponly}; # default = 1 (set httponly) + unless defined $cookie->{httponly}; # default = 1 (set httponly) return $cookie; } @@ -90,7 +91,7 @@ sub calc_expiry { # compat sub calculate_session_cookie_expires { my $c = shift; - my $cfg = $c->config->{session}; + my $cfg = $c->_session_plugin_config; my $value = $c->maybe::next::method(@_); return $value if $value; @@ -111,7 +112,7 @@ sub calculate_session_cookie_expires { sub get_session_cookie { my $c = shift; - my $cookie_name = $c->config->{session}{cookie_name}; + my $cookie_name = $c->_session_plugin_config->{cookie_name}; return $c->request->cookies->{$cookie_name}; } @@ -255,7 +256,7 @@ Default value is 1. Note1: Many peole are confused by the name "HTTPOnly" - it B that this cookie works only over HTTP and not over HTTPS. -Note2: This paramater requires Catalyst::Runtime 5.80005 otherwise is skipped. +Note2: This parameter requires Catalyst::Runtime 5.80005 otherwise is skipped. =item cookie_path @@ -265,7 +266,7 @@ The path of the request url where cookie should be baked. For example, you could stick this in MyApp.pm: - __PACKAGE__->config( session => { + __PACKAGE__->config( 'Plugin::Session' => { cookie_domain => '.mydomain.com', }); @@ -302,10 +303,13 @@ has been heavily modified since. Marcus Ramberg Jonathan Rockway Ejrockway@cpan.orgE Sebastian Riedel + Florian Ragwitz =head1 COPYRIGHT -Copyright (c) 2005, Yuval Kogman C<< >> +Copyright (c) 2005 - 2009 +the Catalyst::Plugin::Session::State::Cookie L and L +as listed above. =head1 LICENSE