Clean up, make author tests not skip, and change perl critic for notabs

diff --git a/Makefile.PL b/Makefile.PL
index 7901ea1..2a24779 100644 (file)
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -27,7 +27,7 @@ test_requires 'HTTP::Request::Common';
 
 author_requires 'Test::Pod' => '1.14';
 author_requires 'Test::Pod::Coverage' => '1.04';
-author_requires 'Test::Perl::Critic' => '1.01';
+author_requires 'Test::NoTabs' => '0.9';
 
 extra_tests;
 

diff --git a/xt/author/02pod.t b/xt/author/02pod.t
index 7846aad..46a0ed1 100644 (file)
--- a/xt/author/02pod.t
+++ b/xt/author/02pod.t
@@ -4,8 +4,6 @@ use warnings;
 use Test::More;
 
 # Ensure a recent version of Test::Pod
-my $min_tp = 1.22;
-eval "use Test::Pod $min_tp";
-plan skip_all => "Test::Pod $min_tp required for testing POD" if $@;
+use Test::Pod 1.22;
 
 all_pod_files_ok();

diff --git a/xt/author/03podcoverage.t b/xt/author/03podcoverage.t
index 2559baf..779780f 100644 (file)
--- a/xt/author/03podcoverage.t
+++ b/xt/author/03podcoverage.t
@@ -4,16 +4,7 @@ use warnings;
 use Test::More;
 
 # Ensure a recent version of Test::Pod::Coverage
-my $min_tpc = 1.08;
-eval "use Test::Pod::Coverage $min_tpc";
-plan skip_all => "Test::Pod::Coverage $min_tpc required for testing POD coverage"
-    if $@;
-
-# Test::Pod::Coverage doesn't require a minimum Pod::Coverage version,
-# but older versions don't recognize some common documentation styles
-my $min_pc = 0.18;
-eval "use Pod::Coverage $min_pc";
-plan skip_all => "Pod::Coverage $min_pc required for testing POD coverage"
-    if $@;
+use Test::Pod::Coverage 1.08;
+use Pod::Coverage 0.18;
 
 all_pod_coverage_ok();

diff --git a/xt/author/04critic.rc b/xt/author/04critic.rc
deleted file mode 100644 (file)
index 412f770..0000000
--- a/xt/author/04critic.rc
+++ /dev/null
@@ -1,5 +0,0 @@
-include  = CodeLayout::ProhibitHardTabs
-only     = 1
-
-[CodeLayout::ProhibitHardTabs]
-allow_leading_tabs = 0
\ No newline at end of file

diff --git a/xt/author/04critic.t b/xt/author/04critic.t
deleted file mode 100644 (file)
index a19b4d6..0000000
--- a/xt/author/04critic.t
+++ /dev/null
@@ -1,17 +0,0 @@
-use strict;
-use warnings;
-
-use File::Spec;
-use FindBin ();
-use Test::More;
-
-eval { require Test::Perl::Critic };
-if ( $@ ) {
-    plan tests => 1;
-    fail( 'You must install Test::Perl::Critic to run 04critic.t' );
-    exit;
-}
-
-my $rcfile = File::Spec->catfile( $FindBin::Bin, '04critic.rc' );
-Test::Perl::Critic->import( -profile => $rcfile );
-all_critic_ok();

diff --git a/xt/author/04tabs.t b/xt/author/04tabs.t
new file mode 100644 (file)
index 0000000..88dea86
--- /dev/null
+++ b/xt/author/04tabs.t
@@ -0,0 +1,8 @@
+use strict;
+use warnings;
+use Test::More;
+
+use Test::NoTabs 0.9;
+
+all_perl_files_ok();
+