From: Alexander Hartmaier Date: Thu, 9 Jan 2014 17:14:13 +0000 (+0100) Subject: added comments to tests regarding use_json_boolean usage in the controllers X-Git-Tag: 2.005001~10 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Controller-DBIC-API.git;a=commitdiff_plain;h=88d300e45ee7a34f351e25b416a4403df1d09813 added comments to tests regarding use_json_boolean usage in the controllers --- diff --git a/t/rest/item.t b/t/rest/item.t index a2a50dd..01203bd 100644 --- a/t/rest/item.t +++ b/t/rest/item.t @@ -32,6 +32,8 @@ my $artist_view_url = "$base/api/rest/artist/"; #artist does not have use_json_boolean => 1, so true values are stringified to 'true' is_deeply( $response, + + # artist doesn't set use_json_boolean { data => \%expected_response, success => 'true' }, 'correct data returned' ); @@ -66,6 +68,8 @@ my $track_view_url = "$base/api/rest/track/"; my $response = $json->decode( $mech->content ); is_deeply( $response, + + # track does set use_json_boolean { data => \%expected_response, success => JSON::true }, 'correct data returned for track with datetime' ); @@ -79,6 +83,8 @@ my $track_view_url = "$base/api/rest/track/"; my $response = $json->decode( $mech->content ); is_deeply( $response, + + # artist doesn't set use_json_boolean { success => 'false' }, 'correct data returned' ); diff --git a/t/rest/list.t b/t/rest/list.t index 7337531..a7a6eb6 100644 --- a/t/rest/list.t +++ b/t/rest/list.t @@ -203,6 +203,8 @@ my $track_list_url = "$base/api/rest/track"; } $schema->resultset('Track')->search( undef, { page => 1, } )->all; is_deeply( $response, + + # track does set use_json_boolean { list => \@expected_response, success => JSON::true, totalcount => 15 }, 'correct data returned for static configured paging' ); @@ -252,6 +254,8 @@ my $track_list_url = "$base/api/rest/track"; { join => { cds => 'tracks' }, } )->all; is_deeply( $response, + + # artist doesn't set use_json_boolean { list => \@expected_response, success => 'true' }, 'correct data returned for search with sql function' );