Fixed pod coverage and added a test for it

updated dist.ini to use @Basic instead of @Classic
fixed twice included PkgVersion (by @Classic and explicit)

diff --git a/Changes b/Changes
index 70b88d5..32e3de0 100644 (file)
--- a/Changes
+++ b/Changes
@@ -6,6 +6,7 @@ Revision history for Catalyst-Controller-DBIC-API: {{ $dist->version }}
 - Use column accessor for updating an existing object instead of passing the new values to update.
   This enables the column accessors to do additional work (for example with method modifiers).
 - Fixed t/rpc/list.t error message regex to pass with Moose version >=1.05
+- Fixed pod coverage and added a test for it
 
 2.002001  2010-04-01 01:41:11 Europe/Berlin
 

diff --git a/dist.ini b/dist.ini
index 9db4d86..f9294ec 100644 (file)
--- a/dist.ini
+++ b/dist.ini
@@ -5,17 +5,22 @@ author = Luke Saunders <luke.saunders@gmail.com>
 author = Alexander Hartmaier <abraxxa@cpan.org>
 author = Florian Ragwitz <rafl@debian.org>
 license = Perl_5
-copyright_holder = Luke Saunders, Nicholas Perez, et al.
+copyright_holder = Luke Saunders, Nicholas Perez, Alexander Hartmaier, et al.
 
-[@Classic]
+[@Basic]
 
 [PodWeaver]
-[BumpVersion]
+[PodSyntaxTests]
+[PodCoverageTests]
 [PkgVersion]
-[PodVersion]
 [NextRelease]
+[MetaConfig]
+[MetaJSON]
+
 [MetaResources]
-repository                          = git://git.shadowcat.co.uk/catagits/Catalyst-Controller-DBIC-API
+repository.type = git
+repository.url = git://git.shadowcat.co.uk/catagits/Catalyst-Controller-DBIC-API
+repository.web = http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits/Catalyst-Controller-DBIC-API.git
 
 [Prereq]
 DBIx::Class = 0.08103

diff --git a/lib/Catalyst/Controller/DBIC/API.pm b/lib/Catalyst/Controller/DBIC/API.pm
index b6ef5bc..e240b05 100644 (file)
--- a/lib/Catalyst/Controller/DBIC/API.pm
+++ b/lib/Catalyst/Controller/DBIC/API.pm
@@ -892,6 +892,12 @@ sub each_object_inflate
     return { $object->get_columns };
 }
 
+=method_protected serialize
+
+multiple actions forward to serialize which uses Catalyst::Action::Serialize.
+
+=cut
+
 # from Catalyst::Action::Serialize
 sub serialize :ActionClass('Serialize') { }
 

diff --git a/lib/Catalyst/Controller/DBIC/API/REST.pm b/lib/Catalyst/Controller/DBIC/API/REST.pm
index 2414a9c..d615b8a 100644 (file)
--- a/lib/Catalyst/Controller/DBIC/API/REST.pm
+++ b/lib/Catalyst/Controller/DBIC/API/REST.pm
@@ -36,17 +36,14 @@ As described in L<Catalyst::Controller::DBIC::API/setup>, this action is the cha
        ...
   );
 
-=method_protected no_id
+=method_protected update_or_create_objects
 
 Chained: L</objects_no_id>
 PathPart: none
-CaptureArgs: 0
-
-Calls list level methods described in L<Catalyst::Controller::DBIC::API> as follows:
+Args: 0
+Method: POST/PUT
 
-DELETE: L<Catalyst::Controller::DBIC::API/delete>
-POST/PUT: L<Catalyst::Controller::DBIC::API/update_or_create>
-GET: forwards to L<Catalyst::Controller::DBIC::API/list>
+Calls L<Catalyst::Controller::DBIC::API/update_or_create>. 
 
 =cut
 
@@ -56,29 +53,48 @@ sub update_or_create_objects : Chained('objects_no_id') PathPart('') Does('Match
     $self->update_or_create($c);
 }
 
+=method_protected delete_many_objects
+
+Chained: L</objects_no_id>
+PathPart: none
+Args: 0
+Method: DELETE
+
+Calls L<Catalyst::Controller::DBIC::API/delete>. 
+
+=cut
+
 sub delete_many_objects : Chained('objects_no_id') PathPart('') Does('MatchRequestMethod') Method('DELETE') Args(0)
 {
        my ( $self, $c ) = @_;
     $self->delete($c);
 }
 
+=method_protected list_objects
+
+Chained: L</objects_no_id>
+PathPart: none
+Args: 0
+Method: GET
+
+Calls L<Catalyst::Controller::DBIC::API/list>. 
+
+=cut
+
 sub list_objects : Chained('objects_no_id') PathPart('') Does('MatchRequestMethod') Method('GET') Args(0)
 {
        my ( $self, $c ) = @_;
     $self->list($c);
 }
 
-=method_protected with_id
+=method_protected update_or_create_one_object
 
 Chained: L</object_with_id>
 PathPart: none
-CaptureArgs: 0
-
-Forwards to list level methods described in L<Catalyst::Controller::DBIC::API> as follows:
+Args: 0
+Method: POST/PUT
 
-DELETE: L<Catalyst::Controller::DBIC::API/delete>
-POST/PUT: L<Catalyst::Controller::DBIC::API/update_or_create>
-GET: forwards to L<Catalyst::Controller::DBIC::API/item>
+Calls L<Catalyst::Controller::DBIC::API/update_or_create>.
 
 =cut
 
@@ -88,12 +104,34 @@ sub update_or_create_one_object : Chained('object_with_id') PathPart('') Does('M
     $self->update_or_create($c);
 }
 
+=method_protected delete_one_object
+
+Chained: L</object_with_id>
+PathPart: none
+Args: 0
+Method: DELETE
+
+Calls L<Catalyst::Controller::DBIC::API/delete>.
+
+=cut
+
 sub delete_one_object : Chained('object_with_id') PathPart('') Does('MatchRequestMethod') Method('DELETE') Args(0)
 {
        my ( $self, $c ) = @_;
     $self->delete($c);
 }
 
+=method_protected list_one_object
+
+Chained: L</object_with_id>
+PathPart: none
+Args: 0
+Method: GET
+
+Calls L<Catalyst::Controller::DBIC::API/item>.
+
+=cut
+
 sub list_one_object : Chained('object_with_id') PathPart('') Does('MatchRequestMethod') Method('GET') Args(0)
 {
        my ( $self, $c ) = @_;

diff --git a/lib/Catalyst/Controller/DBIC/API/RPC.pm b/lib/Catalyst/Controller/DBIC/API/RPC.pm
index b3b17c3..eacd523 100644 (file)
--- a/lib/Catalyst/Controller/DBIC/API/RPC.pm
+++ b/lib/Catalyst/Controller/DBIC/API/RPC.pm
@@ -43,6 +43,16 @@ As described in L<Catalyst::Controller::DBIC::API/setup>, this action is the cha
 
 =cut
 
+=method_protected index
+
+Chained: L</setup>
+PathPart: ''
+Args: 0
+
+Returns http status code 404 by default.
+
+=cut
+
 sub index : Chained('setup') PathPart('') Args(0) {
        my ( $self, $c ) = @_;
 

diff --git a/lib/Catalyst/Controller/DBIC/API/RequestArguments.pm b/lib/Catalyst/Controller/DBIC/API/RequestArguments.pm
index a9b5c33..a2fee74 100644 (file)
--- a/lib/Catalyst/Controller/DBIC/API/RequestArguments.pm
+++ b/lib/Catalyst/Controller/DBIC/API/RequestArguments.pm
@@ -10,6 +10,7 @@ use namespace::autoclean;
 
 use Catalyst::Controller::DBIC::API::JoinBuilder;
 
+=for Pod::Coverage check_rel
 
 =attribute_private search_validator