if username is passed to bind, assume password is passed too and do not default to...
Peter Karman [Wed, 9 Jan 2013 14:51:44 +0000 (14:51 +0000)]
lib/Catalyst/Authentication/Store/LDAP/Backend.pm

index bd5fbdf..43819f9 100644 (file)
@@ -214,8 +214,14 @@ sub ldap_bind {
     if ( !defined($ldap) ) {
         Catalyst::Exception->throw("LDAP Server undefined!");
     }
-    $binddn ||= $self->binddn;
-    $bindpw ||= $self->bindpw;
+
+    # if username is present, make sure password is present too.
+    # see https://rt.cpan.org/Ticket/Display.html?id=81908
+    if ( !defined $binddn ) {
+        $binddn = $self->binddn;
+        $bindpw = $self->bindpw;
+    }
+
     if ( $binddn eq "anonymous" ) {
         $self->_ldap_bind_anon($ldap);
     }