From: Ashley Pond V <ashley@cpan.org>
Date: Thu, 3 Jul 2008 03:42:05 +0000 (+0000)
Subject: This is 0.05.
X-Git-Tag: v0.05^0
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Authentication-Credential-OpenID.git;a=commitdiff_plain;h=ab944aad7e42f6a33f1338b8c648cc14df6e53de

This is 0.05.
---

diff --git a/Changes b/Changes
index 7bcd220..d54bae1 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,12 @@
 Revision history for Catalyst::Authentication::Credential::OpenID
 
+0.05  Wed Jul  2 20:17:21 PDT 2008
+      - Removed UNIVERSAL::require to shrink prereqs and protect
+        namespaces.
+      - Turned on test app tests. I want to know if it's failing for
+        others.
+      - Swapped LWPx::ParanoidAgent for LWP::UA in the test.
+
 0.04  Thu Jun 19 23:20:00 PDT 2008
       - Fixed some of the .conf example. Sigh.
       - Other minor Pod tweaks.
diff --git a/Makefile.PL b/Makefile.PL
index 3aa310c..dd0a957 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -2,6 +2,7 @@ use inc::Module::Install;
 
 name            "Catalyst-Authentication-Credential-OpenID";
 all_from        "lib/Catalyst/Authentication/Credential/OpenID.pm";
+author          "Ashley Pond V <ashley@cpan.org>";
 
 requires  "parent"                => "0.2";
 requires  "Class::Accessor::Fast" => 0;
@@ -9,7 +10,6 @@ requires  "Catalyst::Runtime"     => "5.7";
 requires  "Crypt::DH"             => "0.05"; # IIRC OpenID stuff forgets to prereq this
 requires  "Net::OpenID::Consumer" => "0.14";
 requires  "Catalyst::Exception"   => 0;
-requires  "UNIVERSAL::require"    => 0;
 requires  "Catalyst::Authentication::User::Hash" => 0;
 
 recommends "Config::General"     => "2";
diff --git a/lib/Catalyst/Authentication/Credential/OpenID.pm b/lib/Catalyst/Authentication/Credential/OpenID.pm
index 477b9e7..82678d8 100644
--- a/lib/Catalyst/Authentication/Credential/OpenID.pm
+++ b/lib/Catalyst/Authentication/Credential/OpenID.pm
@@ -8,10 +8,9 @@ BEGIN {
     __PACKAGE__->mk_accessors(qw/ _config realm debug secret /);
 }
 
-our $VERSION = "0.04";
+our $VERSION = "0.05";
 
 use Net::OpenID::Consumer;
-use UNIVERSAL::require;
 use Catalyst::Exception ();
 
 sub new : method {
@@ -37,11 +36,10 @@ sub new : method {
     $self->secret( $secret );
     $self->_config->{ua_class} ||= "LWPx::ParanoidAgent";
 
-    eval {
-        $self->_config->{ua_class}->require;
-    }
-    or Catalyst::Exception->throw("Could not 'require' user agent class " .
-                                  $self->_config->{ua_class});
+    my $agent_class = $self->_config->{ua_class};
+    eval "require $agent_class"
+        or Catalyst::Exception->throw("Could not 'require' user agent class " .
+                                      $self->_config->{ua_class});
 
     $c->log->debug("Setting consumer secret: " . $secret) if $self->debug;
 
@@ -126,15 +124,15 @@ __END__
 
 =head1 NAME
 
-Catalyst::Authentication::Credential::OpenID - OpenID credential for L<Catalyst::Plugin::Authentication> framework.
+Catalyst::Authentication::Credential::OpenID - OpenID credential for Catalyst::Plugin::Authentication framework.
 
 =head1 VERSION
 
-0.04
+0.05
 
 =head1 SYNOPSIS
 
-In MyApp.pm.
+In MyApp.pm-
 
  use Catalyst qw/
     Authentication
@@ -143,7 +141,7 @@ In MyApp.pm.
     Session::State::Cookie
  /;
 
-Somewhere in myapp.conf.
+Somewhere in myapp.conf-
 
  <Plugin::Authentication>
      default_realm   openid
@@ -157,7 +155,7 @@ Somewhere in myapp.conf.
      </realms>
  </Plugin::Authentication>
 
-Or in your myapp.yml if you're using L<YAML> instead.
+Or in your myapp.yml if you're using L<YAML> instead-
 
  Plugin::Authentication:
    default_realm: openid
@@ -167,7 +165,7 @@ Or in your myapp.yml if you're using L<YAML> instead.
          class: OpenID
        ua_class: LWPx::ParanoidAgent
 
-In a controller, perhaps C<Root::openid>.
+In a controller, perhaps C<Root::openid>-
 
  sub openid : Local {
       my($self, $c) = @_;
@@ -183,7 +181,7 @@ In a controller, perhaps C<Root::openid>.
       }
  }
 
-And a L<Template> to match in C<openid.tt>.
+And a L<Template> to match in C<openid.tt>-
 
  <form action="[% c.uri_for('/openid') %]" method="GET" name="openid">
  <input type="text" name="openid_identifier" class="openid" />
diff --git a/t/TestApp/lib/TestApp.pm b/t/TestApp/lib/TestApp.pm
index a904394..a0dbd3c 100644
--- a/t/TestApp/lib/TestApp.pm
+++ b/t/TestApp/lib/TestApp.pm
@@ -38,8 +38,8 @@ __PACKAGE__->config
                           }
               },
               openid => {
-                  ua_class => "LWPx::ParanoidAgent",
-#                  ua_class => "LWP::UserAgent",
+#                  ua_class => "LWPx::ParanoidAgent",
+                  ua_class => "LWP::UserAgent",
                   ua_args => {
                       whitelisted_hosts => [qw/ 127.0.0.1 localhost /],
                   },
diff --git a/t/live_app.t b/t/live_app.t
index 16ab006..fd816db 100644
--- a/t/live_app.t
+++ b/t/live_app.t
@@ -8,16 +8,12 @@ use IO::Socket;
 use Test::More;
 use Test::WWW::Mechanize;
 
-
-plan skip_all => 'set TEST_HTTP to enable this test' unless $ENV{TEST_HTTP};
+# plan skip_all => 'set TEST_HTTP to enable this test' unless $ENV{TEST_HTTP};
 eval "use Catalyst::Devel 1.0";
 plan skip_all => 'Catalyst::Devel required' if $@;
 
-# plan "no_plan";
 plan tests => 17;
 
-# TEST FORK?
-
 # How long to wait for test server to start and timeout for UA.
 my $seconds = 30;
 
@@ -28,7 +24,6 @@ my $port = 30000 + int rand(1 + 10000);
 
 # my $pipe = "perl -I$FindBin::Bin/../lib -I$FindBin::Bin/TestApp/lib $FindBin::Bin/TestApp/script/testapp_server.pl -f -port $port 2>&1 |";
 
-
 my $pid = open my $server, $pipe
     or die "Unable to spawn standalone HTTP server: $!";