From: Tomas Doran Date: Fri, 16 Oct 2009 08:21:45 +0000 (+0000) Subject: Small cleanups X-Git-Tag: v0.17~6 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Authentication-Credential-OpenID.git;a=commitdiff_plain;h=4c4e7c7e91e6ae75d85d8ece8534629db2a66ba8 Small cleanups --- diff --git a/Makefile.PL b/Makefile.PL index f78435c..7f6782c 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,10 +1,11 @@ use inc::Module::Install 0.87; +use strict; +use warnings; name "Catalyst-Authentication-Credential-OpenID"; all_from "lib/Catalyst/Authentication/Credential/OpenID.pm"; -author "Ashley Pond V "; +author "Ashley Pond V "; -requires "parent" => "0.2"; requires "Class::Accessor::Fast" => undef; requires "HTML::Parser" => "3"; requires "LWP::UserAgent" => undef; diff --git a/lib/Catalyst/Authentication/Credential/OpenID.pm b/lib/Catalyst/Authentication/Credential/OpenID.pm index de9a9f3..5f8a6ef 100644 --- a/lib/Catalyst/Authentication/Credential/OpenID.pm +++ b/lib/Catalyst/Authentication/Credential/OpenID.pm @@ -1,18 +1,16 @@ package Catalyst::Authentication::Credential::OpenID; use strict; -# use warnings; no warnings "uninitialized"; # for testing, not production -use parent "Class::Accessor::Fast"; +use warnings; +use base "Class::Accessor::Fast"; -BEGIN { - __PACKAGE__->mk_accessors(qw/ _config realm debug secret /); -} +__PACKAGE__->mk_accessors(qw/ _config realm debug secret /); our $VERSION = "0.16"; use Net::OpenID::Consumer; use Catalyst::Exception (); -sub new : method { +sub new { my ( $class, $config, $c, $realm ) = @_; my $self = { _config => { %{ $config }, %{ $realm->{config} } @@ -47,7 +45,7 @@ sub new : method { return $self; } -sub authenticate : method { +sub authenticate { my ( $self, $c, $realm, $authinfo ) = @_; $c->log->debug("authenticate() called from " . $c->request->uri) if $self->debug;