From: Tomas Doran Date: Sun, 4 Jan 2009 21:43:10 +0000 (+0000) Subject: Checking in changes prior to tagging of version 0.05. Changelog diff is: X-Git-Tag: v0.05^0 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Authentication-Credential-HTTP-Proxy.git;a=commitdiff_plain;h=bbec9b61e82d84f6c04327bb817ffff68688e629 Checking in changes prior to tagging of version 0.05. Changelog diff is: === Changes ================================================================== --- Changes (revision 8586) +++ Changes (local) @@ -1,3 +1,9 @@ +0.05 2009-01-04 + - Start releasing using ShipIt + - Remove use of _config accessor, which I'd stupidly cargo-culted. + - Fix MANIFEST + - Add pod spelling test + 0.04 2008-09-25 - Change namespace to remove ::Plugin:: for new auth framework. - Gutted most of the code in the module by subclassing --- diff --git a/.shipit b/.shipit new file mode 100644 index 0000000..5a1f17f --- /dev/null +++ b/.shipit @@ -0,0 +1,9 @@ +# auto-generated shipit config file. +steps = FindVersion, ChangeVersion, CheckChangeLog, DistTest, Commit, Tag, MakeDist, UploadCPAN + +svk.tagpattern = //mirror/Catalyst-Authentication-Credential-HTTP-Proxy/1.000/tags/%v + +# svn.tagpattern = MyProj-%v +# svn.tagpattern = http://code.example.com/svn/tags/MyProj-%v + +CheckChangeLog.files = Changes diff --git a/Changes b/Changes index a6dc9fd..9164c87 100644 --- a/Changes +++ b/Changes @@ -1,3 +1,9 @@ +0.05 2009-01-04 + - Start releasing using ShipIt + - Remove use of _config accessor, which I'd stupidly cargo-culted. + - Fix MANIFEST + - Add pod spelling test + 0.04 2008-09-25 - Change namespace to remove ::Plugin:: for new auth framework. - Gutted most of the code in the module by subclassing diff --git a/MANIFEST b/MANIFEST index e78ced9..3bef395 100644 --- a/MANIFEST +++ b/MANIFEST @@ -12,6 +12,7 @@ inc/Module/Install/Win32.pm inc/Module/Install/WriteAll.pm lib/Catalyst/Authentication/Credential/HTTP/Proxy.pm lib/Catalyst/Authentication/Credential/HTTP/Proxy/User.pm +lib/Catalyst/Authentication/Credential/HTTP/User.pm Makefile.PL MANIFEST This list of files META.yml @@ -21,4 +22,5 @@ t/live_app.t t/mock.t t/pod.t t/pod_coverage.t +t/pod_spelling.t t/use.t diff --git a/Makefile.PL b/Makefile.PL index 905b2a4..bee12a8 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -5,7 +5,7 @@ all_from 'lib/Catalyst/Authentication/Credential/HTTP/Proxy.pm'; requires 'Catalyst::Runtime'; requires 'Catalyst::Plugin::Authentication'; -requires 'Catalyst::Authentication::Credential::HTTP' => '1.005'; +requires 'Catalyst::Authentication::Credential::HTTP' => '1.009'; requires 'LWP::Simple'; build_requires 'Test::MockObject'; build_requires 'Test::Exception'; diff --git a/lib/Catalyst/Authentication/Credential/HTTP/Proxy.pm b/lib/Catalyst/Authentication/Credential/HTTP/Proxy.pm index 6b16f0e..4285290 100644 --- a/lib/Catalyst/Authentication/Credential/HTTP/Proxy.pm +++ b/lib/Catalyst/Authentication/Credential/HTTP/Proxy.pm @@ -8,12 +8,16 @@ use String::Escape (); use URI::Escape (); use Catalyst::Authentication::Credential::HTTP::Proxy::User; -our $VERSION = "0.04"; +our $VERSION = "0.05"; + +__PACKAGE__->mk_accessors(qw/ + url +/); sub init { my ($self) = @_; - my $type = $self->_config->{'type'} ||= 'basic'; + my $type = $self->type || 'basic'; if (!$self->_config->{url}) { Catalyst::Exception->throw(__PACKAGE__ . " configuration does not include a 'url' key, cannot proceed"); @@ -22,6 +26,7 @@ sub init { if (!grep /^$type$/, ('basic')) { Catalyst::Exception->throw(__PACKAGE__ . " used with unsupported authentication type: " . $type); } + $self->type($type); } sub authenticate_basic { @@ -34,7 +39,7 @@ sub authenticate_basic { if ( my ( $user, $password ) = $headers->authorization_basic ) { my $ua = Catalyst::Authentication::Credential::HTTP::Proxy::User->new; $ua->credentials($user, $password); - my $resp = $ua->get($self->_config->{url}); + my $resp = $ua->get($self->url); if ( $resp->is_success ) { # Config username_field TODO my $user_obj = $realm->find_user( { username => $user }, $c); @@ -57,6 +62,8 @@ sub authenticate_basic { } } +1; + __END__ =pod @@ -102,7 +109,7 @@ for Catlayst. =head1 DESCRIPTION -This moduule lets you use HTTP Proxy authentication with +This module lets you use HTTP Proxy authentication with L. Currently this module only supports the Basic scheme, but upon request Digest diff --git a/t/pod_spelling.t b/t/pod_spelling.t new file mode 100644 index 0000000..73a8a7d --- /dev/null +++ b/t/pod_spelling.t @@ -0,0 +1,25 @@ +use strict; +use warnings; +use Test::More; + +eval 'use Test::Spelling 0.11'; +plan skip_all => 'Test::Spelling 0.11 not installed' if $@; +plan skip_all => 'set TEST_SPELLING to enable this test' unless $ENV{TEST_SPELLING}; + +set_spell_cmd('aspell list'); + +add_stopwords(); + +all_pod_files_spelling_ok(); + +__DATA__ +Initializes +Doran +Ramberg +Catlayst +url +username +auth +authorization +init +