From: Andrew Rodland Date: Fri, 4 Dec 2009 02:04:59 +0000 (-0600) Subject: Port Serialize classes except for View. X-Git-Tag: 0.80~6 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Action-REST.git;a=commitdiff_plain;h=7f36b63e1e7aca928955af6da4c18ac76d7afd4c Port Serialize classes except for View. --- diff --git a/lib/Catalyst/Action/Serialize/Data/Serializer.pm b/lib/Catalyst/Action/Serialize/Data/Serializer.pm index ca42ce7..c58d192 100644 --- a/lib/Catalyst/Action/Serialize/Data/Serializer.pm +++ b/lib/Catalyst/Action/Serialize/Data/Serializer.pm @@ -23,16 +23,10 @@ sub execute { }; if ($@) { $c->log->info("Could not load $serializer, refusing to serialize: $@"); - return 0; + return; } my $dso = Data::Serializer->new( serializer => $serializer ); - my $data; - eval { - $data = $dso->raw_serialize($c->stash->{$stash_key}); - }; - if ($@) { - return $@; - } + my $data = $dso->raw_serialize($c->stash->{$stash_key}); $c->response->output( $data ); return 1; } diff --git a/lib/Catalyst/Action/Serialize/JSON.pm b/lib/Catalyst/Action/Serialize/JSON.pm index d4b12df..c462e58 100644 --- a/lib/Catalyst/Action/Serialize/JSON.pm +++ b/lib/Catalyst/Action/Serialize/JSON.pm @@ -15,13 +15,7 @@ sub execute { $controller->{'serialize'}->{'stash_key'} : $controller->{'stash_key'} ) || 'rest'; - my $output; - eval { - $output = $self->serialize( $c->stash->{$stash_key} ); - }; - if ($@) { - return $@; - } + my $output = $self->serialize( $c->stash->{$stash_key} ); $c->response->output( $output ); return 1; } diff --git a/lib/Catalyst/Action/Serialize/XML/Simple.pm b/lib/Catalyst/Action/Serialize/XML/Simple.pm index a562078..a367596 100644 --- a/lib/Catalyst/Action/Serialize/XML/Simple.pm +++ b/lib/Catalyst/Action/Serialize/XML/Simple.pm @@ -15,7 +15,7 @@ sub execute { if ($@) { $c->log->debug("Could not load XML::Serializer, refusing to serialize: $@") if $c->debug; - return 0; + return; } my $xs = XML::Simple->new(ForceArray => 0,); @@ -24,13 +24,7 @@ sub execute { $controller->{'serialize'}->{'stash_key'} : $controller->{'stash_key'} ) || 'rest'; - my $output; - eval { - $output = $xs->XMLout({ data => $c->stash->{$stash_key} }); - }; - if ($@) { - return $@; - } + my $output = $xs->XMLout({ data => $c->stash->{$stash_key} }); $c->response->output( $output ); return 1; } diff --git a/lib/Catalyst/Action/Serialize/YAML.pm b/lib/Catalyst/Action/Serialize/YAML.pm index 911191b..c3f9003 100644 --- a/lib/Catalyst/Action/Serialize/YAML.pm +++ b/lib/Catalyst/Action/Serialize/YAML.pm @@ -15,13 +15,7 @@ sub execute { $controller->{'serialize'}->{'stash_key'} : $controller->{'stash_key'} ) || 'rest'; - my $output; - eval { - $output = $self->serialize($c->stash->{$stash_key}); - }; - if ($@) { - return $@; - } + my $output = $self->serialize($c->stash->{$stash_key}); $c->response->output( $output ); return 1; }