Added tests and removed message

304 responses have no content.

diff --git a/lib/Catalyst/Controller/REST.pm b/lib/Catalyst/Controller/REST.pm
index fc88cd2..a8f179b 100644 (file)
--- a/lib/Catalyst/Controller/REST.pm
+++ b/lib/Catalyst/Controller/REST.pm
@@ -469,11 +469,9 @@ sub status_not_modified {
     my $self = shift;
     my $c    = shift;
 
-    my %p    = Params::Validate::validate( @_, { message => { type => SCALAR }, }, );
-
     $c->response->status(304);
-    $c->log->debug( "Status Not Modified: " . $p{'message'} ) if $c->debug;
-    $self->_set_entity( $c, { error => $p{'message'} } );
+    $c->log->debug( "Status Not Modified" ) if $c->debug;
+    $self->_set_entity( $c, {  } );
     return 1;
  }
 

diff --git a/t/catalyst-controller-rest.t b/t/catalyst-controller-rest.t
index e37dab8..666c157 100644 (file)
--- a/t/catalyst-controller-rest.t
+++ b/t/catalyst-controller-rest.t
@@ -40,6 +40,10 @@ is_deeply Load( $res->content ),
     "...  status found message";
 is $res->header('Location'), '/rest', "...location of what was found";
 
+ok $res = request( $t->get( url => '/rest/test_status_not_modified' ) );
+is $res->code, 304, '... status not modified';
+is $res->content, '', '... no content';
+
 ok $res = request( $t->get( url => '/rest/test_status_bad_request' ) );
 is $res->code, 400, '... status bad request';
 is_deeply Load( $res->content ),

diff --git a/t/lib/Test/Catalyst/Action/REST/Controller/REST.pm b/t/lib/Test/Catalyst/Action/REST/Controller/REST.pm
index 08bcdf0..7aa5c25 100644 (file)
--- a/t/lib/Test/Catalyst/Action/REST/Controller/REST.pm
+++ b/t/lib/Test/Catalyst/Action/REST/Controller/REST.pm
@@ -44,6 +44,14 @@ sub test_status_found : Local {
     );
 }
 
+sub test_status_not_modified : Local {
+    my ( $self, $c ) = @_;
+    $self->status_not_modified(
+        $c,
+        message => "Not modified",
+    );
+}
+
 sub test_status_accepted : Local {
     my ( $self, $c ) = @_;
     $self->status_accepted(