X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Action-REST.git;a=blobdiff_plain;f=lib%2FCatalyst%2FAction%2FDeserialize.pm;h=6029f9a00ce7a8aa6d0fe9655451771b52448ef1;hp=b779f7cbdc00039472985eaebfaa7b44b67e29e9;hb=d0822465cc09629df95ad9c522bce758f2badc8c;hpb=05009b91e5e1729a5dc81af102e13823ce89f0d6 diff --git a/lib/Catalyst/Action/Deserialize.pm b/lib/Catalyst/Action/Deserialize.pm index b779f7c..6029f9a 100644 --- a/lib/Catalyst/Action/Deserialize.pm +++ b/lib/Catalyst/Action/Deserialize.pm @@ -6,19 +6,36 @@ use namespace::autoclean; extends 'Catalyst::Action::SerializeBase'; use Module::Pluggable::Object; use MRO::Compat; +use Moose::Util::TypeConstraints; -our $VERSION = '0.81'; +our $VERSION = '1.02'; $VERSION = eval $VERSION; has plugins => ( is => 'rw' ); +has deserialize_http_methods => ( + traits => ['Hash'], + isa => do { + my $tc = subtype as 'HashRef[Str]'; + coerce $tc, from 'ArrayRef[Str]', + via { +{ map { ($_ => 1) } @$_ } }; + $tc; + }, + coerce => 1, + builder => '_build_deserialize_http_methods', + handles => { + deserialize_http_methods => 'keys', + _deserialize_handles_http_method => 'exists', + }, +); + +sub _build_deserialize_http_methods { [qw(POST PUT OPTIONS DELETE)] } + sub execute { my $self = shift; my ( $controller, $c ) = @_; - my @demethods = qw(POST PUT OPTIONS); - my $method = $c->request->method; - if ( grep /^$method$/, @demethods ) { + if ( !defined($c->req->data) && $self->_deserialize_handles_http_method($c->request->method) ) { my ( $sclass, $sarg, $content_type ) = $self->_load_content_plugins( 'Catalyst::Action::Deserialize', $controller, $c ); @@ -30,9 +47,9 @@ sub execute { $rc = $sclass->execute( $controller, $c ); } if ( $rc eq "0" ) { - return $self->_unsupported_media_type( $c, $content_type ); + return $self->unsupported_media_type( $c, $content_type ); } elsif ( $rc ne "1" ) { - return $self->_serialize_bad_request( $c, $content_type, $rc ); + return $self->serialize_bad_request( $c, $content_type, $rc ); } } @@ -64,11 +81,27 @@ Catalyst::Action::Deserialize - Deserialize Data in a Request =head1 DESCRIPTION -This action will deserialize HTTP POST, PUT, and OPTIONS requests. +This action will deserialize HTTP POST, PUT, OPTIONS and DELETE requests. It assumes that the body of the HTTP Request is a serialized object. The serializer is selected by introspecting the requests content-type header. +If you want deserialize any other HTTP method besides POST, PUT, +OPTIONS and DELETE you can do this by setting the +C<< deserialize_http_methods >> list via C<< action_args >>. +Just modify the config in your controller and define a list of HTTP +methods the deserialization should happen for: + + __PACKAGE__->config( + action_args => { + '*' => { + deserialize_http_methods => [qw(POST PUT OPTIONS DELETE GET)] + } + } + ); + +See also L. + The specifics of deserializing each content-type is implemented as a plugin to L. You can see a list of currently implemented plugins in L. @@ -87,6 +120,13 @@ Will work just fine. When you use this module, the request class will be changed to L. +=head1 CUSTOM ERRORS + +For building custom error responses when de-serialization fails, you can create +an ActionRole (and use L to apply it to the +C action) which overrides C and/or C<_serialize_bad_request> +methods. + =head1 SEE ALSO You likely want to look at L, which implements