Fix docs citing incorrect method, "serialize_bad_request"

[catagits/Catalyst-Action-REST.git] / lib / Catalyst / Action / Serialize.pm

diff --git a/lib/Catalyst/Action/Serialize.pm b/lib/Catalyst/Action/Serialize.pm
index 09344e8..057cc39 100644 (file)
--- a/lib/Catalyst/Action/Serialize.pm
+++ b/lib/Catalyst/Action/Serialize.pm
@@ -7,9 +7,6 @@ extends 'Catalyst::Action::SerializeBase';
 use Module::Pluggable::Object;
 use MRO::Compat;
 
-our $VERSION = '1.12';
-$VERSION = eval $VERSION;
-
 has _encoders => (
    is => 'ro',
    isa => 'HashRef',
@@ -29,6 +26,15 @@ sub execute {
     return 1 if defined $c->stash->{current_view};
     return 1 if defined $c->stash->{current_view_instance};
 
+    # on 3xx responses, serialize if there's something to
+    # serialize, no-op if not
+    my $stash_key = (
+       $controller->{'serialize'} ?
+           $controller->{'serialize'}->{'stash_key'} :
+                $controller->{'stash_key'}
+           ) || 'rest';
+    return 1 if $c->response->status =~ /^(?:3\d\d)$/ && ! defined $c->stash->{$stash_key};
+
     my ( $sclass, $sarg, $content_type ) =
       $self->_load_content_plugins( "Catalyst::Action::Serialize",
         $controller, $c );
@@ -146,7 +152,7 @@ with the rest of Catalyst.
 
 For building custom error responses when serialization fails, you can create
 an ActionRole (and use L<Catalyst::Controller::ActionRole> to apply it to the
-C<end> action) which overrides C<unsupported_media_type> and/or C<_serialize_bad_request>
+C<end> action) which overrides C<unsupported_media_type> and/or C<serialize_bad_request>
 methods.
 
 =head1 SEE ALSO