7 years agoAttempt to fix 'Attempt to free unreferenced scalar' on 5.8 namespace-cleanup
Dagfinn Ilmari Mannsåker [Tue, 27 Jun 2017 12:16:31 +0000]
Attempt to fix 'Attempt to free unreferenced scalar' on 5.8

Move 'use namespace::clean' to after all the other use statements,
and remove now-pointless empty import lists.

7 years agoRelease 0.07047 0.07047
Dagfinn Ilmari Mannsåker [Fri, 26 May 2017 14:41:06 +0000]
Release 0.07047

7 years agoAdd ticket number for '.' in @INC fix (RT#121905)
Dagfinn Ilmari Mannsåker [Fri, 26 May 2017 14:57:10 +0000]
Add ticket number for '.' in @INC fix (RT#121905)

7 years agoAdd Changes entry exclude/constraint doc improvment (GH#12)
Dagfinn Ilmari Mannsåker [Fri, 26 May 2017 14:10:18 +0000]
Add Changes entry exclude/constraint doc improvment (GH#12)

7 years agoRun Travis-CI test on the latest two stable perls
Dagfinn Ilmari Mannsåker [Mon, 8 May 2017 09:48:16 +0000]
Run Travis-CI test on the latest two stable perls

7 years agoFix running Makefile.PL without '.' in @INC
Dagfinn Ilmari Mannsåker [Mon, 10 Apr 2017 14:19:12 +0000]
Fix running Makefile.PL without '.' in @INC

7 years agoAdd trailing commas in rel_name_map hashref example
Dagfinn Ilmari Mannsåker [Mon, 10 Apr 2017 14:18:32 +0000]
Add trailing commas in rel_name_map hashref example

7 years agoBe more consistent about how we refer to column/table objects
Dagfinn Ilmari Mannsåker [Mon, 10 Apr 2017 14:18:15 +0000]
Be more consistent about how we refer to column/table objects

7 years agoImprove col_accessor_map coderef documentation
Dagfinn Ilmari Mannsåker [Mon, 10 Apr 2017 14:17:00 +0000]
Improve col_accessor_map coderef documentation

Use a proper list for the coderef arguments and be more consistent
about how we refer to the column/table objects.

7 years agoImprove moniker_map coderef documentation (GH#7)
Dagfinn Ilmari Mannsåker [Mon, 10 Apr 2017 13:54:41 +0000]
Improve moniker_map coderef documentation (GH#7)

Rather than using the suggested patch, use a proper list for the
coderef arguments.

7 years agoFix POD typo
Dagfinn Ilmari Mannsåker [Mon, 10 Apr 2017 13:42:01 +0000]
Fix POD typo

7 years agoFix POD punctuation typo
Dagfinn Ilmari Mannsåker [Wed, 1 Feb 2017 13:27:40 +0000]
Fix POD punctuation typo

7 years agoAdd arc to AUTHORS
Dagfinn Ilmari Mannsåker [Tue, 29 Nov 2016 18:56:58 +0000]
Add arc to AUTHORS

7 years agoTweak "exclude" and "constraint" option docs
Aaron Crane [Tue, 29 Nov 2016 17:36:35 +0000]
Tweak "exclude" and "constraint" option docs

A user reading the documentation online may click on a TOC link to the
"exclude" option, not seeing that the description also applies to the
"constraint" option immediately above. This commit seeks to remedy that
by moving the description to the "constraint" section and giving
"exclude" and explicit backward reference to it.

8 years agoAvoid upcoming DBIC warning on implicit SELECT * invocation (RT#118178)
Dagfinn Ilmari Mannsåker [Tue, 4 Oct 2016 16:29:03 +0000]
Avoid upcoming DBIC warning on implicit SELECT * invocation (RT#118178)

8 years agoRelease 0.07046 0.07046
Dagfinn Ilmari Mannsåker [Mon, 5 Sep 2016 11:42:21 +0000]
Release 0.07046

8 years agoConvert complicated unless condition to simpler if
Dagfinn Ilmari Mannsåker [Mon, 7 Mar 2016 16:00:51 +0000]
Convert complicated unless condition to simpler if

Also linewrap

8 years agoFix pointlessly overlong line
Dagfinn Ilmari Mannsåker [Wed, 22 Jun 2016 08:07:17 +0000]
Fix pointlessly overlong line

8 years agoOverwrite if the md5sum in a file is wrong but the content has not changed
Dave Rolsky [Tue, 12 Jan 2016 19:13:18 +0000]
Overwrite if the md5sum in a file is wrong but the content has not changed

The code was reading the file, then generating an md5sum for the content and
comparing it to the md5sum in the file itself. If these didn't match then it
would return the _generated_ MD5 rather than what was actually in the file. It
would then compare this generated MD5 to the MD5 for a regen of the same
file. If they matched it would not bother writing the file.

This works fine if it's the _content_ that has changed, but if the md5sum
itself is wrong but the content has not changed, then returning the generated
MD5 based on the content we just read is wrong.

Instead, we now simply return a non-MD5 string. This will force the file to be
written again whether it was the file's content that had changed or just its
md5sum.

8 years agofix typo of "Module::Install" in Makefile.PL
Justin Hunter [Sun, 19 Jun 2016 19:22:32 +0000]
fix typo of "Module::Install" in Makefile.PL

8 years agoRemove leftover Devel::Dwarn from test
Dagfinn Ilmari Mannsåker [Sat, 18 Jun 2016 15:58:06 +0000]
Remove leftover Devel::Dwarn from test

8 years agoAdd AuthorTests to list of required M:I Plugins
Dagfinn Ilmari Mannsåker [Sat, 18 Jun 2016 15:35:53 +0000]
Add AuthorTests to list of required M:I Plugins

8 years agoDisallow creating dist with extra author mode deps
Dagfinn Ilmari Mannsåker [Thu, 25 Feb 2016 12:36:35 +0000]
Disallow creating dist with extra author mode deps

8 years agoIntrospect view definitions
Dagfinn Ilmari Mannsåker [Tue, 2 Feb 2016 18:15:08 +0000]
Introspect view definitions

Supported on PostgreSQL, MySQL, Oracle, Firebird, and InterBase.

8 years ago(trv) Grant CREATE VIEW to Oracle test user
Dagfinn Ilmari Mannsåker [Fri, 19 Feb 2016 00:45:33 +0000]
(trv) Grant CREATE VIEW to Oracle test user

Unlike CREATE TABLE, it's not included in the 'resource' system role.

8 years ago(trv) Allow threaded 5.8.8 to fail
Dagfinn Ilmari Mannsåker [Fri, 19 Feb 2016 12:14:45 +0000]
(trv) Allow threaded 5.8.8 to fail

namespace::clean fails its tests if Sub::Name or Sub::Util is installed,
see https://rt.cpan.org/Ticket/Display.html?id=107343.

8 years ago(trv) Don't set DBIC_TRACE_PROFILE on perl 5.8
Dagfinn Ilmari Mannsåker [Fri, 19 Feb 2016 12:11:17 +0000]
(trv) Don't set DBIC_TRACE_PROFILE on perl 5.8

It causes weird undef warnings from the guts of utf8_heavy.pl.

8 years agoFix POD spelling error (RT#111383)
gregor herrmann [Sat, 23 Jan 2016 17:47:09 +0000]
Fix POD spelling error (RT#111383)

8 years agoUse common infrastructure to create/drop extra Firebird objects
Dagfinn Ilmari Mannsåker [Thu, 18 Feb 2016 19:47:29 +0000]
Use common infrastructure to create/drop extra Firebird objects

For this to work if the different Firebird DSNs point to the same
database we need to explicitly disconnect between each connect_info set
when only running extra tests.  Running all the tests already does this.

8 years ago(trv) Make sure $NUMTHREADS isn't zero
D. Ilmari Mannsåker [Mon, 25 Jan 2016 14:26:09 +0000]
(trv) Make sure $NUMTHREADS isn't zero

8 years ago(trv) Verbosely fetch the Firebird ODBC driver
D. Ilmari Mannsåker [Mon, 25 Jan 2016 13:29:08 +0000]
(trv) Verbosely fetch the Firebird ODBC driver

8 years ago(trv) Get bc-multiarch from Github
D. Ilmari Mannsåker [Mon, 25 Jan 2016 12:46:45 +0000]
(trv) Get bc-multiarch from Github

8 years agoRelease 0.07045 0.07045
D. Ilmari Mannsåker [Fri, 22 Jan 2016 15:54:30 +0000]
Release 0.07045

8 years agoRelease 0.07044 0.07044
D. Ilmari Mannsåker [Fri, 22 Jan 2016 15:44:05 +0000]
Release 0.07044

9 years agoFix col_accessor_map test for Oracle, DB2 and Firebird
Dagfinn Ilmari Mannsåker [Wed, 11 Nov 2015 14:29:07 +0000]
Fix col_accessor_map test for Oracle, DB2 and Firebird

These DBs return table names in upper case, so add that to the map.

9 years agoFix typo in column object POD link
Dagfinn Ilmari Mannsåker [Wed, 11 Nov 2015 13:19:58 +0000]
Fix typo in column object POD link

9 years agoAdd support for nested hashref form of col_accessor_map
Dagfinn Ilmari Mannsåker [Wed, 11 Nov 2015 13:04:25 +0000]
Add support for nested hashref form of col_accessor_map

Thanks to @davorg++ for spotting the omission.

9 years agoFix missing space before opening brace
Dagfinn Ilmari Mannsåker [Wed, 11 Nov 2015 12:27:06 +0000]
Fix missing space before opening brace

9 years agoTest 'bit varying' without size for Pg
Dagfinn Ilmari Mannsåker [Sun, 13 Sep 2015 16:41:54 +0000]
Test 'bit varying' without size for Pg

9 years agoSipmlify Pg enum value fetching
Dagfinn Ilmari Mannsåker [Sun, 13 Sep 2015 16:39:34 +0000]
Sipmlify Pg enum value fetching

9 years agoEliminate redundant query in Pg _column_comment
Dagfinn Ilmari Mannsåker [Sun, 13 Sep 2015 16:38:38 +0000]
Eliminate redundant query in Pg _column_comment

9 years agoRemove pointless options from _tables_list and _filter_tables
Dagfinn Ilmari Mannsåker [Sat, 29 Aug 2015 21:56:18 +0000]
Remove pointless options from _tables_list and _filter_tables

_filter_tables can just get the constraints from $self instead

9 years agoFix Pg date/time types with zero fractional second digits
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 13:31:33 +0000]
Fix Pg date/time types with zero fractional second digits

9 years agoAdd author test for whitespace errors and make whitespace more consistent
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 17:49:09 +0000]
Add author test for whitespace errors and make whitespace more consistent

9 years agoAdd author test for use strict/warnings
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 17:47:42 +0000]
Add author test for use strict/warnings

9 years agoImprove POD test and make it author-only
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 17:19:04 +0000]
Improve POD test and make it author-only

9 years agoImport the latest ::Optional::Dependencies from DBIC
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 13:06:35 +0000]
Import the latest ::Optional::Dependencies from DBIC

There should be no behavioural changes, only less code and time spent
skipping things.

9 years agoMerge AUTHOR and CONTRIBUTORS into a single AUTHORS section
Dagfinn Ilmari Mannsåker [Wed, 3 Jun 2015 22:28:02 +0000]
Merge AUTHOR and CONTRIBUTORS into a single AUTHORS section

Also alphabetise the list.

9 years agoFix syntax errors in POD data structure example
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 21:29:00 +0000]
Fix syntax errors in POD data structure example

Also wrap over-long verbatim lines

9 years agoAdd .dir-locals.el file
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 13:11:53 +0000]
Add .dir-locals.el file

9 years agoRelease 0.07043 0.07043
Dagfinn Ilmari Mannsåker [Wed, 13 May 2015 16:33:00 +0000]
Release 0.07043

9 years agoAdd tests for disabled constraints and triggers for Oracle
Dagfinn Ilmari Mannsåker [Wed, 13 May 2015 13:15:29 +0000]
Add tests for disabled constraints and triggers for Oracle

Also use the existing deferrability check to skip disabled foreign
keys even if DBD::Oracle returns them.

9 years agoFilter out disabled constraints and triggers for Oracle (GH#5)
Philipp Gortan [Wed, 14 Jan 2015 09:57:53 +0000]
Filter out disabled constraints and triggers for Oracle (GH#5)

9 years agoUse the actual md5sum of the old version when deciding whether to overwrite
Dagfinn Ilmari Mannsåker [Fri, 8 May 2015 17:20:41 +0000]
Use the actual md5sum of the old version when deciding whether to overwrite

Otherwise overwrite_modifications => 1 won't work if the generated
content has been modified but the schema hasn't changed (so the md5sum
in the marker matches the newly-generated one).

9 years agoEnsure schema files are generated as binary files on Windows
Christian Walde [Tue, 5 May 2015 01:34:47 +0000]
Ensure schema files are generated as binary files on Windows

Otherwise they'll be generated with \r newlines in them, which breaks
checksumming and portability of schemas to other OSes.

9 years ago(travis) Fix short-circuiting logic
Dagfinn Ilmari Mannsåker [Tue, 28 Apr 2015 12:16:41 +0000]
(travis) Fix short-circuiting logic

9 years ago(travis) Remove workarounds for fixed issues
Dagfinn Ilmari Mannsåker [Tue, 28 Apr 2015 00:01:36 +0000]
(travis) Remove workarounds for fixed issues

9 years ago(travis) Exclude the DQ-based DBIC 0.089xx
Dagfinn Ilmari Mannsåker [Tue, 28 Apr 2015 00:01:09 +0000]
(travis) Exclude the DQ-based DBIC 0.089xx

9 years agoRemove MySQL year(2) test
Dagfinn Ilmari Mannsåker [Tue, 28 Apr 2015 16:54:03 +0000]
Remove MySQL year(2) test

The year(2) type is deprecated, and as of version 5.6 the size
specification is ignored.

9 years agoAdd option to allow extra columns in many_to_many link tables
Dagfinn Ilmari Mannsåker [Sat, 25 Apr 2015 17:02:30 +0000]
Add option to allow extra columns in many_to_many link tables

The primary key must still equal the union of the foreign keys.

9 years agoRevert "Install DBIC dev rel under CLEANTEST="false""
Dagfinn Ilmari Mannsåker [Mon, 27 Apr 2015 11:25:39 +0000]
Revert "Install DBIC dev rel under CLEANTEST="false""

The hard-coded dev release no longer exists on CPAN, and a fixed version
has been released ages ago.

This reverts commit 3ad4cddb255b56e472a038dcab759ae3ef6bcbf9.

9 years agoSimplify array_eq function
Dagfinn Ilmari Mannsåker [Sat, 25 Apr 2015 17:01:03 +0000]
Simplify array_eq function

It's only ever used for names and has "eq" in the name, so there's no
need to try and be clever about things that look like numbers.

9 years ago(travis) Update package list before installing stuff
Dagfinn Ilmari Mannsåker [Thu, 2 Apr 2015 09:55:13 +0000]
(travis) Update package list before installing stuff

9 years agoUse {List,Sub}::Util instead of List::MoreUtils and Sub::Name
Dagfinn Ilmari Mannsåker [Tue, 27 Jan 2015 19:03:29 +0000]
Use {List,Sub}::Util instead of List::MoreUtils and Sub::Name

That means bumping the dependency on List::Util to 1.33, which means
people on perl < 5.20 will have to upgrade anyway, so we might as well
use Sub::Util (added in 1.40) instead of Sub::Name as well.

Nick the apply, firstidx and uniq functions from List::MoreUtils::PP
into DBIx::Class::Schema::Loader::Utils to avoid depending on it.

9 years agoFix DB2 foreign-key introspection
Dagfinn Ilmari Mannsåker [Tue, 27 Jan 2015 13:24:56 +0000]
Fix DB2 foreign-key introspection

The join to the referenced key columns was only using the constraint
name, which is not necessarily unique.  Also use the referenced table
schema and name.

9 years agoFix skip count when DB2 extra schema creation fails
Dagfinn Ilmari Mannsåker [Mon, 26 Jan 2015 14:48:14 +0000]
Fix skip count when DB2 extra schema creation fails

5975bbe6 updated the extra test count, but not the skip count

9 years agoFix circular relationship diagnostics
Dagfinn Ilmari Mannsåker [Wed, 21 Jan 2015 19:15:48 +0000]
Fix circular relationship diagnostics

9 years agoRun Travis tests on 5.20 and threaded 5.18 as well
Dagfinn Ilmari Mannsåker [Wed, 21 Jan 2015 15:33:30 +0000]
Run Travis tests on 5.20 and threaded 5.18 as well

9 years agoInstall and test DB2 in Travis
Dagfinn Ilmari Mannsåker [Mon, 19 Jan 2015 18:38:52 +0000]
Install and test DB2 in Travis

Test Oracle, DB2 and Firebird separately, since the Travis VM doesn't
have enough memory for all of them

9 years agoInclude nanoseconds in timestamps
Dagfinn Ilmari Mannsåker [Tue, 20 Jan 2015 14:24:54 +0000]
Include nanoseconds in timestamps

9 years agoNick Travis script improvements from DBIC
Dagfinn Ilmari Mannsåker [Tue, 20 Jan 2015 13:46:48 +0000]
Nick Travis script improvements from DBIC

9 years agoUpdate Firebird ODBC driver version
Dagfinn Ilmari Mannsåker [Mon, 19 Jan 2015 19:20:52 +0000]
Update Firebird ODBC driver version

9 years agoShow relationship info on circular rel failure
Dagfinn Ilmari Mannsåker [Wed, 21 Jan 2015 14:21:48 +0000]
Show relationship info on circular rel failure

I've seen this fail with bogus SQL on DB2 on Travis, but can't
reproduce it. Let's at least get some info if it happens again.

9 years agoShut up uninitialized warnings from ->table_info on DB2
Dagfinn Ilmari Mannsåker [Wed, 21 Jan 2015 13:54:35 +0000]
Shut up uninitialized warnings from ->table_info on DB2

9 years agoEnable soft_commit with DBD::Firebird as well
Dagfinn Ilmari Mannsåker [Mon, 19 Jan 2015 20:31:12 +0000]
Enable soft_commit with DBD::Firebird as well

It was accidentally only enabled for DBD::InterBase in 4fb2971c.

9 years agoDocument how to add perltidy markers via filter_generated_code
Olaf Alders [Fri, 19 Dec 2014 17:09:56 +0000]
Document how to add perltidy markers via filter_generated_code

9 years agoUse consistent 4-space indentation in lib/
Dagfinn Ilmari Mannsåker [Sat, 3 Jan 2015 16:52:39 +0000]
Use consistent 4-space indentation in lib/

9 years agoEliminate tabs in lib/
Dagfinn Ilmari Mannsåker [Sat, 3 Jan 2015 15:49:15 +0000]
Eliminate tabs in lib/

10 years agoFix MySQL non-InnoDB test skip counts
Dagfinn Ilmari Mannsåker [Mon, 20 Oct 2014 11:34:21 +0000]
Fix MySQL non-InnoDB test skip counts

10 years agoFix many_to_many bridges with overlapping foreign keys
Dagfinn Ilmari Mannsåker [Fri, 17 Oct 2014 15:37:22 +0000]
Fix many_to_many bridges with overlapping foreign keys

10 years agoAdd missed Changes header for 0.07042
Dagfinn Ilmari Mannsåker [Fri, 17 Oct 2014 15:38:38 +0000]
Add missed Changes header for 0.07042

10 years agoFix broken POD links found by App::PodLinkChecker
Dagfinn Ilmari Mannsåker [Mon, 22 Sep 2014 16:32:46 +0000]
Fix broken POD links found by App::PodLinkChecker

10 years agoEliminate POD-containing heredoc
Dagfinn Ilmari Mannsåker [Tue, 26 Aug 2014 18:38:51 +0000]
Eliminate POD-containing heredoc

The POD was being picked up by POD parsers, and showed up as a
spurious "BASE CLASS: $base_class" heading.

10 years agoRelease 0.07042 0.07042
Dagfinn Ilmari Mannsåker [Tue, 19 Aug 2014 23:21:49 +0000]
Release 0.07042

10 years agoFix Changes typo
Dagfinn Ilmari Mannsåker [Tue, 19 Aug 2014 18:28:21 +0000]
Fix Changes typo

10 years agoUse tempdir() to create temporary directories for testing
Dagfinn Ilmari Mannsåker [Tue, 19 Aug 2014 17:33:48 +0000]
Use tempdir() to create temporary directories for testing

This is the first step towards being able to run tests i parallel.

10 years agoUse undef instead of '%' fore the table and type arguments to $dbh->tables
Dagfinn Ilmari Mannsåker [Tue, 19 Aug 2014 17:31:03 +0000]
Use undef instead of '%' fore the table and type arguments to $dbh->tables

Neither the DBI documentation nor the ODBC specification allow '%' for
the type, but some DBDs do (or did, DBD::Pg 3.4.0 no longer does)
allow it. For the ones that didn't, the loader subclass used override
->_tables_list to pass undef explicitly.

Instead, use undef in the default implementation, but allow subclasses
to override as needed (none currently do).

Also change the table argument to default to undef, since that's
equivalent according to the spec and all the DBDs I've tested with or
looked at (SQLite, MySQL, Pg, Oracle, FireBird, ODBC, InterBase).

10 years agoFix unescaped left braces in regexes in tests
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 19:30:49 +0000]
Fix unescaped left braces in regexes in tests

They cause deprecation warnings in perl 5.21.x.

10 years agoRelease 0.07041 0.07041
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 14:02:35 +0000]
Release 0.07041

10 years agoDocument test failure fix with the upcoming DBIC 0.082800
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 14:02:03 +0000]
Document test failure fix with the upcoming DBIC 0.082800

10 years agoDon't ship dotfiles
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 13:54:13 +0000]
Don't ship dotfiles

(e.g. .travis.yml and .mailmap)

10 years agoAdd Changes entry about Travis smoking
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 13:49:05 +0000]
Add Changes entry about Travis smoking

10 years agoAdd --verify to PERL_CPANM_OPT to catch corrupt tarballs
Dagfinn Ilmari Mannsåker [Wed, 6 Aug 2014 16:06:33 +0000]
Add --verify to PERL_CPANM_OPT to catch corrupt tarballs

<@ribasushi> ilmari: experiment with mirrors
<@ribasushi> the metacpan proxy of the download part (why?!) is
             sometimes giving back shortened tarballs, which happen to
             extract fine
<@ribasushi> but the source is in fact fucked

10 years agoInstall Math::BigInt, 5.8.x ship a too old one
Dagfinn Ilmari Mannsåker [Wed, 6 Aug 2014 13:49:50 +0000]
Install Math::BigInt, 5.8.x ship a too old one

10 years agoAllow 5.8.3 runs to fail
Dagfinn Ilmari Mannsåker [Wed, 6 Aug 2014 16:09:12 +0000]
Allow 5.8.3 runs to fail

Several upstream deps are flaky, and nobody has the tuits to fix them.

10 years agoTest with more perl versions
Dagfinn Ilmari Mannsåker [Tue, 5 Aug 2014 16:29:13 +0000]
Test with more perl versions

10 years agoInstall DBIC dev rel under CLEANTEST="false"
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 15:09:31 +0000]
Install DBIC dev rel under CLEANTEST="false"

The stable one has a broken Storage::DBI::ODBC::Firebird (missing
true value).

10 years agoRemove pointless disconnect after static ->load
Dagfinn Ilmari Mannsåker [Tue, 5 Aug 2014 14:44:53 +0000]
Remove pointless disconnect after static ->load

It was added on the assumption that in static mode nothing else was
going to happen after the loading was done, but that's really none of
our concern, so we shouldn't interfere with it.

It also broke the in-transaction dump test with DBIC's new stricter
connectedness checking on txn ops (dbsrgits/dbix-class@d4702d53).

10 years agoAdjust skip_rels count again
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 14:01:26 +0000]
Adjust skip_rels count again

10 years agoFix many_to_many bridges going back to the same table
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 13:04:08 +0000]
Fix many_to_many bridges going back to the same table

The loop only looked at the moniker name, not the key columns, so
would pick a random one. The tests didn't cover the actual self-m2m
bridge at all, so this only got noticed by the Oracle loader being
unstable in which one it picked and triggering the no-rewrite test.

Also clean up the other m2m rel tests and group them correctly.