Nicholas Clark [Sat, 13 May 2006 12:57:50 +0000]
Only ask about MAD for 5.9.0 and greater. Otherwise silently select
'n'.
p4raw-id: //depot/perl@28188
Jarkko Hietaniemi [Sat, 13 May 2006 11:27:56 +0000]
t/uni/overload.t
Message-ID: <
4465988C.9080407@gmail.com>
Date: Sat, 13 May 2006 11:27:56 +0300
p4raw-id: //depot/perl@28187
Jarkko Hietaniemi [Sat, 13 May 2006 10:15:32 +0000]
sv.c: printf %d wants int not size_t
Message-Id: <
200605130715.k4D7FWg3089581@kosh.hut.fi>
Date: Sat, 13 May 2006 10:15:32 +0300 (EEST)
p4raw-id: //depot/perl@28186
Nicholas Clark [Sat, 13 May 2006 10:36:18 +0000]
Can't do require Foo if $tainted; because taint tunnels.
(Documented, but I regard this as a serious practical deficiency in
tainting)
p4raw-id: //depot/perl@28185
Jarkko Hietaniemi [Fri, 12 May 2006 22:28:49 +0000]
Re: [PATCH] my_snprintf
Message-ID: <
4464E1F1.9010706@gmail.com>
p4raw-id: //depot/perl@28183
Peter Dintelmann [Fri, 5 May 2006 13:20:24 +0000]
AW: question on "len item/string item" with unpack()
From: "Dintelmann, Peter" <Peter.Dintelmann@Dresdner-Bank.com>
Message-ID: <
E9A2605289D8D7468B1A21EC24E59D2104979424@naimucx5.muc.allianz>
p4raw-id: //depot/perl@28181
Andy Lester [Fri, 12 May 2006 00:21:23 +0000]
upgrade bytes_to_uni
Message-ID: <
20060512052123.GA21648@petdance.com>
p4raw-id: //depot/perl@28180
Andy Lester [Tue, 9 May 2006 12:27:30 +0000]
Proper use of static funcs in toke.c and pp_sys.c
Message-ID: <
20060509172730.GA5272@petdance.com>
p4raw-id: //depot/perl@28179
Nicholas Clark [Fri, 12 May 2006 14:08:45 +0000]
The upgrade/croak order in Perl_sv_utf8_encode() seemed utterly
backwards. It now checks for readonly *first*.
p4raw-id: //depot/perl@28178
Rafael Garcia-Suarez [Fri, 12 May 2006 13:09:29 +0000]
Upgrade to Tie::RefHash 1.34, by Yuval Kogman
p4raw-id: //depot/perl@28177
Andy Lester [Thu, 11 May 2006 22:41:01 +0000]
Speed up utf8.c a bit
Message-ID: <
20060512034101.GA10709@petdance.com>
p4raw-id: //depot/perl@28176
Andy Lester [Thu, 11 May 2006 21:54:10 +0000]
Fixing embed.fnc
Message-ID: <
20060512025410.GA32709@petdance.com>
p4raw-id: //depot/perl@28175
Nicholas Clark [Fri, 12 May 2006 11:47:40 +0000]
Threads and signals. Delicious. Tweak change 28168 to add a local
signal handler in the sleeping thread, because some operating systems
deliver the SIGINT to that thread rather than the signalling thread.
p4raw-id: //depot/perl@28174
Jerry D. Hedden [Thu, 11 May 2006 11:50:15 +0000]
Better unsafe signals info in threads.pm
From: "Jerry D. Hedden" <jerry@hedden.us>
Message-ID: <
20060511115015.fb30e530d17747c2b054d625b8945d88.8b4855700b.wbe@email.secureserver.net>
p4raw-id: //depot/perl@28173
Nicholas Clark [Fri, 12 May 2006 09:47:29 +0000]
Fix concise-xs.t following the changes to B::Deparse.
p4raw-id: //depot/perl@28172
Nicholas Clark [Thu, 11 May 2006 21:44:06 +0000]
Tk spots that S_glob_2pv might be called from *_nolen, so we need to
check that len is non-NULL before assigning to it.
p4raw-id: //depot/perl@28171
Jerry D. Hedden [Thu, 11 May 2006 08:55:39 +0000]
Thread signalling [REVISED]
From: "Jerry D. Hedden" <jerry@hedden.us>
Message-ID: <
20060511085539.fb30e530d17747c2b054d625b8945d88.a90037f085.wbe@email.secureserver.net>
p4raw-id: //depot/perl@28168
Rafael Garcia-Suarez [Thu, 11 May 2006 16:06:06 +0000]
Deparse state variables.
p4raw-id: //depot/perl@28166
Steve Peters [Thu, 11 May 2006 00:09:53 +0000]
Adding a mention of STDIN processing by qx// as requested by
RT #34288: perlop: qx/STRING/: mention STDIN
p4raw-id: //depot/perl@28156
Steve Peters [Wed, 10 May 2006 23:02:20 +0000]
Add -fno-delete-null-pointer-checks to ccflags on Itaniums when
compiling with gcc's 3.2, 3.3, or 3.4. This fixes RT #37156.
p4raw-id: //depot/perl@28155
Steve Peters [Wed, 10 May 2006 15:03:03 +0000]
Upgrade to Encode-2.17
p4raw-id: //depot/perl@28152
Nicholas Clark [Wed, 10 May 2006 14:08:43 +0000]
no 5.9.4; should fail in version 5.9.4.
Improve the diagnostics and test names in t/comp/use.t
p4raw-id: //depot/perl@28150
Nicholas Clark [Wed, 10 May 2006 13:08:49 +0000]
Convert use.t to an inlined is/isnt/like implementation, to give better
diagnostics.
p4raw-id: //depot/perl@28149
Dave Mitchell [Wed, 10 May 2006 01:32:10 +0000]
disable WARN and DIE hooks during constant folding
p4raw-id: //depot/perl@28148
Nicholas Clark [Tue, 9 May 2006 21:42:18 +0000]
Change 28145 means that Perl_allocmy() can take a const char *name.
p4raw-id: //depot/perl@28146
Nicholas Clark [Tue, 9 May 2006 20:42:03 +0000]
Simplify the non-printable name error reporting code in Perl_allocmy().
p4raw-id: //depot/perl@28145
Nicholas Clark [Tue, 9 May 2006 20:10:12 +0000]
In Perl_Gv_AMupdate(), there's no need to call sv_unmagic() if we know
the magic isn't there.
p4raw-id: //depot/perl@28144
Nicholas Clark [Tue, 9 May 2006 19:31:04 +0000]
Gv_AMupdate() always creates magic, so mg can never be NULL.
p4raw-id: //depot/perl@28143
Nicholas Clark [Tue, 9 May 2006 16:35:25 +0000]
Two signed array indicies that Coverity spots should be unsigned.
p4raw-id: //depot/perl@28142
Nicholas Clark [Tue, 9 May 2006 16:04:25 +0000]
Ressurect change 27824, which plugs a resource leak in uncalled code.
p4raw-id: //depot/perl@28141
Vadim Konovalov [Tue, 9 May 2006 15:09:43 +0000]
wince crosscompile patch for 28132
Message-ID: <
44607877.90603@vkonovalov.ru>
p4raw-id: //depot/perl@28140
Rafael Garcia-Suarez [Tue, 9 May 2006 14:03:30 +0000]
POD fixes
p4raw-id: //depot/perl@28139
David Landgren [Tue, 9 May 2006 13:03:22 +0000]
Re: [PATCH] ext/IPC/SysV/t/ipcsysv.t using test.pl
Message-ID: <
446076FA.6010409@landgren.net>
p4raw-id: //depot/perl@28138
Rafael Garcia-Suarez [Tue, 9 May 2006 13:18:34 +0000]
Fix another Coverity problem by adding an assert that says that
some string we got from the lexer is null-terminated
p4raw-id: //depot/perl@28137
Rafael Garcia-Suarez [Tue, 9 May 2006 13:10:01 +0000]
Fix a logic error in conditional found by Coverity
p4raw-id: //depot/perl@28136
Dave Mitchell [Tue, 9 May 2006 11:43:55 +0000]
allow exit during fold_constants
eg BEGIN { $SIG{__WARN__} = sub{exit};} "a" == "b"
p4raw-id: //depot/perl@28135
Jerry D. Hedden [Mon, 8 May 2006 10:23:33 +0000]
'threads' patch to fix threaded build on Win32
From: "Jerry D. Hedden" <jerry@hedden.us>
Message-ID: <
20060508102333.fb30e530d17747c2b054d625b8945d88.1e447744fc.wbe@email.secureserver.net>
p4raw-id: //depot/perl@28134
Ash Berlin [Sat, 6 May 2006 14:16:00 +0000]
perlop.pod doc patch: I/O operators
Message-ID: <
445CA190.1070105@cpan.org>
p4raw-id: //depot/perl@28133
Jarkko Hietaniemi [Sat, 6 May 2006 11:21:02 +0000]
PERL_MEM_LOG enhancements
Message-ID: <
445C5C6E.6070201@gmail.com>
p4raw-id: //depot/perl@28132
David Landgren [Fri, 5 May 2006 17:03:39 +0000]
[PATCH] ext/IPC/SysV/t/ipcsysv.t using test.pl
Message-ID: <
445B694B.8060901@landgren.net>
Date: Fri, 05 May 2006 17:03:39 +0200
Subject: Re: [PATCH] ext/IPC/SysV/t/sem.t using test.pl
From: David Landgren <david@landgren.net>
Message-ID: <
445B75EF.3000100@landgren.net>
Date: Fri, 05 May 2006 17:57:35 +0200
p4raw-id: //depot/perl@28131
Steve Peters [Mon, 8 May 2006 19:01:56 +0000]
Rename lib/Text/Balanced/t/00.load.t to
lib/Text/Balanced/t/00-load.t and restore a test to
lib/Text/Balanced/t/extmul.t.
p4raw-id: //depot/perl@28127
Steve Peters [Mon, 8 May 2006 18:46:16 +0000]
Version bump and typo fix from change #28125.
p4raw-link: @28125 on //depot/perl:
eb67bf7e7c7791f145451e273b36c197fb24fcb9
p4raw-id: //depot/perl@28126
Steve Peters [Mon, 8 May 2006 18:37:47 +0000]
Rollback two changes in Text::Balanced which cause test failures in the
CPAN and bleadperl version of the tests. Also, the previous bleadperl
version of one test file is a bit more comprehensive than what was in
CPAN, so it has been completely restored.
p4raw-id: //depot/perl@28125
Steve Peters [Mon, 8 May 2006 16:47:39 +0000]
Upgrade to Digest-SHA-5.36. Actually bumped to 5.36_01 as
change #27352 has not yet been applied to the CPAN version.
p4raw-link: @27352 on //depot/perl:
1d49bf1b4cd8e1b3baa93d02705fe7df545e316f
p4raw-id: //depot/perl@28122
Nicholas Clark [Mon, 8 May 2006 11:23:15 +0000]
Tie::RefHash is now dual life, maintained by Yuval Kogman.
p4raw-id: //depot/perl@28118
H.Merijn Brand [Sun, 7 May 2006 14:18:45 +0000]
Remvove code that gets undone in the next line.
Keep the documentation part.
p4raw-id: //depot/perl@28116
Steve Peters [Fri, 5 May 2006 16:26:48 +0000]
These Module::Build tests depended on STDIN. Unfortunately, cron
closes STDIN, so these build failures were only seen while
running smokes through cron.
p4raw-id: //depot/perl@28108
Rafael Garcia-Suarez [Fri, 5 May 2006 12:48:19 +0000]
Implement state array and state hashes. Initialisation assignment
to state arrays or hashes is not implemented yet.
p4raw-id: //depot/perl@28106
Steve Peters [Fri, 5 May 2006 12:40:41 +0000]
Upgrade to Text-Balanced-1.98
p4raw-id: //depot/perl@28105
Jerry D. Hedden [Thu, 4 May 2006 10:07:58 +0000]
threads - stack size support
From: "Jerry D. Hedden" <jerry@hedden.us>
Message-ID: <
20060504100758.fb30e530d17747c2b054d625b8945d88.1ee893a99c.wbe@email.secureserver.net>
p4raw-id: //depot/perl@28104
Steve Peters [Fri, 5 May 2006 01:26:08 +0000]
Teach checkAUTHORS.pl about Sarathy's new email address.
p4raw-id: //depot/perl@28103
Jan Dubois [Thu, 4 May 2006 15:28:19 +0000]
Email address changes
From: "Jan Dubois" <jand@activestate.com>
Message-ID: <
007101c66fca$0b651a50$2217a8c0@candy>
p4raw-id: //depot/perl@28102
Steve Peters [Thu, 4 May 2006 20:03:42 +0000]
Upgrade to ExtUtils-Install-1.40
p4raw-id: //depot/perl@28101
Vadim Konovalov [Thu, 4 May 2006 17:32:12 +0000]
RE: [PATCH-for-28089] wince yet another step
From: "Konovalov, Vadim Vladimirovich (Vadim)** CTR **" <vkonovalov@Lucent.com>
Message-ID: <
E3FB32585BF1D411B9E900805FF51A0801BCB454@ru0022exch001u.ru.lucent.com>
p4raw-id: //depot/perl@28100
Jerry D. Hedden [Wed, 3 May 2006 12:34:34 +0000]
threads - formatting [REVISED]
From: "Jerry D. Hedden" <jerry@hedden.us>
Message-ID: <
20060503123433.fb30e530d17747c2b054d625b8945d88.d352e5da51.wbe@email.secureserver.net>
p4raw-id: //depot/perl@28099
Rafael Garcia-Suarez [Thu, 4 May 2006 12:06:33 +0000]
Upgrade to Encode 2.16
p4raw-id: //depot/perl@28098
Rafael Garcia-Suarez [Thu, 4 May 2006 11:32:05 +0000]
Resubmit change #28095
p4raw-link: @28095 on //depot/perl:
a86fbd4f9d493275993c0370a0246611dbcffc30
p4raw-id: //depot/perl@28097
Vadim Konovalov [Thu, 4 May 2006 13:04:45 +0000]
wince yet another step
From: "Konovalov, Vadim Vladimirovich (Vadim)** CTR **" <vkonovalov@Lucent.com>
Message-ID: <
E3FB32585BF1D411B9E900805FF51A0801BCB1EE@ru0022exch001u.ru.lucent.com>
p4raw-id: //depot/perl@28096
David Landgren [Wed, 3 May 2006 15:53:38 +0000]
t/op/grep.t using test.pl
Message-ID: <
4458B5E2.7090103@landgren.net>
p4raw-id: //depot/perl@28095
David Landgren [Wed, 3 May 2006 16:20:40 +0000]
t/op/context.t using test.pl
Message-ID: <
4458BC38.6050600@landgren.net>
p4raw-id: //depot/perl@28094
David Landgren [Wed, 3 May 2006 19:40:40 +0000]
t/op/list.t using test.pl
Message-ID: <
4458EB18.8070904@landgren.net>
p4raw-id: //depot/perl@28093
Paul Johnson [Wed, 26 Apr 2006 22:38:43 +0000]
Document order of evaluation for the comma operator
Subject: [PATCH] Re: Kill select((select(OUTPUT_HANDLE), $| = 1)[0]);
Message-ID: <
20060426203843.GE21543@pjcj.net>
p4raw-id: //depot/perl@28092
Jan Dubois [Wed, 3 May 2006 12:41:23 +0000]
RE: [PATCH] Implement ${^WIN32_SLOPPY_STAT}
From: "Jan Dubois" <jand@activestate.com>
Message-ID: <
013f01c66ee9$8f1437a0$d045a8c0@candy>
p4raw-id: //depot/perl@28091
Rafael Garcia-Suarez [Thu, 4 May 2006 07:42:27 +0000]
Another test for state variables and closures,
adapted from a Perl 6 example, pointed out by
Joshua "Limbic_Region" Gatcomb
p4raw-id: //depot/perl@28090
Rafael Garcia-Suarez [Wed, 3 May 2006 22:49:14 +0000]
Ensure that C<(state $x) = $y> is not a state assignment
(due to the parentheses that make it a regular assignment
to a variable declared inside a list)
p4raw-id: //depot/perl@28089
Rafael Garcia-Suarez [Wed, 3 May 2006 22:40:28 +0000]
New test case for state variables with ties, suggested by Nicholas
p4raw-id: //depot/perl@28088
Rafael Garcia-Suarez [Wed, 3 May 2006 22:01:41 +0000]
Add "state" feature
p4raw-id: //depot/perl@28087
Rafael Garcia-Suarez [Wed, 3 May 2006 21:46:02 +0000]
Introduce a new keyword, state, for state variables.
p4raw-id: //depot/perl@28086
Vadim Konovalov [Wed, 3 May 2006 20:11:11 +0000]
wince another step
From: "Konovalov, Vadim Vladimirovich (Vadim)** CTR **"
Message-ID: <
E3FB32585BF1D411B9E900805FF51A0801BCAE1F@ru0022exch001u.ru.lucent.com>
p4raw-id: //depot/perl@28085
Jan Dubois [Wed, 3 May 2006 11:30:03 +0000]
Clarify hard link support on Windows
From: "Jan Dubois" <jand@activestate.com>
Message-ID: <
013a01c66edf$982ebcc0$d045a8c0@candy>
p4raw-id: //depot/perl@28084
Jan Dubois [Wed, 3 May 2006 11:18:30 +0000]
RE: [PATCH] Implement ${^WIN32_SLOPPY_STAT}
From: "Jan Dubois" <jand@activestate.com>
Message-ID: <
013901c66edd$fb8ae750$d045a8c0@candy>
p4raw-id: //depot/perl@28083
Steve Peters [Wed, 3 May 2006 17:56:37 +0000]
Upgrade to CGI-3.20
p4raw-id: //depot/perl@28082
Andy Lester [Tue, 11 Apr 2006 14:14:45 +0000]
more logic localizations
Message-ID: <
20060411191445.GA4938@petdance.com>
p4raw-id: //depot/perl@28081
Sébastien Aperghis-Tramoni [Tue, 2 May 2006 01:37:03 +0000]
-Dmad breaks a few tests
Message-Id: <
64F8ECEA-D96B-11DA-AA80-000502F3279F@free.fr>
(part of, with tweaks)
p4raw-id: //depot/perl@28080
Andy Lester [Wed, 3 May 2006 00:54:30 +0000]
Remove an unnecessary goto
Message-ID: <
20060503055430.GA4922@petdance.com>
p4raw-id: //depot/perl@28079
Andy Lester [Tue, 2 May 2006 21:09:08 +0000]
optimize S_find_array_subscript
Message-ID: <
20060503020908.GA2234@petdance.com>
p4raw-id: //depot/perl@28078
Andy Lester [Tue, 2 May 2006 13:38:15 +0000]
clean up loops in doio.c and dump.c
Message-ID: <
20060502183815.GA7979@petdance.com>
p4raw-id: //depot/perl@28077
Jarkko Hietaniemi [Tue, 2 May 2006 20:04:33 +0000]
pp_sys.c: U8* cast
Message-Id: <
200605021704.k42H4XIh255652@kosh.hut.fi>
p4raw-id: //depot/perl@28076
Jarkko Hietaniemi [Tue, 2 May 2006 20:03:01 +0000]
hv.c: do zeroing via mem wrap check
Message-Id: <
200605021703.k42H31PF216868@kosh.hut.fi>
p4raw-id: //depot/perl@28075
Jarkko Hietaniemi [Wed, 3 May 2006 08:20:31 +0000]
microperl update
Message-ID: <
44583D9F.8060401@gmail.com>
p4raw-id: //depot/perl@28074
Steve Hay [Wed, 3 May 2006 08:25:27 +0000]
Make Perl_unshare_hek visible to core extensions without being public
See the comments in:
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2006-04/msg00480.html
(which were put into practice in changes #27800 and #27848)
p4raw-link: @27800 on //depot/perl:
1242dfaee525d4d0ab20ac8ae62b3f0de03fa88e
p4raw-id: //depot/perl@28073
Vadim Konovalov [Wed, 3 May 2006 06:10:59 +0000]
Re: Smoke [5.9.4] 28069 FAIL(M) MSWin32 WinXP/.Net SP2 (x86/2 cpu)
Message-ID: <
44581133.8080100@vkonovalov.ru>
p4raw-id: //depot/perl@28072
SADAHIRO Tomoyuki [Wed, 3 May 2006 10:00:03 +0000]
Re: Smoke [5.9.4] 28069 FAIL(M) MSWin32 WinXP/.Net SP2 (x86/2 cpu)
Message-Id: <
20060503095420.0357.BQW10602@nifty.com>
p4raw-id: //depot/perl@28071
Nicholas Clark [Tue, 2 May 2006 22:38:52 +0000]
Remove a variable left unused since change 28065.
p4raw-id: //depot/perl@28070
Nicholas Clark [Tue, 2 May 2006 22:19:56 +0000]
Add a new hash key flag HVhek_UNSHARED, to mark all unshared hash keys.
Otherwise Perl_newSVhek(), called by Perl_hv_iterkeysv(), naively
assumes that it can share any hash key directly.
p4raw-id: //depot/perl@28069
Nicholas Clark [Tue, 2 May 2006 22:16:25 +0000]
cumulative totals and list reverse for checkAUTHORS.pl
p4raw-id: //depot/perl@28068
Steve Peters [Tue, 2 May 2006 18:03:57 +0000]
Another place where Intel C++ pretending to be gcc is a really
bad thing.
p4raw-id: //depot/perl@28067
Nicholas Clark [Tue, 2 May 2006 17:46:38 +0000]
*static* pointers to newXSUB(), dammit!
p4raw-id: //depot/perl@28066
Nicholas Clark [Tue, 2 May 2006 17:00:56 +0000]
Assert that SvMAGIC() isn't being called on PVMGs which are using the
same union to store the stash for our.
p4raw-id: //depot/perl@28065
Nicholas Clark [Tue, 2 May 2006 16:24:14 +0000]
Change 28063 forgot 1 key line - acutally use the correct filename
storage.
p4raw-id: //depot/perl@28064
Nicholas Clark [Tue, 2 May 2006 15:55:25 +0000]
Fix bug in DynaLoader, which has been passing a filename in dynamic
storage to newXS() seemingly forever. This involves creating
newXS_flags(), with the first flag being "arrange to copy the
filename and free it at the right time".
p4raw-id: //depot/perl@28063
Vadim Konovalov [Tue, 2 May 2006 17:30:59 +0000]
Move some scripts under win32/ce-helpers.
Subject: RE: Merge WinCE into Win32 directory and remove the the WinCE dir ectory
From: "Konovalov, Vadim Vladimirovich (Vadim)** CTR **" <vkonovalov@Lucent.com>
Message-ID: <
E3FB32585BF1D411B9E900805FF51A0801BB3F03@ru0022exch001u.ru.lucent.com>
p4raw-id: //depot/perl@28062
Yves Orton [Mon, 1 May 2006 19:02:09 +0000]
Re: Merge WinCE into Win32 directory and remove the the WinCE directory
Message-ID: <
9b18b3110605011002m56c0db99n169ae677efb6d059@mail.gmail.com>
Plus adjustements to MANIFEST. Also, perlmain.c seemed to be missing
from the patch.
p4raw-id: //depot/perl@28061
Nicholas Clark [Tue, 2 May 2006 12:41:43 +0000]
GvFILE() cannot be a pointer to the memory owned by the COP, because
COPs created by use can be freed along this memory, but the GP
remains. Given that several GVs may refer to the same file, use a
shared string rather than an individual allocation per GP.
p4raw-id: //depot/perl@28060
Nicholas Clark [Tue, 2 May 2006 12:02:32 +0000]
Change 28037 broke t/op/each.t when running with TEST.
p4raw-id: //depot/perl@28059
Nicholas Clark [Tue, 2 May 2006 11:15:26 +0000]
De-duplicate the code that creates new GPs into Perl_newGP().
p4raw-id: //depot/perl@28058
David Landgren [Sat, 29 Apr 2006 15:32:07 +0000]
Re: [PATCH] t/op/glob.t using test.pl
Message-ID: <
44536AD7.4060608@landgren.net>
p4raw-id: //depot/perl@28057
David Landgren [Sat, 29 Apr 2006 17:51:28 +0000]
t/op/hashwarn.t using test.pl
Message-ID: <
44538B80.2060503@landgren.net>
p4raw-id: //depot/perl@28056
Jarkko Hietaniemi [Tue, 2 May 2006 08:25:55 +0000]
toke.c: function pointer to data pointer
Message-Id: <
200605020525.k425Ptik165705@kosh.hut.fi>
p4raw-id: //depot/perl@28055
Xavier Noria [Tue, 2 May 2006 12:08:34 +0000]
[DOC PATCH] chop warning in perlport
Message-Id: <
E06C0594-CAF6-4822-8EB4-8E06EAD4A889@hashref.com>
p4raw-id: //depot/perl@28054