15 years agoSkip threaded debugger tests unless $Config{usethreads}
Duke Leto [Sun, 14 Jun 2009 19:06:55 +0000]
Skip threaded debugger tests unless $Config{usethreads}

15 years agoAdd a test for a thread-enabled debugger
Duke Leto [Sun, 7 Jun 2009 16:50:38 +0000]
Add a test for a thread-enabled debugger

15 years agoFix my comment about DB::sub and make it DB::DB
Duke Leto [Thu, 4 Jun 2009 23:11:42 +0000]
Fix my comment about DB::sub and make it DB::DB

15 years agoBump version of perl5db.pl to 1.33, add changelog comments and fix a POD typo
Duke Leto [Thu, 4 Jun 2009 08:22:46 +0000]
Bump version of perl5db.pl to 1.33, add changelog comments and fix a POD typo

15 years agoMerge branch 'debugger_symbols' of github.com:leto/perl into debugger_symbols
Duke Leto [Thu, 4 Jun 2009 06:33:24 +0000]
Merge branch 'debugger_symbols' of github.com:leto/perl into debugger_symbols

15 years agoAdd lib/perl5db/t/symbol-table-bug to the MANIFEST
Duke Leto [Wed, 3 Jun 2009 20:29:14 +0000]
Add lib/perl5db/t/symbol-table-bug to the MANIFEST

15 years agoFix shebang line and permissions of lib/perl5db.t
Duke Leto [Wed, 3 Jun 2009 19:28:08 +0000]
Fix shebang line and permissions of lib/perl5db.t

15 years agoAdd the debugger script which tests for undefs in the symbol table
Duke Leto [Wed, 3 Jun 2009 19:02:50 +0000]
Add the debugger script which tests for undefs in the symbol table

15 years agoFix bug introduced in 67924fd which put the key _< with an undefined value in the...
Duke Leto [Wed, 3 Jun 2009 18:40:35 +0000]
Fix bug introduced in 67924fd which put the key _< with an undefined value in the symbol table

This patch makes sure that $filename is defined before setting the _<$filename symbol. It also
adds a test which makes sure that *no* symbols have undefined values after loading perl5db.pl .

15 years agoadd more EXCLUDED and MAP keys to Maintainers.pl
David Mitchell [Wed, 3 Jun 2009 00:42:20 +0000]
add more EXCLUDED and MAP keys to Maintainers.pl

15 years agoUpdate CPANPLUS::Dist::Build to CPAN version 0.32
Chris Williams [Mon, 1 Jun 2009 22:28:45 +0000]
Update CPANPLUS::Dist::Build to CPAN version 0.32

15 years agoparenthesize check for a flag
Stepan Kasal [Tue, 2 Jun 2009 14:20:27 +0000]
parenthesize check for a flag

Hello,
  gcc warned me about a suspicious combination of ! and &
Please consinder the following one-line patch.

Stepan Kasal

From 4b449da2aedf3b40b8f6dfa4c410d9becb33330a Mon Sep 17 00:00:00 2001
From: Stepan Kasal <skasal@redhat.com>
Date: Tue, 2 Jun 2009 16:06:10 +0200
Subject: [PATCH] dump.c: parenthesize flag check

Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

15 years agoDisentangling -g and -DDEBUGGING is a TODO.
Nicholas Clark [Tue, 2 Jun 2009 12:53:19 +0000]
Disentangling -g and -DDEBUGGING is a TODO.

15 years agoIn Perl_hv_iternext_flags(), clarify and generalise the empty hash bailout code.
Nicholas Clark [Tue, 2 Jun 2009 10:36:35 +0000]
In Perl_hv_iternext_flags(), clarify and generalise the empty hash bailout code.

15 years agoAdjust MANIFEST
Rafael Garcia-Suarez [Tue, 2 Jun 2009 06:51:22 +0000]
Adjust MANIFEST

15 years agoMerge branch 'smartmatch' into blead
Rafael Garcia-Suarez [Tue, 2 Jun 2009 06:47:54 +0000]
Merge branch 'smartmatch' into blead

15 years agoMerge branch 'eumm652' into blead
Rafael Garcia-Suarez [Tue, 2 Jun 2009 06:46:41 +0000]
Merge branch 'eumm652' into blead

15 years agostop git whining about trailing whitespace (picky picky..)
David Mitchell [Tue, 2 Jun 2009 00:13:51 +0000]
stop git whining about trailing whitespace (picky picky..)

15 years agostart adding new EXCLUDED and MAP entries to Maintainers.pl.
David Mitchell [Tue, 2 Jun 2009 00:10:01 +0000]
start adding new EXCLUDED and MAP entries to Maintainers.pl.

15 years agoresync some files with their CPAN equivalents (just the trivial errors for
David Mitchell [Tue, 2 Jun 2009 00:08:19 +0000]
resync some files with their CPAN equivalents (just the trivial errors for
now, like whitespace)

15 years agoAdd benchmark test for keys() on empty hashes (RT26188)
Max Maischein [Mon, 1 Jun 2009 12:18:42 +0000]
Add benchmark test for keys() on empty hashes (RT26188)

15 years agoFix RT26188, speed up keys() on empty hash
Max Maischein [Sun, 31 May 2009 21:50:12 +0000]
Fix RT26188, speed up keys() on empty hash

15 years agoCorrect test output for t/op/eval.t (missing newline)
Jerry D. Hedden [Mon, 1 Jun 2009 14:09:24 +0000]
Correct test output for t/op/eval.t (missing newline)

15 years agoProtect against spaces in build directory name when extracting .PL files
Andy Dougherty [Mon, 1 Jun 2009 16:34:36 +0000]
Protect against spaces in build directory name when extracting .PL files

15 years agoMore ~~ tests
Rafael Garcia-Suarez [Mon, 1 Jun 2009 15:32:56 +0000]
More ~~ tests

Also, add a plan to those tests, for extra safety

15 years agoSmart-match perldelta adjustments
Rafael Garcia-Suarez [Mon, 1 Jun 2009 15:16:40 +0000]
Smart-match perldelta adjustments

15 years agoMinor doc fix for the smart table legend (clarify the "Object" entry).
Rafael Garcia-Suarez [Mon, 1 Jun 2009 14:46:42 +0000]
Minor doc fix for the smart table legend (clarify the "Object" entry).

15 years agoAdd test boilerplate to the new MakeMaker tests
Rafael Garcia-Suarez [Mon, 1 Jun 2009 13:52:31 +0000]
Add test boilerplate to the new MakeMaker tests

15 years agoUpgrade to ExtUtils::MakeMaker 6.52
Rafael Garcia-Suarez [Mon, 1 Jun 2009 13:44:14 +0000]
Upgrade to ExtUtils::MakeMaker 6.52

15 years agoMention Devel::NYTProf in perldebug
Steffen Mueller [Sun, 31 May 2009 20:02:33 +0000]
Mention Devel::NYTProf in perldebug

In the short section about profiling with Devel::DProf, we now mention
that other profilers (such as Devel::NYTProf) are available from CPAN.

15 years agoAuto-complete lexicals in the debugger shell
Steffen Mueller [Sun, 31 May 2009 19:57:24 +0000]
Auto-complete lexicals in the debugger shell

When typing the name of a lexical variable in the debugger shell, its
name can now be tab auto-completed just like package variables. Requires
PadWalker to be available. Silently skips lexicals if it's not.

15 years agoFix casting warning
Rafael Garcia-Suarez [Sun, 31 May 2009 20:08:41 +0000]
Fix casting warning

(that was introduced by 9ef5ed94af)

15 years agowrap some long FILES fields in Maintainers.pl
David Mitchell [Sun, 31 May 2009 19:39:33 +0000]
wrap some long FILES fields in Maintainers.pl
(just whitepsace/newline changes)
Basic philosophy is now: if it all fits on one ( < 80 char) line, fine;
otherwise have only one entry per line

15 years agofix Math::BigInt, PathTools entries in Maintainers.pl
David Mitchell [Sun, 31 May 2009 19:22:55 +0000]
fix Math::BigInt, PathTools entries in Maintainers.pl
(botched by 002904c4e2f6cd5caebddf970e6be562946af502)

15 years agoconvert Maintainers.pl from an 8 to a 4 char indent
David Mitchell [Sun, 31 May 2009 19:00:54 +0000]
convert Maintainers.pl from an 8 to a 4 char indent
(to give more room for extra field I'm going to add)

15 years agoClarify the meaning of the %Modules keys in Maintainers.pl,
David Mitchell [Sun, 31 May 2009 18:19:58 +0000]
Clarify the meaning of the %Modules keys in Maintainers.pl,
and fix a couple of keys that don't correspond to an actual module name
that you can 'use'.

15 years agoadd DISTRIBUTION field to %Modules in Maintainers.pl
David Mitchell [Sun, 31 May 2009 18:00:23 +0000]
add DISTRIBUTION field to %Modules in Maintainers.pl
(note that in this initial attempt, the file version numbers are derived
from the newest verions currently available on CPAN, which may not actually
reflect what's bundled with blead. Later on, I'll be fixing this.)

15 years agoMaintainers.pl: rationalise distributions:
David Mitchell [Sun, 31 May 2009 13:43:56 +0000]
Maintainers.pl: rationalise distributions:
    Cwd and File::Spec are both part of PathTools, and
    Math::BigFloat is part of Math-BigInt

15 years agoMaintainers.pl: there is no DB::File, and describe Text::Tabs/Wrap better
David Mitchell [Sun, 31 May 2009 13:17:26 +0000]
Maintainers.pl: there is no DB::File, and describe Text::Tabs/Wrap better

15 years agoClarify perldebug documentation
Bram [Sun, 31 May 2009 15:20:45 +0000]
Clarify perldebug documentation

Mention what happens without Readline support.

15 years agoSilence a warning emitted by test added by last commit
Rafael Garcia-Suarez [Sun, 31 May 2009 14:30:59 +0000]
Silence a warning emitted by test added by last commit

15 years agoAdd test case from RT#54758.
George Greer [Wed, 27 May 2009 01:05:40 +0000]
Add test case from RT#54758.

15 years agoMerge branch 'memleaktest' into blead
Rafael Garcia-Suarez [Sun, 31 May 2009 13:11:40 +0000]
Merge branch 'memleaktest' into blead

15 years agoAdd regression test for [RT#63110]
Rafael Garcia-Suarez [Sun, 31 May 2009 13:09:56 +0000]
Add regression test for [RT#63110]

This is based on a stand-alone test by Bram

15 years agoDocument test structure
Bram [Sun, 31 May 2009 12:47:49 +0000]
Document test structure

(was Re: [perl #56194] Regex: (((??{1 + $^N}))) behaves differently in
5.10.0 than in blead)
Adds some basic documentation about the test structure.

15 years agoFix Filter::Simple entry in Maintainers.pl
David Mitchell [Sat, 30 May 2009 16:17:45 +0000]
Fix Filter::Simple entry in Maintainers.pl

15 years agoNicholas says that SvREFCNT_dec should be sufficient here
Rafael Garcia-Suarez [Sat, 30 May 2009 14:40:03 +0000]
Nicholas says that SvREFCNT_dec should be sufficient here

(instead of marking the SV as mortal.)

15 years agoFix [RT#6266] -- sv_pos_u2b expects to be called with a valid character index
Alex Vandiver [Fri, 29 May 2009 20:21:22 +0000]
Fix [RT#6266] -- sv_pos_u2b expects to be called with a valid character index

sv_pos_u2b, when utf8 position caching is enabled, treats the uoffset
it is given as real, storing it away for lature use.  sprintf, here,
passes the byte length of the string, which causes an invalid offset
to be cached.

15 years agoFix [RT#63110] -- two small memory leaks were introduced in 5b9c067
Alex Vandiver [Sat, 30 May 2009 00:17:36 +0000]
Fix [RT#63110] -- two small memory leaks were introduced in 5b9c067

15 years agoBump version of IPC::Open3
Rafael Garcia-Suarez [Sat, 30 May 2009 13:12:44 +0000]
Bump version of IPC::Open3

15 years agoclarified documentation about using lexical $err in open3 call
Slaven Rezic [Fri, 29 May 2009 16:05:43 +0000]
clarified documentation about using lexical $err in open3 call

15 years agoSpelling nit
Steffen Mueller [Thu, 28 May 2009 18:16:23 +0000]
Spelling nit

15 years agoDocument the PERL_LOADMOD_ flags
Rafael Garcia-Suarez [Fri, 29 May 2009 22:07:40 +0000]
Document the PERL_LOADMOD_ flags

15 years agoFix [RT#66098] -- stricter checking on SvIVX exposed a lack of SvIOK check
Alex Vandiver [Thu, 28 May 2009 20:27:25 +0000]
Fix [RT#66098] -- stricter checking on SvIVX exposed a lack of SvIOK check

15 years agoAdd a guide to writing a perldelta.
Nicholas Clark [Thu, 28 May 2009 13:15:53 +0000]
Add a guide to writing a perldelta.

15 years agoMerge branch 'blead' of camel:/gitroot/perl into blead
Rafael Garcia-Suarez [Wed, 27 May 2009 08:47:22 +0000]
Merge branch 'blead' of camel:/gitroot/perl into blead

15 years agoCatch interdependencies for static builds too
Andy Dougherty [Tue, 26 May 2009 18:18:27 +0000]
Catch interdependencies for static builds too

15 years agoMerge branch 'blead' of camel:/gitroot/perl into blead
Rafael Garcia-Suarez [Tue, 26 May 2009 16:26:40 +0000]
Merge branch 'blead' of camel:/gitroot/perl into blead

15 years agoMore tests for uninitialized warnings in ranges
Vincent Pit [Tue, 26 May 2009 16:09:15 +0000]
More tests for uninitialized warnings in ranges

15 years agoMerge branch 'blead' of camel:/gitroot/perl into blead
Rafael Garcia-Suarez [Tue, 26 May 2009 15:41:43 +0000]
Merge branch 'blead' of camel:/gitroot/perl into blead

15 years agoExplicitely point to $. when it causes an uninitialized warning for ranges in scalar...
Vincent Pit [Tue, 26 May 2009 14:56:39 +0000]
Explicitely point to $. when it causes an uninitialized warning for ranges in scalar context

15 years agoA couple of nits in the ~~ perldelta entry
Rafael Garcia-Suarez [Tue, 26 May 2009 12:57:22 +0000]
A couple of nits in the ~~ perldelta entry

(Thanks to Ricardo)

15 years agoFile tests were already treated as boolean in when()
Rafael Garcia-Suarez [Tue, 26 May 2009 12:00:35 +0000]
File tests were already treated as boolean in when()

It was just not documented in 5.10.0. So no need to mention this
as new in perldelta.

15 years agopatch@2009-05-25.21:50:08 magic.t leaves $ENV{foo} on VMS.
John E. Malmberg [Tue, 26 May 2009 04:12:28 +0000]
patch@2009-05-25.21:50:08 magic.t leaves $ENV{foo} on VMS.

This patches Magic.t to remove the $ENV{foo} it created on VMS.

This environment variable interferes with running other tests including
CPAN tests.

-John
wb8tyw@qsl.net
Personal Opinion Only

Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

15 years agopatch@2009-05-25.21:50:08 perl5db.t leaves db.out behind on VMS
John E. Malmberg [Tue, 26 May 2009 04:26:26 +0000]
patch@2009-05-25.21:50:08 perl5db.t leaves db.out behind on VMS

This patch fixes lib/perl5db.t to not leave a db.out file behind on VMS
after a test run.

-John
wb8tyw@qsl.net
Personal Opinion Only

Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

15 years agopatch@2009-05-25.21:50:08 text-options.t file cleanup on VMS
John E. Malmberg [Tue, 26 May 2009 04:47:34 +0000]
patch@2009-05-25.21:50:08 text-options.t file cleanup on VMS

This patch fixes lib/Pod/text-options.t to not leave tmp.pod and out.tmp
files behind on VMS.

-John
wb8tyw@qsl.net
Personal Opinion Only

Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

15 years agoDescribe smart match and switch changes in perldelta
Rafael Garcia-Suarez [Mon, 25 May 2009 21:48:57 +0000]
Describe smart match and switch changes in perldelta

15 years agoRemove now-obsolete note on ~~ overloading working only on the right.
Rafael Garcia-Suarez [Mon, 25 May 2009 21:09:33 +0000]
Remove now-obsolete note on ~~ overloading working only on the right.

15 years agoDon't run mro/* tests under miniperl
Rafael Garcia-Suarez [Mon, 25 May 2009 10:51:50 +0000]
Don't run mro/* tests under miniperl

15 years agoSkip tests that use attributes.pm under miniperl
Rafael Garcia-Suarez [Mon, 25 May 2009 10:39:27 +0000]
Skip tests that use attributes.pm under miniperl

15 years agoFix test if Fcntl couldn't be loaded (for example with miniperl)
Rafael Garcia-Suarez [Mon, 25 May 2009 10:22:16 +0000]
Fix test if Fcntl couldn't be loaded (for example with miniperl)

15 years agoSkip under miniperl (cannot load Fcntl)
Rafael Garcia-Suarez [Mon, 25 May 2009 10:15:09 +0000]
Skip under miniperl (cannot load Fcntl)

15 years agoSkip tests if PerlIO::scalar is not available
Rafael Garcia-Suarez [Mon, 25 May 2009 09:59:03 +0000]
Skip tests if PerlIO::scalar is not available

15 years agoAvoid using Test::More in given/when tests
Rafael Garcia-Suarez [Mon, 25 May 2009 09:23:08 +0000]
Avoid using Test::More in given/when tests

15 years agoRevert "Fix failing autodie test with new smartmatch semantics."
Rafael Garcia-Suarez [Mon, 25 May 2009 05:54:04 +0000]
Revert "Fix failing autodie test with new smartmatch semantics."

This should now work, since we now allow objects with ~~-overloading
on the left side of ~~.

This reverts commit 7fecd077a7bc92add80772966a8c824277223d09.

15 years agoUpdate CPAN.pm to 1.94
Andreas J Koenig [Sun, 24 May 2009 19:57:49 +0000]
Update CPAN.pm to 1.94

15 years agoFix test for overload in given() with smart match after last change
Rafael Garcia-Suarez [Sun, 24 May 2009 22:22:25 +0000]
Fix test for overload in given() with smart match after last change

15 years agoAllow ~~ overloading on the left side, when the right side is a plain scalar
Rafael Garcia-Suarez [Sun, 24 May 2009 21:51:42 +0000]
Allow ~~ overloading on the left side, when the right side is a plain scalar

15 years agoChange the specs of %h~~%h to avoid mentioning ~~ recursively
Rafael Garcia-Suarez [Sun, 24 May 2009 15:31:15 +0000]
Change the specs of %h~~%h to avoid mentioning ~~ recursively

15 years agoIn the ~~ implementation, consistently use the SV-aware API for hash keys.
Rafael Garcia-Suarez [Sun, 24 May 2009 15:19:11 +0000]
In the ~~ implementation, consistently use the SV-aware API for hash keys.

This way, we can handle tied hashes such as ones that have references as keys.

15 years agoIgnore vim swap files
Vincent Pit [Sun, 24 May 2009 12:19:37 +0000]
Ignore vim swap files

15 years agoRemove vim swap file
Rafael Garcia-Suarez [Sun, 24 May 2009 11:31:29 +0000]
Remove vim swap file

15 years agoperlpodspec corrections
Ricardo SIGNES [Sun, 24 May 2009 08:11:26 +0000]
perlpodspec corrections

15 years agoMove the code to add magic to $0 into Perl_gv_fetchpvn_flags().
Nicholas Clark [Sat, 23 May 2009 10:08:47 +0000]
Move the code to add magic to $0 into Perl_gv_fetchpvn_flags().

Curiously, this appears to always have been implemented slightly inefficiently.
It dates from perl 4.000, which added the functionality to make assigning to $0
set the process name. The equivalent fix for 4.000 is:

--- a/perl.c
+++ b/perl.c
@@ -738,7 +738,7 @@ FIX YOUR KERNEL, PUT A C WRAPPER AROUND THIS SCRIPT, OR USE -u AND UNDUMP!\n");
  (void)hadd(sigstab);
     }

-    magicalize("!#?^~=-%.+&*()<>,\\/[|`':\004\t\020\024\027\006");
+    magicalize("!#?^~=-%.+&*()<>,\\/[|`':0\004\t\020\024\027\006");
     userinit(); /* in case linked C routines want magical variables */

     amperstab = stabent("&",allstabs);
@@ -828,7 +828,6 @@ FIX YOUR KERNEL, PUT A C WRAPPER AROUND THIS SCRIPT, OR USE -u AND UNDUMP!\n");
 #endif
     if (tmpstab = stabent("0",allstabs)) {
  str_set(stab_val(tmpstab),origfilename);
- magicname("0", Nullch, 0);
     }
     if (tmpstab = stabent("\030",allstabs))
  str_set(stab_val(tmpstab),origargv[0]);

15 years agoTODO must be on same line as message for TAP.
Craig A. Berry [Fri, 22 May 2009 16:37:00 +0000]
TODO must be on same line as message for TAP.

Follow-up to b2978f4e665fcbbc23bf7f986d2650556cfec504

15 years agoIn Perl_magic_setsig(), silence a "possible loss of data" warning.
Nicholas Clark [Fri, 22 May 2009 09:11:33 +0000]
In Perl_magic_setsig(), silence a "possible loss of data" warning.

15 years agoSmoke failing on longdouble
Rich Rauenzahn [Thu, 21 May 2009 21:03:37 +0000]
Smoke failing on longdouble

Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

15 years ago$? needs upgrade to PVLV when COMPLEX_STATUS is defined.
Craig A. Berry [Thu, 21 May 2009 17:07:26 +0000]
$? needs upgrade to PVLV when COMPLEX_STATUS is defined.

15 years agoMerge Perl_magic_setisa() and Perl_magic_clearisa(), to remove duplicated logic.
Nicholas Clark [Thu, 21 May 2009 15:24:37 +0000]
Merge Perl_magic_setisa() and Perl_magic_clearisa(), to remove duplicated logic.

15 years agoIn Perl_magic_setisa(), re-order two independant return early checks.
Nicholas Clark [Thu, 21 May 2009 14:45:50 +0000]
In Perl_magic_setisa(), re-order two independant return early checks.

15 years agoRemove all the 5005threads specific mutex macros, which are now vestigial.
Nicholas Clark [Thu, 21 May 2009 08:55:37 +0000]
Remove all the 5005threads specific mutex macros, which are now vestigial.

15 years agoUse only one block of memory for both PL_psig_name and PL_psig_ptr.
Nicholas Clark [Thu, 21 May 2009 07:02:38 +0000]
Use only one block of memory for both PL_psig_name and PL_psig_ptr.

15 years agoCache the signal number or -1 in mg_private, to reduce calls to Perl_whichsig().
Nicholas Clark [Thu, 21 May 2009 06:08:53 +0000]
Cache the signal number or -1 in mg_private, to reduce calls to Perl_whichsig().
It doesn't matter that 0 isn't cacheable, as the logic in Perl_magic_setsig()
is such that we already can't "set" $SIG{ZERO}. Without this we make thousands
of failing calls to Perl_whichsig() from Perl_magic_getsig() for "__WARN__".

15 years agoPerl_mg_clear() did not cope with the called magic deleting itself - fix this.
Nicholas Clark [Wed, 20 May 2009 22:02:07 +0000]
Perl_mg_clear() did not cope with the called magic deleting itself - fix this.

Should all routines that iterate over the magic chain be hardened against this?

15 years agorun dos2unix on lib/Parse/CPAN/Meta.pm
David Mitchell [Wed, 20 May 2009 21:57:52 +0000]
run dos2unix on lib/Parse/CPAN/Meta.pm
(for some reaon de044c3605bd12a0b679b024ec9c16b44093c54b added ^M's)

15 years agoAdd new files from Parse::CPAN::Meta 1.38 to the MANIFEST.
Nicholas Clark [Wed, 20 May 2009 21:49:03 +0000]
Add new files from Parse::CPAN::Meta 1.38 to the MANIFEST.

15 years agoIn Perl_magic_setsig(), don't discard and then recreate the signal name SV.
Nicholas Clark [Wed, 20 May 2009 21:33:30 +0000]
In Perl_magic_setsig(), don't discard and then recreate the signal name SV.

15 years agoRefactor Perl_magic_setsig() to remove duplication in the function exit logic.
Nicholas Clark [Wed, 20 May 2009 20:53:31 +0000]
Refactor Perl_magic_setsig() to remove duplication in the function exit logic.

(With a lot of re-indenting, which vanishes with a whitespace ignoring diff)

15 years agoMerge the bulk of Perl_magic_clearsig() into Perl_magic_setsig().
Nicholas Clark [Wed, 20 May 2009 19:52:58 +0000]
Merge the bulk of Perl_magic_clearsig() into Perl_magic_setsig().

The comment at the top of Perl_magic_clearsig() said:
    XXX Some of this code was copied from Perl_magic_setsig. A little
    refactoring might be in order.
and it was not wrong.

Perl_magic_clearsig() is almost equivalent to Perl_magic_setsig() with the new
signal handler as "DEFAULT". Externally, the sv parameter to Perl_magic_setsig()
was Not NULL, so use a NULL sv to signal that the code is being called as
Perl_magic_clearsig(), for the places where the behaviour of the two diverges.

15 years agoPerl_magic_clearsig() needs to remove magic, else delete $SIG{INT} returns undef
Nicholas Clark [Wed, 20 May 2009 14:17:19 +0000]
Perl_magic_clearsig() needs to remove magic, else delete $SIG{INT} returns undef
instead of the now-removed INT handler.