16 years agoAdd CheckVersionsMatch step
Dave Rolsky [Thu, 25 Sep 2008 03:09:48 +0000]
Add CheckVersionsMatch step

16 years agoOops, this is Moose::Exporter, not MooseX
Dave Rolsky [Thu, 25 Sep 2008 02:21:57 +0000]
Oops, this is Moose::Exporter, not MooseX

16 years agosynopsis tweak
Todd Hepler [Wed, 24 Sep 2008 21:01:41 +0000]
synopsis tweak
(I'm pretty sure you need a ->meta there)

16 years agoFix handling of anon subtype with both constraint & message
Dave Rolsky [Mon, 22 Sep 2008 15:14:38 +0000]
Fix handling of anon subtype with both constraint & message

16 years agoRemove a bunch of hard tabs
Dave Rolsky [Mon, 22 Sep 2008 15:05:03 +0000]
Remove a bunch of hard tabs

16 years agoFirst, fix confess() so it actually exists. I don't know how
Dave Rolsky [Mon, 22 Sep 2008 15:02:40 +0000]
First, fix confess() so it actually exists. I don't know how
nothingmuch planned to implement switchign between throw_error() and
confess() here though.

16 years agoMake sure that metaclass incompat fixing doesn't touch base object class setting.
Dave Rolsky [Sat, 20 Sep 2008 14:52:12 +0000]
Make sure that metaclass incompat fixing doesn't touch base object class setting.

16 years agoupdate manifest 0.58
Dave Rolsky [Sat, 20 Sep 2008 14:33:10 +0000]
update manifest

16 years agoBe defensive against being called for a Moose::Meta::Role (which can
Dave Rolsky [Sat, 20 Sep 2008 14:30:29 +0000]
Be defensive against being called for a Moose::Meta::Role (which can
happen if we apply a trait to a role).

16 years agoTweak throw_error changes description
Dave Rolsky [Thu, 18 Sep 2008 20:19:04 +0000]
Tweak throw_error changes description

16 years agochangelog error_class
Yuval Kogman [Thu, 18 Sep 2008 16:37:56 +0000]
changelog error_class

16 years agoMore !!
Dave Rolsky [Thu, 18 Sep 2008 15:08:03 +0000]
More !!

16 years agoDocument error_class attribute.
Dave Rolsky [Thu, 18 Sep 2008 15:06:57 +0000]
Document error_class attribute.

Tweaked the metaclass reconciliation bits to account for error_class.

16 years agoAdd some MetaRole related tests for error_class. Added a test plan.
Dave Rolsky [Thu, 18 Sep 2008 15:06:30 +0000]
Add some MetaRole related tests for error_class. Added a test plan.

16 years agoDocument latest bug fix
Dave Rolsky [Thu, 18 Sep 2008 15:05:46 +0000]
Document latest bug fix

16 years agoFixed a bug where an explicitly set constructor or destructor (and now
Dave Rolsky [Thu, 18 Sep 2008 15:05:00 +0000]
Fixed a bug where an explicitly set constructor or destructor (and now
error) class would be lost if roles were applied to other metaclasses,
but not said class.

16 years agoforgot to update MANIFEST on last commit
Todd Hepler [Wed, 17 Sep 2008 15:32:54 +0000]
forgot to update MANIFEST on last commit

16 years agocheck for a valid attribute name in Moose::Meta::Role
Todd Hepler [Tue, 16 Sep 2008 22:20:58 +0000]
check for a valid attribute name in Moose::Meta::Role
added testcase for odd has() calls
squashed a warning exposed by that test in Moose::Meta::Class

16 years agoThis need to subclass Class::MOP::Method::Generated too
Dave Rolsky [Tue, 16 Sep 2008 19:05:54 +0000]
This need to subclass Class::MOP::Method::Generated too

16 years agoRun this through tidy
Dave Rolsky [Tue, 16 Sep 2008 18:44:34 +0000]
Run this through tidy

16 years agoNo need for default to be a sub when it just returns a string.
Dave Rolsky [Tue, 16 Sep 2008 18:44:05 +0000]
No need for default to be a sub when it just returns a string.

16 years agoInclude tidying.
Dave Rolsky [Tue, 16 Sep 2008 18:42:40 +0000]
Include tidying.

Load Carp

16 years agoNeed to load the error class or tests fail
Dave Rolsky [Tue, 16 Sep 2008 18:41:04 +0000]
Need to load the error class or tests fail

16 years agoadd strict & warnings, tidy
Dave Rolsky [Tue, 16 Sep 2008 18:40:01 +0000]
add strict & warnings, tidy

16 years agoremove old comment
Yuval Kogman [Tue, 16 Sep 2008 18:11:33 +0000]
remove old comment

16 years agotest last_error
Yuval Kogman [Tue, 16 Sep 2008 18:07:55 +0000]
test last_error

16 years agorename 'error' error parameter to 'last_error'
Yuval Kogman [Tue, 16 Sep 2008 18:07:42 +0000]
rename 'error' error parameter to 'last_error'

16 years agoerror_class is now the one true way
Yuval Kogman [Tue, 16 Sep 2008 17:56:51 +0000]
error_class is now the one true way

16 years agoAdd docs on how metaclass incompat is resolved
Dave Rolsky [Tue, 16 Sep 2008 14:01:26 +0000]
Add docs on how metaclass incompat is resolved

16 years agoBold the method name
Dave Rolsky [Tue, 16 Sep 2008 13:45:40 +0000]
Bold the method name

16 years agoNo need to fix metaclass incompat here, it'll be fixed when
Dave Rolsky [Tue, 16 Sep 2008 13:42:35 +0000]
No need to fix metaclass incompat here, it'll be fixed when
superclasses is called.

16 years agoupdate manifest
Dave Rolsky [Tue, 16 Sep 2008 13:40:06 +0000]
update manifest

16 years agoerror tests and fixes
Yuval Kogman [Tue, 16 Sep 2008 13:27:00 +0000]
error tests and fixes

16 years agoerror tests and fixes
Yuval Kogman [Tue, 16 Sep 2008 13:26:06 +0000]
error tests and fixes

16 years agoAdd note about conflict list
Dave Rolsky [Mon, 15 Sep 2008 20:19:05 +0000]
Add note about conflict list

16 years agoRestructure the logic here a bit
Dave Rolsky [Mon, 15 Sep 2008 20:16:52 +0000]
Restructure the logic here a bit

16 years agoRequire the next MOP
Dave Rolsky [Mon, 15 Sep 2008 17:09:14 +0000]
Require the next MOP

16 years agoAdd conflict detection for modules we know break with this release of
Dave Rolsky [Mon, 15 Sep 2008 17:07:54 +0000]
Add conflict detection for modules we know break with this release of
Moose.

16 years agoBump version for next release (soonish, I hope0
Dave Rolsky [Mon, 15 Sep 2008 16:58:27 +0000]
Bump version for next release (soonish, I hope0

16 years agoupdate manifest post-merge
Dave Rolsky [Mon, 15 Sep 2008 15:45:27 +0000]
update manifest post-merge

16 years agoChanges indentation fixup
Dave Rolsky [Mon, 15 Sep 2008 15:45:11 +0000]
Changes indentation fixup

16 years agomerge method-changes branch into trunk
Dave Rolsky [Mon, 15 Sep 2008 15:41:45 +0000]
merge method-changes branch into trunk

16 years agoMove the generation of delegation methods into MM::Method::Delegation itself.
Dave Rolsky [Mon, 15 Sep 2008 15:40:16 +0000]
Move the generation of delegation methods into MM::Method::Delegation itself.

16 years agoSmall tweaks and add jnapiorkowski's name to all his changes
Dave Rolsky [Mon, 15 Sep 2008 14:12:47 +0000]
Small tweaks and add jnapiorkowski's name to all his changes

16 years agoupdated the changelog
John Napiorkowski [Mon, 15 Sep 2008 14:09:20 +0000]
updated the changelog

16 years agomerge trunk to method-changes branch
Dave Rolsky [Mon, 15 Sep 2008 13:32:49 +0000]
merge trunk to method-changes branch

16 years agoMerge jnapiorkowski's parameterize_constructor_role branch, which
Dave Rolsky [Mon, 15 Sep 2008 13:30:53 +0000]
Merge jnapiorkowski's parameterize_constructor_role branch, which
makes it easier to build a library for structured types.

16 years agoFix docs for parameterize
Dave Rolsky [Sun, 14 Sep 2008 21:59:11 +0000]
Fix docs for parameterize

16 years agoThere's no need ot expose Parameterizable's ->parse_type_constraint
Dave Rolsky [Sun, 14 Sep 2008 21:56:49 +0000]
There's no need ot expose Parameterizable's ->parse_type_constraint
method as a public method, since it was used once, and it's return
value was passed right back into said module.

16 years agoAdd a missing space.
Dave Rolsky [Sun, 14 Sep 2008 21:51:53 +0000]
Add a missing space.

16 years agoFix method name in docs
Dave Rolsky [Sun, 14 Sep 2008 21:50:21 +0000]
Fix method name in docs

16 years agoEven more code tidying
Dave Rolsky [Sun, 14 Sep 2008 21:48:33 +0000]
Even more code tidying

16 years agoMore code tidying
Dave Rolsky [Sun, 14 Sep 2008 21:47:25 +0000]
More code tidying

16 years agoYes, I know it's a string, that's why we're parsing it ;)
Dave Rolsky [Sun, 14 Sep 2008 21:46:04 +0000]
Yes, I know it's a string, that's why we're parsing it ;)

16 years agoI'm going to take away jnapiorkowski's tab key!
Dave Rolsky [Sun, 14 Sep 2008 21:42:40 +0000]
I'm going to take away jnapiorkowski's tab key!

16 years agoTidy some funky code.
Dave Rolsky [Sun, 14 Sep 2008 21:40:35 +0000]
Tidy some funky code.

16 years agoMerge Moose trunk to parameterize_constructor_role branch
Dave Rolsky [Sun, 14 Sep 2008 21:37:56 +0000]
Merge Moose trunk to parameterize_constructor_role branch

16 years agoDoc check_metaclass_compatibility
Dave Rolsky [Sun, 14 Sep 2008 21:21:42 +0000]
Doc check_metaclass_compatibility

16 years agosuperclasses expects an array, not a reference.
Dave Rolsky [Sun, 14 Sep 2008 21:20:23 +0000]
superclasses expects an array, not a reference.

16 years agoWeaken anon class metaclasses after updating them in the CMOP cache.
Dave Rolsky [Sun, 14 Sep 2008 21:11:32 +0000]
Weaken anon class metaclasses after updating them in the CMOP cache.

16 years agoSimply fix metaclass incompat before we check if it is compat.
Dave Rolsky [Sun, 14 Sep 2008 21:04:16 +0000]
Simply fix metaclass incompat before we check if it is compat.

This fixes various weird edge cases where a metaclass object is
created and is not compat with the parent's metaclass. In particular,
this fixes the case where a class applied traits to its metaclass, and
some other class subclasses it via "use base" and not extends.

16 years agochanged made sure I properly delegate parsing the type constraint parameter string...
John Napiorkowski [Sun, 14 Sep 2008 05:32:43 +0000]
changed made sure I properly delegate parsing the type constraint parameter string to the actual type constraint, instead of try to shove everything into the utils package

16 years agoAdd description for metaclass incompat changes.
Dave Rolsky [Sun, 14 Sep 2008 02:58:49 +0000]
Add description for metaclass incompat changes.

16 years agoThese tests pass now
Dave Rolsky [Sun, 14 Sep 2008 02:57:06 +0000]
These tests pass now

16 years agoAdd comment on my voodoo line which makes all my tests pass
Dave Rolsky [Sun, 14 Sep 2008 02:56:06 +0000]
Add comment on my voodoo line which makes all my tests pass

16 years agoThere's no need for _fix_metaclass_compatibility to return anything,
Dave Rolsky [Sun, 14 Sep 2008 02:48:21 +0000]
There's no need for _fix_metaclass_compatibility to return anything,
it can just alter the reference in place.

16 years agoTest that the metaclass role we apply for My::Class10 is actually applied
Dave Rolsky [Sun, 14 Sep 2008 02:41:57 +0000]
Test that the metaclass role we apply for My::Class10 is actually applied

16 years agoFix typo in test description
Dave Rolsky [Sun, 14 Sep 2008 02:17:54 +0000]
Fix typo in test description

16 years agoMore metaclass compatibility handling.
Dave Rolsky [Sat, 13 Sep 2008 04:16:34 +0000]
More metaclass compatibility handling.

When creating a new class, fix its metaclass compatibility as well as
when extends is called. This means that classes created via
Moose::Util::MetaRole (aka new metaclasses) have their metaclass
compatibility fixed. Sounds crazy, but it basically lets combine
modules which give the caller a new metaclass (like Fey::ORM::Table)
and modules which then apply roles to the caller's metaclass (like
MX::ClassAttribute).

And hey, there's tests.

16 years agoFix the spelling of compatibility in here too.
Dave Rolsky [Sat, 13 Sep 2008 03:26:23 +0000]
Fix the spelling of compatibility in here too.

16 years agoOops, left in a conflict marker
Dave Rolsky [Sat, 13 Sep 2008 02:40:48 +0000]
Oops, left in a conflict marker

16 years agomerge trunk to method-changes branch
Dave Rolsky [Sat, 13 Sep 2008 02:38:16 +0000]
merge trunk to method-changes branch

16 years agoOn further examination, this test is bogus. If you subclass a Moose
Dave Rolsky [Fri, 12 Sep 2008 22:39:20 +0000]
On further examination, this test is bogus. If you subclass a Moose
class via "use base" and not "extends", you don't get to complain that
Moose finds a metaclass incompatibility. When you call "extends" Moose
explicitly fixes said incompatibility.

16 years agoThe super-duper fix metaclass update.
Dave Rolsky [Fri, 12 Sep 2008 22:36:04 +0000]
The super-duper fix metaclass update.

Basically, this implements the whole "if two classes differ by roles,
reconcile the roles" algorithm.

Along the way, this also fixes some bugs in
_fix_metaclass_compatibility, where it could lose things like roles on
a metaclass's attribute metaclass if the parent class's metaclass was
a subclass of said metaclass (ugh, this is hard to talk about).

16 years agoadded a method to normalize incoming type constraint names and changed how union...
John Napiorkowski [Fri, 12 Sep 2008 21:26:05 +0000]
added a method to normalize incoming type constraint names and changed how union types are named to match this, updated tests to match

16 years agoMerge 'trunk' into 'parameterize_constructor_role'
John Napiorkowski [Fri, 12 Sep 2008 20:39:06 +0000]
Merge 'trunk' into 'parameterize_constructor_role'

r16946@dev (orig r5826):  sartak | 2008-09-11 01:39:57 -0500
 r71616@onn:  sartak | 2008-09-11 02:39:02 -0400
 Add a failing test for the following construct, which explodes due to metaclass incompatibility:

 package Parent;
 use Moose -traits => ...;
 package Child;
 use base 'Parent';

r16950@dev (orig r5830):  autarch | 2008-09-11 08:48:05 -0500
Skip these tests for now (hopefully this will get fixed in a near-future release)

r17011@dev (orig r5882):  autarch | 2008-09-12 10:33:41 -0500
Do not unimport functions which we explicitly re-export by reference
as-is. This means that Moose _always_ gives you Carp::confess,
Scalar::Util::blessed, etc.
r17012@dev (orig r5883):  autarch | 2008-09-12 10:34:07 -0500
Update changes with credit for latest bug fix

16 years agomore tests to flex type constraint name normalization
John Napiorkowski [Fri, 12 Sep 2008 20:36:33 +0000]
more tests to flex type constraint name normalization

16 years ago- moved the ->parameterize tests to own test suite
John Napiorkowski [Fri, 12 Sep 2008 18:25:32 +0000]
- moved the ->parameterize tests to own test suite
- changed  t/030_roles/017_extending_role_attrs.t to deal with the fact we sort
  union type constraints
- removed ugly hack from ->parameterize to force a tc name
- union types now sort @TC and properly canonicalize their names
- changed the regex parsing for stringed type constraints so that we ignore
  pointless whitespace and have support for upcoming structured types

16 years agoUpdate changes with credit for latest bug fix
Dave Rolsky [Fri, 12 Sep 2008 15:34:07 +0000]
Update changes with credit for latest bug fix

16 years agoDo not unimport functions which we explicitly re-export by reference
Dave Rolsky [Fri, 12 Sep 2008 15:33:41 +0000]
Do not unimport functions which we explicitly re-export by reference
as-is. This means that Moose _always_ gives you Carp::confess,
Scalar::Util::blessed, etc.

16 years agoMake backwards incompatibility clear in changes
Dave Rolsky [Fri, 12 Sep 2008 02:56:26 +0000]
Make backwards incompatibility clear in changes

16 years agoActually implement associated_attribute for delegation methods, and
Dave Rolsky [Thu, 11 Sep 2008 20:39:22 +0000]
Actually implement associated_attribute for delegation methods, and
test it.

Add docs for Moose::Meta::Method::Delegation.

16 years agoUpdate changes for this branch
Dave Rolsky [Thu, 11 Sep 2008 20:36:13 +0000]
Update changes for this branch

16 years agoAdd Moose::Meta::Method::Delegation and use it for delegation methods
Dave Rolsky [Thu, 11 Sep 2008 20:31:36 +0000]
Add Moose::Meta::Method::Delegation and use it for delegation methods

16 years agoNo more alias_method for roles either. This meant more or less copying
Dave Rolsky [Thu, 11 Sep 2008 20:19:12 +0000]
No more alias_method for roles either. This meant more or less copying
the latest changes in CMOP::Class->add_method to Moose::Meta::Role.

Now roles add methods via add_method, which clones method objects as
needed. Added tests for this cloning and making sure we can track the
history of a method through any roles it's been in.

16 years agoOne of our todo methods here now passes, because Moose::Meta::Role::Method isa Moose...
Dave Rolsky [Thu, 11 Sep 2008 19:53:38 +0000]
One of our todo methods here now passes, because Moose::Meta::Role::Method isa Moose::Meta::Method

16 years agoMake docs match reality
Dave Rolsky [Thu, 11 Sep 2008 19:49:44 +0000]
Make docs match reality

16 years agoMake this class subclass Moose::Meta::Method, which keeps things saner.
Dave Rolsky [Thu, 11 Sep 2008 19:49:26 +0000]
Make this class subclass Moose::Meta::Method, which keeps things saner.

16 years agoremoved debugging code, all tests are passing, added method to parse the type paramet...
John Napiorkowski [Thu, 11 Sep 2008 18:02:40 +0000]
removed debugging code, all tests are passing, added method to parse the type parameter string

16 years agofinished parameterized method, tests and converted Moose::Util::TypeConstraints to...
John Napiorkowski [Thu, 11 Sep 2008 16:45:36 +0000]
finished parameterized method, tests and converted Moose::Util::TypeConstraints to use it

16 years agoThis branch will include several changes:
Dave Rolsky [Thu, 11 Sep 2008 16:44:20 +0000]
This branch will include several changes:

* Tracking the source of all methods added from roles (via method cloning)

* Added a Delegation method class for delegated methods

* Finally, changing _fix_metaclass_compatibility to use the source
  tracking to implement the "if metaclasses differ by roles, reconcile
  the roles" algorithm.

16 years agofinished parameterized method, tests and converted Moose::Util::TypeConstraints to...
John Napiorkowski [Thu, 11 Sep 2008 16:40:16 +0000]
finished parameterized method, tests and converted Moose::Util::TypeConstraints to use it

16 years agoSkip these tests for now (hopefully this will get fixed in a near-future release)
Dave Rolsky [Thu, 11 Sep 2008 13:48:05 +0000]
Skip these tests for now (hopefully this will get fixed in a near-future release)

16 years agoAdd a failing test for the following construct, which explodes due to metaclass incom...
Shawn M Moore [Thu, 11 Sep 2008 06:39:57 +0000]
Add a failing test for the following construct, which explodes due to metaclass incompatibility:

package Parent;
use Moose -traits => ...;
package Child;
use base 'Parent';

16 years agofirst go at some test cases and basic implementation
John Napiorkowski [Thu, 11 Sep 2008 03:30:57 +0000]
first go at some test cases and basic implementation

16 years agonew branch to create a more generic constructor for type constraints that accept...
John Napiorkowski [Wed, 10 Sep 2008 19:05:20 +0000]
new branch to create a more generic constructor for type constraints that accept parameters

16 years agoAdd some tests for the error handling in Moose::Object, and fix a bug
Dave Rolsky [Mon, 8 Sep 2008 17:21:13 +0000]
Add some tests for the error handling in Moose::Object, and fix a bug
I found which motivated said tests.

16 years agoAdd a plan and tidied the code a little
Dave Rolsky [Mon, 8 Sep 2008 14:42:05 +0000]
Add a plan and tidied the code a little

16 years agofix errorneous planning (no_plan doesn't take args)
Yuval Kogman [Sun, 7 Sep 2008 23:18:15 +0000]
fix errorneous planning (no_plan doesn't take args)

16 years agofix errorneous planning (no_plan doesn't take args)
Yuval Kogman [Sun, 7 Sep 2008 23:17:35 +0000]
fix errorneous planning (no_plan doesn't take args)