rabbit+bugs@rabbit.us [Mon, 6 Oct 2008 04:19:10 +0000]
[perl #59650] File::Copy does not handle file objects sanely
From: "rabbit+bugs@rabbit.us (via RT)" <perlbug-followup@perl.org>
Message-ID: <rt-3.6.HEAD-29762-
1223291950-1373.59650-75-0@perl.org>
Suggested change modified to cope with the hoop-jumping needed to keep
File::Copy working whilst bootstrapping the core build.
Some tests by me, to try to ensure that (arguablly buggy) IO::Scalar
will still work.
p4raw-id: //depot/perl@34519
Nicholas Clark [Sun, 19 Oct 2008 10:23:11 +0000]
Upgrade PathTools to 3.28_01
p4raw-id: //depot/perl@34514
Nicholas Clark [Sat, 18 Oct 2008 21:20:19 +0000]
Suggestion from Slaven - reverse the part of 23348 that removed the
conditional call to dl_expandspec() on platforms that default
$do_expand to false. autorequire, rightly or wrongly, is relying on
being able to set $do_expand to true.
p4raw-id: //depot/perl@34513
Nicholas Clark [Sat, 18 Oct 2008 19:08:07 +0000]
Update Porting/makemeta to generate a META.yml compliant with the 1.4
spec. (Add a generated_by, and rename private to no_index.)
p4raw-id: //depot/perl@34510
Nicholas Clark [Sat, 18 Oct 2008 19:07:10 +0000]
Re-run Porting/makemeta
p4raw-id: //depot/perl@34509
Nicholas Clark [Sat, 18 Oct 2008 18:43:44 +0000]
MANIFEST update relating to change 34504.
p4raw-id: //depot/perl@34508
Marcus Holland-Moritz [Sat, 18 Oct 2008 18:11:57 +0000]
Fix memory leak in // caused by single-char character class
optimization. This was most probably introduced with #28262.
This change fixes perl #59516.
p4raw-id: //depot/perl@34507
Marcus Holland-Moritz [Sat, 18 Oct 2008 18:04:40 +0000]
Fix memory leak in qr// operator. This was most probably
introduced with #30849.
p4raw-id: //depot/perl@34506
Nicholas Clark [Sat, 18 Oct 2008 17:39:33 +0000]
Damian has transferred Filter::Simple to p5p. Bump its version to 0.83
with the new contact details, and remove the out-of-date README from
core.
p4raw-id: //depot/perl@34505
H.Merijn Brand [Sat, 18 Oct 2008 15:26:02 +0000]
y2038 time checks have overflow checks. Added documentation and
test programs in Porting/
p4raw-id: //depot/perl@34504
Nicholas Clark [Fri, 17 Oct 2008 08:46:28 +0000]
Upgrade to ExtUtils-MakeMaker-6.47_02
p4raw-id: //depot/perl@34498
Nicholas Clark [Thu, 16 Oct 2008 20:18:39 +0000]
Clarify which save types are in mathoms, which aren't used, and which
still are in use.
p4raw-id: //depot/perl@34494
Steve Peters [Wed, 15 Oct 2008 19:07:38 +0000]
Silence a warning in Test::Builder that was causing lib/constant.t
to fail.
p4raw-id: //depot/perl@34491
Steve Peters [Wed, 15 Oct 2008 18:23:56 +0000]
One final tweak for the Test-Simple-0.82 upgrade. Ugh.
p4raw-id: //depot/perl@34490
Steve Peters [Wed, 15 Oct 2008 14:32:01 +0000]
*sigh* More files messed with for Test-Simple-0.82.
p4raw-id: //depot/perl@34488
Jos I. Boumans [Mon, 13 Oct 2008 15:40:22 +0000]
Update Archive::Tar to 1.40
From: "Jos I. Boumans" <jos@dwim.org>
Message-Id: <
D694D518-2404-4476-B578-A5B95F89660A@dwim.org>
...minus the Pod tests that we've been regularly removing.
p4raw-id: //depot/perl@34486
Steve Peters [Wed, 15 Oct 2008 13:38:59 +0000]
Must remember to update MANIFEST, OK?
p4raw-id: //depot/perl@34485
Steve Peters [Wed, 15 Oct 2008 13:20:02 +0000]
Some additional files changes for Test-Simple-0.82
p4raw-id: //depot/perl@34484
Steve Peters [Wed, 15 Oct 2008 13:11:04 +0000]
Upgrade to Test-Simple-0.82.
p4raw-id: //depot/perl@34483
Nicholas Clark [Wed, 15 Oct 2008 11:27:28 +0000]
Upgrade to ExtUtils-MakeMaker-6.47_01
p4raw-id: //depot/perl@34482
YAMASHINA Hio [Wed, 15 Oct 2008 17:34:35 +0000]
Storable.thaw segv on blessed reference to overloaded object
Message-Id: <
20081015173435.dd95b362.hio@hio.jp>
p4raw-id: //depot/perl@34481
Nicholas Clark [Tue, 14 Oct 2008 21:16:05 +0000]
Yet another [ACGHS]V pointer in the interpreter structure that needs to
be reset if its SV is freed. (see change 22688 (30952)).
A real live bug found by Slaven and Andreas whilst smoking maint-5.8.x.
I guess that we should audit the interpreter structure for any others.
p4raw-id: //depot/perl@34479
Marcus Holland-Moritz [Sun, 12 Oct 2008 20:23:51 +0000]
Upgrade to Devel::PPPort 3.14_02
p4raw-id: //depot/perl@34475
Marcus Holland-Moritz [Sun, 12 Oct 2008 02:51:44 +0000]
Make expand-macro.pl accept macro expressions, i.e. macros with
arguments. This makes it much more convenient to get expanded
expressions that can be directly copied to a debugger. This is
optional, so the original behaviour is maintained. Allow to read
the macro name or expression from stdin, which can be useful for
feeding it multi-line macro expressions. Use Pod::Usage and move
the usage to POD section.
p4raw-id: //depot/perl@34474
Marcus Holland-Moritz [Sat, 11 Oct 2008 16:13:12 +0000]
Make sure expand-macro.pl also works for macros in headers
that are not included by perl.h (like regcomp.h).
p4raw-id: //depot/perl@34473
Jos I. Boumans [Fri, 10 Oct 2008 15:14:27 +0000]
Update File::Fetch to 0.16
From: "Jos I. Boumans" <jos@dwim.org>
Message-Id: <
84818689-C970-47A1-9FE7-969C2B74183D@dwim.org>
p4raw-id: //depot/perl@34472
Abigail [Tue, 7 Oct 2008 21:56:55 +0000]
Change of email address.
Message-ID: <
20081007195655.GA22986@almanda>
p4raw-id: //depot/perl@34471
Steve Hay [Tue, 7 Oct 2008 12:18:11 +0000]
Define HAS_QUAD on Win32 and introduce new value for QUADKIND
where appropriate.
This doesn't make much difference on Win32 because IVSIZE is still 4,
but access to the appropriate "quad" type is still useful, e.g. for
Y2038 support.
p4raw-id: //depot/perl@34470
Steve Hay [Tue, 7 Oct 2008 08:28:05 +0000]
Refine Win32's s{GM|LOCAL}TIME_{min|max} values based on the output of
Schwern's latest check_max.c program.
See:
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-10/msg00049.html
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-10/msg00137.html
p4raw-id: //depot/perl@34469
Nicholas Clark [Mon, 6 Oct 2008 16:13:39 +0000]
Update Eddy Tan's address.
p4raw-id: //depot/perl@34466
Nicholas Clark [Sun, 5 Oct 2008 21:51:54 +0000]
Avoid allocating 1 extra regnode when duplicating a regexp.
See http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-09/msg00590.html
and http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-10/msg00163.html
p4raw-id: //depot/perl@34464
Nicholas Clark [Sun, 5 Oct 2008 17:39:24 +0000]
Update copyright year to 2008.
p4raw-id: //depot/perl@34463
Nicholas Clark [Sun, 5 Oct 2008 16:17:05 +0000]
Correct address.
p4raw-id: //depot/perl@34460
Nicholas Clark [Sun, 5 Oct 2008 15:50:38 +0000]
Most of the AUTHORS file already has hard tabs, so convert the
remaining lines.
p4raw-id: //depot/perl@34458
Nicholas Clark [Sun, 5 Oct 2008 15:20:15 +0000]
All the volunteers who contributed to Paul Fenwick's project to help
write perl589delta.pod, who weren't already in the AUTHORS file.
Big thanks to all of them (including the 6 already in it). Still not
to late to book your place in eternity - contact Paul for details.
p4raw-id: //depot/perl@34457
H.Merijn Brand [Fri, 3 Oct 2008 16:19:55 +0000]
Add probes for *time64 () functions
Add missing config vars
p4raw-id: //depot/perl@34456
Nicholas Clark [Wed, 1 Oct 2008 20:59:42 +0000]
It's RISC OS, dammit. Hard space, upper case. Always.
p4raw-id: //depot/perl@34454
Steve Hay [Wed, 1 Oct 2008 16:55:42 +0000]
Fix Archive-Tar's 02_methods.t when IO::Compress::Bzip2 is absent
p4raw-id: //depot/perl@34453
Steve Hay [Wed, 1 Oct 2008 16:53:57 +0000]
Upgrade to Archive-Tar-1.39_04
Local change 32352 remains in 04_resolved_issues.t
p4raw-id: //depot/perl@34452
Nicholas Clark [Wed, 1 Oct 2008 08:55:48 +0000]
error reporting of [$a ; $b] can be a TODO.
p4raw-id: //depot/perl@34451
Steve Hay [Tue, 30 Sep 2008 16:31:09 +0000]
Correct the sLOCALTIME_{min|max} values added by #34363 for BCC and VC9
(Manually checking with the Configure test programs shows that the
values differ fromt he sGMTIME_{min|max} values for these compilers)
p4raw-id: //depot/perl@34449
Steve Hay [Tue, 30 Sep 2008 12:41:16 +0000]
Add the two new test files that I missed in 34446
(Thanks to Rafael for the spot)
p4raw-id: //depot/perl@34448
Steve Hay [Tue, 30 Sep 2008 11:27:36 +0000]
Fix Module-Build's compat.t when HARNESS_TIMER is set to 1
This is hopefully a better way of fixing the failure originally
addressed by 33340 (which was not assimilated into 0.30)
p4raw-id: //depot/perl@34447
Steve Hay [Tue, 30 Sep 2008 11:25:01 +0000]
Upgrade to Module-Build-0.30
Local changes 32357 in ppm.t and 32351 in test_type.t and xs.t remain,
but not the tilde.t part of 32351, which looks like it might be
superseded by changes in 0.30
p4raw-id: //depot/perl@34446
H.Merijn Brand [Mon, 29 Sep 2008 16:56:12 +0000]
A builtin hard upper bound for sLOCALTIME_max to prevent AIX
from stalling in the tests
p4raw-id: //depot/perl@34444
H.Merijn Brand [Mon, 29 Sep 2008 16:15:52 +0000]
Allow s{GM,LOCAL)TIME_{min,max} to be set from CLI, Policy.sh and hints
p4raw-id: //depot/perl@34443
H.Merijn Brand [Mon, 29 Sep 2008 12:41:37 +0000]
Version up for adding hints/hpux.pl
p4raw-id: //depot/perl@34442
H.Merijn Brand [Mon, 29 Sep 2008 12:40:38 +0000]
Storable and HP-UX Optimizer don't like eachother on 5.8.x
Dropping optimization level for HP C-ANSI-C to +O1 won't
do too much harm to all other builds, so keep it simple
p4raw-id: //depot/perl@34441
Steve Hay [Mon, 29 Sep 2008 09:14:25 +0000]
Upgrade to ExtUtils-MakeMaker-6.46
Local changes 32905 and 32964 in MM_Unix.pm and 33259 in MM_Unix.t
remain
p4raw-id: //depot/perl@34440
Shlomi Fish [Tue, 23 Sep 2008 19:00:41 +0000]
Re: [PATCH] Add open "|-" and open "-|" to perlopentut
Message-id: <
200809231900.41474.shlomif@iglu.org.il>
p4raw-id: //depot/perl@34435
Jerry D. Hedden [Tue, 23 Sep 2008 09:40:27 +0000]
Loading modules in test.pl
From: "Jerry D. Hedden" <jdhedden@cpan.org>
Message-ID: <
1ff86f510809230640y2d5a072g6abff6604f9daa79@mail.gmail.com>
p4raw-id: //depot/perl@34434
Nicholas Clark [Sat, 27 Sep 2008 09:27:59 +0000]
$? is PVLV on VMS (and actually, anywhere else where COMPLEX_STATUS is
defined).
p4raw-id: //depot/perl@34433
Steve Hay [Fri, 26 Sep 2008 16:43:21 +0000]
Upgrade Compression modules to 2.015
p4raw-id: //depot/perl@34425
Chris BinGOs Williams [Thu, 25 Sep 2008 16:03:10 +0000]
Hints file for MirOS BSD
From: "Chris 'BinGOs' Williams" <chris@bingosnet.co.uk>
Message-ID: <
20080925150310.GA30736@klanker.bingosnet.co.uk>
Date: Thu, 25 Sep 2008 16:03:10 +0100
p4raw-id: //depot/perl@34423
Nicholas Clark [Fri, 26 Sep 2008 09:10:02 +0000]
Upgrade to XSLoader 0.10.
p4raw-id: //depot/perl@34422
Steve Hay [Fri, 26 Sep 2008 08:44:33 +0000]
Upgrade to podlators-2.1.4
p4raw-id: //depot/perl@34421
H.Merijn Brand [Fri, 26 Sep 2008 08:39:27 +0000]
$! and $1 are PVMG(), but their content is undefined when peeking
p4raw-id: //depot/perl@34420
Steve Hay [Thu, 25 Sep 2008 17:12:37 +0000]
Don't skip exporting Perl_sv_peek in non-DEBUGGING builds since it
is now used in XS::APItest (as of #34417)
p4raw-id: //depot/perl@34419
H.Merijn Brand [Thu, 25 Sep 2008 13:46:24 +0000]
Add new test file to MANIFEST. Fix tests for threaded builds.
p4raw-id: //depot/perl@34418
H.Merijn Brand [Thu, 25 Sep 2008 12:54:16 +0000]
New XS::APItest's for sv_peek based on my DDumper work
p4raw-id: //depot/perl@34417
H.Merijn Brand [Thu, 25 Sep 2008 11:55:49 +0000]
pv_uni_display () omitted backslash in output string
p4raw-id: //depot/perl@34416
Richard Foley [Wed, 24 Sep 2008 14:07:38 +0000]
Couple of mail address fixes
Message-Id: <
200809241407.38389.Richard.Foley@rfi.net>
p4raw-id: //depot/perl@34414
Nicholas Clark [Tue, 23 Sep 2008 13:48:10 +0000]
defined %{$package.'::'} isn't good enough to tell whether a module is
loaded when it's XS and staticly linked to perl.
p4raw-id: //depot/perl@34409
brian d foy [Sun, 21 Sep 2008 15:23:47 +0000]
Show using waitpid in IPC::Open[23] SYNOPSIS
Message-ID: <
210920081523471499%brian.d.foy@gmail.com>
p4raw-id: //depot/perl@34408
Nicholas Clark [Tue, 23 Sep 2008 13:31:26 +0000]
The tests for the -ostash option to B::Concise will have been failing
for -Uusedl since they were added. For now, test with a non-XS module,
and TODO the test with the XS module when usedl is undefined.
p4raw-id: //depot/perl@34406
Nicholas Clark [Tue, 23 Sep 2008 12:00:05 +0000]
Fix tests for the case of -Du_usedl
p4raw-id: //depot/perl@34404
Andy Dougherty [Mon, 22 Sep 2008 13:36:57 +0000]
[perl #59208][PATCH 5.8.x] ext/DynaLoader/t/XSLoader.t assumes dynamic loading
Message-ID: <Pine.LNX.4.64.
0809221334120.11020@fractal.phys.lafayette.edu>
p4raw-id: //depot/perl@34402
Nicholas Clark [Mon, 22 Sep 2008 20:39:30 +0000]
Change 30638 to 5.8.x inadvertently introduced (at lest) two
regressions into the regexp engine. Add tests for the constructions
that regressed, to prevent any future change falling foul of the same
problem.
p4raw-id: //depot/perl@34400
Rafael Garcia-Suarez [Mon, 22 Sep 2008 08:30:40 +0000]
Avoid uninitialized warnings from XSLoader
p4raw-id: //depot/perl@34392
Steve Hay [Mon, 22 Sep 2008 08:16:57 +0000]
Skip another module from the VERSION comparison checks
p4raw-id: //depot/perl@34391
Steve Hay [Mon, 22 Sep 2008 07:58:57 +0000]
Fix syntax error in makedef.pl introduced by #34379
p4raw-id: //depot/perl@34390
Moritz Lenz [Sun, 21 Sep 2008 17:47:11 +0000]
Re: [perl #59128] Typo in perldsc(1)
Message-ID: <
48D66C7F.6000602@casella.verplant.org>
p4raw-id: //depot/perl@34389
Sébastien Aperghis-Tramoni [Sun, 21 Sep 2008 18:31:48 +0000]
Fwd: CPAN Upload: S/SA/SAPER/XSLoader-0.09.tar.gz
Message-Id: <
D065A3BF-289B-43D4-9F30-D316414C1923@free.fr>
p4raw-id: //depot/perl@34388
Sébastien Aperghis-Tramoni [Sun, 21 Sep 2008 19:07:47 +0000]
Fwd: CPAN Upload: S/SA/SAPER/Sys-Syslog-0.27.tar.gz
Message-Id: <
E10A395B-92A8-4803-8E75-383F7CE8A624@free.fr>
p4raw-id: //depot/perl@34387
Moritz Lenz [Sun, 21 Sep 2008 17:50:04 +0000]
Re: [perl #59134] Typo in File::stat man pag
Message-ID: <
20080921154935.4916.qmail@lists.develooper.com>
p4raw-id: //depot/perl@34386
Sébastien Aperghis-Tramoni [Sun, 21 Sep 2008 16:13:36 +0000]
Fwd: CPAN Upload: S/SA/SAPER/constant-1.16.tar.gz
Message-Id: <
5B1668F5-06FA-4104-9966-9727E880C533@free.fr>
p4raw-id: //depot/perl@34385
Gisle Aas [Sat, 20 Sep 2008 18:13:37 +0000]
Implement IO::Handle::say the same way as the builtin say().
IO::Handle::say used to output $, before the newline.
p4raw-id: //depot/perl@34384
Nicholas Clark [Sat, 20 Sep 2008 16:21:00 +0000]
Another missing 'static' picked up by one of Merijn's smokers.
p4raw-id: //depot/perl@34383
Nicholas Clark [Sat, 20 Sep 2008 11:38:46 +0000]
Two missing 'static's, spotted by Merijn's smoker.
p4raw-id: //depot/perl@34381
Nicholas Clark [Fri, 19 Sep 2008 20:46:56 +0000]
Kevin J. Woolley has taken over from Gozer.
p4raw-id: //depot/perl@34380
Jan Dubois [Mon, 15 Sep 2008 17:43:34 +0000]
RE: [perl #58858] Building Perl 5.10.0 in AIX 5.3 using "-Duseshrplib" option --> "ERROR: Undefined symbol: boot_DynaLoader"
From: "Jan Dubois" <jand@activestate.com>
Message-ID: <
043301c91795$3fe15df0$bfa419d0$@com>
p4raw-id: //depot/perl@34379
Paul Fenwick [Tue, 16 Sep 2008 20:32:39 +0000]
Re: [PATCH] Revised: Improved documentation for flock() in perlfunc.pod
Message-ID: <
48CF8B47.30803@perltraining.com.au>
p4raw-id: //depot/perl@34378
Jerry D. Hedden [Tue, 16 Sep 2008 16:35:11 +0000]
Don't reuse temp files in tests
From: "Jerry D. Hedden" <jdhedden@cpan.org>
Message-ID: <
1ff86f510809161335j73312da3v90fa6ef0cb8ac7c@mail.gmail.com>
Date: Tue, 16 Sep 2008 16:35:11 -0400
p4raw-id: //depot/perl@34377
Nicholas Clark [Tue, 16 Sep 2008 09:58:01 +0000]
"Upgrade" AutoSplit to 1.06.
p4raw-id: //depot/perl@34373
Nicholas Clark [Mon, 15 Sep 2008 22:53:27 +0000]
SEGV in readline with $/ set to a reference, discovered by theorbtwo.
The bug turns out to have been introduced in 2003, with change 18580.
p4raw-id: //depot/perl@34371
Nicholas Clark [Mon, 15 Sep 2008 21:55:51 +0000]
Bump $ExtUtils::Constant::Utils::VERSION.
p4raw-id: //depot/perl@34370
Nicholas Clark [Mon, 15 Sep 2008 19:28:39 +0000]
Bump $O::VERSION, to reflect change 32626, a doc change that is the only
change to O.pm since 2001.
p4raw-id: //depot/perl@34369
Steve Hay [Mon, 15 Sep 2008 17:01:08 +0000]
Bump VERSIONs in all non-dual-lived modules that have changed
since 5.8.8, ready for merging into maint-5.8 prior to 5.8.9.
(Many (all?) of these should really have been changed prior to
5.10.0, but better late than never.)
Also modify cmpVERSION.pl to skip uninstalled test modules whose
VERSIONs don't really matter.
p4raw-id: //depot/perl@34365
Nicholas Clark [Mon, 15 Sep 2008 10:56:23 +0000]
Upgrade to podlators 2.1.3
p4raw-id: //depot/perl@34364
H.Merijn Brand [Mon, 15 Sep 2008 08:22:14 +0000]
Add probes for LOCALTIME_max and LOCALTIME_min (y2038 project)
p4raw-id: //depot/perl@34363
Nicholas Clark [Sun, 14 Sep 2008 21:27:42 +0000]
The program spawned from process.t needs to set up @INC correctly, as
process.t does not add an -I../lib for core.
p4raw-id: //depot/perl@34361
Nicholas Clark [Sat, 13 Sep 2008 15:25:35 +0000]
Upgrade to Test::Harness 3.14
p4raw-id: //depot/perl@34359
Vincent Pit [Sat, 13 Sep 2008 01:13:30 +0000]
Re: [5.8] Change 33727 (op.c) breaks constant folding in "elsif"
Message-ID: <
48CAF79A.6000001@profvince.com>
p4raw-id: //depot/perl@34358
Nicholas Clark [Fri, 12 Sep 2008 21:02:55 +0000]
In S_mro_get_linear_isa_dfs(), add void casts to silence two warnings
about "value computed is not used". Re-order the code to group
operations on the isa hash with each other. Add a SvREADONLY_on() on
the isa array if it is generated by Perl_get_isa_hash().
p4raw-id: //depot/perl@34357
Nicholas Clark [Fri, 12 Sep 2008 09:25:55 +0000]
Build the isa cache from any linear ISA, rather than forcing the use
of dfs. This avoids calling dfs on a C3 class (and all its parents),
which won't break anything, but is more work than is needed.
p4raw-id: //depot/perl@34356
Nicholas Clark [Fri, 12 Sep 2008 08:52:50 +0000]
Need to free the isa lookup hash before rebuilding it.
p4raw-id: //depot/perl@34355
Nicholas Clark [Fri, 12 Sep 2008 00:19:51 +0000]
Create a direct lookup hash for ->isa() lookup, by retaining the
de-duping hash used by S_mro_get_linear_isa_dfs(). Provide a new
function Perl_get_isa_hash() to lazily retrieve this. (Which could
actually be static if S_isa_lookup() and Perl_sv_derived_from()
moved into mro.c.) Make S_isa_lookup() use this lookup hash in place
of a linear walk of the linear isa. This should turn isa lookups from
O(n) to O(1), which should make heavy users of ->isa() faster.
(eg PPI, and hence Perl Critic).
p4raw-id: //depot/perl@34354
Nicholas Clark [Thu, 11 Sep 2008 22:11:32 +0000]
Abolish the warning "Can't locate package %"SVf" for the parents of %s"
which doesn't tell you anything you won't discover soon enough when you
try to call a method. (Or haven't already been warned about when @ISA
was linearised)
p4raw-id: //depot/perl@34353
Nicholas Clark [Thu, 11 Sep 2008 21:46:28 +0000]
As stash can't be NULL, no need to check name_stash is not NULL before
comparing the two, as a NULL == NULL comparison can't happen.
p4raw-id: //depot/perl@34352
Nicholas Clark [Thu, 11 Sep 2008 21:27:43 +0000]
The stash argument to S_isa_lookup() actually never is NULL.
p4raw-id: //depot/perl@34351