13 years agoRename method, normalize rv to [$sql, @bind]
Peter Rabbitson [Sun, 28 Nov 2010 02:15:24 +0000]
Rename method, normalize rv to [$sql, @bind]

13 years agoKeep belongs_to related object / fk values in sync
Peter Rabbitson [Sun, 28 Nov 2010 00:49:41 +0000]
Keep belongs_to related object / fk values in sync

13 years agoFix count on rs with a having clause with an aliased condition
Peter Rabbitson [Sat, 27 Nov 2010 23:14:22 +0000]
Fix count on rs with a having clause with an aliased condition

13 years agoexplain how to use HashRefInflator with search
Al Newkirk [Sat, 6 Nov 2010 21:53:55 +0000]
explain how to use HashRefInflator with search

13 years agoFix the DBI-destroy-warning silencer
Peter Rabbitson [Fri, 26 Nov 2010 13:15:55 +0000]
Fix the DBI-destroy-warning silencer

13 years agoMicrooptimization of the IC::DT registration code
Peter Rabbitson [Thu, 25 Nov 2010 00:48:43 +0000]
Microoptimization of the IC::DT registration code

13 years agorefactor DBIx::Class::Storage::Statistics::debugfh() to be lazy
Arthur Axel 'fREW' Schmidt [Fri, 26 Nov 2010 23:11:20 +0000]
refactor DBIx::Class::Storage::Statistics::debugfh() to be lazy

14 years agoQuote table name when inserting DEFAULT VALUES
Rafael Kitover [Wed, 24 Nov 2010 09:42:52 +0000]
Quote table name when inserting DEFAULT VALUES

14 years agoFix multiple storage regressions from 52416317
Rafael Kitover [Mon, 22 Nov 2010 08:41:56 +0000]
Fix multiple storage regressions from 52416317

Factor out the pre-insert value fetching again, some storages need
to hook there. The rest is just riba being retarded, Caelum++

14 years agofix left-over from use_namespaces
Moritz Lenz [Tue, 23 Nov 2010 15:30:20 +0000]
fix left-over from use_namespaces

14 years agoadded website to community resources in main POD
Rafael Kitover [Tue, 23 Nov 2010 11:52:56 +0000]
added website to community resources in main POD

14 years agoAlways run the META.yml check
Peter Rabbitson [Thu, 18 Nov 2010 09:28:21 +0000]
Always run the META.yml check

14 years agoBackout inconsistent changes to +columns handling
Peter Rabbitson [Fri, 12 Nov 2010 14:58:24 +0000]
Backout inconsistent changes to +columns handling

introduced in 67ba664605de95b5130b55397c7351f53dae4c19 2 years ago

14 years agoOverhaul thread handling
Peter Rabbitson [Thu, 18 Nov 2010 07:56:14 +0000]
Overhaul thread handling

Throw away _verify_tid as it happens too late (when a request is fired).
Instead destroy the current $dbh as soon as possible in CLONE and hope for
the best. Also deactivate _verify_pid on Win32 as it silently spawns a
thread in the background (and thus invokes CLONE).

14 years agoSuppress replicated test warnings on win32 as well
Peter Rabbitson [Thu, 18 Nov 2010 07:10:48 +0000]
Suppress replicated test warnings on win32 as well

14 years agoFix 2 stupid omissions in tests
Peter Rabbitson [Mon, 15 Nov 2010 10:32:48 +0000]
Fix 2 stupid omissions in tests

14 years agoStop showing __BULK_INSERT__ during populate() without bindvals
Peter Rabbitson [Sun, 14 Nov 2010 12:43:00 +0000]
Stop showing __BULK_INSERT__  during populate() without bindvals

Also restructure the code a bit (e.g. avoid a useless list-copy)

14 years agoFix a forgotten nested try::tiny usage
Peter Rabbitson [Sun, 14 Nov 2010 12:37:28 +0000]
Fix a forgotten nested try::tiny usage

14 years agoAttach a storage debugobj lazily instead of at new() time
Peter Rabbitson [Sun, 14 Nov 2010 12:24:06 +0000]
Attach a storage debugobj lazily instead of at new() time

14 years agoUnqualify imported functions
Peter Rabbitson [Sun, 14 Nov 2010 12:23:19 +0000]
Unqualify imported functions

14 years agoCroak more intelligently when attrs->{page} is an unexpected value
Andrew Rodland [Tue, 9 Nov 2010 01:19:04 +0000]
Croak more intelligently when attrs->{page} is an unexpected value

14 years agoMajor overhaul of select/as resolution handling (fixes RT#61235)
Peter Rabbitson [Sat, 9 Oct 2010 09:01:35 +0000]
Major overhaul of select/as resolution handling (fixes RT#61235)

14 years agoAdd notes about handling of inflated objects in resultset conditions
Mike Baas [Fri, 29 Oct 2010 02:55:49 +0000]
Add notes about handling of inflated objects in resultset conditions

14 years agoStop spurious warnings in cdbi test
Peter Rabbitson [Fri, 12 Nov 2010 15:22:01 +0000]
Stop spurious warnings in cdbi test

14 years agoOverhaul serialization test, add optional Memcached testing
Peter Rabbitson [Tue, 9 Nov 2010 13:30:20 +0000]
Overhaul serialization test, add optional Memcached testing

14 years agoAdd Storable freeze/thaw hooks to ResultSet to detach active cursors
Peter Rabbitson [Sat, 30 Oct 2010 09:42:43 +0000]
Add Storable freeze/thaw hooks to ResultSet to detach active cursors

This allows serialization of resultsets "in-progress". Furthermore
testing revealed cached resultsets are serializable just fine \o/

14 years agoSwitch all Storable serialization calls from freeze() to nfreeze()
Peter Rabbitson [Sat, 30 Oct 2010 09:36:47 +0000]
Switch all Storable serialization calls from freeze() to nfreeze()

ovid++ for researching this:
http://blogs.perl.org/users/ovid/2010/10/storable-freeze-versus-nfreeze.html

14 years agoFix regressions in IC::DT registration logic
Peter Rabbitson [Mon, 8 Nov 2010 11:52:29 +0000]
Fix regressions in IC::DT registration logic

14 years agoFix datetime dependency in t/60core.t (RT62635)
Peter Rabbitson [Mon, 8 Nov 2010 02:03:36 +0000]
Fix datetime dependency in t/60core.t (RT62635)

14 years agoDeprecate rolled-out hash-condition in search()
Peter Rabbitson [Mon, 8 Nov 2010 01:54:09 +0000]
Deprecate rolled-out hash-condition in search()

14 years agoDie on search in void context
Peter Rabbitson [Mon, 8 Nov 2010 01:26:47 +0000]
Die on search in void context

14 years agoRefactor insert logic (Row should not handle SQLA options)
Peter Rabbitson [Mon, 8 Nov 2010 01:10:20 +0000]
Refactor insert logic (Row should not handle SQLA options)

14 years agoIntroduce columns_info, switch a large portion of the code over
Peter Rabbitson [Sun, 7 Nov 2010 23:20:11 +0000]
Introduce columns_info, switch a large portion of the code over

(saves on repeated method calls)

14 years agoCleanup Row::sequence()
Peter Rabbitson [Sun, 12 Sep 2010 18:52:49 +0000]
Cleanup Row::sequence()

While it seems like a rather useless method these days (we have excellent sequence
detection) keep it around nevertheless. However move it to ResultSource where
it logically belongs, and undocument its use from a couple of ::Storage driver
POD examples

14 years agoCleanup ::ResultSourceProxy, use a proxy-method generator
Peter Rabbitson [Sun, 12 Sep 2010 18:50:34 +0000]
Cleanup ::ResultSourceProxy, use a proxy-method generator

14 years agoMore robust Oracle autoinc pk sequence detection
Alexander Hartmaier [Fri, 29 Oct 2010 15:59:04 +0000]
More robust Oracle autoinc pk sequence detection

When only one trigger could possible match a specific column, the trigger
detection rules can be more lenient.

14 years agoHide package from PAUSE
Peter Rabbitson [Sat, 30 Oct 2010 08:40:11 +0000]
Hide package from PAUSE

14 years agoDon't quote NULL for debug output
Arthur Axel 'fREW' Schmidt [Tue, 9 Nov 2010 00:25:27 +0000]
Don't quote NULL for debug output

Also require new SQLA with more goodies (and which can take advantage
of an unquoted NULL)

14 years agofix and regression test for RT #62642
John Napiorkowski [Wed, 10 Nov 2010 02:22:58 +0000]
fix and regression test for RT #62642

14 years agoRemoved unintentionally doubled cd pk trigger from t/73oracle.t
Alexander Hartmaier [Fri, 29 Oct 2010 15:55:41 +0000]
Removed unintentionally doubled cd pk trigger from t/73oracle.t

14 years agofREWFail: Remove IRC topic from DBIx::Class
Arthur Axel 'fREW' Schmidt [Fri, 29 Oct 2010 15:10:24 +0000]
fREWFail: Remove IRC topic from DBIx::Class

14 years agorelease 0.08124 v0.08124
Arthur Axel 'fREW' Schmidt [Thu, 28 Oct 2010 15:52:55 +0000]
release 0.08124

14 years agoChanges for 0.08124
Arthur Axel 'fREW' Schmidt [Thu, 28 Oct 2010 14:23:47 +0000]
Changes for 0.08124

14 years agoGeneralize leak-trace handling
Peter Rabbitson [Thu, 28 Oct 2010 09:01:41 +0000]
Generalize leak-trace handling

Disable the leak tests for perls 5.13.5 and 5.13.6 on *smoker only*

14 years agoTest::Builder2 has a fancy set of singletons
Peter Rabbitson [Thu, 28 Oct 2010 08:00:54 +0000]
Test::Builder2 has a fancy set of singletons

14 years agopodcoverage exception (how did I miss *that*!?)
Peter Rabbitson [Thu, 28 Oct 2010 08:00:05 +0000]
podcoverage exception (how did I miss *that*!?)

14 years agorelease 0.08123_03
Arthur Axel 'fREW' Schmidt [Wed, 27 Oct 2010 23:28:24 +0000]
release 0.08123_03

14 years agoadd changes from last few commits
Arthur Axel 'fREW' Schmidt [Wed, 27 Oct 2010 23:25:30 +0000]
add changes from last few commits

14 years agoView-dep cleanups (really paper overs, code needs a rewrite)
Amiri Barksdale at Home [Mon, 12 Jul 2010 02:58:41 +0000]
View-dep cleanups (really paper overs, code needs a rewrite)

Tighter check for ref type in resolver (this was broken but unnoticed)
Skip table result classes in view part of resolver.
No uninitialized warnings in resolver where it expects some misses (ugh!)
Cleanup viewdeps test (and correct incorrect comparison)

This should have not merged as is, but time is short to fix it properly.
Hopefully next iter.

14 years agoBring back deleted classes
Peter Rabbitson [Wed, 27 Oct 2010 22:39:55 +0000]
Bring back deleted classes

The idea was to move them into a separate dist, but ENOTIME

14 years agoLatest DBD::SQLite really went to shit >:(
Peter Rabbitson [Wed, 27 Oct 2010 18:01:35 +0000]
Latest DBD::SQLite really went to shit >:(

14 years agoThis test in fact requires DT::F::SQLite
Peter Rabbitson [Wed, 27 Oct 2010 17:59:15 +0000]
This test in fact requires DT::F::SQLite

14 years agoAdd a fix to cookbook recipe
Peter Rabbitson [Wed, 27 Oct 2010 11:57:39 +0000]
Add a fix to cookbook recipe

14 years agoFix load_namespaces fail when classes tinker with $_
Peter Rabbitson [Wed, 27 Oct 2010 10:39:22 +0000]
Fix load_namespaces fail when classes tinker with $_

14 years agoFixed a prefetch bug (o2m->prefetch_o2m+order_by+rows)
Norbert Buchmuller [Fri, 22 Oct 2010 12:21:28 +0000]
Fixed a prefetch bug (o2m->prefetch_o2m+order_by+rows)

14 years agoAdd undocumented ability to disable the join optimizer
Peter Rabbitson [Wed, 27 Oct 2010 10:18:41 +0000]
Add undocumented ability to disable the join optimizer

The capability system in its current form is insufficient - pending a
redesign/rewrite. In the meantime remove mention of it from Changes
and add an extra cap to disable the join-optimizer on request (prodded
by timbunce :)

14 years agoAutomatically mark the cap. framework methods as unimplemented for replication
Peter Rabbitson [Wed, 27 Oct 2010 10:11:15 +0000]
Automatically mark the cap. framework methods as unimplemented for replication

14 years agoFail gracefully on Config::Any PROFILE-loading errors
Peter Rabbitson [Tue, 26 Oct 2010 17:42:29 +0000]
Fail gracefully on Config::Any PROFILE-loading errors

14 years agorelease 0.08123_02
Arthur Axel 'fREW' Schmidt [Tue, 26 Oct 2010 15:00:05 +0000]
release 0.08123_02

14 years agobump version for dev users
Arthur Axel 'fREW' Schmidt [Tue, 26 Oct 2010 14:49:05 +0000]
bump version for dev users

14 years ago$sth->{Active} may throw during destruction >.<
Peter Rabbitson [Tue, 26 Oct 2010 12:12:06 +0000]
$sth->{Active} may throw during destruction >.<

14 years agoExtra adjustments of find() documentation and code (as suggested by freetime)
Peter Rabbitson [Tue, 26 Oct 2010 11:59:56 +0000]
Extra adjustments of find() documentation and code (as suggested by freetime)

14 years agoExtra authordeps
Peter Rabbitson [Tue, 26 Oct 2010 11:55:50 +0000]
Extra authordeps

14 years agoPatch up weird MRO fail on 5.8 perls
Peter Rabbitson [Tue, 26 Oct 2010 11:51:24 +0000]
Patch up weird MRO fail on 5.8 perls

14 years agoTemporary fixes for 5.13.x $@ handling
Peter Rabbitson [Tue, 26 Oct 2010 11:16:26 +0000]
Temporary fixes for 5.13.x $@ handling

Some patchups to mitigate fallout from
http://perl5.git.perl.org/perl.git/commitdiff/96d9b9cd

Included several "time-bombs" set to go off when 5.13.8
is available (the "Contentious Changes freeze" release)

14 years agoBreak out the txn_scope_guard tests, some cleanup
Peter Rabbitson [Mon, 25 Oct 2010 03:15:02 +0000]
Break out the txn_scope_guard tests, some cleanup

14 years agogitignore MYMETA
Peter Rabbitson [Tue, 26 Oct 2010 09:30:00 +0000]
gitignore MYMETA

14 years agoGet test suite to pass under 5.13.6 (peepeeness!)
Peter Rabbitson [Tue, 26 Oct 2010 09:25:17 +0000]
Get test suite to pass under 5.13.6 (peepeeness!)

A regression slipped into 5.13.6 introduced by
http://perl5.git.perl.org/perl.git/commit/304474c3
Fixed by: http://perl5.git.perl.org/perl.git/commit/cefd5c7c

14 years ago-ident implementation
Peter Rabbitson [Thu, 21 Oct 2010 18:04:21 +0000]
-ident implementation

14 years agoRemove useless use of Storable from t/100extra_source.t
Peter Rabbitson [Tue, 17 Aug 2010 05:18:06 +0000]
Remove useless use of Storable from t/100extra_source.t

Cleanup needed before merging extended rels (Storable chokes on
the coderefs). Rewrite the test while we are here.

14 years agoReturn a unique list of k/vs from get_inflated_columns
Peter Rabbitson [Fri, 22 Oct 2010 18:28:55 +0000]
Return a unique list of k/vs from get_inflated_columns

14 years agoMassive cleanup of transaction handlers
Peter Rabbitson [Thu, 21 Oct 2010 22:37:06 +0000]
Massive cleanup of transaction handlers

Audit the txn_do/scope_guard/txn_begin|txn_commit codepaths to make
sure they can be interchangeably used and still just DTRT.
Write a ton of tests to codify current behavior

In the process revert d8a5a2340b0ac0dbf1c3e7779e7951b1bec2ccd5 which
introduces a regression (now poperly caught by tests)

14 years agoMake sure t/storage/debug.t passes with DBIC_TRACE_PROFILE set
Peter Rabbitson [Thu, 21 Oct 2010 14:49:18 +0000]
Make sure t/storage/debug.t passes with DBIC_TRACE_PROFILE set

14 years agoAdd Hash::Merge exception to the leak test
Peter Rabbitson [Sun, 10 Oct 2010 18:36:47 +0000]
Add Hash::Merge exception to the leak test

This is so that a user with a DBIC_TRACE_PROFILE in the env will
still be able to pass the tests/install

14 years agoadd SEE ALSO
Arthur Axel 'fREW' Schmidt [Wed, 20 Oct 2010 14:57:32 +0000]
add SEE ALSO

14 years agoDoc fix: DBIx::Class::Row->discard_changes documented twice
Aaron Crane [Mon, 18 Oct 2010 12:20:25 +0000]
Doc fix: DBIx::Class::Row->discard_changes documented twice

14 years agoSkip cross-schema tests for Oracle 8i (no clear fix yet)
Robert Bohne [Sun, 17 Oct 2010 18:24:16 +0000]
Skip cross-schema tests for Oracle 8i (no clear fix yet)

14 years agoFixed test for hierarchical queries with Oracle 8i.
Robert Bohne [Sun, 13 Jun 2010 16:56:13 +0000]
Fixed test for hierarchical queries with Oracle 8i.

14 years agoMerge branch 'people/riba/find_cleanup' into people/riba/master_cherry
Peter Rabbitson [Sun, 17 Oct 2010 15:47:27 +0000]
Merge branch 'people/riba/find_cleanup' into people/riba/master_cherry

14 years agoTest for already fixed RT#59219
Peter Rabbitson [Sat, 16 Oct 2010 23:51:33 +0000]
Test for already fixed RT#59219

14 years agoExtensive updates to find/key related documentation
Peter Rabbitson [Sat, 16 Oct 2010 22:46:18 +0000]
Extensive updates to find/key related documentation

14 years agoFix find() with an explicit constraint name (... { key => $cname } )
Peter Rabbitson [Sat, 16 Oct 2010 16:40:53 +0000]
Fix find() with an explicit constraint name (... { key => $cname } )

Fix the code being overly lax on evaluation of the combined
condition (user supplied + $rs inherited). If we can not prove
that a constraint is deteministic - we throw

Also fix the heuristics invoked without a key attr. to not
consider constraints for which NULL values have been supplied

14 years agoDe-golf _is_deterministic_value, add more tests for create() with $rs conds
Peter Rabbitson [Sat, 16 Oct 2010 00:14:03 +0000]
De-golf _is_deterministic_value, add more tests for create() with $rs conds

14 years agoReduce mount of perlgolf in ResultSet.pm
Peter Rabbitson [Fri, 15 Oct 2010 22:11:37 +0000]
Reduce mount of perlgolf in ResultSet.pm

14 years agoRemove support for find( col1 => $val1, col2 => $val2, ... )
Peter Rabbitson [Fri, 15 Oct 2010 20:53:14 +0000]
Remove support for find( col1 => $val1, col2 => $val2, ... )

14 years agoAdd a unique constraint to artist.name in the test schema
Peter Rabbitson [Sat, 16 Oct 2010 14:18:29 +0000]
Add a unique constraint to artist.name in the test schema

While at it adjust tests that assume the name is not unique

14 years agoSwitch t/relationship/core.t $@ checks to Test::Exception
Peter Rabbitson [Fri, 15 Oct 2010 15:56:10 +0000]
Switch t/relationship/core.t $@ checks to Test::Exception

14 years agoAdd deprecation warning to DBIx::Class::ResultSetProxy
Peter Rabbitson [Sun, 12 Sep 2010 18:49:06 +0000]
Add deprecation warning to DBIx::Class::ResultSetProxy

14 years agoRemove _is_unique_query (more dead code from 2006)
Peter Rabbitson [Sat, 16 Oct 2010 15:01:00 +0000]
Remove _is_unique_query (more dead code from 2006)

14 years agoDeleting long forgotten ::Storage::DBI:Role:QueryCounter
Peter Rabbitson [Sun, 12 Sep 2010 17:03:51 +0000]
Deleting long forgotten ::Storage::DBI:Role:QueryCounter

Added in 62fa8aecef5887b274659ebfb4233a37cff5a3e6

Then development backed out in
  b0ca666f56fbdac8c0b4a08a292eed26ba8a21be
  72305dab8d827fdddba16d79f0ca31f9b5d5e735

14 years agoFix bug in update of resultset using qualified condition in "-or"
Aaron Crane [Thu, 7 Oct 2010 14:58:33 +0000]
Fix bug in update of resultset using qualified condition in "-or"

DBIx::Class::Storage::DBIHacks::_strip_cond_qualifiers was failing to
recurse down "-or" conditions.  Add minimal support for that, including a
test.

14 years agofixed oracle test sequence detection from a different schema
Robert Bohne [Sat, 16 Oct 2010 15:17:16 +0000]
fixed oracle test sequence detection from a different schema

14 years agofixed wrong sequence returned when multiple triggers for a table exist + tests
Alexander Hartmaier [Wed, 13 Oct 2010 12:18:52 +0000]
fixed wrong sequence returned when multiple triggers for a table exist + tests

14 years agoStop adding GROUP BY's to subqueries that do not contain 1:M joins
Peter Rabbitson [Sun, 18 Jul 2010 15:03:47 +0000]
Stop adding GROUP BY's to subqueries that do not contain 1:M joins

siracusa++ for spotting the incorrect SQL in the first place,
and pointing out that the competition sucks :)

14 years agoFix spotty handling of complex order_by relationship attrs while prefetching
Peter Rabbitson [Thu, 14 Oct 2010 05:06:28 +0000]
Fix spotty handling of complex order_by relationship attrs while prefetching

14 years agoSet name_sep by default (even if unused). Simplify raw-sql scanner code
Peter Rabbitson [Thu, 14 Oct 2010 05:06:28 +0000]
Set name_sep by default (even if unused). Simplify raw-sql scanner code

14 years agoThat's an embarrasing c/p :(
Peter Rabbitson [Thu, 14 Oct 2010 04:18:30 +0000]
That's an embarrasing c/p :(

14 years agoUndocument lies
Peter Rabbitson [Wed, 13 Oct 2010 18:37:03 +0000]
Undocument lies

14 years agoRequire unborked CAG
Peter Rabbitson [Tue, 12 Oct 2010 09:00:31 +0000]
Require unborked CAG

14 years agoClarify $rs->update/delete documentation
Peter Rabbitson [Mon, 11 Oct 2010 06:50:52 +0000]
Clarify $rs->update/delete documentation