15 years agobetter tests for "smalldatetime" support in MSSQL
Rafael Kitover [Thu, 30 Jul 2009 08:12:45 +0000]
better tests for "smalldatetime" support in MSSQL

15 years agoMerge 'trunk' into 'mssql_storage_minor_refactor'
Rafael Kitover [Tue, 28 Jul 2009 01:03:47 +0000]
Merge 'trunk' into 'mssql_storage_minor_refactor'

r6365@hlagh (orig r7126):  caelum | 2009-07-27 20:03:47 -0400
add postgres "timestamp without time zone" support

15 years agoadd postgres "timestamp without time zone" support
Rafael Kitover [Tue, 28 Jul 2009 00:03:47 +0000]
add postgres "timestamp without time zone" support

15 years agoSAVEPOINT methods for MSSQL
Rafael Kitover [Sun, 26 Jul 2009 16:04:29 +0000]
SAVEPOINT methods for MSSQL

15 years agoadd a comment
Rafael Kitover [Sat, 25 Jul 2009 14:12:01 +0000]
add a comment

15 years agomove placeholder support detection into ::Sybase::Base
Rafael Kitover [Sat, 25 Jul 2009 14:10:30 +0000]
move placeholder support detection into ::Sybase::Base

15 years agominor doc clarification
Rafael Kitover [Fri, 24 Jul 2009 14:39:06 +0000]
minor doc clarification

15 years agoadd placeholder support detection for mssql through dbd::sybase
Rafael Kitover [Fri, 24 Jul 2009 07:22:33 +0000]
add placeholder support detection for mssql through dbd::sybase

15 years agofix a warning in SQLAHacks
Rafael Kitover [Fri, 24 Jul 2009 06:49:54 +0000]
fix a warning in SQLAHacks

15 years agomerge in some more MSSQL code, including odbc dynamic cursor support
Rafael Kitover [Fri, 24 Jul 2009 06:46:16 +0000]
merge in some more MSSQL code, including odbc dynamic cursor support

15 years agomoved code to ::DBI::MSSQL and added DT inflation test
Rafael Kitover [Fri, 24 Jul 2009 05:28:11 +0000]
moved code to ::DBI::MSSQL and added DT inflation test

15 years agoMerge 'mssql_money_type' into 'trunk'
Rafael Kitover [Thu, 23 Jul 2009 18:14:11 +0000]
Merge 'mssql_money_type' into 'trunk'

r6092@hlagh (orig r7090):  caelum | 2009-07-23 08:24:39 -0400
new branch for fixing the MONEY type in MSSQL
r6093@hlagh (orig r7091):  caelum | 2009-07-23 08:34:01 -0400
add test
r6283@hlagh (orig r7093):  caelum | 2009-07-23 10:31:08 -0400
fix money columns
r6284@hlagh (orig r7094):  caelum | 2009-07-23 10:34:06 -0400
minor change
r6285@hlagh (orig r7095):  caelum | 2009-07-23 11:01:37 -0400
add test for updating money value to NULL
r6286@hlagh (orig r7096):  caelum | 2009-07-23 14:09:26 -0400
add money type tests to dbd::sybase+mssql tests

15 years agoadd money type tests to dbd::sybase+mssql tests
Rafael Kitover [Thu, 23 Jul 2009 18:09:26 +0000]
add money type tests to dbd::sybase+mssql tests

15 years agoadd test for updating money value to NULL
Rafael Kitover [Thu, 23 Jul 2009 15:01:37 +0000]
add test for updating money value to NULL

15 years agominor change
Rafael Kitover [Thu, 23 Jul 2009 14:34:06 +0000]
minor change

15 years agofix money columns
Rafael Kitover [Thu, 23 Jul 2009 14:31:08 +0000]
fix money columns

15 years agoadd test
Rafael Kitover [Thu, 23 Jul 2009 12:34:01 +0000]
add test

15 years agoLazy folks do not run the whole test suite before merging >:(
Peter Rabbitson [Wed, 22 Jul 2009 01:50:57 +0000]
Lazy folks do not run the whole test suite before merging >:(

15 years agoshow Oracle datetime_setup alter session statements in debug output
Rafael Kitover [Tue, 21 Jul 2009 16:16:34 +0000]
show Oracle datetime_setup alter session statements in debug output

15 years agoupdate Storage::Replicated prereqs
Rafael Kitover [Tue, 21 Jul 2009 14:51:55 +0000]
update Storage::Replicated prereqs

15 years agoFixing what my svk client screwed up.
Norbert Buchmuller [Tue, 21 Jul 2009 15:06:05 +0000]
Fixing what my svk client screwed up.

15 years agoFixed 'typo' (removed a word that I left there by accident).
Norbert Buchmuller [Tue, 21 Jul 2009 06:05:18 +0000]
Fixed 'typo' (removed a word that I left there by accident).

15 years agoFixed documentation and added test for the "Arbitrary SQL through a custom ResultSour...
Norbert Buchmuller [Tue, 21 Jul 2009 05:58:12 +0000]
Fixed documentation and added test for the "Arbitrary SQL through a custom ResultSource" Cookbook alternate (subclassing) recipe.

15 years ago(no commit message)
Norbert Buchmuller [Mon, 20 Jul 2009 22:59:30 +0000]

15 years agoFix POD changes from r7040.
Tom Hukins [Mon, 20 Jul 2009 16:20:37 +0000]
Fix POD changes from r7040.

15 years agoMinor POD grammar: it's -> its where appropriate
Dan Dascalescu [Fri, 17 Jul 2009 01:37:28 +0000]
Minor POD grammar: it's -> its where appropriate

15 years agoincreased Moose version requirements due to changes in the way type constraints get...
John Napiorkowski [Thu, 16 Jul 2009 15:03:32 +0000]
increased Moose version requirements due to changes in the way type constraints get validated, which is not backwardly compatible

15 years agoMerge 'new_replication_transaction_fixup' into 'trunk'
Peter Rabbitson [Thu, 16 Jul 2009 04:29:41 +0000]
Merge 'new_replication_transaction_fixup' into 'trunk'

15 years agoA couple of typos, and general whitespace cleanup (ick)
Peter Rabbitson [Thu, 16 Jul 2009 04:28:44 +0000]
A couple of typos, and general whitespace cleanup (ick)

15 years agoadd "smalldatetime" support to IC::DT
Rafael Kitover [Wed, 15 Jul 2009 22:54:22 +0000]
add "smalldatetime" support to IC::DT

15 years agoAdded SQLA link for more comprehensive documentation of order_by options available
Ian Wells [Wed, 15 Jul 2009 16:55:35 +0000]
Added SQLA link for more comprehensive documentation of order_by options available

15 years agoMerge 'trunk' into 'new_replication_transaction_fixup'
Rob Kinyon [Tue, 14 Jul 2009 17:50:28 +0000]
Merge 'trunk' into 'new_replication_transaction_fixup'

r7028@rkinyon-lt-osx (orig r7027):  caelum | 2009-07-10 17:56:57 -0400
fix PodInherit call in Makefile.PL
r7030@rkinyon-lt-osx (orig r7029):  robkinyon | 2009-07-10 18:03:07 -0400
Applied patch from kados regarding use of a DateTime::Format class to validate
r7031@rkinyon-lt-osx (orig r7030):  caelum | 2009-07-11 05:26:40 -0400
reword IC::DT doc patch
r7038@rkinyon-lt-osx (orig r7037):  dandv | 2009-07-13 08:06:08 -0400
PK::Auto has moved into Core since 2007
r7039@rkinyon-lt-osx (orig r7038):  dandv | 2009-07-13 08:15:13 -0400
Fixed has_many example in Intro.pod
r7040@rkinyon-lt-osx (orig r7039):  dandv | 2009-07-13 16:58:45 -0400
Fixed run-on sentences in FAQ
r7041@rkinyon-lt-osx (orig r7040):  dandv | 2009-07-13 17:18:11 -0400
Minor POD fixes in Example.pod
r7042@rkinyon-lt-osx (orig r7041):  dandv | 2009-07-13 17:48:18 -0400
Favored using ->single to get the topmost result over less readable ->slice(0)
r7043@rkinyon-lt-osx (orig r7042):  dandv | 2009-07-13 18:56:31 -0400
Minor POD fixes in Cookbook
r7046@rkinyon-lt-osx (orig r7045):  ribasushi | 2009-07-14 07:30:55 -0400
Minor logic cleanup
r7047@rkinyon-lt-osx (orig r7046):  ribasushi | 2009-07-14 08:07:11 -0400
grouped prefetch fix

15 years agogrouped prefetch fix
Peter Rabbitson [Tue, 14 Jul 2009 12:07:11 +0000]
grouped prefetch fix

15 years agoMinor logic cleanup
Peter Rabbitson [Tue, 14 Jul 2009 11:30:55 +0000]
Minor logic cleanup

15 years agoMinor POD fixes in Cookbook
Dan Dascalescu [Mon, 13 Jul 2009 22:56:31 +0000]
Minor POD fixes in Cookbook

15 years agoFavored using ->single to get the topmost result over less readable ->slice(0)
Dan Dascalescu [Mon, 13 Jul 2009 21:48:18 +0000]
Favored using ->single to get the topmost result over less readable ->slice(0)

15 years agoMinor POD fixes in Example.pod
Dan Dascalescu [Mon, 13 Jul 2009 21:18:11 +0000]
Minor POD fixes in Example.pod

15 years agoFixed run-on sentences in FAQ
Dan Dascalescu [Mon, 13 Jul 2009 20:58:45 +0000]
Fixed run-on sentences in FAQ

15 years agoFixed has_many example in Intro.pod
Dan Dascalescu [Mon, 13 Jul 2009 12:15:13 +0000]
Fixed has_many example in Intro.pod

15 years agoPK::Auto has moved into Core since 2007
Dan Dascalescu [Mon, 13 Jul 2009 12:06:08 +0000]
PK::Auto has moved into Core since 2007

15 years agoreword IC::DT doc patch
Rafael Kitover [Sat, 11 Jul 2009 09:26:40 +0000]
reword IC::DT doc patch

15 years agoApplied patch from kados regarding use of a DateTime::Format class to validate
Rob Kinyon [Fri, 10 Jul 2009 22:03:07 +0000]
Applied patch from kados regarding use of a DateTime::Format class to validate

15 years agofix PodInherit call in Makefile.PL
Rafael Kitover [Fri, 10 Jul 2009 21:56:57 +0000]
fix PodInherit call in Makefile.PL

15 years agoa few more Moose Type related fixes and added diag to the replication test to report...
John Napiorkowski [Fri, 10 Jul 2009 17:37:53 +0000]
a few more Moose Type related fixes and added diag to the replication test to report the moose and types version used, to help us debug some of the moose related errors being reported

15 years agoupdated Changes file to reflect work completed
John Napiorkowski [Fri, 10 Jul 2009 17:10:57 +0000]
updated Changes file to reflect work completed

15 years agopod cleanup, fixed broken pod links, and new Introduction pod
John Napiorkowski [Fri, 10 Jul 2009 16:00:38 +0000]
pod cleanup, fixed broken pod links, and new Introduction pod

15 years agosome documention updates and changed the way we find paths for the sqlite dbfiles...
John Napiorkowski [Thu, 9 Jul 2009 23:23:07 +0000]
some documention updates and changed the way we find paths for the sqlite dbfiles to use File::Spec, which I hope will solve some of the Win32 error messages

15 years agofixed test resultclass formatting, added a few more DBIC::Storage::DBI methods that...
John Napiorkowski [Thu, 9 Jul 2009 21:52:22 +0000]
fixed test resultclass formatting, added a few more DBIC::Storage::DBI methods that I might need to delegate.

15 years agocorrected the number of skipped tests
John Napiorkowski [Thu, 9 Jul 2009 21:26:59 +0000]
corrected the number of skipped tests

15 years agoset correct number of tests, changed the debuggin output to not warn on DDL, minor...
John Napiorkowski [Thu, 9 Jul 2009 21:23:37 +0000]
set correct number of tests, changed the debuggin output to not warn on DDL, minor change to a test resultclass so we can deploy to mysql properly

15 years agobig update to the test suite so that we now check to make sure the storage that was...
John Napiorkowski [Thu, 9 Jul 2009 20:26:47 +0000]
big update to the test suite so that we now check to make sure the storage that was expected was actually used

15 years agomore changes to the way debug output works
John Napiorkowski [Thu, 9 Jul 2009 18:17:03 +0000]
more changes to the way debug output works

15 years agochanged the way transactions are detected for replication to work with the standard...
John Napiorkowski [Thu, 9 Jul 2009 18:06:44 +0000]
changed the way transactions are detected for replication to work with the standard way to do this, minor doc updates, fix to the force pool so you can force a particular slave, changes to the way the debugging is created

15 years agoMerge '0.08108_prerelease_please_do_not_pull_into_it' into 'trunk'
Peter Rabbitson [Mon, 6 Jul 2009 06:12:57 +0000]
Merge '0.08108_prerelease_please_do_not_pull_into_it' into 'trunk'

r6995@Thesaurus (orig r6994):  ribasushi | 2009-07-06 01:12:57 +0200
Where 08108 will come from

15 years agoWhere 08108 will come from
Peter Rabbitson [Sun, 5 Jul 2009 23:12:57 +0000]
Where 08108 will come from

15 years agoPut Pod::Inherit stuff back after proper copy
Peter Rabbitson [Sun, 5 Jul 2009 23:10:22 +0000]
Put Pod::Inherit stuff back after proper copy

15 years agoTemporarily backout Pod::Inherit changes
Peter Rabbitson [Sun, 5 Jul 2009 23:07:05 +0000]
Temporarily backout Pod::Inherit changes

15 years agoForgotten pod exclusions
Peter Rabbitson [Sun, 5 Jul 2009 22:55:36 +0000]
Forgotten pod exclusions

15 years agoCouple of makefile fixes:
Peter Rabbitson [Sun, 5 Jul 2009 22:06:52 +0000]
Couple of makefile fixes:
use is compile time, use require
recommends is for distro maintainers only, push the dependency into the authors hash (it is not to be executed by mere mortals)

15 years agoAdded Pod::Inherit use to Makefile.PL at author-time, comments/suggestions as to...
Jess Robinson [Sun, 5 Jul 2009 20:00:55 +0000]
Added Pod::Inherit use to Makefile.PL at author-time, comments/suggestions as to whether its too "noisy" welcome.

15 years agotodos are shorter now
Peter Rabbitson [Sat, 4 Jul 2009 11:09:39 +0000]
todos are shorter now

15 years agoFix POD
Peter Rabbitson [Sat, 4 Jul 2009 10:40:47 +0000]
Fix POD

15 years agotypo
Peter Rabbitson [Sat, 4 Jul 2009 10:11:18 +0000]
typo

15 years agoMissing newline
Peter Rabbitson [Sat, 4 Jul 2009 10:08:16 +0000]
Missing newline

15 years agoBackout mysql changes for further polishing
Peter Rabbitson [Sat, 4 Jul 2009 09:45:24 +0000]
Backout mysql changes for further polishing

15 years agoAdd set_ansi_mode POD
Peter Rabbitson [Sat, 4 Jul 2009 09:37:25 +0000]
Add set_ansi_mode POD

15 years agoHide devel documentation from the indexer
Peter Rabbitson [Sat, 4 Jul 2009 09:34:08 +0000]
Hide devel documentation from the indexer

15 years agoMerge 'mssql_top_fixes' into 'trunk'
Peter Rabbitson [Fri, 3 Jul 2009 18:20:42 +0000]
Merge 'mssql_top_fixes' into 'trunk'

r6554@Thesaurus (orig r6553):  frew | 2009-06-09 00:06:42 +0200
branch for mssql top issues
r6572@Thesaurus (orig r6571):  frew | 2009-06-09 23:18:46 +0200
more tests for SQL Server!
r6573@Thesaurus (orig r6572):  frew | 2009-06-09 23:49:10 +0200
Added AmbiguousGlob.pm for silly servers like mssql and mysql.  See docs for more info
r6574@Thesaurus (orig r6573):  frew | 2009-06-09 23:55:22 +0200
fix plan
r6602@Thesaurus (orig r6601):  frew | 2009-06-10 17:03:30 +0200
more failing tests
r6608@Thesaurus (orig r6607):  frew | 2009-06-10 20:05:53 +0200
don't use eval!
r6610@Thesaurus (orig r6609):  frew | 2009-06-10 20:07:49 +0200
beginning of DWIM for IDENTITY_INSERT
r6628@Thesaurus (orig r6627):  frew | 2009-06-11 18:13:02 +0200
still busted :-(
r6631@Thesaurus (orig r6630):  frew | 2009-06-11 19:39:00 +0200
general function to go from column names and ident to result source
r6632@Thesaurus (orig r6631):  frew | 2009-06-11 19:40:11 +0200
Use new _resolve_column_sources method and begin insert_bulk method
r6635@Thesaurus (orig r6634):  frew | 2009-06-11 20:12:38 +0200
updated _resolve_column_source to _resolve_column_info as per ribasushi's suggestion
r6650@Thesaurus (orig r6649):  frew | 2009-06-12 17:13:32 +0200
Now I just need to check if the actual values are set...
r6651@Thesaurus (orig r6650):  frew | 2009-06-12 17:26:53 +0200
Insert Identity works!
r6652@Thesaurus (orig r6651):  frew | 2009-06-12 17:34:13 +0200
silly warns.
r6684@Thesaurus (orig r6683):  frew | 2009-06-15 16:49:00 +0200
failing test
r6686@Thesaurus (orig r6685):  ribasushi | 2009-06-15 18:10:26 +0200
make all resolved attrs visible to sqla
r6698@Thesaurus (orig r6697):  ribasushi | 2009-06-17 02:31:37 +0200
Half way working stuff, needs a LOT of tweaking still
r6729@Thesaurus (orig r6728):  ribasushi | 2009-06-19 19:49:27 +0200
Merge badness
r6730@Thesaurus (orig r6729):  ribasushi | 2009-06-19 19:49:40 +0200
fix eol
r6731@Thesaurus (orig r6730):  ribasushi | 2009-06-19 19:55:47 +0200
augment inheritance
r6735@Thesaurus (orig r6734):  ribasushi | 2009-06-20 10:34:42 +0200
Maybe I've nailed it
r6746@Thesaurus (orig r6745):  ribasushi | 2009-06-20 23:53:55 +0200
Test and merge fixes
r6747@Thesaurus (orig r6746):  ribasushi | 2009-06-21 00:01:09 +0200
Really fix tests
r6748@Thesaurus (orig r6747):  ribasushi | 2009-06-21 00:01:54 +0200
Really fix tests
r6749@Thesaurus (orig r6748):  ribasushi | 2009-06-21 00:18:33 +0200
Now really final
r6750@Thesaurus (orig r6749):  ribasushi | 2009-06-21 00:22:23 +0200
whoops
r6751@Thesaurus (orig r6750):  ribasushi | 2009-06-21 00:42:18 +0200
That should be all
r6752@Thesaurus (orig r6751):  ribasushi | 2009-06-21 08:54:00 +0200
Make sure quoting works
r6755@Thesaurus (orig r6754):  ribasushi | 2009-06-21 15:21:23 +0200
Groundwork for sanification of the toplimit test
r6863@Thesaurus (orig r6862):  ribasushi | 2009-06-30 01:13:49 +0200
Make sure storage classes use c3, just like the rest of dbic (tested on 5.8 as well)
r6869@Thesaurus (orig r6868):  ribasushi | 2009-06-30 09:53:27 +0200
Some fixes after review
r6874@Thesaurus (orig r6873):  ribasushi | 2009-06-30 11:54:34 +0200
Fix borked next invocation
r6896@Thesaurus (orig r6895):  frew | 2009-06-30 21:38:26 +0200
silly misspells and trailing whitespace
r6955@Thesaurus (orig r6954):  ribasushi | 2009-07-03 01:21:28 +0200
Some hack consolidation
r6962@Thesaurus (orig r6961):  ribasushi | 2009-07-03 12:06:57 +0200
Fix some mssql shortcommings when confronted with the new subequeried prefetch sql
r6963@Thesaurus (orig r6962):  ribasushi | 2009-07-03 12:47:57 +0200
Ask for newer DBD::Pg in author mode, suggest the newer version otherwise (proper array support). Make test more resilient as well
r6964@Thesaurus (orig r6963):  ribasushi | 2009-07-03 12:49:16 +0200
Switch to C3 mro throughout the ::Storage hierarchy (DBIx::Class brings in MRO::Compat, and all ::Storage's are based on it, tested on 5.8
r6969@Thesaurus (orig r6968):  ribasushi | 2009-07-03 19:54:04 +0200
Duh
r6970@Thesaurus (orig r6969):  frew | 2009-07-03 19:59:48 +0200
fix tests for new codez
r6971@Thesaurus (orig r6970):  ribasushi | 2009-07-03 20:18:53 +0200
detabify
r6972@Thesaurus (orig r6971):  ribasushi | 2009-07-03 20:20:07 +0200
changes

15 years agochanges
Peter Rabbitson [Fri, 3 Jul 2009 18:20:07 +0000]
changes

15 years agodetabify
Peter Rabbitson [Fri, 3 Jul 2009 18:18:53 +0000]
detabify

15 years agofix tests for new codez
Arthur Axel "fREW" Schmidt [Fri, 3 Jul 2009 17:59:48 +0000]
fix tests for new codez

15 years agoDuh
Peter Rabbitson [Fri, 3 Jul 2009 17:54:04 +0000]
Duh

15 years agoExtra test to demonstrate has_one working, and a POD clarification of multicreate
Peter Rabbitson [Fri, 3 Jul 2009 14:36:32 +0000]
Extra test to demonstrate has_one working, and a POD clarification of multicreate

15 years agoDouble an existing might_have test as has_one
Peter Rabbitson [Fri, 3 Jul 2009 13:07:49 +0000]
Double an existing might_have test as has_one

15 years agoCapitalize mysql commands
Peter Rabbitson [Fri, 3 Jul 2009 11:37:06 +0000]
Capitalize mysql commands

15 years agoAdd set_ansi_mode on_connect_call for mysql
Peter Rabbitson [Fri, 3 Jul 2009 11:19:27 +0000]
Add set_ansi_mode on_connect_call for mysql
Also switch to _do_query instead of plain dbh->do (shows up in the trace)

15 years agoSwitch to C3 mro throughout the ::Storage hierarchy (DBIx::Class brings in MRO::Compa...
Peter Rabbitson [Fri, 3 Jul 2009 10:49:16 +0000]
Switch to C3 mro throughout the ::Storage hierarchy (DBIx::Class brings in MRO::Compat, and all ::Storage's are based on it, tested on 5.8

15 years agoAsk for newer DBD::Pg in author mode, suggest the newer version otherwise (proper...
Peter Rabbitson [Fri, 3 Jul 2009 10:47:57 +0000]
Ask for newer DBD::Pg in author mode, suggest the newer version otherwise (proper array support). Make test more resilient as well

15 years agoFix some mssql shortcommings when confronted with the new subequeried prefetch sql
Peter Rabbitson [Fri, 3 Jul 2009 10:06:57 +0000]
Fix some mssql shortcommings when confronted with the new subequeried prefetch sql

15 years agoSome hack consolidation
Peter Rabbitson [Thu, 2 Jul 2009 23:21:28 +0000]
Some hack consolidation

15 years agoMerge 'trunk' into 'mssql_top_fixes'
Peter Rabbitson [Thu, 2 Jul 2009 22:24:00 +0000]
Merge 'trunk' into 'mssql_top_fixes'

r6932@Thesaurus (orig r6931):  ribasushi | 2009-07-02 08:08:33 +0200
Another candidate for somethingawful.com (fix left join-ed count)
r6934@Thesaurus (orig r6933):  ribasushi | 2009-07-02 09:04:13 +0200
Changelog
r6935@Thesaurus (orig r6934):  ribasushi | 2009-07-02 11:23:48 +0200
cleanup
r6936@Thesaurus (orig r6935):  ijw | 2009-07-02 12:41:01 +0200
Check fetched rows == count for related resultsets
r6937@Thesaurus (orig r6936):  ijw | 2009-07-02 12:43:47 +0200
Confirm prefetch doesn't affect main row fetch, and main row fetch works with and without counting
r6938@Thesaurus (orig r6937):  ribasushi | 2009-07-02 12:52:51 +0200
More fail (fix is known but needs work)
r6939@Thesaurus (orig r6938):  ribasushi | 2009-07-02 13:07:22 +0200
And more fail
r6940@Thesaurus (orig r6939):  ribasushi | 2009-07-02 13:16:46 +0200
These tests are in prefetch/count.t
r6941@Thesaurus (orig r6940):  ribasushi | 2009-07-02 13:38:31 +0200
cleanup
r6942@Thesaurus (orig r6941):  ribasushi | 2009-07-02 13:38:49 +0200
Solve more prefetch inflation crap
r6943@Thesaurus (orig r6942):  ribasushi | 2009-07-02 13:47:41 +0200
Make the code readable
r6944@Thesaurus (orig r6943):  ribasushi | 2009-07-02 15:52:35 +0200
Everything works, just need to fix join-path chaining over search_related (to guard against obscure db quirks)
r6946@Thesaurus (orig r6945):  caelum | 2009-07-02 21:06:32 +0200
add sybase reconnect test
r6948@Thesaurus (orig r6947):  ribasushi | 2009-07-02 22:20:21 +0200
Last part of the join handling puzzle
r6951@Thesaurus (orig r6950):  ribasushi | 2009-07-03 00:14:50 +0200
 r6360@Thesaurus (orig r6359):  arcanez | 2009-05-21 20:18:52 +0200
 branch to work on prefetch/select
 r6361@Thesaurus (orig r6360):  arcanez | 2009-05-21 20:32:46 +0200
 failing test
 r6373@Thesaurus (orig r6372):  ribasushi | 2009-05-22 11:07:26 +0200
 Simplify unresolvable test by arcanez
 r6905@Thesaurus (orig r6904):  ribasushi | 2009-07-01 12:54:03 +0200
 Extend test
 r6950@Thesaurus (orig r6949):  ribasushi | 2009-07-03 00:14:09 +0200
 Apparent fix - simply delay the in_storage flagging of the main object until all prefetched objects are inflated. The rest of the changes are just cosmetics, preparing for the collapse_result rewrite

r6953@Thesaurus (orig r6952):  ribasushi | 2009-07-03 00:17:22 +0200
Changes

15 years agoChanges
Peter Rabbitson [Thu, 2 Jul 2009 22:17:22 +0000]
Changes

15 years agoMerge 'unresolvable_prefetch' into 'trunk'
Peter Rabbitson [Thu, 2 Jul 2009 22:14:50 +0000]
Merge 'unresolvable_prefetch' into 'trunk'

r6360@Thesaurus (orig r6359):  arcanez | 2009-05-21 20:18:52 +0200
branch to work on prefetch/select
r6361@Thesaurus (orig r6360):  arcanez | 2009-05-21 20:32:46 +0200
failing test
r6373@Thesaurus (orig r6372):  ribasushi | 2009-05-22 11:07:26 +0200
Simplify unresolvable test by arcanez
r6905@Thesaurus (orig r6904):  ribasushi | 2009-07-01 12:54:03 +0200
Extend test
r6950@Thesaurus (orig r6949):  ribasushi | 2009-07-03 00:14:09 +0200
Apparent fix - simply delay the in_storage flagging of the main object until all prefetched objects are inflated. The rest of the changes are just cosmetics, preparing for the collapse_result rewrite

15 years agoApparent fix - simply delay the in_storage flagging of the main object until all...
Peter Rabbitson [Thu, 2 Jul 2009 22:14:09 +0000]
Apparent fix - simply delay the in_storage flagging of the main object until all prefetched objects are inflated. The rest of the changes are just cosmetics, preparing for the collapse_result rewrite

15 years agoMerge 'trunk' into 'unresolvable_prefetch'
Peter Rabbitson [Thu, 2 Jul 2009 20:55:02 +0000]
Merge 'trunk' into 'unresolvable_prefetch'

r6910@Thesaurus (orig r6909):  ribasushi | 2009-07-01 13:27:15 +0200
Optimize set_column on uninserted objects
r6921@Thesaurus (orig r6920):  caelum | 2009-07-01 17:40:32 +0200
 r5859@hlagh (orig r6912):  caelum | 2009-07-01 06:21:30 -0700
 new connected() for dbd::sybase users
 r5860@hlagh (orig r6913):  caelum | 2009-07-01 06:25:46 -0700
 add a couple of dbd::sybase reconnection tests
 r5861@hlagh (orig r6914):  caelum | 2009-07-01 06:35:07 -0700
 better connection test
 r5862@hlagh (orig r6915):  caelum | 2009-07-01 06:45:05 -0700
 use dbh->do for connected instead of prepare_cached
 r5863@hlagh (orig r6916):  ribasushi | 2009-07-01 06:55:21 -0700
 Segfault
 r5864@hlagh (orig r6917):  caelum | 2009-07-01 07:03:22 -0700
 use ->do instead of ->prepare_cached in oracle's connected() too
 r5865@hlagh (orig r6918):  caelum | 2009-07-01 08:20:52 -0700
 fix segfault with old DBD::Sybase
 r5866@hlagh (orig r6919):  caelum | 2009-07-01 08:39:18 -0700
 move connection tests into _ping()

r6924@Thesaurus (orig r6923):  ijw | 2009-07-01 19:34:32 +0200
Added a test for a resultset to related-resultset join for 0 related records
r6928@Thesaurus (orig r6927):  ijw | 2009-07-01 20:04:16 +0200
Additional tests on prefetch - illustrates the bug with left-join has_many (NULL row returned) and the one that results from the trivial fix (prefetch gives no artist)
r6932@Thesaurus (orig r6931):  ribasushi | 2009-07-02 08:08:33 +0200
Another candidate for somethingawful.com (fix left join-ed count)
r6934@Thesaurus (orig r6933):  ribasushi | 2009-07-02 09:04:13 +0200
Changelog
r6935@Thesaurus (orig r6934):  ribasushi | 2009-07-02 11:23:48 +0200
cleanup
r6936@Thesaurus (orig r6935):  ijw | 2009-07-02 12:41:01 +0200
Check fetched rows == count for related resultsets
r6937@Thesaurus (orig r6936):  ijw | 2009-07-02 12:43:47 +0200
Confirm prefetch doesn't affect main row fetch, and main row fetch works with and without counting
r6938@Thesaurus (orig r6937):  ribasushi | 2009-07-02 12:52:51 +0200
More fail (fix is known but needs work)
r6939@Thesaurus (orig r6938):  ribasushi | 2009-07-02 13:07:22 +0200
And more fail
r6940@Thesaurus (orig r6939):  ribasushi | 2009-07-02 13:16:46 +0200
These tests are in prefetch/count.t
r6941@Thesaurus (orig r6940):  ribasushi | 2009-07-02 13:38:31 +0200
cleanup
r6942@Thesaurus (orig r6941):  ribasushi | 2009-07-02 13:38:49 +0200
Solve more prefetch inflation crap
r6943@Thesaurus (orig r6942):  ribasushi | 2009-07-02 13:47:41 +0200
Make the code readable
r6944@Thesaurus (orig r6943):  ribasushi | 2009-07-02 15:52:35 +0200
Everything works, just need to fix join-path chaining over search_related (to guard against obscure db quirks)
r6946@Thesaurus (orig r6945):  caelum | 2009-07-02 21:06:32 +0200
add sybase reconnect test
r6948@Thesaurus (orig r6947):  ribasushi | 2009-07-02 22:20:21 +0200
Last part of the join handling puzzle

15 years agoLast part of the join handling puzzle
Peter Rabbitson [Thu, 2 Jul 2009 20:20:21 +0000]
Last part of the join handling puzzle

15 years agoadd sybase reconnect test
Rafael Kitover [Thu, 2 Jul 2009 19:06:32 +0000]
add sybase reconnect test

15 years agoEverything works, just need to fix join-path chaining over search_related (to guard...
Peter Rabbitson [Thu, 2 Jul 2009 13:52:35 +0000]
Everything works, just need to fix join-path chaining over search_related (to guard against obscure db quirks)

15 years agoMake the code readable
Peter Rabbitson [Thu, 2 Jul 2009 11:47:41 +0000]
Make the code readable

15 years agoSolve more prefetch inflation crap
Peter Rabbitson [Thu, 2 Jul 2009 11:38:49 +0000]
Solve more prefetch inflation crap

15 years agocleanup
Peter Rabbitson [Thu, 2 Jul 2009 11:38:31 +0000]
cleanup

15 years agoThese tests are in prefetch/count.t
Peter Rabbitson [Thu, 2 Jul 2009 11:16:46 +0000]
These tests are in prefetch/count.t

15 years agoAnd more fail
Peter Rabbitson [Thu, 2 Jul 2009 11:07:22 +0000]
And more fail

15 years agoMore fail (fix is known but needs work)
Peter Rabbitson [Thu, 2 Jul 2009 10:52:51 +0000]
More fail (fix is known but needs work)

15 years agoConfirm prefetch doesn't affect main row fetch, and main row fetch works with and...
Ian Wells [Thu, 2 Jul 2009 10:43:47 +0000]
Confirm prefetch doesn't affect main row fetch, and main row fetch works with and without counting

15 years agoCheck fetched rows == count for related resultsets
Ian Wells [Thu, 2 Jul 2009 10:41:01 +0000]
Check fetched rows == count for related resultsets

15 years agocleanup
Peter Rabbitson [Thu, 2 Jul 2009 09:23:48 +0000]
cleanup

15 years agoChangelog
Peter Rabbitson [Thu, 2 Jul 2009 07:04:13 +0000]
Changelog

15 years agoAnother candidate for somethingawful.com (fix left join-ed count)
Peter Rabbitson [Thu, 2 Jul 2009 06:08:33 +0000]
Another candidate for somethingawful.com (fix left join-ed count)

15 years agoMerge 'trunk' into 'mssql_top_fixes'
Peter Rabbitson [Thu, 2 Jul 2009 05:43:30 +0000]
Merge 'trunk' into 'mssql_top_fixes'

r6875@Thesaurus (orig r6874):  ribasushi | 2009-06-30 12:39:06 +0200
Allow broken resultsource-class-derived objects to still work
r6876@Thesaurus (orig r6875):  ribasushi | 2009-06-30 12:40:46 +0200
clarify
r6878@Thesaurus (orig r6877):  ash | 2009-06-30 13:48:13 +0200
Update POD on Dynamic sub-classing

r6883@Thesaurus (orig r6882):  ribasushi | 2009-06-30 17:36:38 +0200
 r6815@Thesaurus (orig r6814):  ribasushi | 2009-06-28 10:32:42 +0200
 Branch to explore double joins on search_related
 r6816@Thesaurus (orig r6815):  ribasushi | 2009-06-28 10:34:16 +0200
 Thetest case that started it all
 r6817@Thesaurus (orig r6816):  ribasushi | 2009-06-28 10:35:11 +0200
 The proposed fix (do not add an extra join if it is already present in the topmost join)
 r6818@Thesaurus (orig r6817):  ribasushi | 2009-06-28 11:04:26 +0200
 Minor omission
 r6819@Thesaurus (orig r6818):  ribasushi | 2009-06-28 11:07:33 +0200
 Adjust a couple of tests for new behavior (thus all of this might be backwards incompatible to the point of being useless):
 The counts in t/90join_torture.t are now 5*3, not 5*3*3, as a second join is not induced by search_related
 The raw sql scan in t/prefetch/standard.t is just silly, won't even try to understand it
 Just to maintain the TreeLike folding, I add a 3rd children join which was inserted by search_related before the code changes

r6889@Thesaurus (orig r6888):  ribasushi | 2009-06-30 19:36:11 +0200
Todoify test for now
r6890@Thesaurus (orig r6889):  ribasushi | 2009-06-30 19:37:05 +0200
Todoify test for now (2)
r6892@Thesaurus (orig r6891):  ribasushi | 2009-06-30 19:52:31 +0200
Todoify test for now (3)
r6903@Thesaurus (orig r6902):  ribasushi | 2009-07-01 08:46:12 +0200
Fixed deadlock test
r6904@Thesaurus (orig r6903):  ribasushi | 2009-07-01 12:22:00 +0200
Clarify exception text
r6907@Thesaurus (orig r6906):  ribasushi | 2009-07-01 13:23:46 +0200
 r6821@Thesaurus (orig r6820):  ribasushi | 2009-06-28 13:09:11 +0200
 Branch for prefetch+group play
 r6823@Thesaurus (orig r6822):  ribasushi | 2009-06-28 14:38:36 +0200
 Normalize group_by
 r6824@Thesaurus (orig r6823):  ribasushi | 2009-06-28 14:39:54 +0200
 Proper prefetch+group test
 r6826@Thesaurus (orig r6825):  ribasushi | 2009-06-28 14:42:48 +0200
 Whoops
 r6828@Thesaurus (orig r6827):  ribasushi | 2009-06-28 15:06:57 +0200
 Lose the literal sql bits - castaway is right it's silly to support those
 r6833@Thesaurus (orig r6832):  ribasushi | 2009-06-28 22:38:43 +0200
 Rogue comments
 r6837@Thesaurus (orig r6836):  ribasushi | 2009-06-29 09:44:25 +0200
 A couple of test fixes
 r6838@Thesaurus (orig r6837):  ribasushi | 2009-06-29 09:46:13 +0200
 Support for -select/-as in SQLAHacks field selection
 r6839@Thesaurus (orig r6838):  ribasushi | 2009-06-29 09:49:53 +0200
 This is tested elsewhere
 r6840@Thesaurus (orig r6839):  ribasushi | 2009-06-29 09:50:43 +0200
 This is tested elsewhere (2)
 r6841@Thesaurus (orig r6840):  ribasushi | 2009-06-29 10:07:09 +0200
 Test cleanups
 r6842@Thesaurus (orig r6841):  ribasushi | 2009-06-29 10:11:13 +0200
 Most of the grouped prefetch solution
 r6843@Thesaurus (orig r6842):  ribasushi | 2009-06-29 10:14:45 +0200
 clearer
 r6845@Thesaurus (orig r6844):  ribasushi | 2009-06-29 12:05:37 +0200
 And score! (all works)
 r6882@Thesaurus (orig r6881):  ribasushi | 2009-06-30 16:23:06 +0200
 rs->get_column now properly recognizes prefetch and collapses if at all possible
 r6886@Thesaurus (orig r6885):  ribasushi | 2009-06-30 17:39:58 +0200
 Whoops

r6910@Thesaurus (orig r6909):  ribasushi | 2009-07-01 13:27:15 +0200
Optimize set_column on uninserted objects
r6921@Thesaurus (orig r6920):  caelum | 2009-07-01 17:40:32 +0200
 r5859@hlagh (orig r6912):  caelum | 2009-07-01 06:21:30 -0700
 new connected() for dbd::sybase users
 r5860@hlagh (orig r6913):  caelum | 2009-07-01 06:25:46 -0700
 add a couple of dbd::sybase reconnection tests
 r5861@hlagh (orig r6914):  caelum | 2009-07-01 06:35:07 -0700
 better connection test
 r5862@hlagh (orig r6915):  caelum | 2009-07-01 06:45:05 -0700
 use dbh->do for connected instead of prepare_cached
 r5863@hlagh (orig r6916):  ribasushi | 2009-07-01 06:55:21 -0700
 Segfault
 r5864@hlagh (orig r6917):  caelum | 2009-07-01 07:03:22 -0700
 use ->do instead of ->prepare_cached in oracle's connected() too
 r5865@hlagh (orig r6918):  caelum | 2009-07-01 08:20:52 -0700
 fix segfault with old DBD::Sybase
 r5866@hlagh (orig r6919):  caelum | 2009-07-01 08:39:18 -0700
 move connection tests into _ping()

r6924@Thesaurus (orig r6923):  ijw | 2009-07-01 19:34:32 +0200
Added a test for a resultset to related-resultset join for 0 related records
r6928@Thesaurus (orig r6927):  ijw | 2009-07-01 20:04:16 +0200
Additional tests on prefetch - illustrates the bug with left-join has_many (NULL row returned) and the one that results from the trivial fix (prefetch gives no artist)