4 years agoadd -nest to hashpair expansion
Matt S Trout [Mon, 3 Sep 2018 21:50:36 +0000]
add -nest to hashpair expansion

4 years agohashpair expansion - defaulting to $self->{cmp}
Matt S Trout [Mon, 3 Sep 2018 21:34:47 +0000]
hashpair expansion - defaulting to $self->{cmp}

4 years agoexpression expansion pass, zeroth cut
Matt S Trout [Mon, 3 Sep 2018 21:13:36 +0000]
expression expansion pass, zeroth cut

4 years agoremove another special case IS NULL rendering
Matt S Trout [Sun, 2 Sep 2018 20:45:37 +0000]
remove another special case IS NULL rendering

4 years agomake undef value use is operator
Matt S Trout [Sun, 2 Sep 2018 20:28:52 +0000]
make undef value use is operator

4 years agoexplicit defaulting of scalar-rhs hashpair
Matt S Trout [Sun, 2 Sep 2018 20:23:57 +0000]
explicit defaulting of scalar-rhs hashpair

4 years agoRelease commit for 1.87 v1.87
Dagfinn Ilmari Mannsåker [Tue, 2 Jun 2020 10:36:30 +0000]
Release commit for 1.87

4 years agoBumping version to 1.87
Dagfinn Ilmari Mannsåker [Tue, 2 Jun 2020 10:32:51 +0000]
Bumping version to 1.87

4 years agoAdd a missed fallback to the package-global $tb
Dagfinn Ilmari Mannsåker [Mon, 3 Feb 2020 11:33:02 +0000]
Add a missed fallback to the package-global $tb

4 years agoRemove explicit Exporter inheritace in SQL::Abstract::Test
Dagfinn Ilmari Mannsåker [Fri, 31 Jan 2020 17:37:11 +0000]
Remove explicit Exporter inheritace in SQL::Abstract::Test

Test:::Builder::Module is documented to inherit from Exporter.

4 years agoRe-fetch the Test::Builder object in each test function
Dagfinn Ilmari Mannsåker [Fri, 31 Jan 2020 17:29:16 +0000]
Re-fetch the Test::Builder object in each test function

Rather than stashing it in a global, as recommende in the
Test::Builder::Module documentation.  However, keep the global in case
someone is overriding it despite it not being documented.

4 years agoAdd runtime dependency on Test::Deep and Test::Builder::Module (RT#131623)
Dagfinn Ilmari Mannsåker [Fri, 31 Jan 2020 11:27:38 +0000]
Add runtime dependency on Test::Deep and Test::Builder::Module (RT#131623)

They are used by SQL::Abstract::Test, and modules that test-depend on
that shouldn't have to explicitly depend on Test::Deep themselves.

4 years agoConsistently use single quotes for deps in Makefile.PL
Dagfinn Ilmari Mannsåker [Fri, 31 Jan 2020 11:18:24 +0000]
Consistently use single quotes for deps in Makefile.PL

6 years agoRelease commit for 1.86 v1.86
Dagfinn Ilmari Mannsåker [Mon, 9 Jul 2018 16:28:58 +0000]
Release commit for 1.86

6 years agoBumping version to 1.86
Dagfinn Ilmari Mannsåker [Mon, 9 Jul 2018 16:22:24 +0000]
Bumping version to 1.86

6 years agoAdd Changes entry for literal '0' WHERE fix
Dagfinn Ilmari Mannsåker [Mon, 9 Jul 2018 15:49:09 +0000]
Add Changes entry for literal '0' WHERE fix

6 years agoDo not replace the literal string '0' with ''
Fabrizio Gennari [Fri, 6 Apr 2018 08:58:30 +0000]
Do not replace the literal string '0' with ''

6 years agoAdd overloadable _select_fields method
Sebastian Riedel [Sun, 28 Jan 2018 11:34:40 +0000]
Add overloadable _select_fields method

Consistent with _update_set_values and _insert_values

6 years agoRemove spaces before colons in POD
Dagfinn Ilmari Mannsåker [Sat, 27 Jan 2018 12:08:30 +0000]
Remove spaces before colons in POD

6 years agoRemove obsolete docs for arrayrefref as select source
Dagfinn Ilmari Mannsåker [Sat, 27 Jan 2018 11:51:29 +0000]
Remove obsolete docs for arrayrefref as select source

Support for this was removed as "useless", with no Changes or
documentation update, in version 1.74 (commit
a0d6d3230359880681d5d328d6b1775c0fbe5983).

6 years agoIgnore built dist files and directories
Dagfinn Ilmari Mannsåker [Sat, 27 Jan 2018 11:29:26 +0000]
Ignore built dist files and directories

6 years agoRelease commit for 1.85 v1.85
Dagfinn Ilmari Mannsåker [Sat, 27 Jan 2018 11:15:01 +0000]
Release commit for 1.85

6 years agoBumping version to 1.85
Dagfinn Ilmari Mannsåker [Sat, 27 Jan 2018 11:10:01 +0000]
Bumping version to 1.85

6 years agoAdd Changes entry for UPDATE ... SET ... refactor
Dagfinn Ilmari Mannsåker [Sat, 27 Jan 2018 10:57:45 +0000]
Add Changes entry for UPDATE ... SET ... refactor

6 years agoRemove pointless quoting of single variables
Dagfinn Ilmari Mannsåker [Fri, 26 Jan 2018 22:59:23 +0000]
Remove pointless quoting of single variables

By moving the spaces into adjacent SQL literals

6 years agoadd reusable _update_set_values method, consistent with _insert_values
Sebastian Riedel [Fri, 26 Jan 2018 19:01:20 +0000]
add reusable _update_set_values method, consistent with _insert_values

6 years agoAdd Travis-CI config
Dagfinn Ilmari Mannsåker [Wed, 17 Jan 2018 12:01:26 +0000]
Add Travis-CI config

7 years agoSpelling errors
Xavier Guimard [Wed, 25 Oct 2017 20:37:36 +0000]
Spelling errors

7 years agoWhitespace cleanup
Dagfinn Ilmari Mannsåker [Thu, 13 Apr 2017 10:13:38 +0000]
Whitespace cleanup

7 years agoPrune pointless puke parens
Dagfinn Ilmari Mannsåker [Thu, 13 Apr 2017 10:35:48 +0000]
Prune pointless puke parens

7 years agoMake META->{no_index}->{package} an array
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 16:58:45 +0000]
Make META->{no_index}->{package} an array

CPAN::Meta::Converter fixes it, but might as well make it right from
the beginning.

7 years agoAdd modules used in author tests to develop-requires
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 15:48:03 +0000]
Add modules used in author tests to develop-requires

Also remove conditional skippage from author tests

7 years agoRestore perl version requirement missed in the Distar port
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 15:32:43 +0000]
Restore perl version requirement missed in the Distar port

7 years agoRelease commit for 1.84 v1.84
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 15:29:18 +0000]
Release commit for 1.84

7 years agoBumping version to 1.84
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 15:28:00 +0000]
Bumping version to 1.84

7 years agoRestore 'dynamic_config => 0' missed in the Distar port
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 15:27:41 +0000]
Restore 'dynamic_config => 0' missed in the Distar port

7 years agoRelease commit for 1.83 v1.83
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 15:20:15 +0000]
Release commit for 1.83

7 years agoBumping version to 1.83
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 15:16:15 +0000]
Bumping version to 1.83

7 years agoPort to Distar
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 15:16:06 +0000]
Port to Distar

7 years agoNote GitHub PR number for DELETE ... RETURNING (GH#9)
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 14:42:04 +0000]
Note GitHub PR number for DELETE ... RETURNING (GH#9)

7 years agoComment why each of the RETURNING clauses have their own method
Dagfinn Ilmari Mannsåker [Mon, 3 Apr 2017 10:25:29 +0000]
Comment why each of the RETURNING clauses have their own method

7 years agoAdd support for DELETE ... RETURNING ...
Sebastian Riedel [Mon, 20 Mar 2017 21:39:23 +0000]
Add support for DELETE ... RETURNING ...

7 years agoRelease 1.82 v1.82
Dagfinn Ilmari Mannsåker [Mon, 20 Mar 2017 17:55:06 +0000]
Release 1.82

7 years agoAlign clauses of complex ORDER BY example for readability
Dagfinn Ilmari Mannsåker [Wed, 1 Mar 2017 12:22:46 +0000]
Align clauses of complex ORDER BY example for readability

7 years agoFix syntax errors in ORDER BY docs (GH#7)
Joshua Keroes [Fri, 15 Jul 2016 21:34:48 +0000]
Fix syntax errors in ORDER BY docs (GH#7)

Missing some } characters. Had to reformat the table to make them fit.

Read under -w

7 years agoAdd explicit dependency on Sub::Quote (GH#8)
Dagfinn Ilmari Mannsåker [Wed, 1 Mar 2017 12:11:16 +0000]
Add explicit dependency on Sub::Quote (GH#8)

Sub::Quote was split out of Moo in version 2.00300, but keep the
versioned requirement the same as for Moo so we don't force people on
intermediate versions to upgrade.

7 years agoRelease 1.81_01 v1.81_01
Dagfinn Ilmari Mannsåker [Tue, 28 Feb 2017 19:09:42 +0000]
Release 1.81_01

7 years agoAdd Changes entry for ORDER BY doc improvements
Dagfinn Ilmari Mannsåker [Mon, 20 Feb 2017 12:04:17 +0000]
Add Changes entry for ORDER BY doc improvements

8 years agoDocument arrayrefref (\[...]) form for order_by
Ricardo Signes [Fri, 6 May 2016 20:36:36 +0000]
Document arrayrefref (\[...]) form for order_by

Amended by committer to also mention it and the scalarref form in the
introductory paragraph, and move the scalarref form further down the
table of examples.

8 years agoRemove pointless prototypes on methods
Dagfinn Ilmari Mannsåker [Fri, 4 Mar 2016 15:03:06 +0000]
Remove pointless prototypes on methods

8 years agoFix ->insert($table, \@values) with >26 values (RT#112684)
Dagfinn Ilmari Mannsåker [Fri, 4 Mar 2016 14:59:17 +0000]
Fix ->insert($table, \@values) with >26 values (RT#112684)

This gets rid of the cute hash key ordering hack and instead factors the
body of the loop in ->_insert_values into a separate method that the
arrayref version calls directly in the right order.

8 years agoAdd Changes entry for UPDATE ... RETURNING
Dagfinn Ilmari Mannsåker [Sat, 20 Feb 2016 15:10:54 +0000]
Add Changes entry for UPDATE ... RETURNING

8 years ago10% speedup of identifier quoting
Dagfinn Ilmari Mannsåker [Wed, 30 Dec 2015 23:49:47 +0000]
10% speedup of identifier quoting

9 years agoTeach ::Tree that ILIKE (PostgreSQL) and REGEXP (MySQL) are binary ops
Dagfinn Ilmari Mannsåker [Mon, 19 Oct 2015 10:25:53 +0000]
Teach ::Tree that ILIKE (PostgreSQL) and REGEXP (MySQL) are binary ops

9 years agoFix ORDER BY clause type in synopsis and where() header
Dagfinn Ilmari Mannsåker [Tue, 23 Jun 2015 10:32:32 +0000]
Fix ORDER BY clause type in synopsis and where() header

The ORDER BY clause can be either a string, stringref, arrayref or
hashref, so don't imply it has to be an arrayref in the docs.

9 years agoFix order clauses with bind parameters in ->where
Dagfinn Ilmari Mannsåker [Sun, 28 Jun 2015 13:32:28 +0000]
Fix order clauses with bind parameters in ->where

->where was ignoring the bind parameters returned by ->_order_by

9 years agoIgnore editor droppings
Dagfinn Ilmari Mannsåker [Tue, 7 Jul 2015 18:24:04 +0000]
Ignore editor droppings

9 years agoBump Moo dep and remove warning defatalisation hack
Dagfinn Ilmari Mannsåker [Tue, 7 Jul 2015 18:19:52 +0000]
Bump Moo dep and remove warning defatalisation hack

Moo 2 no longer pulls in strictures

9 years agoAdd _update_returning method for UPDATE … RETURNING
Dagfinn Ilmari Mannsåker [Sun, 21 Dec 2014 14:43:28 +0000]
Add _update_returning method for UPDATE … RETURNING

It just calls _returning, but allows subclasses to override UPDATE …
RETURNING independently from INSERT … RETURNING

9 years agoKeep calling _insert_returning for INSERT … RETURNING
Dagfinn Ilmari Mannsåker [Sun, 21 Dec 2014 14:42:45 +0000]
Keep calling _insert_returning for INSERT … RETURNING

DBIC::SQLMaker::Oracle overrides this method, and its insert calls
next::method, so we need keep calling the old method for the override to
work.

9 years agoFixed missing '}' in POD examples and reformat for clarity
Daniel Perrett [Fri, 10 Oct 2014 10:17:50 +0000]
Fixed missing '}' in POD examples and reformat for clarity

9 years agoReinstate _insert_returning method for DBIC compat
Dagfinn Ilmari Mannsåker [Mon, 15 Dec 2014 20:29:57 +0000]
Reinstate _insert_returning method for DBIC compat

9 years agoAdd support for UPDATE ... RETURNING ...
Dagfinn Ilmari Mannsåker [Mon, 15 Dec 2014 20:14:46 +0000]
Add support for UPDATE ... RETURNING ...

Similar to INSERT ... RETURNING ...

10 years agoRelease 1.81 v1.81
Peter Rabbitson [Sat, 25 Oct 2014 11:30:24 +0000]
Release 1.81

10 years agoFix overly-enthusiastic parenthesis unroller (RT#99503)
Peter Rabbitson [Sat, 25 Oct 2014 10:47:35 +0000]
Fix overly-enthusiastic parenthesis unroller (RT#99503)

10 years agoRe-indent and quote versions in Makefile
Peter Rabbitson [Sat, 25 Oct 2014 10:46:39 +0000]
Re-indent and quote versions in Makefile

No functional changes

10 years agoRelease 1.80 v1.80
Peter Rabbitson [Sun, 5 Oct 2014 21:05:57 +0000]
Release 1.80

10 years agoSkip tests on smokers with a broken DBIC trial
Peter Rabbitson [Sun, 5 Oct 2014 21:03:53 +0000]
Skip tests on smokers with a broken DBIC trial

10 years agoCroak on invalid top-level special ops
Peter Rabbitson [Fri, 26 Sep 2014 12:02:04 +0000]
Croak on invalid top-level special ops

When they were originally introduced it never occured neither to me, nor
whoever reviewed that a plain special-op will not work at top level.
Add an extra check at the fallback point (ugly, but still effective)

10 years agoSaner handling of nested_lhs, we now set it in one spot only
Peter Rabbitson [Fri, 3 Oct 2014 11:21:49 +0000]
Saner handling of nested_lhs, we now set it in one spot only

10 years agospelling mistake (RT#99147)
gregor herrmann [Fri, 26 Sep 2014 14:34:04 +0000]
spelling mistake (RT#99147)

10 years agoWhatever I was thinking it wasn't making much sense
Peter Rabbitson [Fri, 26 Sep 2014 01:56:45 +0000]
Whatever I was thinking it wasn't making much sense

Good thing I started pondering how to port this to DQ, otherwise would not
have noticed I fucked up... for a while

10 years agoRelease 1.79 v1.79
Peter Rabbitson [Thu, 25 Sep 2014 12:00:59 +0000]
Release 1.79

10 years agoEven though MRO::C is a dep of Moo, specify it explicitly
Peter Rabbitson [Thu, 25 Sep 2014 11:59:55 +0000]
Even though MRO::C is a dep of Moo, specify it explicitly

Some folks do this http://cpanratings.perl.org/dist/SQL-Abstract#9620

10 years agoDeprecate and properly handle empty lhs
Peter Rabbitson [Thu, 25 Sep 2014 11:08:35 +0000]
Deprecate and properly handle empty lhs

10 years agoMore robust Moo import block (modelled on DBIC)
Peter Rabbitson [Wed, 24 Sep 2014 00:25:20 +0000]
More robust Moo import block (modelled on DBIC)

10 years agoUpdating links to repositories, added GitHub mirror
Rudolf Leermakers [Tue, 23 Sep 2014 23:29:56 +0000]
Updating links to repositories, added GitHub mirror

Modelled on the corresponding DBIC setup

10 years agoMinor documentation fixes; typos, POD formatting code syntax, return value explanatio...
Rudolf Leermakers [Tue, 23 Sep 2014 23:01:11 +0000]
Minor documentation fixes; typos, POD formatting code syntax, return value explanation consistency

10 years agoLink fixes (no other changes)
Peter Rabbitson [Sun, 21 Sep 2014 17:40:27 +0000]
Link fixes (no other changes)

10 years agoWarn if _recurse_where is called in scalar context
Dagfinn Ilmari Mannsåker [Sat, 12 Apr 2014 17:09:17 +0000]
Warn if _recurse_where is called in scalar context

DBIC used to do this, but doesn't any more. Still something else might...

10 years agoTruly fix literal+bind examples (build upon a3e3e6a18)
Peter Rabbitson [Sat, 20 Sep 2014 23:03:12 +0000]
Truly fix literal+bind examples (build upon a3e3e6a18)

Throw away the dummy text - it was always misleading and incorrect
Add some space to clarify which part is which

10 years agoFix typos in literal + bind examples
Dagfinn Ilmari Mannsåker [Tue, 22 Jul 2014 22:52:47 +0000]
Fix typos in literal + bind examples

10 years agoIRC meta
Peter Rabbitson [Fri, 19 Sep 2014 16:05:12 +0000]
IRC meta

10 years agoWell how about them apples?! Add temporary overload-madness escape hatch
Peter Rabbitson [Fri, 19 Sep 2014 15:54:52 +0000]
Well how about them apples?! Add temporary overload-madness escape hatch

10 years agoBoolification-derived-stringification is a thing... just shoot me now
Peter Rabbitson [Fri, 19 Sep 2014 14:35:14 +0000]
Boolification-derived-stringification is a thing... just shoot me now

10 years agoAn arrayref makes sense for literals, but no sense for values
Peter Rabbitson [Sun, 14 Sep 2014 17:45:01 +0000]
An arrayref makes sense for literals, but no sense for values

Change the API before it goes live (extra benefit - no mixing up of
the functions by accident)

10 years agoMore (still passing!!!) test cases after conversation with FC
Peter Rabbitson [Wed, 10 Sep 2014 05:51:11 +0000]
More (still passing!!!) test cases after conversation with FC

10 years agoEven more versatile is_plain_value testing - feeble attempts to trip up perl
Peter Rabbitson [Fri, 5 Sep 2014 06:16:57 +0000]
Even more versatile is_plain_value testing - feeble attempts to trip up perl

This is an attempt to simulate the behavior of JSON::PP::Boolean, and to
replicate the error autarch was seeing - clearly there is more to it than
just simple value juggling. Oh well, commit already written tests anyway.

See further commits for the actual code changes

10 years agoMake sure is_plain_value returns the actual object pre-stringify
Peter Rabbitson [Fri, 5 Sep 2014 08:37:21 +0000]
Make sure is_plain_value returns the actual object pre-stringify

This is important since DBIC is starting to heavily rely on the
contents of the returned []

10 years agoEven more reuse of @_
Peter Rabbitson [Fri, 5 Sep 2014 07:59:15 +0000]
Even more reuse of @_

10 years ago{ -ident => undef } makes zero sense
Peter Rabbitson [Thu, 4 Sep 2014 10:29:49 +0000]
{ -ident => undef } makes zero sense

10 years agoCorrect comments about overload methods vs. ->can()
Dagfinn Ilmari Mannsåker [Fri, 18 Jul 2014 09:08:01 +0000]
Correct comments about overload methods vs. ->can()

10 years agoAha - this is why I didn't use ->can originally
Peter Rabbitson [Thu, 17 Jul 2014 17:05:49 +0000]
Aha - this is why I didn't use ->can originally

Punt for the time being, will investigate why later. The error looks like:

rabbit@Ahasver:~/devel/dbic$ git rev-parse HEAD
32497625ce5699576c8a63edd16401d4f741c282

rabbit@Ahasver:~/devel/dbic$ PERL5LIB=/home/rabbit/devel/sqla/lib prove -lT t/100populate.t
t/100populate.t .. 1/? Stub found while resolving method "???" overloading """" in package "Path::Class::File" at /home/rabbit/devel/sqla/lib/SQL/Abstract.pm line 118, <> line 1.
t/100populate.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
All 43 subtests passed

Test Summary Report
-------------------
t/100populate.t (Wstat: 65280 Tests: 43 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
Files=1, Tests=43,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.90 cusr  0.03 csys =  0.97 CPU)
Result: FAIL

10 years agoNew exportable functions: is_literal_value($) and is_plain_value($)
Peter Rabbitson [Thu, 17 Jul 2014 09:23:53 +0000]
New exportable functions: is_literal_value($) and is_plain_value($)

Ported from DBIC with some corner case fixes added.

10 years agoFix -values not being handled properly with NULLs
Peter Rabbitson [Wed, 16 Jul 2014 11:50:55 +0000]
Fix -values not being handled properly with NULLs

10 years agoEscape closing quote character in table and column names
Dagfinn Ilmari Mannsåker [Thu, 29 May 2014 09:12:08 +0000]
Escape closing quote character in table and column names

10 years agoAfter 5f3fa0ac script/ is no more
Peter Rabbitson [Wed, 16 Jul 2014 11:47:43 +0000]
After 5f3fa0ac script/ is no more

10 years agoFixup descriptions a bit
Peter Rabbitson [Wed, 16 Jul 2014 10:00:47 +0000]
Fixup descriptions a bit

10 years agoAdd basic .dir-locals.el
Dagfinn Ilmari Mannsåker [Wed, 25 Jun 2014 17:07:37 +0000]
Add basic .dir-locals.el

10 years agorelease 1.78 v1.78
Peter Rabbitson [Wed, 28 May 2014 10:13:30 +0000]
release 1.78