Jarkko Hietaniemi [Sat, 8 Mar 2003 06:49:35 +0000]
regen_headers tiny tidying:
- regen.pl renamed as regen_lib.pl
- regen_headers.pl renamed as regen.pl
- added make target 'regen' (kept target 'regen_headers'
for porters' brains' backward compatibility)
- regen.pl fancified a bit to display the names
of the files that got changed by running the scripts
p4raw-id: //depot/perl@18851
Jarkko Hietaniemi [Fri, 7 Mar 2003 08:40:52 +0000]
Give pointers to runtime Unicode changes.
p4raw-id: //depot/perl@18848
Jarkko Hietaniemi [Fri, 7 Mar 2003 08:02:50 +0000]
Extra character noticed by Tels.
p4raw-id: //depot/perl@18847
Kay Roepke [Thu, 6 Mar 2003 23:00:10 +0000]
FreeBSD 5.0 gethostbyaddr_r hints update
Message-ID: <
3E67C4EA.A55FFE5C@dolphin-services.de>
(plus change the d_gethostbyaddr_r_proto default to "0",
that is what an undefined r_proto looks like)
p4raw-id: //depot/perl@18846
Jarkko Hietaniemi [Fri, 7 Mar 2003 05:21:43 +0000]
Define the Perl_pp_i_modulo_1() only iff we have glibc.
(Stronger variant of "pp.c: Perl_pp_i_modulo_1 needs help
in non-glibc case", from Craig Berry)
p4raw-id: //depot/perl@18845
Jarkko Hietaniemi [Fri, 7 Mar 2003 05:05:57 +0000]
Good observation from Philip Newton.
p4raw-id: //depot/perl@18844
Rafael Garcia-Suarez [Thu, 6 Mar 2003 21:59:02 +0000]
Make the -A switch work without an assertion name.
by Salvador Fandiño.
p4raw-id: //depot/perl@18843
Jos I. Boumans [Fri, 21 Feb 2003 20:33:53 +0000]
Re: [PATCH] let perlmodstyle mention Module::Build and Test::More
From: "Jos I. Boumans" <kane@dwim.org>
Message-ID: <
3E567F21.6020006@dwim.org>
(with some minor tweaks)
p4raw-id: //depot/perl@18842
Adrian M. Enache [Sun, 2 Mar 2003 06:05:22 +0000]
Re: [perl #20682] [fix] @- array not visible in s///
Message-ID: <
20030302040522.GB4905@ratsnest.hole>
p4raw-id: //depot/perl@18841
Adrian M. Enache [Wed, 5 Mar 2003 12:06:20 +0000]
cleaning up tests of the 'eval { decl. } <=> runtime decl.' assumption
Message-ID: <
20030305100620.GA909@ratsnest.hole>
p4raw-id: //depot/perl@18840
Craig A. Berry [Thu, 6 Mar 2003 10:42:05 +0000]
mg.c needs Perl_csighandler prototype
From: "Craig A. Berry" <craigberry@mac.com>
Message-ID: <
3E677A5D.10805@mac.com>
p4raw-id: //depot/perl@18839
Jarkko Hietaniemi [Thu, 6 Mar 2003 10:11:22 +0000]
Thinko fix.
p4raw-id: //depot/perl@18838
Jarkko Hietaniemi [Thu, 6 Mar 2003 09:33:33 +0000]
PERL_UNICODE explanation saga continues.
p4raw-id: //depot/perl@18837
Jarkko Hietaniemi [Thu, 6 Mar 2003 07:55:03 +0000]
Handle also extra directories et alia.
p4raw-id: //depot/perl@18836
Jarkko Hietaniemi [Thu, 6 Mar 2003 07:48:05 +0000]
Add mani(fest) check(ing) utility.
p4raw-id: //depot/perl@18835
Stas Bekman [Thu, 6 Mar 2003 12:03:39 +0000]
[patch config_h.SH] redefining __attribute__
Message-ID: <
3E669E6B.1060606@stason.org>
p4raw-id: //depot/perl@18833
Jarkko Hietaniemi [Wed, 5 Mar 2003 19:56:41 +0000]
Couple more _r possibilities (found in a RH 8.0 box), and
the random() macros were all wrong. (I don't know why
metaconfig did so much reordering of config_h.SH.)
p4raw-id: //depot/perl@18831
Rafael Garcia-Suarez [Tue, 4 Mar 2003 23:25:01 +0000]
Change #18829 makes this test workaround obsolete.
p4raw-id: //depot/perl@18830
Rafael Garcia-Suarez [Tue, 4 Mar 2003 22:23:41 +0000]
Patch by Salvador Fandiño to read the warning mask
returned by caller() and ${^WARNING_BITS} from
$warnings::Bits{all} and not from the hardcoded core
constant. (This mask could have been extended by
warnings::register.) Plus tests.
p4raw-id: //depot/perl@18829
Salvador Fandiño [Fri, 21 Feb 2003 17:26:16 +0000]
[PATCH] assertions
Message-ID: <
3E566138.4090709@yahoo.com>
and the complement : (with added comments)
Subject: [PATCH] bug in ext/B/t/deparse.t
Message-ID: <
3E563E16.7060303@yahoo.com>
plus perldiag.pod patch for the new warning
(previous change was, once again, empty)
p4raw-id: //depot/perl@18828
Salvador Fandiño [Fri, 21 Feb 2003 17:26:16 +0000]
[PATCH] assertions
Message-ID: <
3E566138.4090709@yahoo.com>
and the complement : (with added comments)
Subject: [PATCH] bug in ext/B/t/deparse.t
Message-ID: <
3E563E16.7060303@yahoo.com>
plus perldiag.pod patch for the new warning
p4raw-id: //depot/perl@18827
Jarkko Hietaniemi [Tue, 4 Mar 2003 20:22:25 +0000]
Try to make PPPort.pm 5.005-friendlier (see [perl #21339]).
The variant is from how List::Util Util.xs does it.
p4raw-id: //depot/perl@18826
Rafael Garcia-Suarez [Tue, 4 Mar 2003 19:56:28 +0000]
Doc typos.
p4raw-id: //depot/perl@18825
Jarkko Hietaniemi [Tue, 4 Mar 2003 05:33:50 +0000]
Try to give rcatline() a good jog on Unicode.
p4raw-id: //depot/perl@18823
Adrian M. Enache [Sun, 2 Mar 2003 05:43:54 +0000]
Re: [perl #21395] rcatline doesn't grok utf8
Message-ID: <
20030302034354.GA4905@ratsnest.hole>
p4raw-id: //depot/perl@18822
Jarkko Hietaniemi [Tue, 4 Mar 2003 04:58:36 +0000]
Can't test this without PerlIO.
p4raw-id: //depot/perl@18821
Artur Bergman [Tue, 4 Mar 2003 01:01:07 +0000]
Fixes bug #15654 bizarre constant mangling in 5.8.0
What happened was that a constant was freed, the pad released but
the pad slot still held the SV, when pad slot was reallocated
to be a target for a stringify, it did a sv_setpv on the target
and the original SV was wiped out. When this SV was later on
to new places using the constant, they got the wrong value.
By replacing pad_free with pad_swipe for these cases, we
won't have such a problem. (pad_swipe also removes the
pointer to the original SV).
p4raw-id: //depot/perl@18820
Jarkko Hietaniemi [Mon, 3 Mar 2003 19:15:07 +0000]
Further clarification on PERL_UNICODE's semantics.
p4raw-id: //depot/perl@18819
Graham Barr [Mon, 3 Mar 2003 10:07:44 +0000]
Sync with libnet-1.13
p4raw-id: //depot/perl@18818
Jarkko Hietaniemi [Mon, 3 Mar 2003 06:45:59 +0000]
Upgrade to Unicode::Normalize 0.20.
p4raw-id: //depot/perl@18817
Jarkko Hietaniemi [Mon, 3 Mar 2003 06:17:28 +0000]
Upgrade to Encode 1.89. The enc_module.t required
a little tweak, sending that to Dan.
p4raw-id: //depot/perl@18816
Jarkko Hietaniemi [Mon, 3 Mar 2003 05:33:21 +0000]
Use a macro for abs() to avoid the possible truncation to an int;
also make an explicit (double)cast for the arguments to fabs().
p4raw-id: //depot/perl@18813
Andreas König [Wed, 19 Feb 2003 11:05:28 +0000]
Re: [PATCH] Make adding notes to patchlevel.h easier
Message-ID: <m3d6lozitz.fsf@k242.linux.bogus>
p4raw-id: //depot/perl@18812
Edmund Bacon [Tue, 18 Feb 2003 21:05:15 +0000]
[perl #21289] [Fwd: IPC::Msg bug report]
From: Edmund Bacon (via RT) <perlbug-followup@perl.org>
Message-Id: <rt-21289-52384.13.
2700974026643@bugs6.perl.org>
p4raw-id: //depot/perl@18811
Richard Soderberg [Sat, 15 Feb 2003 01:27:21 +0000]
Re: [perl #18872] File::Basename example misleading
Message-Id: <
89FAC8B9-40AE-11D7-9B07-000393801F84@crystalflame.net>
p4raw-id: //depot/perl@18810
Anders Johnson [Sat, 15 Feb 2003 00:21:41 +0000]
[perl #21031] $File::Find::name ne $_ w/no_chdir
From: "Anders Johnson" (via RT) <perlbug-followup@perl.org>
Message-Id: <rt-21031-51306.12.
8541374577158@bugs6.perl.org>
p4raw-id: //depot/perl@18809
Hugo van der Sanden [Sun, 2 Mar 2003 21:22:56 +0000]
Reverse copyright update (#18801) for files not changed in 2003.
p4raw-id: //depot/perl@18807
Adrian M. Enache [Sun, 2 Mar 2003 10:11:27 +0000]
Re: [perl #21411] [fix] Postponed RE with split()
Message-ID: <
20030302081127.GA10782@ratsnest.hole>
p4raw-id: //depot/perl@18805
Anders Johnson [Mon, 10 Feb 2003 14:09:46 +0000]
RE: [perl #20613] Perl_magic_setsig/clearsig problems (patch included)
From: "Anders Johnson" <ajohnson@wischip.com>
Message-ID: <
000e01c2d151$2228ca90$9800a8c0@wis.com>
p4raw-id: //depot/perl@18803
Jarkko Hietaniemi [Sun, 2 Mar 2003 15:39:06 +0000]
Narrow down the -C test skippage.
p4raw-id: //depot/perl@18802
Hugo van der Sanden [Sun, 2 Mar 2003 15:24:22 +0000]
Update all copyrights to 2003, from Jarkko
p4raw-id: //depot/perl@18801
Richard Foley [Wed, 19 Feb 2003 13:24:38 +0000]
for perl5db.pl against missing args destroying pre-post command setups
Message-ID: <
B374141B0A424D4F9CF143CC51B3ADD98579DB@NZURC900PEX1.ubsgs.ubsgroup.net>
p4raw-id: //depot/perl@18800
Jarkko Hietaniemi [Sun, 2 Mar 2003 13:34:13 +0000]
The -CI cannot be easily tested under UTF-8 locale with
the t/test.pl (the 'stdin' data gets doubly UTF-8-ied).
Also other small tweaks in the -C neighbourhood.
p4raw-id: //depot/perl@18799
Jarkko Hietaniemi [Sun, 2 Mar 2003 09:12:06 +0000]
Go with "right = -right" for greater portability, some platforms
might require llabs() to get abs() of long longs.
p4raw-id: //depot/perl@18798
Jarkko Hietaniemi [Sun, 2 Mar 2003 08:07:32 +0000]
Patch for [perl #9402], known also as "glibc _moddi3 bug
with negative quads", or also as RedHat bug #65612.
p4raw-id: //depot/perl@18797
Jarkko Hietaniemi [Sun, 2 Mar 2003 07:34:54 +0000]
Forgotten from change #18795.
p4raw-link: @18795 on //depot/perl:
2aa6a10326178f0f3d8bbf2f0847bd6f4e40b81b
p4raw-id: //depot/perl@18796
Abe Timmerman [Sun, 2 Mar 2003 02:03:16 +0000]
Re: [PATCH embed.fnc] Re: [PATCH] Get MSWin32 back compiling
Message-Id: <
200303020203.16708.abe@ztreet.demon.nl>
p4raw-id: //depot/perl@18795
Jarkko Hietaniemi [Sun, 2 Mar 2003 07:21:36 +0000]
Further Unicode formats patching from Inaba Hiroto.
p4raw-id: //depot/perl@18794
Jarkko Hietaniemi [Sat, 1 Mar 2003 08:18:35 +0000]
Integrate change #18788 from maint.
p4raw-link: @18788 on //depot/maint-5.8/perl:
f0499ddfc6bc8a9696a167e0ea98e851c0d4ff1a
p4raw-id: //depot/perl@18793
p4raw-integrated: from //depot/maint-5.8/perl@18788 'merge in' perl.h
(@18783..)
Abe Timmerman [Sat, 1 Mar 2003 04:31:19 +0000]
Get MSWin32 back compiling
Message-Id: <
200303010431.20205.abe@ztreet.demon.nl>
p4raw-id: //depot/perl@18792
Inaba Hiroto [Mon, 10 Feb 2003 00:04:51 +0000]
Re: [PATCH] Re: format, PerlIO and utf8
Message-ID: <
3E466E12.E5349D84@st.rim.or.jp>
p4raw-id: //depot/perl@18785
Jarkko Hietaniemi [Wed, 26 Feb 2003 19:45:53 +0000]
An already fixed bug from perl-unicode.
p4raw-id: //depot/perl@18784
Adrian M. Enache [Sun, 23 Feb 2003 20:16:39 +0000]
Re: [perl #20683] [fix] Better Patch
Message-ID: <
20030223181639.GA18713@ratsnest.hole>
p4raw-id: //depot/perl@18782
Hugo van der Sanden [Wed, 26 Feb 2003 01:11:14 +0000]
regen headers
p4raw-id: //depot/perl@18781
Hugo van der Sanden [Wed, 26 Feb 2003 00:25:32 +0000]
Two typos found by Philip Newton <pnewton@gmx.de>
p4raw-id: //depot/perl@18780
Jarkko Hietaniemi [Tue, 25 Feb 2003 18:20:01 +0000]
Add tests for the -C switch. Depending on the
CLIs some $^O dance may be needed.
p4raw-id: //depot/perl@18779
Hugo van der Sanden [Tue, 25 Feb 2003 15:24:17 +0000]
Add missing file from change #18774.
p4raw-link: @18774 on //depot/perl:
82d039840b913b4eed10833ac05709a5abd02ead
p4raw-id: //depot/perl@18778
Hugo van der Sanden [Tue, 25 Feb 2003 14:07:59 +0000]
More variables for change #18776.
p4raw-link: @18776 on //depot/perl:
83b43d9236da9ea6e31fd2df2474f4d7f7220a85
p4raw-id: //depot/perl@18777
Adrian M. Enache [Fri, 21 Feb 2003 17:50:14 +0000]
[perl #20682] [fix] @- array not visible in s///
Message-ID: <
20030221155014.GB793@ratsnest.hole>
p4raw-id: //depot/perl@18776
Adrian M. Enache [Fri, 21 Feb 2003 17:49:41 +0000]
[perl #20684] [fix] s/// with (??{..}) inside returns wrong count
Message-ID: <
20030221154941.GA793@ratsnest.hole>
p4raw-id: //depot/perl@18775
Rafael Garcia-Suarez [Sun, 23 Feb 2003 00:03:27 +0000]
Re: [perl #21321] local ${"FOO"} does not work
Message-Id: <
20030223000327.6f0c11fa.rgarciasuarez@free.fr>
p4raw-id: //depot/perl@18774
Dan Kogai [Thu, 20 Feb 2003 23:49:55 +0000]
[Encode] 1.88 Released
Message-Id: <
935F75D0-44E2-11D7-B310-000393AE4244@dan.co.jp>
p4raw-id: //depot/perl@18773
Yitzchak Scott-Thoennes [Wed, 19 Feb 2003 13:37:39 +0000]
[perl@18752] warnings from CGI tests under cygwin
Message-ID: <jk/U+gzkg2DE092yn@efn.org>
p4raw-id: //depot/perl@18772
Jarkko Hietaniemi [Tue, 25 Feb 2003 07:46:53 +0000]
Cleanup #18770 as suggested by Rafael.
p4raw-id: //depot/perl@18771
Jarkko Hietaniemi [Tue, 25 Feb 2003 06:01:09 +0000]
A new try at #18765 (for [perl #20920]).
p4raw-id: //depot/perl@18770
Jarkko Hietaniemi [Tue, 25 Feb 2003 05:33:10 +0000]
Retract change #18765: makes HiRes.t hang after subtest #11.
p4raw-link: @18765 on //depot/perl:
2fb44b4522b8956ab337b2f83a5fe619b0773788
p4raw-id: //depot/perl@18769
Chip Salzenberg [Mon, 24 Feb 2003 21:42:57 +0000]
Include p4d2p in Porting again, because p4genpatch doesn't work
until a change has been submitted.
p4raw-id: //depot/perl@18768
Chip Salzenberg [Mon, 24 Feb 2003 21:35:56 +0000]
In Porting scripts, use standard perl path of "/usr/bin/perl".
p4raw-id: //depot/perl@18767
Jarkko Hietaniemi [Mon, 24 Feb 2003 20:04:36 +0000]
PERL_SIGNALS=unsafe enables the old unsafe/immediate signals.
p4raw-id: //depot/perl@18766
Slaven Rezic [Fri, 14 Feb 2003 09:11:15 +0000]
Re: [perl #20920] Segmentation fault ("Safe Signal" queue problem?)
Message-ID: <878ywji8nw.fsf@vran.herceg.de>
(with slight tweaks)
p4raw-id: //depot/perl@18765
Jarkko Hietaniemi [Mon, 24 Feb 2003 18:44:41 +0000]
Patching magic from Inaba-san's keyboard: fix for [perl #8769]:
"scalar upgraded to UTF-8 as a side effect of quote-interpolation
when 'use encoding' is engaged"-- wasn't actually encoding's fault.
p4raw-id: //depot/perl@18764
Chip Salzenberg [Mon, 24 Feb 2003 14:54:36 +0000]
Use PL_{argv,stdin,stdout}gv to avoid unnecessary gv_fetch calls.
p4raw-id: //depot/perl@18763
Hugo van der Sanden [Mon, 24 Feb 2003 00:18:42 +0000]
Remove no-longer-true line from perlop
p4raw-id: //depot/perl@18762
Jarkko Hietaniemi [Sun, 23 Feb 2003 12:07:53 +0000]
Chip noticed that the intended optionality of the 'IV' was
forgotten in the change #18758.
p4raw-link: @18758 on //depot/perl:
f0fabfd7a60ca1c99e9f3f4c4b66d46eab58e4d5
p4raw-id: //depot/perl@18761
Jarkko Hietaniemi [Sat, 22 Feb 2003 19:17:04 +0000]
API doc tweaks.
p4raw-id: //depot/perl@18760
Artur Bergman [Fri, 21 Feb 2003 09:08:30 +0000]
Change regex to be a bit more friendly against various
outputs from ps -f, regex suggest by rgs
p4raw-id: //depot/perl@18759
Peter Prymmer [Thu, 20 Feb 2003 13:28:09 +0000]
add some IV stuff to ext/Devel/Peek/Peek.t test 21
Message-ID: <O
F2DC297F4.A63F24F9-ON85256CD3.006513E4@factset.com>
p4raw-id: //depot/perl@18758
Peter Prymmer [Wed, 19 Feb 2003 15:04:40 +0000]
add probe for yet another dangerous logical name: COMP
Message-ID: <O
FC0A627AD.02B9D968-ON85256CD2.006DDC21@factset.com>
p4raw-id: //depot/perl@18757
Jarkko Hietaniemi [Thu, 20 Feb 2003 06:16:05 +0000]
Doc tweakage on -C.
p4raw-id: //depot/perl@18756
Brendan O'Dea [Sun, 16 Feb 2003 21:09:23 +0000]
5.8.0: typo in pod/perlcompile.pod
Message-ID: <
20030216100923.GA29761@londo.c47.org>
p4raw-id: //depot/perl@18755
Rafael Garcia-Suarez [Wed, 19 Feb 2003 21:14:37 +0000]
Document clearly that "_" is always in package "main".
p4raw-id: //depot/perl@18754
Adrian M. Enache [Thu, 13 Feb 2003 04:52:21 +0000]
Re: [perl #20716] scope error with brackets
Message-ID: <
20030213025221.GA1215@ratsnest.hole>
(better version of change #18687)
p4raw-link: @18687 on //depot/perl:
437fd2104756c25dedf68c6e31cd29ecbf0e2569
p4raw-id: //depot/perl@18753
Jarkko Hietaniemi [Wed, 19 Feb 2003 05:10:26 +0000]
'A' is not 65 everywhere.
p4raw-id: //depot/perl@18752
Chip Salzenberg [Wed, 19 Feb 2003 03:54:45 +0000]
Support one-parameter unpack(), which unpacks $_.
p4raw-id: //depot/perl@18751
Salvador Fandiño [Tue, 18 Feb 2003 19:24:13 +0000]
more complex assertions activation:
Subject: Re: Did the assertion patch/feature submission get overlooked?
Message-ID: <
3E52885D.5060903@yahoo.com>
p4raw-id: //depot/perl@18750
Andreas König [Tue, 18 Feb 2003 11:48:40 +0000]
Make adding notes to patchlevel.h easier
Message-ID: <m3n0kt27av.fsf@k242.linux.bogus>
p4raw-id: //depot/perl@18749
Dave Mitchell [Tue, 18 Feb 2003 21:45:45 +0000]
Blocking option ignored
Date: Tue, 18 Feb 2003 21:45:45 +0000
Message-ID: <
20030218214545.C18547@fdgroup.com>
and tests for the same:
From: Dave Mitchell <davem@fdgroup.com>
Date: Wed, 19 Feb 2003 00:42:01 +0000
Message-ID: <
20030219004201.F18547@fdgroup.com>
p4raw-id: //depot/perl@18748
Hugo van der Sanden [Tue, 18 Feb 2003 23:47:06 +0000]
Shouldn't have added as t/run/switchA.t in #18739 - it'll cause
problems on case-insensitive file systems. Rename it back to
t/run/switch_A.t
p4raw-id: //depot/perl@18747
Michael G. Schwern [Tue, 18 Feb 2003 21:31:37 +0000]
Re: -Os for Darwin why?
Message-Id: <
20030218113739.D25848@ttul.org>
p4raw-id: //depot/perl@18746
Jarkko Hietaniemi [Tue, 18 Feb 2003 14:01:34 +0000]
Format nit.
p4raw-id: //depot/perl@18741
Michael G. Schwern [Tue, 18 Feb 2003 06:33:57 +0000]
Re: -Os for Darwin why?
Message-Id: <
20030217191403.A17553@ttul.org>
p4raw-id: //depot/perl@18740
Salvador Fandiño [Mon, 17 Feb 2003 23:38:05 +0000]
Re: Did the assertion patch/feature submission get overlooked?
Message-ID: <
3E51725D.5060303@yahoo.com>
p4raw-id: //depot/perl@18739
Nicholas Clark [Mon, 17 Feb 2003 21:07:03 +0000]
Re: [PATCH] Re: [PATCH] Copy on write for $& and $1...
Message-ID: <
20030217210330.A8611@plum.flirble.org>
p4raw-id: //depot/perl@18738
Stephen McCamant [Mon, 17 Feb 2003 19:34:36 +0000]
Re: [perl #21261] B::Terse not outputting correct constants or variable names
Date: Mon, 17 Feb 2003 19:34:36 -0500
Date: Mon, 17 Feb 2003 19:34:36 -0500
Message-ID: <15953.32668.277063.470885@syllepsis.MIT.EDU>
p4raw-id: //depot/perl@18737
Nicholas Clark [Sun, 16 Feb 2003 23:09:50 +0000]
Re: [PATCH] Copy on write for $& and $1...
Message-ID: <
20030216230950.GB276@Bagpuss.unfortu.net>
p4raw-id: //depot/perl@18736
Hugo van der Sanden [Mon, 17 Feb 2003 09:13:02 +0000]
Use the escape E<ntilde> in source files rather than the actual char.
p4raw-id: //depot/perl@18735
Hugo van der Sanden [Mon, 17 Feb 2003 09:06:44 +0000]
Suppress empty #ifdef blocks in embed.pl
p4raw-id: //depot/perl@18734
Hugo van der Sanden [Mon, 17 Feb 2003 08:51:53 +0000]
fix typo in sv.c and regenerate perlapi.pod
p4raw-id: //depot/perl@18733
Jarkko Hietaniemi [Mon, 17 Feb 2003 06:40:09 +0000]
Philip Newton has eagle eyes :-)
p4raw-id: //depot/perl@18732
Jarkko Hietaniemi [Mon, 17 Feb 2003 05:31:18 +0000]
Doc tweaks (and one code tweak) based on Philip Newton's comments.
p4raw-id: //depot/perl@18731