Jesse Luehrs [Thu, 16 Jun 2011 16:51:51 +0000]
if we aren't calling _inline_return_value, none of this is necessary
Dave Rolsky [Thu, 16 Jun 2011 15:35:14 +0000]
Add some tests for array traits to make sure it doesn't have the same accessor method bug that hash traits had
Dave Rolsky [Thu, 16 Jun 2011 15:34:21 +0000]
Sort the keys in %handles when making delegation methods
This makes it easier to find a given generated method when dumping the generated source
Dave Rolsky [Thu, 16 Jun 2011 15:30:56 +0000]
Tweak test description and tidy code
Dave Rolsky [Thu, 16 Jun 2011 15:29:22 +0000]
Optimize the get branch for hash accessors a little bit
Jesse Luehrs [Wed, 15 Jun 2011 23:33:22 +0000]
changelog
Jesse Luehrs [Wed, 15 Jun 2011 23:31:23 +0000]
fix hash accessor generation (with a bit of a hack/:)
Jesse Luehrs [Wed, 15 Jun 2011 23:12:19 +0000]
better accessor context descriptions in general
Jesse Luehrs [Wed, 15 Jun 2011 22:48:45 +0000]
better definition context for native delegation methods
Jesse Luehrs [Wed, 15 Jun 2011 22:03:04 +0000]
test for hash accessor bug (rt 68837)
Dave Rolsky [Wed, 15 Jun 2011 18:09:04 +0000]
Fix bad package name
Karen Etheridge [Mon, 13 Jun 2011 19:37:16 +0000]
addition of first_index to the native Array trait.
Jesse Luehrs [Mon, 6 Jun 2011 22:25:12 +0000]
changelog
Jesse Luehrs [Mon, 6 Jun 2011 22:05:15 +0000]
move this one to after build
Jesse Luehrs [Mon, 6 Jun 2011 21:56:00 +0000]
run these after filegatherers and such
Jesse Luehrs [Mon, 6 Jun 2011 21:47:24 +0000]
changelog and version bump
Jesse Luehrs [Mon, 6 Jun 2011 21:43:08 +0000]
move these plugins earlier
Jesse Luehrs [Mon, 6 Jun 2011 21:39:06 +0000]
use correct version number in ::Delta
Jesse Luehrs [Mon, 6 Jun 2011 21:09:50 +0000]
dzil plugin to ensure ::Delta doesn't have $NEXT in it
Jesse Luehrs [Mon, 6 Jun 2011 20:54:30 +0000]
add 2.0007 to the changelog
Jesse Luehrs [Mon, 6 Jun 2011 20:16:35 +0000]
add a dzil plugin to ensure that the git checkout is up to date
Dave Rolsky [Mon, 6 Jun 2011 20:20:42 +0000]
No need to mention TC inlining twice
Jesse Luehrs [Mon, 6 Jun 2011 20:02:44 +0000]
Merge remote-tracking branch 'origin/master'
Jesse Luehrs [Mon, 6 Jun 2011 20:00:21 +0000]
changelog
Dave Rolsky [Mon, 6 Jun 2011 19:08:58 +0000]
Work around List::MoreUtils::all being misparsed under 5.10 (no idea why that was happening)
Dave Rolsky [Mon, 6 Jun 2011 19:05:59 +0000]
Remove ; at end of sub definition
Dave Rolsky [Mon, 6 Jun 2011 15:08:04 +0000]
Gitalist has a bug in its test suite where tests fail if you're running from a git checkout and you've set your username via git config
Dave Rolsky [Mon, 6 Jun 2011 05:55:33 +0000]
Conflict with MX::ClassAttribute <= 0.25
Dave Rolsky [Sun, 5 Jun 2011 21:40:21 +0000]
When generating inlining code, distinguish between $default from calling $attr->default and the default val it generates
Dave Rolsky [Sun, 5 Jun 2011 21:34:04 +0000]
Add definition context to every accessor defined internally
Dave Rolsky [Sun, 5 Jun 2011 15:15:14 +0000]
ignore MYMETA.yml
Dave Rolsky [Sun, 5 Jun 2011 15:13:04 +0000]
Just fetch Value type once rather than each time inlining is done for Num and Int
Karen Etheridge [Tue, 31 May 2011 21:00:25 +0000]
update docs to show how to call into parent checks
Karen Etheridge [Tue, 31 May 2011 19:52:40 +0000]
in each subtype inline_as, use the check from the parent rather than repeating the code
Karen Etheridge [Tue, 31 May 2011 19:03:10 +0000]
Also run the special Str tests on the types that descend from Str (tests still pass).
Karen Etheridge [Wed, 1 Jun 2011 00:42:47 +0000]
fix punctuation
Karen Etheridge [Mon, 30 May 2011 20:30:12 +0000]
punctuation fix
Dave Rolsky [Thu, 19 May 2011 18:55:41 +0000]
Add Chloro to deps test
Dave Rolsky [Thu, 19 May 2011 14:49:12 +0000]
Remove JSORB
It may be what's killing Jenkins, and Stevan doesn't seem interested in maintaining it
Dave Rolsky [Wed, 18 May 2011 21:42:14 +0000]
MooseX::Net::API has been deprecated by the author
Jesse Luehrs [Thu, 19 May 2011 07:20:58 +0000]
better error message for calling superclasses as a writer when immutable
Dave Rolsky [Wed, 18 May 2011 20:36:47 +0000]
Remove FCGI::Engine
One of its tests, t/020_basic_manager.t, seem to be just hanging forever
Dave Rolsky [Wed, 18 May 2011 18:56:21 +0000]
Bump version in master
Jesse Luehrs [Wed, 18 May 2011 18:08:30 +0000]
fix changelog
Jesse Luehrs [Tue, 17 May 2011 21:33:07 +0000]
pod coverage and such
Jesse Luehrs [Tue, 26 Apr 2011 05:31:01 +0000]
add stuff from that test to author requirements
Jesse Luehrs [Tue, 26 Apr 2011 05:23:19 +0000]
tests for closing over stuff
Jesse Luehrs [Tue, 26 Apr 2011 03:04:13 +0000]
stop closing over method objects when installing modifiers
Jesse Luehrs [Tue, 26 Apr 2011 01:15:32 +0000]
also don't close over member tc objects in native delegations
Jesse Luehrs [Tue, 26 Apr 2011 00:24:49 +0000]
changelog
Jesse Luehrs [Mon, 25 Apr 2011 23:58:49 +0000]
actually, can't do that, since Moose::Error::Default isa CMOP::Object
Jesse Luehrs [Mon, 25 Apr 2011 23:37:06 +0000]
we don't need an actual inlined version of this
Jesse Luehrs [Mon, 25 Apr 2011 18:39:50 +0000]
stop closing over the type constraint object
Jesse Luehrs [Mon, 25 Apr 2011 17:48:26 +0000]
refactor the default type constraint message logic a bit
Jesse Luehrs [Mon, 25 Apr 2011 17:13:51 +0000]
stop closing over the method metaobject
changed this to close over the class metaobject if we're using a custom
error class, but there's no real way around that. the whole error system
really needs to be thrown out and redone anyway.
Jesse Luehrs [Mon, 25 Apr 2011 15:38:05 +0000]
fix setting associated_metaclass and attribute on accessor objects
Jesse Luehrs [Mon, 25 Apr 2011 07:21:14 +0000]
this only matters for lazy attributes with initializers
Jesse Luehrs [Mon, 25 Apr 2011 06:11:00 +0000]
don't close over attrs in the constructor unless necessary
Jesse Luehrs [Mon, 25 Apr 2011 05:18:48 +0000]
close over the coercion sub separately
Jesse Luehrs [Sun, 24 Apr 2011 22:47:07 +0000]
remove unnecessary(?) code
not sure what the original intent was, but it's certainly not breaking
any aliasing in this form
Jesse Luehrs [Sun, 24 Apr 2011 20:32:01 +0000]
restructure this method a bit for readability
Jesse Luehrs [Sun, 24 Apr 2011 20:14:05 +0000]
don't close over the type constraint for inlined tcs
Jesse Luehrs [Sun, 24 Apr 2011 19:39:39 +0000]
stop closing over $attr in accessor generation
Jesse Luehrs [Tue, 17 May 2011 21:04:54 +0000]
fix up a few spelling and pod issues
Dave Rolsky [Mon, 25 Apr 2011 01:57:10 +0000]
Wrap all TC inlining in parens and a do { } block
The parens protect against precedence issues when being used with logical operators.
The do { } block provides each TC its own scope, so that if it defines variables they don't leak out to the enclosing code.
Dave Rolsky [Mon, 25 Apr 2011 01:40:41 +0000]
Union inlining should always be surrounded by its own set of parens, for safety
Jesse Luehrs [Thu, 21 Apr 2011 21:35:25 +0000]
fix up the inlining test
Jesse Luehrs [Thu, 21 Apr 2011 21:32:14 +0000]
make sure these are defined
Jesse Luehrs [Thu, 21 Apr 2011 21:23:25 +0000]
these can be undef
Jesse Luehrs [Thu, 21 Apr 2011 21:16:36 +0000]
there's no reason the suffix has to be fixed length
Jesse Luehrs [Thu, 21 Apr 2011 21:15:16 +0000]
one more constrained scope in tc inlining
Dave Rolsky [Thu, 21 Apr 2011 20:55:22 +0000]
Make sure that every type passes all its tests when unioned with itself
Dave Rolsky [Thu, 21 Apr 2011 20:51:36 +0000]
Make sure that inlining union preserves the inline env
Make sure that an enum's inline env works when unioned with another enum (each env has a unique var)
Dave Rolsky [Thu, 21 Apr 2011 20:40:08 +0000]
Whenever we inline a type constraint, we need to include its inline environment.
Test every builtin TC as a simple attr's constraint, and as a native Array trait's member TC.
This thoroughly tests that we are propogating the TC's inline environment properly.
Dave Rolsky [Thu, 21 Apr 2011 20:39:20 +0000]
Make inline constraints safer ...
If we're defining a temp var - do this in a do {} block to limit its scope and
prevent it from conflicting with another constraint's var.
Don't use return in an inline constraint (this is super bad)
Don't use $_ to iterate over a collection of values in generated code, since
this could easily conflict with the surrounding code.
Dave Rolsky [Thu, 21 Apr 2011 20:33:28 +0000]
Don't assume that value that fails a duck type constraint is blessed or we get undef warnings
Dave Rolsky [Thu, 21 Apr 2011 20:18:07 +0000]
Don't use $_ when checking member constraints, since that can conflict with $_ used in inlined TC
Dave Rolsky [Thu, 21 Apr 2011 19:52:22 +0000]
Add comprehensive test for all builtin types as a simple class attribute and as a native trait attribute
Dave Rolsky [Thu, 21 Apr 2011 18:54:47 +0000]
Docs, Delta, and Changes for inline constraints
Dave Rolsky [Thu, 21 Apr 2011 18:44:24 +0000]
Rename has_inlined_type_constraint to can_be_inlined
Jesse Luehrs [Thu, 21 Apr 2011 14:13:35 +0000]
changelog
Jesse Luehrs [Thu, 21 Apr 2011 14:02:04 +0000]
one more Eval::Closure use
Jesse Luehrs [Thu, 21 Apr 2011 06:03:39 +0000]
one more fix for unoptimized constraints
Jesse Luehrs [Thu, 21 Apr 2011 05:55:51 +0000]
stop using a package global for enums, just close over it
Jesse Luehrs [Thu, 21 Apr 2011 05:55:03 +0000]
also use Eval::Closure in the test
Jesse Luehrs [Thu, 21 Apr 2011 05:40:22 +0000]
fix a couple of unoptimized constraints
there are still more that need to be fixed i think, but do we really
care about these at all? they're pretty much only useful for
informational purposes, i don't think there's any way to actually
trigger this codepath
Jesse Luehrs [Thu, 21 Apr 2011 05:39:35 +0000]
confess here, since this should never happen
Jesse Luehrs [Thu, 21 Apr 2011 05:39:23 +0000]
more readable inlined code
Jesse Luehrs [Thu, 21 Apr 2011 01:41:12 +0000]
use Eval::Closure rather than doing string eval directly
Jesse Luehrs [Thu, 21 Apr 2011 01:35:03 +0000]
compare references with == rather than eq
Dave Rolsky [Fri, 15 Apr 2011 16:11:07 +0000]
Add tests for a fake regex object ( bless {}, 'Regexp' )
Dave Rolsky [Fri, 15 Apr 2011 16:10:00 +0000]
Don't disable 'once' warnings in the whole test
Dave Rolsky [Fri, 15 Apr 2011 16:08:33 +0000]
Test that Str can handle return value of substr()
Dave Rolsky [Fri, 15 Apr 2011 16:03:20 +0000]
Make sure that Int rejects "1\n" and "\n1" (but Num does accept it)
Dave Rolsky [Fri, 15 Apr 2011 15:40:12 +0000]
A name-only subtype now inherits inlining from its parent type
Remove explicit optimized constraint in M::M::TC subclasses
Dave Rolsky [Fri, 15 Apr 2011 15:40:04 +0000]
Add inlining code for Role constraint class
Dave Rolsky [Fri, 15 Apr 2011 15:37:21 +0000]
Explicitly set the constraint for role type
Dave Rolsky [Fri, 15 Apr 2011 15:36:24 +0000]
Enum needs to check that the value is not a ref
Dave Rolsky [Fri, 15 Apr 2011 15:23:29 +0000]
Drop optimized subs for all builtins - instead use the inlining code to generate a sub
Fix inline code for ArrayRef & HashRef type - need to check the ref type of
the value before dereferencing it
Fix TODO test to test the right thing in inlining.t
Dave Rolsky [Mon, 11 Apr 2011 15:33:15 +0000]
Add a thorough test for inlining TCs, especially testing parameterized types and unions