9 years agoFix syntax errors in POD data structure example
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 21:29:00 +0000]
Fix syntax errors in POD data structure example

Also wrap over-long verbatim lines

9 years agoAdd .dir-locals.el file
Dagfinn Ilmari Mannsåker [Sat, 13 Jun 2015 13:11:53 +0000]
Add .dir-locals.el file

9 years agoRelease 0.07043 0.07043
Dagfinn Ilmari Mannsåker [Wed, 13 May 2015 16:33:00 +0000]
Release 0.07043

9 years agoAdd tests for disabled constraints and triggers for Oracle
Dagfinn Ilmari Mannsåker [Wed, 13 May 2015 13:15:29 +0000]
Add tests for disabled constraints and triggers for Oracle

Also use the existing deferrability check to skip disabled foreign
keys even if DBD::Oracle returns them.

9 years agoFilter out disabled constraints and triggers for Oracle (GH#5)
Philipp Gortan [Wed, 14 Jan 2015 09:57:53 +0000]
Filter out disabled constraints and triggers for Oracle (GH#5)

9 years agoUse the actual md5sum of the old version when deciding whether to overwrite
Dagfinn Ilmari Mannsåker [Fri, 8 May 2015 17:20:41 +0000]
Use the actual md5sum of the old version when deciding whether to overwrite

Otherwise overwrite_modifications => 1 won't work if the generated
content has been modified but the schema hasn't changed (so the md5sum
in the marker matches the newly-generated one).

9 years agoEnsure schema files are generated as binary files on Windows
Christian Walde [Tue, 5 May 2015 01:34:47 +0000]
Ensure schema files are generated as binary files on Windows

Otherwise they'll be generated with \r newlines in them, which breaks
checksumming and portability of schemas to other OSes.

9 years ago(travis) Fix short-circuiting logic
Dagfinn Ilmari Mannsåker [Tue, 28 Apr 2015 12:16:41 +0000]
(travis) Fix short-circuiting logic

9 years ago(travis) Remove workarounds for fixed issues
Dagfinn Ilmari Mannsåker [Tue, 28 Apr 2015 00:01:36 +0000]
(travis) Remove workarounds for fixed issues

9 years ago(travis) Exclude the DQ-based DBIC 0.089xx
Dagfinn Ilmari Mannsåker [Tue, 28 Apr 2015 00:01:09 +0000]
(travis) Exclude the DQ-based DBIC 0.089xx

9 years agoRemove MySQL year(2) test
Dagfinn Ilmari Mannsåker [Tue, 28 Apr 2015 16:54:03 +0000]
Remove MySQL year(2) test

The year(2) type is deprecated, and as of version 5.6 the size
specification is ignored.

9 years agoAdd option to allow extra columns in many_to_many link tables
Dagfinn Ilmari Mannsåker [Sat, 25 Apr 2015 17:02:30 +0000]
Add option to allow extra columns in many_to_many link tables

The primary key must still equal the union of the foreign keys.

9 years agoRevert "Install DBIC dev rel under CLEANTEST="false""
Dagfinn Ilmari Mannsåker [Mon, 27 Apr 2015 11:25:39 +0000]
Revert "Install DBIC dev rel under CLEANTEST="false""

The hard-coded dev release no longer exists on CPAN, and a fixed version
has been released ages ago.

This reverts commit 3ad4cddb255b56e472a038dcab759ae3ef6bcbf9.

9 years agoSimplify array_eq function
Dagfinn Ilmari Mannsåker [Sat, 25 Apr 2015 17:01:03 +0000]
Simplify array_eq function

It's only ever used for names and has "eq" in the name, so there's no
need to try and be clever about things that look like numbers.

9 years ago(travis) Update package list before installing stuff
Dagfinn Ilmari Mannsåker [Thu, 2 Apr 2015 09:55:13 +0000]
(travis) Update package list before installing stuff

9 years agoUse {List,Sub}::Util instead of List::MoreUtils and Sub::Name
Dagfinn Ilmari Mannsåker [Tue, 27 Jan 2015 19:03:29 +0000]
Use {List,Sub}::Util instead of List::MoreUtils and Sub::Name

That means bumping the dependency on List::Util to 1.33, which means
people on perl < 5.20 will have to upgrade anyway, so we might as well
use Sub::Util (added in 1.40) instead of Sub::Name as well.

Nick the apply, firstidx and uniq functions from List::MoreUtils::PP
into DBIx::Class::Schema::Loader::Utils to avoid depending on it.

9 years agoFix DB2 foreign-key introspection
Dagfinn Ilmari Mannsåker [Tue, 27 Jan 2015 13:24:56 +0000]
Fix DB2 foreign-key introspection

The join to the referenced key columns was only using the constraint
name, which is not necessarily unique.  Also use the referenced table
schema and name.

9 years agoFix skip count when DB2 extra schema creation fails
Dagfinn Ilmari Mannsåker [Mon, 26 Jan 2015 14:48:14 +0000]
Fix skip count when DB2 extra schema creation fails

5975bbe6 updated the extra test count, but not the skip count

9 years agoFix circular relationship diagnostics
Dagfinn Ilmari Mannsåker [Wed, 21 Jan 2015 19:15:48 +0000]
Fix circular relationship diagnostics

9 years agoRun Travis tests on 5.20 and threaded 5.18 as well
Dagfinn Ilmari Mannsåker [Wed, 21 Jan 2015 15:33:30 +0000]
Run Travis tests on 5.20 and threaded 5.18 as well

9 years agoInstall and test DB2 in Travis
Dagfinn Ilmari Mannsåker [Mon, 19 Jan 2015 18:38:52 +0000]
Install and test DB2 in Travis

Test Oracle, DB2 and Firebird separately, since the Travis VM doesn't
have enough memory for all of them

9 years agoInclude nanoseconds in timestamps
Dagfinn Ilmari Mannsåker [Tue, 20 Jan 2015 14:24:54 +0000]
Include nanoseconds in timestamps

9 years agoNick Travis script improvements from DBIC
Dagfinn Ilmari Mannsåker [Tue, 20 Jan 2015 13:46:48 +0000]
Nick Travis script improvements from DBIC

9 years agoUpdate Firebird ODBC driver version
Dagfinn Ilmari Mannsåker [Mon, 19 Jan 2015 19:20:52 +0000]
Update Firebird ODBC driver version

9 years agoShow relationship info on circular rel failure
Dagfinn Ilmari Mannsåker [Wed, 21 Jan 2015 14:21:48 +0000]
Show relationship info on circular rel failure

I've seen this fail with bogus SQL on DB2 on Travis, but can't
reproduce it. Let's at least get some info if it happens again.

9 years agoShut up uninitialized warnings from ->table_info on DB2
Dagfinn Ilmari Mannsåker [Wed, 21 Jan 2015 13:54:35 +0000]
Shut up uninitialized warnings from ->table_info on DB2

9 years agoEnable soft_commit with DBD::Firebird as well
Dagfinn Ilmari Mannsåker [Mon, 19 Jan 2015 20:31:12 +0000]
Enable soft_commit with DBD::Firebird as well

It was accidentally only enabled for DBD::InterBase in 4fb2971c.

9 years agoDocument how to add perltidy markers via filter_generated_code
Olaf Alders [Fri, 19 Dec 2014 17:09:56 +0000]
Document how to add perltidy markers via filter_generated_code

9 years agoUse consistent 4-space indentation in lib/
Dagfinn Ilmari Mannsåker [Sat, 3 Jan 2015 16:52:39 +0000]
Use consistent 4-space indentation in lib/

9 years agoEliminate tabs in lib/
Dagfinn Ilmari Mannsåker [Sat, 3 Jan 2015 15:49:15 +0000]
Eliminate tabs in lib/

10 years agoFix MySQL non-InnoDB test skip counts
Dagfinn Ilmari Mannsåker [Mon, 20 Oct 2014 11:34:21 +0000]
Fix MySQL non-InnoDB test skip counts

10 years agoFix many_to_many bridges with overlapping foreign keys
Dagfinn Ilmari Mannsåker [Fri, 17 Oct 2014 15:37:22 +0000]
Fix many_to_many bridges with overlapping foreign keys

10 years agoAdd missed Changes header for 0.07042
Dagfinn Ilmari Mannsåker [Fri, 17 Oct 2014 15:38:38 +0000]
Add missed Changes header for 0.07042

10 years agoFix broken POD links found by App::PodLinkChecker
Dagfinn Ilmari Mannsåker [Mon, 22 Sep 2014 16:32:46 +0000]
Fix broken POD links found by App::PodLinkChecker

10 years agoEliminate POD-containing heredoc
Dagfinn Ilmari Mannsåker [Tue, 26 Aug 2014 18:38:51 +0000]
Eliminate POD-containing heredoc

The POD was being picked up by POD parsers, and showed up as a
spurious "BASE CLASS: $base_class" heading.

10 years agoRelease 0.07042 0.07042
Dagfinn Ilmari Mannsåker [Tue, 19 Aug 2014 23:21:49 +0000]
Release 0.07042

10 years agoFix Changes typo
Dagfinn Ilmari Mannsåker [Tue, 19 Aug 2014 18:28:21 +0000]
Fix Changes typo

10 years agoUse tempdir() to create temporary directories for testing
Dagfinn Ilmari Mannsåker [Tue, 19 Aug 2014 17:33:48 +0000]
Use tempdir() to create temporary directories for testing

This is the first step towards being able to run tests i parallel.

10 years agoUse undef instead of '%' fore the table and type arguments to $dbh->tables
Dagfinn Ilmari Mannsåker [Tue, 19 Aug 2014 17:31:03 +0000]
Use undef instead of '%' fore the table and type arguments to $dbh->tables

Neither the DBI documentation nor the ODBC specification allow '%' for
the type, but some DBDs do (or did, DBD::Pg 3.4.0 no longer does)
allow it. For the ones that didn't, the loader subclass used override
->_tables_list to pass undef explicitly.

Instead, use undef in the default implementation, but allow subclasses
to override as needed (none currently do).

Also change the table argument to default to undef, since that's
equivalent according to the spec and all the DBDs I've tested with or
looked at (SQLite, MySQL, Pg, Oracle, FireBird, ODBC, InterBase).

10 years agoFix unescaped left braces in regexes in tests
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 19:30:49 +0000]
Fix unescaped left braces in regexes in tests

They cause deprecation warnings in perl 5.21.x.

10 years agoRelease 0.07041 0.07041
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 14:02:35 +0000]
Release 0.07041

10 years agoDocument test failure fix with the upcoming DBIC 0.082800
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 14:02:03 +0000]
Document test failure fix with the upcoming DBIC 0.082800

10 years agoDon't ship dotfiles
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 13:54:13 +0000]
Don't ship dotfiles

(e.g. .travis.yml and .mailmap)

10 years agoAdd Changes entry about Travis smoking
Dagfinn Ilmari Mannsåker [Sat, 9 Aug 2014 13:49:05 +0000]
Add Changes entry about Travis smoking

10 years agoAdd --verify to PERL_CPANM_OPT to catch corrupt tarballs
Dagfinn Ilmari Mannsåker [Wed, 6 Aug 2014 16:06:33 +0000]
Add --verify to PERL_CPANM_OPT to catch corrupt tarballs

<@ribasushi> ilmari: experiment with mirrors
<@ribasushi> the metacpan proxy of the download part (why?!) is
             sometimes giving back shortened tarballs, which happen to
             extract fine
<@ribasushi> but the source is in fact fucked

10 years agoInstall Math::BigInt, 5.8.x ship a too old one
Dagfinn Ilmari Mannsåker [Wed, 6 Aug 2014 13:49:50 +0000]
Install Math::BigInt, 5.8.x ship a too old one

10 years agoAllow 5.8.3 runs to fail
Dagfinn Ilmari Mannsåker [Wed, 6 Aug 2014 16:09:12 +0000]
Allow 5.8.3 runs to fail

Several upstream deps are flaky, and nobody has the tuits to fix them.

10 years agoTest with more perl versions
Dagfinn Ilmari Mannsåker [Tue, 5 Aug 2014 16:29:13 +0000]
Test with more perl versions

10 years agoInstall DBIC dev rel under CLEANTEST="false"
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 15:09:31 +0000]
Install DBIC dev rel under CLEANTEST="false"

The stable one has a broken Storage::DBI::ODBC::Firebird (missing
true value).

10 years agoRemove pointless disconnect after static ->load
Dagfinn Ilmari Mannsåker [Tue, 5 Aug 2014 14:44:53 +0000]
Remove pointless disconnect after static ->load

It was added on the assumption that in static mode nothing else was
going to happen after the loading was done, but that's really none of
our concern, so we shouldn't interfere with it.

It also broke the in-transaction dump test with DBIC's new stricter
connectedness checking on txn ops (dbsrgits/dbix-class@d4702d53).

10 years agoAdjust skip_rels count again
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 14:01:26 +0000]
Adjust skip_rels count again

10 years agoFix many_to_many bridges going back to the same table
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 13:04:08 +0000]
Fix many_to_many bridges going back to the same table

The loop only looked at the moniker name, not the key columns, so
would pick a random one. The tests didn't cover the actual self-m2m
bridge at all, so this only got noticed by the Oracle loader being
unstable in which one it picked and triggering the no-rewrite test.

Also clean up the other m2m rel tests and group them correctly.

10 years agoTurn the duplicated code in _generate_m2ms into loops
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 11:12:27 +0000]
Turn the duplicated code in _generate_m2ms into loops

10 years agoTest on perl 5.16 as well
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 01:31:30 +0000]
Test on perl 5.16 as well

This might help suss out whether the m2m instability on Oracle is due to
hashes or the database.

10 years agoRevert "Run tests verbosely"
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 01:00:07 +0000]
Revert "Run tests verbosely"

This reverts commit ea34d3424b6169316ec979cc44efddcfca2f65a6.

10 years agoGenerate m2m rels in deterministic order
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 00:59:04 +0000]
Generate m2m rels in deterministic order

10 years agoUse Test::Differences to check lack of file rewrite
Dagfinn Ilmari Mannsåker [Tue, 29 Jul 2014 00:43:17 +0000]
Use Test::Differences to check lack of file rewrite

10 years agoTest Moose bits
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 23:34:08 +0000]
Test Moose bits

10 years agoReturn FK info in a deterministic order in ::DBI::InterBase
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 23:20:31 +0000]
Return FK info in a deterministic order in ::DBI::InterBase

10 years agoRun multi-DSN tests in a deterministic order
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 23:17:42 +0000]
Run multi-DSN tests in a deterministic order

10 years agoSilence more Firebird warnings
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 23:05:22 +0000]
Silence more Firebird warnings

10 years agoRun tests verbosely
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 23:02:14 +0000]
Run tests verbosely

10 years agoFix MySQL skip counts
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 19:48:35 +0000]
Fix MySQL skip counts

10 years agoTest MySQL with InnoDB (i.e. relationships) as well
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 19:36:50 +0000]
Test MySQL with InnoDB (i.e. relationships) as well

10 years agoInstall modules needed by DBD-specific tests for CLEANTEST=false
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 18:58:38 +0000]
Install modules needed by DBD-specific tests for CLEANTEST=false

10 years agoEnable backcompat tests for CLEANTEST=false
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 18:58:23 +0000]
Enable backcompat tests for CLEANTEST=false

10 years agoWe have no xt tests
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 18:40:10 +0000]
We have no xt tests

10 years agoDisable taint checking for tests for now
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 18:39:50 +0000]
Disable taint checking for tests for now

10 years agoDisable parallel testing for now
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 18:15:52 +0000]
Disable parallel testing for now

10 years agoInstall Module::Install::ReadmeFromPod in Travis
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 18:14:09 +0000]
Install Module::Install::ReadmeFromPod in Travis

10 years agoSteal Travis-CI setup from DBIx::Class
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 17:54:33 +0000]
Steal Travis-CI setup from DBIx::Class

10 years agoUse skip_all or diag for missing RDBMS test dependencies
Dagfinn Ilmari Mannsåker [Mon, 28 Jul 2014 17:40:36 +0000]
Use skip_all or diag for missing RDBMS test dependencies

This way we get a list of all the missing modules if DBICTEST_FOO_DSN
is set, but something is missing.

10 years agoBump MooseX::NonMoose - the Zefram strikes back
Peter Rabbitson [Thu, 12 Jun 2014 03:06:27 +0000]
Bump MooseX::NonMoose - the Zefram strikes back

10 years agoRelease 0.07040 0.07040
Dagfinn Ilmari Mannsåker [Tue, 27 May 2014 18:14:30 +0000]
Release 0.07040

10 years agoFix stray tab in Changes file
Dagfinn Ilmari Mannsåker [Tue, 27 May 2014 16:46:02 +0000]
Fix stray tab in Changes file

10 years agoAvoid clobbering caller's $_ (RT#96010)
Dagfinn Ilmari Mannsåker [Tue, 27 May 2014 16:37:21 +0000]
Avoid clobbering caller's $_ (RT#96010)

10 years agoFix inconsistent naming of duplicate unique constraints
Dagfinn Ilmari Mannsåker [Wed, 21 May 2014 16:50:59 +0000]
Fix inconsistent naming of duplicate unique constraints

Sort the constraints by name in _table_uniq_info, so we consistently
pick the same constraint if there are several on the same set of
columns.

10 years agoAdd moritz to CONTRIBUTORS in dbicdump too
Dagfinn Ilmari Mannsåker [Sun, 20 Apr 2014 16:43:16 +0000]
Add moritz to CONTRIBUTORS in dbicdump too

10 years agoAdd moritz to CONTRIBUTORS
Dagfinn Ilmari Mannsåker [Sun, 20 Apr 2014 16:42:12 +0000]
Add moritz to CONTRIBUTORS

10 years agoFix name and encoding
Moritz Lenz [Sun, 20 Apr 2014 16:12:29 +0000]
Fix name and encoding

10 years agoImprove config example in dbicdump
Moritz Lenz [Sun, 20 Apr 2014 15:21:25 +0000]
Improve config example in dbicdump

it was not apparent to me that dump_directory belongs into the
loader_options section, so make it obvious in the example

10 years agoFix dumping unique indexes with DBD::Pg < 1.50
Dagfinn Ilmari Mannsåker [Sat, 5 Apr 2014 20:56:18 +0000]
Fix dumping unique indexes with DBD::Pg < 1.50

10 years agoSkip dumping unique indexes with expressions (RT#93613)
Dagfinn Ilmari Mannsåker [Fri, 4 Apr 2014 15:27:22 +0000]
Skip dumping unique indexes with expressions (RT#93613)

DBD::Pg 3.0.0 returns expression indexes from ->statistics_info, with
COLUMN_NAME => undef and pg_expression => $expression.  Because
->_table_uniq_info just skipped individual rows without COLUMN_NAME,
an index contains a mix of plain columns and expressions would
generate erroneous ->add_unique_constraint() calls.

10 years agoAdd Dag-Erling Smørgrav to CONTRIBUTORS
Dagfinn Ilmari Mannsåker [Fri, 4 Apr 2014 13:36:49 +0000]
Add Dag-Erling Smørgrav to CONTRIBUTORS

10 years agoAdd options to omit the version and timestamp from the generated code (RT#92300)
Dag-Erling Smørgrav [Fri, 4 Apr 2014 13:26:27 +0000]
Add options to omit the version and timestamp from the generated code (RT#92300)

10 years agoRelease 0.07039 0.07039
Dagfinn Ilmari Mannsåker [Mon, 6 Jan 2014 17:55:26 +0000]
Release 0.07039

10 years agoFix generated_classes with dry_run => 1
Dagfinn Ilmari Mannsåker [Mon, 6 Jan 2014 15:33:20 +0000]
Fix generated_classes with dry_run => 1

10 years agoAdd dry-run mode for static schema creation
Dagfinn Ilmari Mannsåker [Tue, 26 Nov 2013 17:36:07 +0000]
Add dry-run mode for static schema creation

10 years agoAdd accessor for the list of (re)generated classes
Dagfinn Ilmari Mannsåker [Tue, 26 Nov 2013 17:28:05 +0000]
Add accessor for the list of (re)generated classes

10 years agoConvert t/22dump.t to done_testing()
Dagfinn Ilmari Mannsåker [Mon, 6 Jan 2014 13:46:49 +0000]
Convert t/22dump.t to done_testing()

10 years agoAdd mailmap file
Dagfinn Ilmari Mannsåker [Thu, 2 Jan 2014 21:59:49 +0000]
Add mailmap file

10 years agoadd myself to contributors pod
Matt Phillips [Thu, 2 Jan 2014 21:28:42 +0000]
add myself to contributors pod

10 years agoSupport for DBD::DB2 1.85 as well as < 1.85
Matt Phillips [Tue, 3 Sep 2013 16:21:45 +0000]
Support for DBD::DB2 1.85 as well as < 1.85

IBM attempted to become compatible with the DBI spec with their latest release,
but seem to have failed. This tweak fixes support for all versions of the DBD.

10 years agoSwap order of _relnames_and_method return values
Dagfinn Ilmari Mannsåker [Fri, 20 Dec 2013 22:06:29 +0000]
Swap order of _relnames_and_method return values

It makes more sense to have the local relname first, then the remote
relname and method. Note that this plus the previous commit are not a
no-op, since the meanings of the names have changed.

10 years agoSwap local_relname and remote_relname around in RelBuilder
Dagfinn Ilmari Mannsåker [Fri, 20 Dec 2013 21:47:47 +0000]
Swap local_relname and remote_relname around in RelBuilder

All the other remote/local names refer to things _on_ the respective
tables, except these, which referred to the name of the rel _to_ the
named table. Fixing this longstanding inconsistency makes the code
easier to understand (IMHO, at least).

10 years agoUse hash slice assignment instead of loop
Dagfinn Ilmari Mannsåker [Fri, 20 Dec 2013 19:28:33 +0000]
Use hash slice assignment instead of loop

10 years agoRe-wrap and re-indent for readability and consistency
Dagfinn Ilmari Mannsåker [Fri, 20 Dec 2013 19:11:40 +0000]
Re-wrap and re-indent for readability and consistency

11 years agoRelease 0.07038 0.07038
Dagfinn Ilmari Mannsåker [Wed, 20 Nov 2013 11:38:16 +0000]
Release 0.07038

11 years agoFix detection of qualified sequence names for Oracle (RT#90341)
Dagfinn Ilmari Mannsåker [Fri, 15 Nov 2013 15:03:44 +0000]
Fix detection of qualified sequence names for Oracle (RT#90341)

11 years agoFix national character type sizes on DBD::Oracle >= 1.52
Dagfinn Ilmari Mannsåker [Tue, 19 Nov 2013 18:36:01 +0000]
Fix national character type sizes on DBD::Oracle >= 1.52

Older versions erroneously reported the size in bytes (using UTF-16),
not characters.