14 years agoMerge branch 'people/riba/find_cleanup' into people/riba/master_cherry
Peter Rabbitson [Sun, 17 Oct 2010 15:47:27 +0000]
Merge branch 'people/riba/find_cleanup' into people/riba/master_cherry

14 years agoTest for already fixed RT#59219
Peter Rabbitson [Sat, 16 Oct 2010 23:51:33 +0000]
Test for already fixed RT#59219

14 years agoExtensive updates to find/key related documentation
Peter Rabbitson [Sat, 16 Oct 2010 22:46:18 +0000]
Extensive updates to find/key related documentation

14 years agoFix find() with an explicit constraint name (... { key => $cname } )
Peter Rabbitson [Sat, 16 Oct 2010 16:40:53 +0000]
Fix find() with an explicit constraint name (... { key => $cname } )

Fix the code being overly lax on evaluation of the combined
condition (user supplied + $rs inherited). If we can not prove
that a constraint is deteministic - we throw

Also fix the heuristics invoked without a key attr. to not
consider constraints for which NULL values have been supplied

14 years agoDe-golf _is_deterministic_value, add more tests for create() with $rs conds
Peter Rabbitson [Sat, 16 Oct 2010 00:14:03 +0000]
De-golf _is_deterministic_value, add more tests for create() with $rs conds

14 years agoReduce mount of perlgolf in ResultSet.pm
Peter Rabbitson [Fri, 15 Oct 2010 22:11:37 +0000]
Reduce mount of perlgolf in ResultSet.pm

14 years agoRemove support for find( col1 => $val1, col2 => $val2, ... )
Peter Rabbitson [Fri, 15 Oct 2010 20:53:14 +0000]
Remove support for find( col1 => $val1, col2 => $val2, ... )

14 years agoAdd a unique constraint to artist.name in the test schema
Peter Rabbitson [Sat, 16 Oct 2010 14:18:29 +0000]
Add a unique constraint to artist.name in the test schema

While at it adjust tests that assume the name is not unique

14 years agoSwitch t/relationship/core.t $@ checks to Test::Exception
Peter Rabbitson [Fri, 15 Oct 2010 15:56:10 +0000]
Switch t/relationship/core.t $@ checks to Test::Exception

14 years agoAdd deprecation warning to DBIx::Class::ResultSetProxy
Peter Rabbitson [Sun, 12 Sep 2010 18:49:06 +0000]
Add deprecation warning to DBIx::Class::ResultSetProxy

14 years agoRemove _is_unique_query (more dead code from 2006)
Peter Rabbitson [Sat, 16 Oct 2010 15:01:00 +0000]
Remove _is_unique_query (more dead code from 2006)

14 years agoDeleting long forgotten ::Storage::DBI:Role:QueryCounter
Peter Rabbitson [Sun, 12 Sep 2010 17:03:51 +0000]
Deleting long forgotten ::Storage::DBI:Role:QueryCounter

Added in 62fa8aecef5887b274659ebfb4233a37cff5a3e6

Then development backed out in
  b0ca666f56fbdac8c0b4a08a292eed26ba8a21be
  72305dab8d827fdddba16d79f0ca31f9b5d5e735

14 years agoFix bug in update of resultset using qualified condition in "-or"
Aaron Crane [Thu, 7 Oct 2010 14:58:33 +0000]
Fix bug in update of resultset using qualified condition in "-or"

DBIx::Class::Storage::DBIHacks::_strip_cond_qualifiers was failing to
recurse down "-or" conditions.  Add minimal support for that, including a
test.

14 years agofixed oracle test sequence detection from a different schema
Robert Bohne [Sat, 16 Oct 2010 15:17:16 +0000]
fixed oracle test sequence detection from a different schema

14 years agofixed wrong sequence returned when multiple triggers for a table exist + tests
Alexander Hartmaier [Wed, 13 Oct 2010 12:18:52 +0000]
fixed wrong sequence returned when multiple triggers for a table exist + tests

14 years agoStop adding GROUP BY's to subqueries that do not contain 1:M joins
Peter Rabbitson [Sun, 18 Jul 2010 15:03:47 +0000]
Stop adding GROUP BY's to subqueries that do not contain 1:M joins

siracusa++ for spotting the incorrect SQL in the first place,
and pointing out that the competition sucks :)

14 years agoFix spotty handling of complex order_by relationship attrs while prefetching
Peter Rabbitson [Thu, 14 Oct 2010 05:06:28 +0000]
Fix spotty handling of complex order_by relationship attrs while prefetching

14 years agoSet name_sep by default (even if unused). Simplify raw-sql scanner code
Peter Rabbitson [Thu, 14 Oct 2010 05:06:28 +0000]
Set name_sep by default (even if unused). Simplify raw-sql scanner code

14 years agoThat's an embarrasing c/p :(
Peter Rabbitson [Thu, 14 Oct 2010 04:18:30 +0000]
That's an embarrasing c/p :(

14 years agoUndocument lies
Peter Rabbitson [Wed, 13 Oct 2010 18:37:03 +0000]
Undocument lies

14 years agoRequire unborked CAG
Peter Rabbitson [Tue, 12 Oct 2010 09:00:31 +0000]
Require unborked CAG

14 years agoClarify $rs->update/delete documentation
Peter Rabbitson [Mon, 11 Oct 2010 06:50:52 +0000]
Clarify $rs->update/delete documentation

14 years agoClarify ResultSet RV docs, bring set_cache RV in line with tests
Peter Rabbitson [Mon, 11 Oct 2010 06:28:11 +0000]
Clarify ResultSet RV docs, bring set_cache RV in line with tests

14 years agoImprove the leak tracer - hook bless() as early as possible
Peter Rabbitson [Sun, 10 Oct 2010 18:17:42 +0000]
Improve the leak tracer - hook bless() as early as possible

14 years agoLoad sqlite backup required modules on demand only
Peter Rabbitson [Sun, 10 Oct 2010 18:13:07 +0000]
Load sqlite backup required modules on demand only

14 years agoRename vaguely named internal method
Peter Rabbitson [Fri, 8 Oct 2010 10:41:54 +0000]
Rename vaguely named internal method

14 years agoEntire test suite passes under DBIC_TRACE=1
Peter Rabbitson [Tue, 31 Aug 2010 12:13:19 +0000]
Entire test suite passes under DBIC_TRACE=1

Explicitly disable debug on some noisy tests (when dealing with blobs)
Bump Test::Exception to a version that does not go bizarre copy on you

14 years agofeature doc map
Arthur Axel 'fREW' Schmidt [Sat, 10 Jul 2010 07:11:48 +0000]
feature doc map

14 years agoRemove a stack frame from the SQLA Carp overrides
Peter Rabbitson [Sun, 3 Oct 2010 23:15:35 +0000]
Remove a stack frame from the SQLA Carp overrides

14 years agoDelay construction of try block until an active $sth is asserted
Peter Rabbitson [Sat, 2 Oct 2010 13:25:00 +0000]
Delay construction of try block until an active $sth is asserted

14 years agoRemove deprecated use of qw// as (qw//)
Peter Rabbitson [Thu, 30 Sep 2010 09:59:46 +0000]
Remove deprecated use of qw// as (qw//)

14 years agoMake Data::Page total count evaluation lazy
Peter Rabbitson [Mon, 27 Sep 2010 07:27:39 +0000]
Make Data::Page total count evaluation lazy

The short version is - now you can do $rs->pager->total_entries($satanic_num)
and DBIC will never even try to fire a COUNT query

This may seem to be a *lot* of code to do something that could
be done with a trivial subclass. However keep in mind that this
is a proof-of-concept of what do we do when we can *not* (or do
not want to) subclass.

14 years agoFix compose_namespace rsrc leaks, introduce a badass leaktracer
Peter Rabbitson [Sun, 26 Sep 2010 17:36:41 +0000]
Fix compose_namespace rsrc leaks, introduce a badass leaktracer

14 years agoMinor cleanup of memory cycle tracing and IC::DT inflator selector logic
Peter Rabbitson [Sun, 26 Sep 2010 16:59:57 +0000]
Minor cleanup of memory cycle tracing and IC::DT inflator selector logic

14 years agoReorganize runmode detection a bit
Peter Rabbitson [Sun, 26 Sep 2010 16:39:21 +0000]
Reorganize runmode detection a bit

Add two helpers: is_smoker and is_plain, to make it easier to indicate which
test should run when. Note that cpanm sets AUTOMATED_TESTING to trick modules
that expect input, so is_smoker isn't as simple as it should have been.

14 years agoChanges/author for a1e1a51
Peter Rabbitson [Sun, 26 Sep 2010 04:56:58 +0000]
Changes/author for a1e1a51

14 years agoExtend proxy rel attr
wreis [Thu, 23 Sep 2010 13:39:39 +0000]
Extend proxy rel attr

The proxy rel attribute can be specified as a hashref and arrayref,
in order to create delegation methods to a related class.

- Test cases for extending proxy rel attr
- Update Relationship::Base docs and Changes file

14 years agoexample for columns explaining correlation to select/as
David Schmidt [Sat, 2 Oct 2010 11:12:48 +0000]
example for columns explaining correlation to select/as

14 years agoAdded ontes on where to override store_column (request from kd)
Jess Robinson [Sat, 25 Sep 2010 12:27:05 +0000]
Added ontes on where to override store_column (request from kd)

14 years agofix precedence error in Row->_is_column_numeric
Mark Dominus [Tue, 21 Sep 2010 17:31:55 +0000]
fix precedence error in Row->_is_column_numeric

14 years agoFix RT61503 (bump DateTime::Format::Pg dep)
Peter Rabbitson [Tue, 21 Sep 2010 04:36:04 +0000]
Fix RT61503 (bump DateTime::Format::Pg dep)

14 years agoDisable author mode during cpanX --installdeps .
Peter Rabbitson [Tue, 21 Sep 2010 04:32:10 +0000]
Disable author mode during cpanX --installdeps .

14 years agoMake test suite pass under DBICTEST_SQLITE_USE_FILE=1
Peter Rabbitson [Sat, 18 Sep 2010 01:08:06 +0000]
Make test suite pass under DBICTEST_SQLITE_USE_FILE=1

14 years agoFix leak of $sth during populate() on perls < 5.10
Peter Rabbitson [Fri, 17 Sep 2010 15:18:04 +0000]
Fix leak of $sth during populate() on perls < 5.10

The removal of the explicit ->disconnect on $storage DESTROY
revealed a problem with older perls and nesting of try blocks

14 years agoFix forgotten external-$dbh test warnings
Peter Rabbitson [Fri, 17 Sep 2010 09:44:33 +0000]
Fix forgotten external-$dbh test warnings

14 years agoNo longer explicitly disconnect on ::Storage DESTROY
Peter Rabbitson [Tue, 14 Sep 2010 22:15:46 +0000]
No longer explicitly disconnect  on ::Storage DESTROY

14 years agoFix the exception-hungry exception_action
Peter Rabbitson [Mon, 13 Sep 2010 00:21:37 +0000]
Fix the exception-hungry exception_action

14 years agoRemove duplicate test (same as end of t/storage/error.t)
Peter Rabbitson [Mon, 13 Sep 2010 00:17:08 +0000]
Remove duplicate test (same as end of t/storage/error.t)

14 years agoRemove bogus pre-txn_begin first-connect call
Peter Rabbitson [Sun, 12 Sep 2010 16:48:36 +0000]
Remove bogus pre-txn_begin first-connect call
Rename the txn-retry debug envvar

14 years agoOptimize RowNum limit dialect as per suggestion in RT#61277
Peter Rabbitson [Sun, 12 Sep 2010 12:14:43 +0000]
Optimize RowNum limit dialect as per suggestion in RT#61277

14 years agoRename incorrectly named internal method (has nothing to do with MySQL)
Peter Rabbitson [Sun, 5 Sep 2010 10:49:37 +0000]
Rename incorrectly named internal method (has nothing to do with MySQL)
Add an extra test (written due to a false-alarm)

14 years agoMake _server_info() _determine_driver-bound
Peter Rabbitson [Wed, 8 Sep 2010 08:51:48 +0000]
Make _server_info() _determine_driver-bound

14 years agoDBIC_TRACE_PROFILE
Arthur Axel 'fREW' Schmidt [Thu, 9 Sep 2010 03:32:08 +0000]
DBIC_TRACE_PROFILE

14 years agoFilterColumn tweaks - docs and parameter tests
Nigel Metheringham [Thu, 16 Sep 2010 11:17:22 +0000]
FilterColumn tweaks - docs and parameter tests

Now throws exception if no filter parameters passed.
Documentation tweaked slightly.

14 years agoModernising/updating of the ::Manual::FAQ
Jess Robinson [Mon, 6 Sep 2010 13:26:32 +0000]
Modernising/updating of the ::Manual::FAQ

14 years agoAdding twitter account link to docs
Jess Robinson [Mon, 6 Sep 2010 12:42:32 +0000]
Adding twitter account link to docs

14 years agoAdding more manual bits to main Manual.pod
Jess Robinson [Sun, 5 Sep 2010 10:57:46 +0000]
Adding more manual bits to main Manual.pod
Updating/adding glossary definitions

14 years agoPreserve unblessed reference exceptions
Arthur Axel 'fREW' Schmidt [Wed, 1 Sep 2010 17:42:58 +0000]
Preserve unblessed reference exceptions

14 years agoDon't try to load DBIx::Class during the Makefile.PL stage, just
Peter Rabbitson [Tue, 31 Aug 2010 14:44:35 +0000]
Don't try to load DBIx::Class during the Makefile.PL stage, just
to detemrine its version

14 years agoFix mysterious ::Storage::DBI goto-shim failures on older
Peter Rabbitson [Tue, 31 Aug 2010 10:39:01 +0000]
Fix mysterious ::Storage::DBI goto-shim failures on older
perl versions (tested on 5.8.1)

14 years agoRemove forgotten frame from Storage-method overrides (was missing
Peter Rabbitson [Tue, 31 Aug 2010 10:22:45 +0000]
Remove forgotten frame from Storage-method overrides (was missing
a goto in the driver-already-determined shim)
Simplify the DBI Cursor DESTROY a little

14 years agoMake CDBICompat keep a stable oder of columns in each column-group
Peter Rabbitson [Tue, 31 Aug 2010 10:19:57 +0000]
Make CDBICompat keep a stable oder of columns in each column-group
(was relying on order of %{} until now)

14 years agoMassive cleanup of DateTime test dependencies, other interim
Peter Rabbitson [Mon, 30 Aug 2010 04:38:34 +0000]
Massive cleanup of DateTime test dependencies, other interim
janitorial work

14 years agoEnable pg test disabled god knows why, minor cleanup.
Peter Rabbitson [Mon, 30 Aug 2010 03:50:46 +0000]
Enable pg test disabled god knows why, minor cleanup.

14 years agoMinor cleanup of ::Optional::Dependencies innards
Peter Rabbitson [Mon, 30 Aug 2010 03:17:35 +0000]
Minor cleanup of ::Optional::Dependencies innards

14 years agoReformat Changes (features listed as fix/misc)
Peter Rabbitson [Mon, 30 Aug 2010 03:11:13 +0000]
Reformat Changes (features listed as fix/misc)

14 years agoDisable t/zzzzzzz_sqlite_deadlock.t for regular installs
Peter Rabbitson [Fri, 27 Aug 2010 14:57:29 +0000]
Disable t/zzzzzzz_sqlite_deadlock.t for regular installs

14 years agoMake running test under DBIC_TRACE=1 bearable
Peter Rabbitson [Fri, 11 Jun 2010 16:26:14 +0000]
Make running test under DBIC_TRACE=1 bearable

14 years agoFix RT#58554 (make sure FOR X is always the last part of a select)
Peter Rabbitson [Fri, 27 Aug 2010 14:29:30 +0000]
Fix RT#58554 (make sure FOR X is always the last part of a select)

14 years agoFix the taint mode test to correctly work under local-lib or similar
Peter Rabbitson [Tue, 24 Aug 2010 07:38:11 +0000]
Fix the taint mode test to correctly work under local-lib or similar

14 years agoMerge branch 'people/riba/retire_sqla_limit'
Peter Rabbitson [Fri, 27 Aug 2010 10:58:15 +0000]
Merge branch 'people/riba/retire_sqla_limit'

14 years agoRename SQLAHacks to SQLMaker, shuffle around files, add extensive
Peter Rabbitson [Fri, 27 Aug 2010 10:49:38 +0000]
Rename SQLAHacks to SQLMaker, shuffle around files, add extensive
POD.

14 years agoDrop-in legacy code for DB2-AS/400
Peter Rabbitson [Sat, 14 Aug 2010 11:04:14 +0000]
Drop-in legacy code for DB2-AS/400

14 years agoFactor out the limit implementations into a separate file
Peter Rabbitson [Sat, 14 Aug 2010 11:02:03 +0000]
Factor out the limit implementations into a separate file

14 years agoSQLA::Limit is no more \o/
Peter Rabbitson [Sat, 14 Aug 2010 10:50:08 +0000]
SQLA::Limit is no more \o/

14 years agoStop relying on ->can in the SQL::Abstract carp-hack, allows
Peter Rabbitson [Sat, 14 Aug 2010 10:27:53 +0000]
Stop relying on ->can in the SQL::Abstract carp-hack, allows
proper use of namespace::clean

14 years agoAdd a Pg limit test (just to extend coverage)
Peter Rabbitson [Tue, 10 Aug 2010 13:08:45 +0000]
Add a Pg limit test (just to extend coverage)

14 years agoRemove leftover use from the SIGSEGV trapping days
Peter Rabbitson [Fri, 13 Aug 2010 10:58:55 +0000]
Remove leftover use from the SIGSEGV trapping days

14 years agoSome TODO test revisions prompted by RT#59565
Peter Rabbitson [Sun, 8 Aug 2010 11:50:25 +0000]
Some TODO test revisions prompted by RT#59565

14 years agoFix Verisoned.pm to not issue queries that break down with quoting
Peter Rabbitson [Sun, 8 Aug 2010 11:31:36 +0000]
Fix Verisoned.pm to not issue queries that break down with quoting
enabled. Also simplify table-test SQL. (RT#59619)

14 years agoAdd META resource as per RT#58549
Peter Rabbitson [Sun, 8 Aug 2010 11:23:03 +0000]
Add META resource as per RT#58549

14 years agoadd proper test for column names with punctuation, bump CAG dep for fix
Rafael Kitover [Sat, 12 Jun 2010 08:47:28 +0000]
add proper test for column names with punctuation, bump CAG dep for fix

14 years agoNew $dbh capability handling - allows someone to say
Peter Rabbitson [Sun, 18 Jul 2010 15:03:47 +0000]
New $dbh capability handling - allows someone to say
$schema->storage->_use_insert_returning(0)

14 years agoFix a corner case when a distinct plus an unqualified order_by on one
Peter Rabbitson [Fri, 6 Aug 2010 23:09:23 +0000]
Fix a corner case when a distinct plus an unqualified order_by on one
of the distinct-ed columns resulted in double-specification in the
GROUP BY clause

14 years agofix sybase fail, add more diagnostics for firebird blob fail
Rafael Kitover [Thu, 22 Jul 2010 09:43:43 +0000]
fix sybase fail, add more diagnostics for firebird blob fail

14 years ago_pri_cols throws incorrect exceptions when called on an instances not attached to...
Peter Rabbitson [Wed, 14 Jul 2010 00:51:17 +0000]
_pri_cols throws incorrect exceptions when called on an instances not attached to a schema (e.g. during belongs_to fk-column guessing)

14 years agoFix IC::DT to stop autovivifying columninfo keys
Peter Rabbitson [Sun, 21 Mar 2010 06:52:01 +0000]
Fix IC::DT to stop autovivifying columninfo keys

14 years agoRewrite the DBI connector to use Try::Tiny, avoid a leak by evoking a callback codere...
Peter Rabbitson [Mon, 12 Jul 2010 02:55:25 +0000]
Rewrite the DBI connector to use Try::Tiny, avoid a leak by evoking a callback coderef installer coderef :D

14 years agoFix bulk-insert trace
Peter Rabbitson [Sun, 11 Jul 2010 01:18:37 +0000]
Fix bulk-insert trace

14 years agoMerge branch 'view-deps'
Peter Rabbitson [Sat, 10 Jul 2010 20:30:49 +0000]
Merge branch 'view-deps'

14 years agoAdjust thread test diag
Peter Rabbitson [Sat, 10 Jul 2010 16:29:42 +0000]
Adjust thread test diag

14 years agoUnified _resolve_deps from two branches to one.
Amiri Barksdale at Home [Thu, 8 Jul 2010 03:00:53 +0000]
Unified _resolve_deps from two branches to one.

14 years agoUse fully-qualified result class names instead of source names in deploy_depends_on.
Amiri Barksdale at Home [Tue, 15 Jun 2010 02:16:57 +0000]
Use fully-qualified result class names instead of source names in deploy_depends_on.

14 years agoRemove useless dep in View.pm.
Amiri Barksdale at Home [Sun, 13 Jun 2010 00:32:34 +0000]
Remove useless dep in View.pm.

14 years agoChange API of deploy_depends_on: pass it source names. Fix optional deps on 105view_d...
Amiri Barksdale at Home [Sun, 13 Jun 2010 00:10:31 +0000]
Change API of deploy_depends_on: pass it source names. Fix optional deps on 105view_deps.t. Catch warning in 105view_deps.t.

14 years agoDocpatch for ::FilterColumn (component loading)
hakim [Fri, 9 Jul 2010 21:59:16 +0000]
Docpatch for ::FilterColumn (component loading)

14 years agoCleanup shebang lines of all maint/example scripts, remove from tests entirely
Peter Rabbitson [Thu, 8 Jul 2010 12:35:22 +0000]
Cleanup shebang lines of all maint/example scripts, remove from tests entirely

14 years agoThis hack is superseded by theorbtwo's POD::Inherit (which however has problems on...
Peter Rabbitson [Thu, 8 Jul 2010 12:27:22 +0000]
This hack is superseded by theorbtwo's POD::Inherit (which however has problems on its own)

14 years agoSVN tools no longer applicable
Peter Rabbitson [Thu, 8 Jul 2010 12:26:14 +0000]
SVN tools no longer applicable

14 years agoThe support structure for this was deleted in 2006
Peter Rabbitson [Thu, 8 Jul 2010 12:25:42 +0000]
The support structure for this was deleted in 2006